Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12672

RPC timeout should not override IPC ping interval

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 2.7.3, 2.6.4
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:

      Description

      Currently if the value of ipc.client.rpc-timeout.ms is greater than 0, the timeout overrides the ipc.ping.interval and client will throw exception instead of sending ping when the interval is passed. RPC timeout should work without effectively disabling IPC ping.

      1. HADOOP-12672.001.patch
        7 kB
        Masatake Iwasaki
      2. HADOOP-12672.002.patch
        9 kB
        Masatake Iwasaki
      3. HADOOP-12672.003.patch
        9 kB
        Masatake Iwasaki
      4. HADOOP-12672.004.patch
        8 kB
        Masatake Iwasaki
      5. HADOOP-12672.005.patch
        11 kB
        Masatake Iwasaki
      6. HADOOP-12672.006.patch
        11 kB
        Masatake Iwasaki

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 45s trunk passed
          +1 compile 8m 7s trunk passed with JDK v1.8.0_66
          +1 compile 8m 41s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 17s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 51s trunk passed
          +1 javadoc 0m 54s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 38s the patch passed
          +1 compile 7m 57s the patch passed with JDK v1.8.0_66
          +1 javac 7m 57s the patch passed
          +1 compile 8m 43s the patch passed with JDK v1.7.0_91
          +1 javac 8m 43s the patch passed
          +1 checkstyle 0m 16s the patch passed
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          -1 findbugs 2m 0s hadoop-common-project/hadoop-common introduced 1 new FindBugs issues.
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_91
          +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 7m 27s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          70m 13s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            Inconsistent synchronization of org.apache.hadoop.ipc.Client$Connection.pingInterval; locked 80% of time Unsynchronized access at Client.java:80% of time Unsynchronized access at Client.java:[line 491]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781786/HADOOP-12672.001.patch
          JIRA Issue HADOOP-12672
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 4844c8eae90c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1715864
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8390/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8390/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8390/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 45s trunk passed +1 compile 8m 7s trunk passed with JDK v1.8.0_66 +1 compile 8m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 17s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 0m 54s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 38s the patch passed +1 compile 7m 57s the patch passed with JDK v1.8.0_66 +1 javac 7m 57s the patch passed +1 compile 8m 43s the patch passed with JDK v1.7.0_91 +1 javac 8m 43s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. -1 findbugs 2m 0s hadoop-common-project/hadoop-common introduced 1 new FindBugs issues. +1 javadoc 0m 54s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_91 +1 unit 7m 22s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 7m 27s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 70m 13s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Inconsistent synchronization of org.apache.hadoop.ipc.Client$Connection.pingInterval; locked 80% of time Unsynchronized access at Client.java:80% of time Unsynchronized access at Client.java: [line 491] Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781786/HADOOP-12672.001.patch JIRA Issue HADOOP-12672 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 4844c8eae90c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1715864 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8390/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8390/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8390/console This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          addressing findbugs warnings in 002.

          Show
          iwasakims Masatake Iwasaki added a comment - addressing findbugs warnings in 002.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 21s trunk passed
          +1 compile 8m 45s trunk passed with JDK v1.8.0_66
          +1 compile 9m 18s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 38s the patch passed
          +1 compile 9m 6s the patch passed with JDK v1.8.0_66
          +1 javac 9m 6s the patch passed
          +1 compile 9m 20s the patch passed with JDK v1.7.0_91
          +1 javac 9m 20s the patch passed
          -1 checkstyle 0m 18s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 97, now 98).
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 2m 6s the patch passed
          +1 javadoc 0m 55s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_91
          -1 unit 7m 49s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 7m 45s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          75m 9s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781833/HADOOP-12672.002.patch
          JIRA Issue HADOOP-12672
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 497a81bc9f84 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1715864
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 21s trunk passed +1 compile 8m 45s trunk passed with JDK v1.8.0_66 +1 compile 9m 18s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 38s the patch passed +1 compile 9m 6s the patch passed with JDK v1.8.0_66 +1 javac 9m 6s the patch passed +1 compile 9m 20s the patch passed with JDK v1.7.0_91 +1 javac 9m 20s the patch passed -1 checkstyle 0m 18s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 97, now 98). +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_91 -1 unit 7m 49s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 7m 45s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 75m 9s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781833/HADOOP-12672.002.patch JIRA Issue HADOOP-12672 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 497a81bc9f84 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1715864 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8391/console This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Hi Masatake Iwasaki, the patch lgtm. One nitpick for readability. Callers of handleTimeout can increment waiting since callers know how long the wait was. e.g.

                      waiting += soTimeout;
                      handleTimeout(e, waiting);
          ...
                private void handleTimeout(SocketTimeoutException e, int waiting)
          
          Show
          arpitagarwal Arpit Agarwal added a comment - Hi Masatake Iwasaki , the patch lgtm. One nitpick for readability. Callers of handleTimeout can increment waiting since callers know how long the wait was. e.g. waiting += soTimeout; handleTimeout(e, waiting); ... private void handleTimeout(SocketTimeoutException e, int waiting)
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I updated the patch based on the suggestion. Thanks, Arpit Agarwal.

          Show
          iwasakims Masatake Iwasaki added a comment - I updated the patch based on the suggestion. Thanks, Arpit Agarwal .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 0s trunk passed
          +1 compile 7m 45s trunk passed with JDK v1.8.0_72
          +1 compile 7m 57s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 12s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 50s trunk passed
          +1 javadoc 1m 6s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 44s the patch passed
          +1 compile 6m 49s the patch passed with JDK v1.8.0_72
          +1 javac 6m 49s the patch passed
          +1 compile 8m 8s the patch passed with JDK v1.7.0_95
          +1 javac 8m 8s the patch passed
          -1 checkstyle 0m 23s hadoop-common-project/hadoop-common: patch generated 1 new + 94 unchanged - 0 fixed = 95 total (was 94)
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 56s the patch passed
          +1 javadoc 0m 59s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 11s the patch passed with JDK v1.7.0_95
          -1 unit 8m 8s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 8m 45s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          69m 42s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788395/HADOOP-12672.003.patch
          JIRA Issue HADOOP-12672
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux fc4da6c7f1ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7de7068
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 0s trunk passed +1 compile 7m 45s trunk passed with JDK v1.8.0_72 +1 compile 7m 57s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 12s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 50s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 6m 49s the patch passed with JDK v1.8.0_72 +1 javac 6m 49s the patch passed +1 compile 8m 8s the patch passed with JDK v1.7.0_95 +1 javac 8m 8s the patch passed -1 checkstyle 0m 23s hadoop-common-project/hadoop-common: patch generated 1 new + 94 unchanged - 0 fixed = 95 total (was 94) +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 56s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 11s the patch passed with JDK v1.7.0_95 -1 unit 8m 8s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 8m 45s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 69m 42s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788395/HADOOP-12672.003.patch JIRA Issue HADOOP-12672 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux fc4da6c7f1ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7de7068 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8659/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Sorry I missed your updated patch Masatake Iwasaki. +1 lgtm.

          Show
          arpitagarwal Arpit Agarwal added a comment - Sorry I missed your updated patch Masatake Iwasaki . +1 lgtm.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks, Arpit Agarwal. I needed trivial rebasing. Attaching rebased patch.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks, Arpit Agarwal . I needed trivial rebasing. Attaching rebased patch.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 for the v4 patch.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 for the v4 patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 58s trunk passed
          +1 compile 6m 35s trunk passed with JDK v1.8.0_74
          +1 compile 7m 8s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 37s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 44s the patch passed
          +1 compile 6m 32s the patch passed with JDK v1.8.0_74
          +1 javac 6m 32s the patch passed
          +1 compile 7m 26s the patch passed with JDK v1.7.0_95
          +1 javac 7m 26s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 2s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 10s the patch passed with JDK v1.7.0_95
          +1 unit 8m 7s hadoop-common in the patch passed with JDK v1.8.0_74.
          +1 unit 8m 12s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          64m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792608/HADOOP-12672.004.patch
          JIRA Issue HADOOP-12672
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux cd598eb45e8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e01c6ea
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8837/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8837/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 58s trunk passed +1 compile 6m 35s trunk passed with JDK v1.8.0_74 +1 compile 7m 8s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 6m 32s the patch passed with JDK v1.8.0_74 +1 javac 6m 32s the patch passed +1 compile 7m 26s the patch passed with JDK v1.7.0_95 +1 javac 7m 26s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 2s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 10s the patch passed with JDK v1.7.0_95 +1 unit 8m 7s hadoop-common in the patch passed with JDK v1.8.0_74. +1 unit 8m 12s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 64m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792608/HADOOP-12672.004.patch JIRA Issue HADOOP-12672 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux cd598eb45e8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e01c6ea Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8837/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8837/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Committed to branch-2.6 and above. Thanks.

          Show
          iwasakims Masatake Iwasaki added a comment - Committed to branch-2.6 and above. Thanks.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9453 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9453/)
          HADOOP-12672. RPC timeout should not override IPC ping interval (iwasakims: rev 682adc6ba9db3bed94fd4ea3d83761db6abfe695)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9453 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9453/ ) HADOOP-12672 . RPC timeout should not override IPC ping interval (iwasakims: rev 682adc6ba9db3bed94fd4ea3d83761db6abfe695) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          stevel@apache.org Steve Loughran added a comment -

          this just broke everything. Rolling back across the board.

          Show
          stevel@apache.org Steve Loughran added a comment - this just broke everything. Rolling back across the board.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9456 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9456/)
          Revert "HADOOP-12672. RPC timeout should not override IPC ping interval (stevel: rev 754299695b778b9b602e46836c35a3ac9474d7f8)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9456 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9456/ ) Revert " HADOOP-12672 . RPC timeout should not override IPC ping interval (stevel: rev 754299695b778b9b602e46836c35a3ac9474d7f8) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I apologize for the breakage. Thanks for taking care, Steve Loughran.

          NameNode proxy in DFSClient is initialized with the timeout value given by Client#getTimeout which is -1 by default meaning that timeout is not set. I should have take that into account.

          Show
          iwasakims Masatake Iwasaki added a comment - I apologize for the breakage. Thanks for taking care, Steve Loughran . NameNode proxy in DFSClient is initialized with the timeout value given by Client#getTimeout which is -1 by default meaning that timeout is not set. I should have take that into account.
          Hide
          iwasakims Masatake Iwasaki added a comment -
            final public static int getTimeout(Configuration conf) {
              if (!conf.getBoolean(CommonConfigurationKeys.IPC_CLIENT_PING_KEY,
                  CommonConfigurationKeys.IPC_CLIENT_PING_DEFAULT)) {
                return getPingInterval(conf);
              }
              return -1;
            }
          

          Client#getTimeout returns -1 if ipc.client.ping is true, otherwise returns the value of ipc.ping.interval. This seems to reflect the previous behaviour. Current client does not time out even if ipc.client.ping = false because ConnectionId#ConnectionId set pingInterval to 0 in that case. This is existing behaviour even before HADOOP-11252.

          Show
          iwasakims Masatake Iwasaki added a comment - final public static int getTimeout(Configuration conf) { if (!conf.getBoolean(CommonConfigurationKeys.IPC_CLIENT_PING_KEY, CommonConfigurationKeys.IPC_CLIENT_PING_DEFAULT)) { return getPingInterval(conf); } return -1; } Client#getTimeout returns -1 if ipc.client.ping is true, otherwise returns the value of ipc.ping.interval. This seems to reflect the previous behaviour. Current client does not time out even if ipc.client.ping = false because ConnectionId#ConnectionId set pingInterval to 0 in that case. This is existing behaviour even before HADOOP-11252 .
          Hide
          iwasakims Masatake Iwasaki added a comment -

          The value of Client#getTimeout is used in 2 places in the current hadoop code base.

          • DfsClientConf.hdfsTimeout
          • NameNodeProxiesClient#createNonHAProxyWithClientProtocol (HDFS-4646)

          DfsClientConf.hdfsTimeout affects the renewal time of LeaseRenewer. There is no problem to fix Client#getTimeout to return rgiht timeout value.

          There is a compatibility concern about NameNodeProxiesClient#createNonHAProxyWithClientProtocol since HDFS-4646 depends on the value of Client#getTimeout when ipc.client.ping = false.

          ipc.client.ping = false
          ipc.ping.interval = 6000 (default)
          ipc.client.rpc-timeout.ms = 0(default)
          

          Client#getTimeout currently returns 6000 on the configuration above. If we fix to return 0 as timeout value, existing cluster which uses ipc.client.ping = false expecting that the timeout of namenode proxy is set to ipc.ping.interval lose the timeout setting.

          Show
          iwasakims Masatake Iwasaki added a comment - The value of Client#getTimeout is used in 2 places in the current hadoop code base. DfsClientConf.hdfsTimeout NameNodeProxiesClient#createNonHAProxyWithClientProtocol ( HDFS-4646 ) DfsClientConf.hdfsTimeout affects the renewal time of LeaseRenewer. There is no problem to fix Client#getTimeout to return rgiht timeout value. There is a compatibility concern about NameNodeProxiesClient#createNonHAProxyWithClientProtocol since HDFS-4646 depends on the value of Client#getTimeout when ipc.client.ping = false . ipc.client.ping = false ipc.ping.interval = 6000 (default) ipc.client.rpc-timeout.ms = 0(default) Client#getTimeout currently returns 6000 on the configuration above. If we fix to return 0 as timeout value, existing cluster which uses ipc.client.ping = false expecting that the timeout of namenode proxy is set to ipc.ping.interval lose the timeout setting.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I updated the patch.

          • fixed not to set negative soTimeout
          • added test case for negative timeout value is given
          • updated tests based on refactoring by HADOOP-12813
          • added Client#getRpcTimeout and deprecated Client#getTimeout
          Show
          iwasakims Masatake Iwasaki added a comment - I updated the patch. fixed not to set negative soTimeout added test case for negative timeout value is given updated tests based on refactoring by HADOOP-12813 added Client#getRpcTimeout and deprecated Client#getTimeout
          Hide
          iwasakims Masatake Iwasaki added a comment -

          attaching 006.

          Client#getTimeout should return the value of ipc.client.rpc-timeout.ms if it is set to > 0.

          Show
          iwasakims Masatake Iwasaki added a comment - attaching 006. Client#getTimeout should return the value of ipc.client.rpc-timeout.ms if it is set to > 0.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 8m 58s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 15m 54s Maven dependency ordering for branch
          +1 mvninstall 6m 30s trunk passed
          +1 compile 5m 33s trunk passed with JDK v1.8.0_74
          +1 compile 6m 31s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 1m 28s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 10s trunk passed
          +1 javadoc 1m 10s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 25s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 11s the patch passed
          +1 compile 5m 30s the patch passed with JDK v1.8.0_74
          -1 javac 6m 55s root-jdk1.8.0_74 with JDK v1.8.0_74 generated 2 new + 738 unchanged - 0 fixed = 740 total (was 738)
          +1 javac 5m 30s the patch passed
          +1 compile 6m 29s the patch passed with JDK v1.7.0_95
          -1 javac 13m 24s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 734 unchanged - 0 fixed = 736 total (was 734)
          +1 javac 6m 29s the patch passed
          +1 checkstyle 1m 4s the patch passed
          +1 mvnsite 1m 28s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 3m 36s the patch passed
          +1 javadoc 1m 11s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 26s the patch passed with JDK v1.7.0_95
          +1 unit 6m 43s hadoop-common in the patch passed with JDK v1.8.0_74.
          +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          -1 unit 6m 55s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          91m 57s



          Reason Tests
          JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestRPCWaitForProxy



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793164/HADOOP-12672.005.patch
          JIRA Issue HADOOP-12672
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux a8e06d04d990 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 658ee95
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac root-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_74.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 8m 58s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 15m 54s Maven dependency ordering for branch +1 mvninstall 6m 30s trunk passed +1 compile 5m 33s trunk passed with JDK v1.8.0_74 +1 compile 6m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 5s trunk passed +1 mvnsite 1m 28s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 10s trunk passed +1 javadoc 1m 10s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 25s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 11s the patch passed +1 compile 5m 30s the patch passed with JDK v1.8.0_74 -1 javac 6m 55s root-jdk1.8.0_74 with JDK v1.8.0_74 generated 2 new + 738 unchanged - 0 fixed = 740 total (was 738) +1 javac 5m 30s the patch passed +1 compile 6m 29s the patch passed with JDK v1.7.0_95 -1 javac 13m 24s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 734 unchanged - 0 fixed = 736 total (was 734) +1 javac 6m 29s the patch passed +1 checkstyle 1m 4s the patch passed +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 3m 36s the patch passed +1 javadoc 1m 11s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 26s the patch passed with JDK v1.7.0_95 +1 unit 6m 43s hadoop-common in the patch passed with JDK v1.8.0_74. +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. -1 unit 6m 55s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 91m 57s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestRPCWaitForProxy Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793164/HADOOP-12672.005.patch JIRA Issue HADOOP-12672 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux a8e06d04d990 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 658ee95 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_74.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8840/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 2m 57s Maven dependency ordering for branch
          +1 mvninstall 7m 2s trunk passed
          +1 compile 5m 40s trunk passed with JDK v1.8.0_74
          +1 compile 6m 30s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 1m 27s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 11s trunk passed
          +1 javadoc 1m 10s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 26s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 9s the patch passed
          +1 compile 5m 33s the patch passed with JDK v1.8.0_74
          -1 javac 6m 56s root-jdk1.8.0_74 with JDK v1.8.0_74 generated 2 new + 738 unchanged - 0 fixed = 740 total (was 738)
          +1 javac 5m 33s the patch passed
          +1 compile 6m 30s the patch passed with JDK v1.7.0_95
          -1 javac 13m 27s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 734 unchanged - 0 fixed = 736 total (was 734)
          +1 javac 6m 30s the patch passed
          +1 checkstyle 1m 4s the patch passed
          +1 mvnsite 1m 27s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 39s the patch passed
          +1 javadoc 1m 14s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 26s the patch passed with JDK v1.7.0_95
          -1 unit 6m 55s hadoop-common in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 52s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          -1 unit 6m 51s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          71m 6s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.ha.TestZKFailoverController
          JDK v1.7.0_95 Failed junit tests hadoop.fs.TestFsShellReturnCode



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793168/HADOOP-12672.006.patch
          JIRA Issue HADOOP-12672
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 621e2212f6c4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 658ee95
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac root-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_74.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 2m 57s Maven dependency ordering for branch +1 mvninstall 7m 2s trunk passed +1 compile 5m 40s trunk passed with JDK v1.8.0_74 +1 compile 6m 30s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 4s trunk passed +1 mvnsite 1m 27s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 11s trunk passed +1 javadoc 1m 10s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 26s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 9s the patch passed +1 compile 5m 33s the patch passed with JDK v1.8.0_74 -1 javac 6m 56s root-jdk1.8.0_74 with JDK v1.8.0_74 generated 2 new + 738 unchanged - 0 fixed = 740 total (was 738) +1 javac 5m 33s the patch passed +1 compile 6m 30s the patch passed with JDK v1.7.0_95 -1 javac 13m 27s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 734 unchanged - 0 fixed = 736 total (was 734) +1 javac 6m 30s the patch passed +1 checkstyle 1m 4s the patch passed +1 mvnsite 1m 27s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 39s the patch passed +1 javadoc 1m 14s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 26s the patch passed with JDK v1.7.0_95 -1 unit 6m 55s hadoop-common in the patch failed with JDK v1.8.0_74. +1 unit 0m 52s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. -1 unit 6m 51s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 71m 6s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.ha.TestZKFailoverController JDK v1.7.0_95 Failed junit tests hadoop.fs.TestFsShellReturnCode Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793168/HADOOP-12672.006.patch JIRA Issue HADOOP-12672 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 621e2212f6c4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 658ee95 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_74.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8841/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          No worries about the breakage, though I think I'd have been happier if 2.6 wasn't picking up so much of these RPC changes, not until they were stable.

          Can you add this patch to HDFS and YARN JIRAs so we can verify their miniclusters are happy this time round?

          Show
          stevel@apache.org Steve Loughran added a comment - No worries about the breakage, though I think I'd have been happier if 2.6 wasn't picking up so much of these RPC changes, not until they were stable. Can you add this patch to HDFS and YARN JIRAs so we can verify their miniclusters are happy this time round?
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I filed HDFS-9954 to test the patch against HDFS. I will file a YARN task if it works.

          Show
          iwasakims Masatake Iwasaki added a comment - I filed HDFS-9954 to test the patch against HDFS. I will file a YARN task if it works.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          It turned out that creating HDFS jira and attaching patch does not invoke HDFS tests. test-patch runs tests based on the contents of the patch. Though test-patch.sh of Yetus provides --modulelist option to run additional tests, it seems not to be possible to use it via QA build. (Thanks to Kengo Seki for the information.)

          I ran tests of HDFS and YARN locally after applying 006 and mvn install -DskipTests. No test failure except for already reported intermittent ones.

          Show
          iwasakims Masatake Iwasaki added a comment - It turned out that creating HDFS jira and attaching patch does not invoke HDFS tests. test-patch runs tests based on the contents of the patch. Though test-patch.sh of Yetus provides --modulelist option to run additional tests, it seems not to be possible to use it via QA build. (Thanks to Kengo Seki for the information.) I ran tests of HDFS and YARN locally after applying 006 and mvn install -DskipTests . No test failure except for already reported intermittent ones.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 the v6 patch lgtm. Ran a few failing tests locally and they passed although it is unfortunate we cannot get a full unit test run. Thanks.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 the v6 patch lgtm. Ran a few failing tests locally and they passed although it is unfortunate we cannot get a full unit test run. Thanks.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks again, Arpit Agarwal. I will wait further comments from other reviewers for a day before committing this.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks again, Arpit Agarwal . I will wait further comments from other reviewers for a day before committing this.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Committed to branch-2.8 and above. Thanks.

          Show
          iwasakims Masatake Iwasaki added a comment - Committed to branch-2.8 and above. Thanks.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9561 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9561/)
          HADOOP-12672. RPC timeout should not override IPC ping interval (iwasakims: rev 85ec5573eb9fd746a9295ecc6fe1ae683073aaf5)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/DfsClientConf.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9561 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9561/ ) HADOOP-12672 . RPC timeout should not override IPC ping interval (iwasakims: rev 85ec5573eb9fd746a9295ecc6fe1ae683073aaf5) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/DfsClientConf.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml

            People

            • Assignee:
              iwasakims Masatake Iwasaki
              Reporter:
              iwasakims Masatake Iwasaki
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development