Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12668

Support excluding weak Ciphers in HttpServer2 through ssl-server.xml

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      The Code Changes include following:
      - Modified DFSUtil.java in Apache HDFS project for supplying new parameter ssl.server.exclude.cipher.list
      - Modified HttpServer2.java in Apache Hadoop-common project to work with new parameter and exclude ciphers using jetty setExcludeCihers method.
      - Modfied associated test classes to owrk with existing code and also cover the newfunctionality in junit
      Show
      The Code Changes include following: - Modified DFSUtil.java in Apache HDFS project for supplying new parameter ssl.server.exclude.cipher.list - Modified HttpServer2.java in Apache Hadoop-common project to work with new parameter and exclude ciphers using jetty setExcludeCihers method. - Modfied associated test classes to owrk with existing code and also cover the newfunctionality in junit
    • Tags:
      security ssl tls hadoop

      Description

      Currently Embeded jetty Server used across all hadoop services is configured through ssl-server.xml file from their respective configuration section. However, the SSL/TLS protocol being used for this jetty servers can be downgraded to weak cipher suites. This code changes aims to add following functionality:
      1) Add logic in hadoop common (HttpServer2.java and associated interfaces) to spawn jetty servers with ability to exclude weak cipher suites. I propose we make this though ssl-server.xml and hence each service can choose to disable specific ciphers.
      2) Modify DFSUtil.java used by HDFS code to supply new parameter ssl.server.exclude.cipher.list for hadoop-common code, so it can exclude the ciphers supplied through this key.

      1. Hadoop-12668.012.patch
        23 kB
        Zhe Zhang
      2. Hadoop-12668.011.patch
        24 kB
        Vijay Singh
      3. Hadoop-12668.010.patch
        24 kB
        Vijay Singh
      4. Hadoop-12668.009.patch
        20 kB
        Vijay Singh
      5. Hadoop-12668.008.patch
        20 kB
        Vijay Singh
      6. test.log
        186 kB
        Vijay Singh
      7. Hadoop-12668.007.patch
        16 kB
        Vijay Singh
      8. Hadoop-12668.006.patch
        14 kB
        Vijay Singh

        Issue Links

          Activity

          Hide
          zhz Zhe Zhang added a comment -

          I cherry-picked this to branch-2.7 in support of HADOOP-12765

          Show
          zhz Zhe Zhang added a comment - I cherry-picked this to branch-2.7 in support of HADOOP-12765
          Hide
          SINGHVJD Vijay Singh added a comment -

          Zhe Zhang
          Thanks a ton for all your suggestions and updating the license header file. Thank you again.

          Show
          SINGHVJD Vijay Singh added a comment - Zhe Zhang Thanks a ton for all your suggestions and updating the license header file. Thank you again.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9342 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9342/)
          HADOOP-12668. Support excluding weak Ciphers in HttpServer2 through (zhz: rev a2fdfff02daef85b651eda31e99868986aab5b28)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestSSLHttpServer.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/KeyStoreTestUtil.java
          • hadoop-common-project/hadoop-common/src/main/conf/ssl-server.xml.example
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpCookieFlag.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9342 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9342/ ) HADOOP-12668 . Support excluding weak Ciphers in HttpServer2 through (zhz: rev a2fdfff02daef85b651eda31e99868986aab5b28) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestSSLHttpServer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/KeyStoreTestUtil.java hadoop-common-project/hadoop-common/src/main/conf/ssl-server.xml.example hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpCookieFlag.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Hide
          zhz Zhe Zhang added a comment -

          Committed v12 patch to trunk, branch-2, and branch-2.8. Thanks Vijay for the contribution!

          Show
          zhz Zhe Zhang added a comment - Committed v12 patch to trunk, branch-2, and branch-2.8. Thanks Vijay for the contribution!
          Hide
          zhz Zhe Zhang added a comment -

          Thanks Vijay Singh, +1 on the v11 patch except for the unnecessary license header change. I'm attaching v12 to address. Will commit the patch soon.

          Show
          zhz Zhe Zhang added a comment - Thanks Vijay Singh , +1 on the v11 patch except for the unnecessary license header change. I'm attaching v12 to address. Will commit the patch soon.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Patch 11 (same code) when submitted for the latest tests, ran fine for tests in error in earlier run. However, there was one error in latest run that did not error in earlier release. This makes me believe the test runs though in error have covered all unit tests successfully in two separate runs.

          Please advise the next steps for me. I am at loss here as to how can I guarantee successful run without any -1.

          Show
          SINGHVJD Vijay Singh added a comment - Patch 11 (same code) when submitted for the latest tests, ran fine for tests in error in earlier run. However, there was one error in latest run that did not error in earlier release. This makes me believe the test runs though in error have covered all unit tests successfully in two separate runs. Please advise the next steps for me. I am at loss here as to how can I guarantee successful run without any -1.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 2m 12s Maven dependency ordering for branch
          +1 mvninstall 6m 48s trunk passed
          +1 compile 6m 21s trunk passed with JDK v1.8.0_72
          +1 compile 6m 43s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 2m 25s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 4m 36s trunk passed
          +1 javadoc 2m 23s trunk passed with JDK v1.8.0_72
          +1 javadoc 3m 20s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 50s the patch passed
          +1 compile 5m 37s the patch passed with JDK v1.8.0_72
          +1 javac 5m 37s the patch passed
          +1 compile 6m 38s the patch passed with JDK v1.7.0_95
          +1 javac 6m 38s the patch passed
          +1 checkstyle 1m 5s the patch passed
          +1 mvnsite 2m 21s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 5m 16s the patch passed
          +1 javadoc 2m 20s the patch passed with JDK v1.8.0_72
          +1 javadoc 3m 20s the patch passed with JDK v1.7.0_95
          +1 unit 6m 43s hadoop-common in the patch passed with JDK v1.8.0_72.
          -1 unit 52m 9s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          +1 unit 7m 3s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 50m 6s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          188m 18s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.TestFileAppend



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788852/Hadoop-12668.011.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux b85e0fd56126 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d5abd29
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8673/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8673/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8673/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8673/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 2m 12s Maven dependency ordering for branch +1 mvninstall 6m 48s trunk passed +1 compile 6m 21s trunk passed with JDK v1.8.0_72 +1 compile 6m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 5s trunk passed +1 mvnsite 2m 25s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 4m 36s trunk passed +1 javadoc 2m 23s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 20s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 50s the patch passed +1 compile 5m 37s the patch passed with JDK v1.8.0_72 +1 javac 5m 37s the patch passed +1 compile 6m 38s the patch passed with JDK v1.7.0_95 +1 javac 6m 38s the patch passed +1 checkstyle 1m 5s the patch passed +1 mvnsite 2m 21s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 16s the patch passed +1 javadoc 2m 20s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 20s the patch passed with JDK v1.7.0_95 +1 unit 6m 43s hadoop-common in the patch passed with JDK v1.8.0_72. -1 unit 52m 9s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. +1 unit 7m 3s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 50m 6s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 188m 18s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.TestFileAppend Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788852/Hadoop-12668.011.patch JIRA Issue HADOOP-12668 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux b85e0fd56126 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d5abd29 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8673/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8673/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8673/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8673/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Attaching the same patch to get one more clean run.

          Show
          SINGHVJD Vijay Singh added a comment - Attaching the same patch to get one more clean run.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Zhe Zhang
          I ran the tests again locally and everything seems to pass. Additionally, even apache yetus based runs seem to throw mutually exclusive errors for apparent no code change at all. Example: v10 and v11 only differ in usage of Cipher for TestSSLHttpServer class but have mutually disjoint errors for JDK7 and JDK8.
          Thank you for your feedback. I have incorporated all the suggestions. Please let me know if you have further feedback.

          Show
          SINGHVJD Vijay Singh added a comment - Zhe Zhang I ran the tests again locally and everything seems to pass. Additionally, even apache yetus based runs seem to throw mutually exclusive errors for apparent no code change at all. Example: v10 and v11 only differ in usage of Cipher for TestSSLHttpServer class but have mutually disjoint errors for JDK7 and JDK8. Thank you for your feedback. I have incorporated all the suggestions. Please let me know if you have further feedback.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 37s Maven dependency ordering for branch
          +1 mvninstall 13m 14s trunk passed
          +1 compile 19m 43s trunk passed with JDK v1.8.0_72
          +1 compile 13m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 54s trunk passed
          +1 mvnsite 4m 33s trunk passed
          +1 mvneclipse 1m 5s trunk passed
          +1 findbugs 7m 54s trunk passed
          +1 javadoc 5m 44s trunk passed with JDK v1.8.0_72
          +1 javadoc 6m 30s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 25s Maven dependency ordering for patch
          +1 mvninstall 3m 39s the patch passed
          +1 compile 17m 48s the patch passed with JDK v1.8.0_72
          +1 javac 17m 48s the patch passed
          +1 compile 11m 33s the patch passed with JDK v1.7.0_95
          +1 javac 11m 33s the patch passed
          +1 checkstyle 1m 37s the patch passed
          +1 mvnsite 3m 50s the patch passed
          +1 mvneclipse 1m 1s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 8m 7s the patch passed
          +1 javadoc 3m 54s the patch passed with JDK v1.8.0_72
          +1 javadoc 4m 45s the patch passed with JDK v1.7.0_95
          +1 unit 11m 19s hadoop-common in the patch passed with JDK v1.8.0_72.
          -1 unit 85m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 3m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          -1 unit 11m 50s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 93m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 unit 3m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 40s Patch does not generate ASF License warnings.
          345m 1s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestRollingUpgrade
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
            org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager
            org.apache.hadoop.hdfs.TestHDFSFileSystemContract
            org.apache.hadoop.hdfs.TestBlockStoragePolicy
            org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
          JDK v1.7.0_95 Failed junit tests hadoop.fs.shell.find.TestPrint
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.TestSecureNameNode
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788646/Hadoop-12668.011.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 472860775de3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 748b6c0
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 37s Maven dependency ordering for branch +1 mvninstall 13m 14s trunk passed +1 compile 19m 43s trunk passed with JDK v1.8.0_72 +1 compile 13m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 54s trunk passed +1 mvnsite 4m 33s trunk passed +1 mvneclipse 1m 5s trunk passed +1 findbugs 7m 54s trunk passed +1 javadoc 5m 44s trunk passed with JDK v1.8.0_72 +1 javadoc 6m 30s trunk passed with JDK v1.7.0_95 0 mvndep 0m 25s Maven dependency ordering for patch +1 mvninstall 3m 39s the patch passed +1 compile 17m 48s the patch passed with JDK v1.8.0_72 +1 javac 17m 48s the patch passed +1 compile 11m 33s the patch passed with JDK v1.7.0_95 +1 javac 11m 33s the patch passed +1 checkstyle 1m 37s the patch passed +1 mvnsite 3m 50s the patch passed +1 mvneclipse 1m 1s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 8m 7s the patch passed +1 javadoc 3m 54s the patch passed with JDK v1.8.0_72 +1 javadoc 4m 45s the patch passed with JDK v1.7.0_95 +1 unit 11m 19s hadoop-common in the patch passed with JDK v1.8.0_72. -1 unit 85m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 3m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. -1 unit 11m 50s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 93m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 unit 3m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 40s Patch does not generate ASF License warnings. 345m 1s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestRollingUpgrade   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.security.TestDelegationTokenForProxyUser JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2   org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager   org.apache.hadoop.hdfs.TestHDFSFileSystemContract   org.apache.hadoop.hdfs.TestBlockStoragePolicy   org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010 JDK v1.7.0_95 Failed junit tests hadoop.fs.shell.find.TestPrint   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.TestSecureNameNode   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788646/Hadoop-12668.011.patch JIRA Issue HADOOP-12668 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux 472860775de3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 748b6c0 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8670/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 41s trunk passed
          +1 compile 5m 51s trunk passed with JDK v1.8.0_72
          +1 compile 6m 38s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 2m 23s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 4m 34s trunk passed
          +1 javadoc 2m 24s trunk passed with JDK v1.8.0_72
          +1 javadoc 3m 24s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 52s the patch passed
          +1 compile 5m 44s the patch passed with JDK v1.8.0_72
          +1 javac 5m 44s the patch passed
          +1 compile 6m 37s the patch passed with JDK v1.7.0_95
          +1 javac 6m 37s the patch passed
          +1 checkstyle 1m 5s the patch passed
          +1 mvnsite 2m 23s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 5m 16s the patch passed
          +1 javadoc 2m 24s the patch passed with JDK v1.8.0_72
          +1 javadoc 3m 22s the patch passed with JDK v1.7.0_95
          -1 unit 6m 35s hadoop-common in the patch failed with JDK v1.8.0_72.
          -1 unit 51m 39s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          -1 unit 6m 35s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 50m 2s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          184m 43s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.http.TestSSLHttpServer
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.TestDFSUpgradeFromImage
          JDK v1.7.0_95 Failed junit tests hadoop.http.TestSSLHttpServer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788633/Hadoop-12668.010.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 0f0fa426d738 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 748b6c0
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 41s trunk passed +1 compile 5m 51s trunk passed with JDK v1.8.0_72 +1 compile 6m 38s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 6s trunk passed +1 mvnsite 2m 23s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 4m 34s trunk passed +1 javadoc 2m 24s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 24s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 52s the patch passed +1 compile 5m 44s the patch passed with JDK v1.8.0_72 +1 javac 5m 44s the patch passed +1 compile 6m 37s the patch passed with JDK v1.7.0_95 +1 javac 6m 37s the patch passed +1 checkstyle 1m 5s the patch passed +1 mvnsite 2m 23s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 16s the patch passed +1 javadoc 2m 24s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 22s the patch passed with JDK v1.7.0_95 -1 unit 6m 35s hadoop-common in the patch failed with JDK v1.8.0_72. -1 unit 51m 39s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. -1 unit 6m 35s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 50m 2s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 184m 43s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.http.TestSSLHttpServer   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.TestDFSUpgradeFromImage JDK v1.7.0_95 Failed junit tests hadoop.http.TestSSLHttpServer Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788633/Hadoop-12668.010.patch JIRA Issue HADOOP-12668 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux 0f0fa426d738 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 748b6c0 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8668/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Please find attached the patch v11 for review.

          Show
          SINGHVJD Vijay Singh added a comment - Please find attached the patch v11 for review.
          Hide
          SINGHVJD Vijay Singh added a comment -

          One more thing, patch 10 assumes that Unlimited JCE policy files will be installed and JCE provider will suppport AES 256 on test platform. However, that may not always be a prudent assumption. Consequently , I am posting the new patch with AES128 bit ciphers for atleast one enabled cipher and mutually exclusive cipher test. This patch is patch version 11. Please review patch 11 and provide feedback if any.

          Show
          SINGHVJD Vijay Singh added a comment - One more thing, patch 10 assumes that Unlimited JCE policy files will be installed and JCE provider will suppport AES 256 on test platform. However, that may not always be a prudent assumption. Consequently , I am posting the new patch with AES128 bit ciphers for atleast one enabled cipher and mutually exclusive cipher test. This patch is patch version 11. Please review patch 11 and provide feedback if any.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Please review the new patch with suggested changes.

          Show
          SINGHVJD Vijay Singh added a comment - Please review the new patch with suggested changes.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Zhe Zhang
          Thank you for feedback. I will incorporate the changes as per suggestion and submit new patch version tonight.

          Show
          SINGHVJD Vijay Singh added a comment - Zhe Zhang Thank you for feedback. I will incorporate the changes as per suggestion and submit new patch version tonight.
          Hide
          zhz Zhe Zhang added a comment -

          Thanks for the new patch Vijay Singh. The main code change looks good. A few minors on the test code:

          1. PrefferedCipherSSLSocketFactory is a good idea to handle different enabled ciphers on local test machines. Thanks for the thoughtful work. However it shouldn't be in the test package instead of main. Since it's only used by TestSSLHttpServer we should actually make it an inner class.
          2. Ideally we should verify 2 things: 1) when the set of enabled ciphers is not fully covered by the set of excluded ciphers, SSL handshake should work; 2) when the set of enabled ciphers is fully covered by excluded ciphers, handshake should fail. We can add a separate enabledCiphers which doesn't overlap with excludeCiphers:
            private static final String enabledCiphers = "XXXX";
            ...
            PrefferedCipherSSLSocketFactory testPreferredCipherSSLSocketFactory
                        = new PrefferedCipherSSLSocketFactory(sslSocketFactory,
                    enabledCiphers.split(","));
            // Try handshake, should work
            PrefferedCipherSSLSocketFactory testPreferredCipherSSLSocketFactory
                        = new PrefferedCipherSSLSocketFactory(sslSocketFactory,
                    excludeCiphers.split(","));
            // Try handshake again, should fail
            

            This is optional though. Up to you whether to add it. I tried the enabledCiphers idea locally, saw expected behavior.

          3. A better way to assert a test failure is to add fail in the try segment:
            try {
                  InputStream in = conn.getInputStream();
                  ByteArrayOutputStream out = new ByteArrayOutputStream();
                  IOUtils.copyBytes(in, out, 1024);
                  fail("SSLHandshake shouldn't pass xxxx");
            } catch (SSLHandshakeException ex) {
                  LOG.info("No Ciphers in common, expected behavior", ex);
            }
            
          4. testExcludedCiphers has some unused local variables: excludedCiphers, response
          5. Typo "succeded"

          +1 after addressing the above

          Show
          zhz Zhe Zhang added a comment - Thanks for the new patch Vijay Singh . The main code change looks good. A few minors on the test code: PrefferedCipherSSLSocketFactory is a good idea to handle different enabled ciphers on local test machines. Thanks for the thoughtful work. However it shouldn't be in the test package instead of main . Since it's only used by TestSSLHttpServer we should actually make it an inner class. Ideally we should verify 2 things: 1) when the set of enabled ciphers is not fully covered by the set of excluded ciphers, SSL handshake should work; 2) when the set of enabled ciphers is fully covered by excluded ciphers, handshake should fail. We can add a separate enabledCiphers which doesn't overlap with excludeCiphers : private static final String enabledCiphers = "XXXX" ; ... PrefferedCipherSSLSocketFactory testPreferredCipherSSLSocketFactory = new PrefferedCipherSSLSocketFactory(sslSocketFactory, enabledCiphers.split( "," )); // Try handshake, should work PrefferedCipherSSLSocketFactory testPreferredCipherSSLSocketFactory = new PrefferedCipherSSLSocketFactory(sslSocketFactory, excludeCiphers.split( "," )); // Try handshake again, should fail This is optional though. Up to you whether to add it. I tried the enabledCiphers idea locally, saw expected behavior. A better way to assert a test failure is to add fail in the try segment: try { InputStream in = conn.getInputStream(); ByteArrayOutputStream out = new ByteArrayOutputStream(); IOUtils.copyBytes(in, out, 1024); fail( "SSLHandshake shouldn't pass xxxx" ); } catch (SSLHandshakeException ex) { LOG.info( "No Ciphers in common, expected behavior" , ex); } testExcludedCiphers has some unused local variables: excludedCiphers , response Typo "succeded" +1 after addressing the above
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 14s Maven dependency ordering for branch
          +1 mvninstall 7m 0s trunk passed
          +1 compile 5m 56s trunk passed with JDK v1.8.0_72
          +1 compile 6m 43s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 8s trunk passed
          +1 mvnsite 2m 31s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 4m 35s trunk passed
          +1 javadoc 2m 30s trunk passed with JDK v1.8.0_72
          +1 javadoc 3m 24s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 55s the patch passed
          +1 compile 5m 49s the patch passed with JDK v1.8.0_72
          +1 javac 5m 49s the patch passed
          +1 compile 6m 55s the patch passed with JDK v1.7.0_95
          +1 javac 6m 55s the patch passed
          -1 checkstyle 1m 7s root: patch generated 1 new + 149 unchanged - 0 fixed = 150 total (was 149)
          +1 mvnsite 2m 31s the patch passed
          +1 mvneclipse 0m 45s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 5m 26s the patch passed
          +1 javadoc 2m 29s the patch passed with JDK v1.8.0_72
          +1 javadoc 3m 24s the patch passed with JDK v1.7.0_95
          +1 unit 7m 4s hadoop-common in the patch passed with JDK v1.8.0_72.
          -1 unit 64m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 68m 14s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          220m 16s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestLeaseRecovery2



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788404/Hadoop-12668.009.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux d1d67ba7966c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7de7068
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 14s Maven dependency ordering for branch +1 mvninstall 7m 0s trunk passed +1 compile 5m 56s trunk passed with JDK v1.8.0_72 +1 compile 6m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 8s trunk passed +1 mvnsite 2m 31s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 4m 35s trunk passed +1 javadoc 2m 30s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 24s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 55s the patch passed +1 compile 5m 49s the patch passed with JDK v1.8.0_72 +1 javac 5m 49s the patch passed +1 compile 6m 55s the patch passed with JDK v1.7.0_95 +1 javac 6m 55s the patch passed -1 checkstyle 1m 7s root: patch generated 1 new + 149 unchanged - 0 fixed = 150 total (was 149) +1 mvnsite 2m 31s the patch passed +1 mvneclipse 0m 45s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 26s the patch passed +1 javadoc 2m 29s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 24s the patch passed with JDK v1.7.0_95 +1 unit 7m 4s hadoop-common in the patch passed with JDK v1.8.0_72. -1 unit 64m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 68m 14s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 220m 16s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788404/Hadoop-12668.009.patch JIRA Issue HADOOP-12668 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux d1d67ba7966c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7de7068 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8660/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Added Patch-9 file to address checkstyle issues. Junit tests run fine locally for me.

          Show
          SINGHVJD Vijay Singh added a comment - Added Patch-9 file to address checkstyle issues. Junit tests run fine locally for me.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Working on checkstyle issues and analyzing failed JDK tests. Will update by tonight

          Show
          SINGHVJD Vijay Singh added a comment - Working on checkstyle issues and analyzing failed JDK tests. Will update by tonight
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 7m 6s trunk passed
          +1 compile 6m 27s trunk passed with JDK v1.8.0_72
          +1 compile 7m 10s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 9s trunk passed
          +1 mvnsite 2m 34s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 4m 55s trunk passed
          +1 javadoc 2m 36s trunk passed with JDK v1.8.0_72
          +1 javadoc 3m 33s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 2m 1s the patch passed
          +1 compile 6m 26s the patch passed with JDK v1.8.0_72
          +1 javac 6m 26s the patch passed
          +1 compile 7m 8s the patch passed with JDK v1.7.0_95
          +1 javac 7m 8s the patch passed
          -1 checkstyle 1m 8s root: patch generated 69 new + 150 unchanged - 0 fixed = 219 total (was 150)
          +1 mvnsite 2m 32s the patch passed
          +1 mvneclipse 0m 43s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 5m 40s the patch passed
          +1 javadoc 2m 31s the patch passed with JDK v1.8.0_72
          +1 javadoc 3m 32s the patch passed with JDK v1.7.0_95
          +1 unit 9m 3s hadoop-common in the patch passed with JDK v1.8.0_72.
          -1 unit 67m 46s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          -1 unit 7m 47s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 unit 59m 23s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          219m 10s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
          JDK v1.7.0_95 Failed junit tests hadoop.net.TestClusterTopology
            hadoop.hdfs.TestEncryptionZones



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788194/Hadoop-12668.008.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux c087fa0dddfc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 453e7e0
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 7m 6s trunk passed +1 compile 6m 27s trunk passed with JDK v1.8.0_72 +1 compile 7m 10s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 9s trunk passed +1 mvnsite 2m 34s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 4m 55s trunk passed +1 javadoc 2m 36s trunk passed with JDK v1.8.0_72 +1 javadoc 3m 33s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 2m 1s the patch passed +1 compile 6m 26s the patch passed with JDK v1.8.0_72 +1 javac 6m 26s the patch passed +1 compile 7m 8s the patch passed with JDK v1.7.0_95 +1 javac 7m 8s the patch passed -1 checkstyle 1m 8s root: patch generated 69 new + 150 unchanged - 0 fixed = 219 total (was 150) +1 mvnsite 2m 32s the patch passed +1 mvneclipse 0m 43s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 5m 40s the patch passed +1 javadoc 2m 31s the patch passed with JDK v1.8.0_72 +1 javadoc 3m 32s the patch passed with JDK v1.7.0_95 +1 unit 9m 3s hadoop-common in the patch passed with JDK v1.8.0_72. -1 unit 67m 46s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. -1 unit 7m 47s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 59m 23s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 219m 10s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS JDK v1.7.0_95 Failed junit tests hadoop.net.TestClusterTopology   hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788194/Hadoop-12668.008.patch JIRA Issue HADOOP-12668 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux c087fa0dddfc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 453e7e0 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8641/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Thanks Vijay Singh

          Show
          jzhuge John Zhuge added a comment - Thanks Vijay Singh
          Hide
          SINGHVJD Vijay Singh added a comment -

          This patch file introduces the junit testcase to test excluded ciphers. This is done by using delegation based subclass for SSLSocketfactory and overriding the createSocket method to only support disabled algorithms on the client. When this new subclass called PrefferedCipherSSLSocketFactory is passed to clientSSLFactory, we encounter SSLHandshakeException. This validates the unit test case, we catch the exception pass the changed flag to assert method.

          Please provide additional suggestions if any.

          Show
          SINGHVJD Vijay Singh added a comment - This patch file introduces the junit testcase to test excluded ciphers. This is done by using delegation based subclass for SSLSocketfactory and overriding the createSocket method to only support disabled algorithms on the client. When this new subclass called PrefferedCipherSSLSocketFactory is passed to clientSSLFactory, we encounter SSLHandshakeException. This validates the unit test case, we catch the exception pass the changed flag to assert method. Please provide additional suggestions if any.
          Hide
          jzhuge John Zhuge added a comment -

          Vijay Singh,

          Thank you for working on this fix. Is the new patch coming up?

          Thanks,
          John

          Show
          jzhuge John Zhuge added a comment - Vijay Singh , Thank you for working on this fix. Is the new patch coming up? Thanks, John
          Hide
          SINGHVJD Vijay Singh added a comment -

          Got it. It seems on mac availableCiphers include excludedCiphers. However, on Centos/RHEL they do not. I will come up with more complete unit test using SSLScoket mechanism.
          Thanks for valuable feedback suggestions.

          Show
          SINGHVJD Vijay Singh added a comment - Got it. It seems on mac availableCiphers include excludedCiphers. However, on Centos/RHEL they do not. I will come up with more complete unit test using SSLScoket mechanism. Thanks for valuable feedback suggestions.
          Hide
          zhz Zhe Zhang added a comment -

          I added a break point and printed the values in availableCiphers. I think the main point of the unit test is to verify that once we add one of the below to excludeCiphers, they won't appear in availableCiphers anymore. Then we know the added config knob is taking effect.

          0 = "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA"
          1 = "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA"
          2 = "TLS_RSA_WITH_AES_128_CBC_SHA"
          3 = "TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA"
          4 = "TLS_ECDH_RSA_WITH_AES_128_CBC_SHA"
          5 = "TLS_DHE_RSA_WITH_AES_128_CBC_SHA"
          6 = "TLS_DHE_DSS_WITH_AES_128_CBC_SHA"
          7 = "TLS_ECDHE_ECDSA_WITH_RC4_128_SHA"
          8 = "TLS_ECDHE_RSA_WITH_RC4_128_SHA"
          9 = "SSL_RSA_WITH_RC4_128_SHA"
          10 = "TLS_ECDH_ECDSA_WITH_RC4_128_SHA"
          11 = "TLS_ECDH_RSA_WITH_RC4_128_SHA"
          12 = "TLS_ECDHE_ECDSA_WITH_3DES_EDE_CBC_SHA"
          13 = "TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA"
          14 = "SSL_RSA_WITH_3DES_EDE_CBC_SHA"
          15 = "TLS_ECDH_ECDSA_WITH_3DES_EDE_CBC_SHA"
          16 = "TLS_ECDH_RSA_WITH_3DES_EDE_CBC_SHA"
          17 = "SSL_DHE_RSA_WITH_3DES_EDE_CBC_SHA"
          18 = "SSL_DHE_DSS_WITH_3DES_EDE_CBC_SHA"
          19 = "SSL_RSA_WITH_RC4_128_MD5"
          20 = "TLS_EMPTY_RENEGOTIATION_INFO_SCSV"
          
          Show
          zhz Zhe Zhang added a comment - I added a break point and printed the values in availableCiphers . I think the main point of the unit test is to verify that once we add one of the below to excludeCiphers , they won't appear in availableCiphers anymore. Then we know the added config knob is taking effect. 0 = "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA" 1 = "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA" 2 = "TLS_RSA_WITH_AES_128_CBC_SHA" 3 = "TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA" 4 = "TLS_ECDH_RSA_WITH_AES_128_CBC_SHA" 5 = "TLS_DHE_RSA_WITH_AES_128_CBC_SHA" 6 = "TLS_DHE_DSS_WITH_AES_128_CBC_SHA" 7 = "TLS_ECDHE_ECDSA_WITH_RC4_128_SHA" 8 = "TLS_ECDHE_RSA_WITH_RC4_128_SHA" 9 = "SSL_RSA_WITH_RC4_128_SHA" 10 = "TLS_ECDH_ECDSA_WITH_RC4_128_SHA" 11 = "TLS_ECDH_RSA_WITH_RC4_128_SHA" 12 = "TLS_ECDHE_ECDSA_WITH_3DES_EDE_CBC_SHA" 13 = "TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA" 14 = "SSL_RSA_WITH_3DES_EDE_CBC_SHA" 15 = "TLS_ECDH_ECDSA_WITH_3DES_EDE_CBC_SHA" 16 = "TLS_ECDH_RSA_WITH_3DES_EDE_CBC_SHA" 17 = "SSL_DHE_RSA_WITH_3DES_EDE_CBC_SHA" 18 = "SSL_DHE_DSS_WITH_3DES_EDE_CBC_SHA" 19 = "SSL_RSA_WITH_RC4_128_MD5" 20 = "TLS_EMPTY_RENEGOTIATION_INFO_SCSV"
          Hide
          SINGHVJD Vijay Singh added a comment -

          Zhe Zhang

          1. Yes, it is designed that way. we are setting the excludedCiphers right in the beginning as private static member and using it to create sslConf. As a result, the excludedCiphers will never be empty. What I can do here is that I can write a testNonEmptyExcludedCipher to assert that it is never null or empty. Please suggest if this unit test will be sufficiet.
          2. I Will take get rid of trivial annotations
          3. I will make the Hashamp on availableCiphers and Iterate over smaller excludedCipher to create hash based key (ciphersuite) lookup.
          Show
          SINGHVJD Vijay Singh added a comment - Zhe Zhang Yes, it is designed that way. we are setting the excludedCiphers right in the beginning as private static member and using it to create sslConf. As a result, the excludedCiphers will never be empty. What I can do here is that I can write a testNonEmptyExcludedCipher to assert that it is never null or empty. Please suggest if this unit test will be sufficiet. I Will take get rid of trivial annotations I will make the Hashamp on availableCiphers and Iterate over smaller excludedCipher to create hash based key (ciphersuite) lookup.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Thank you for your comments. I will incoroprate te feedback shortly, test and submit the patch by tonight.

          Show
          SINGHVJD Vijay Singh added a comment - Thank you for your comments. I will incoroprate te feedback shortly, test and submit the patch by tonight.
          Hide
          zhz Zhe Zhang added a comment -

          Thanks Vijay for updating the patch. Agreed that Jenkins seems broken in the last run. I just triggered again.

          A few comments about the test:

          1. In TestSSLHttpServer#testExcludedCiphers, even with an empty excludeCiphers, the test will pass. Is getDefaultCipherSuites the right method to use?
          2. Javadoc of testExcludedCiphers shouldn't include empty/trivial return and throws annotations.
          3. The below double loop can be replaced with a hash map lookup to make sure there's no overlap.
                for(String excludedCipher : excludedCiphers) {
                  for (String availableCipher : availableCiphers) {
            
          4. Tyop "execluded"
          Show
          zhz Zhe Zhang added a comment - Thanks Vijay for updating the patch. Agreed that Jenkins seems broken in the last run. I just triggered again. A few comments about the test: In TestSSLHttpServer#testExcludedCiphers , even with an empty excludeCiphers , the test will pass. Is getDefaultCipherSuites the right method to use? Javadoc of testExcludedCiphers shouldn't include empty/trivial return and throws annotations. The below double loop can be replaced with a hash map lookup to make sure there's no overlap. for ( String excludedCipher : excludedCiphers) { for ( String availableCipher : availableCiphers) { Tyop "execluded"
          Hide
          SINGHVJD Vijay Singh added a comment -

          Attached the test log file for failed test cases.

          Show
          SINGHVJD Vijay Singh added a comment - Attached the test log file for failed test cases.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Zhe Zhang
          Although, apache yetus run had few tests failed, when I ran the test in standalone centos server on AWS, it executed perfectly for failed errors. Attached the log for same. I am at loss here for these intermittent test case failures.

          Show
          SINGHVJD Vijay Singh added a comment - Zhe Zhang Although, apache yetus run had few tests failed, when I ran the test in standalone centos server on AWS, it executed perfectly for failed errors. Attached the log for same. I am at loss here for these intermittent test case failures.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 36s Maven dependency ordering for branch
          +1 mvninstall 10m 41s trunk passed
          +1 compile 14m 6s trunk passed with JDK v1.8.0_66
          +1 compile 11m 21s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 36s trunk passed
          +1 mvnsite 3m 48s trunk passed
          +1 mvneclipse 0m 58s trunk passed
          +1 findbugs 7m 41s trunk passed
          +1 javadoc 4m 26s trunk passed with JDK v1.8.0_66
          +1 javadoc 5m 3s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 36s Maven dependency ordering for patch
          +1 mvninstall 2m 55s the patch passed
          +1 compile 14m 12s the patch passed with JDK v1.8.0_66
          +1 javac 14m 12s the patch passed
          +1 compile 11m 58s the patch passed with JDK v1.7.0_91
          +1 javac 11m 58s the patch passed
          +1 checkstyle 1m 40s the patch passed
          +1 mvnsite 4m 4s the patch passed
          +1 mvneclipse 1m 2s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 8m 34s the patch passed
          +1 javadoc 4m 26s the patch passed with JDK v1.8.0_66
          +1 javadoc 5m 30s the patch passed with JDK v1.7.0_91
          -1 unit 12m 42s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 113m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 3m 46s hadoop-yarn-common in the patch failed with JDK v1.8.0_66.
          -1 unit 12m 53s hadoop-common in the patch failed with JDK v1.7.0_91.
          -1 unit 103m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 45s hadoop-yarn-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 40s Patch does not generate ASF License warnings.
          365m 32s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestRPCWaitForProxy
            hadoop.ha.TestZKFailoverController
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestIname
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.TestLocalDFS
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.yarn.logaggregation.TestAggregatedLogDeletionService
          JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.find.TestName
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestIname
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.security.TestDelegationTokenForProxyUser



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784992/Hadoop-12668.007.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 1b191b4343f5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 61382ff
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 10m 41s trunk passed +1 compile 14m 6s trunk passed with JDK v1.8.0_66 +1 compile 11m 21s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 36s trunk passed +1 mvnsite 3m 48s trunk passed +1 mvneclipse 0m 58s trunk passed +1 findbugs 7m 41s trunk passed +1 javadoc 4m 26s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 3s trunk passed with JDK v1.7.0_91 0 mvndep 0m 36s Maven dependency ordering for patch +1 mvninstall 2m 55s the patch passed +1 compile 14m 12s the patch passed with JDK v1.8.0_66 +1 javac 14m 12s the patch passed +1 compile 11m 58s the patch passed with JDK v1.7.0_91 +1 javac 11m 58s the patch passed +1 checkstyle 1m 40s the patch passed +1 mvnsite 4m 4s the patch passed +1 mvneclipse 1m 2s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 8m 34s the patch passed +1 javadoc 4m 26s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 30s the patch passed with JDK v1.7.0_91 -1 unit 12m 42s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 113m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 3m 46s hadoop-yarn-common in the patch failed with JDK v1.8.0_66. -1 unit 12m 53s hadoop-common in the patch failed with JDK v1.7.0_91. -1 unit 103m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 unit 0m 45s hadoop-yarn-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 40s Patch does not generate ASF License warnings. 365m 32s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestRPCWaitForProxy   hadoop.ha.TestZKFailoverController   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestIname   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.yarn.logaggregation.TestAggregatedLogDeletionService JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.find.TestName   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestIname   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.security.TestDelegationTokenForProxyUser Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784992/Hadoop-12668.007.patch JIRA Issue HADOOP-12668 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux 1b191b4343f5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 61382ff Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8488/console This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Please find attached the updated patch file containing junit test and code to address review feedback. I am looking forward to additional suggestions if any. Thank you for reviewing the changes.

          Show
          SINGHVJD Vijay Singh added a comment - Please find attached the updated patch file containing junit test and code to address review feedback. I am looking forward to additional suggestions if any. Thank you for reviewing the changes.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Thanks for review comments. I will include the changes in patch by tomorrow and submit for review again.

          Show
          SINGHVJD Vijay Singh added a comment - Thanks for review comments. I will include the changes in patch by tomorrow and submit for review again.
          Hide
          zhz Zhe Zhang added a comment -

          Thanks Vijay for the fix. The patch LGTM overall. A few minor issues / questions:

          1. Can we add a unit test to verify the same as above system test ?
          2. Java uses lazy evaluation so we can safely combine the following into single if
                      if(null != excludeCiphers) {
                        if(!excludeCiphers.isEmpty()) {
            
          3. Can combine the below as a single return
                Configuration serverSSLConf = createSSLConfig(SSLFactory.Mode.SERVER,
                  serverKS, password, keyPassword, trustKS, excludeCiphers);
                return serverSSLConf;
            
          Show
          zhz Zhe Zhang added a comment - Thanks Vijay for the fix. The patch LGTM overall. A few minor issues / questions: Can we add a unit test to verify the same as above system test ? Java uses lazy evaluation so we can safely combine the following into single if if ( null != excludeCiphers) { if (!excludeCiphers.isEmpty()) { Can combine the below as a single return Configuration serverSSLConf = createSSLConfig(SSLFactory.Mode.SERVER, serverKS, password, keyPassword, trustKS, excludeCiphers); return serverSSLConf;
          Hide
          jzhuge John Zhuge added a comment -

          +1 for the patch

          Show
          jzhuge John Zhuge added a comment - +1 for the patch
          Hide
          SINGHVJD Vijay Singh added a comment -

          Added HADOOP-12708 to track request for configuring specfic ciphers.

          Show
          SINGHVJD Vijay Singh added a comment - Added HADOOP-12708 to track request for configuring specfic ciphers.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Hi Haohui Mai,
          Based on current jetty depndency in pom (release 6), setInluceCiphersuites is not available for SSLSocketConnector yet. Please refer the maven for current jetty dependency.
          http://mvnrepository.com/artifact/org.mortbay.jetty/jetty/6.1.26

          I suggest that we open a new ticket to include cipher suites when we upgrade jetty version in pom. I am going to open two jira issues: 1) To upgrade jetty and 2) To include cipher suites based on configuration.

          Show
          SINGHVJD Vijay Singh added a comment - Hi Haohui Mai , Based on current jetty depndency in pom (release 6), setInluceCiphersuites is not available for SSLSocketConnector yet. Please refer the maven for current jetty dependency. http://mvnrepository.com/artifact/org.mortbay.jetty/jetty/6.1.26 I suggest that we open a new ticket to include cipher suites when we upgrade jetty version in pom. I am going to open two jira issues: 1) To upgrade jetty and 2) To include cipher suites based on configuration.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Hi Haohui Mai,
          I also want to mention that HttpFs is war project that can utilize ssl-server.xml for tomcat. However, these hadoop common services (namenode, seocndary namenode, qjm, yarn rm) are jar modules and are based on embedded jetty implementation (documentation maintained at link LikeJettyXml ). Currently, programmatic setting is the only option I am aware of and also also I am just leveraging the current implementation, while still utilizing current ssl-server.xml config file to maintain the configuration based flexibility. I am looking for suggestions if there is an alternate approach. I will continue to extend the functionality to include CipherSuites as well.

          Show
          SINGHVJD Vijay Singh added a comment - Hi Haohui Mai , I also want to mention that HttpFs is war project that can utilize ssl-server.xml for tomcat. However, these hadoop common services (namenode, seocndary namenode, qjm, yarn rm) are jar modules and are based on embedded jetty implementation (documentation maintained at link LikeJettyXml ). Currently, programmatic setting is the only option I am aware of and also also I am just leveraging the current implementation, while still utilizing current ssl-server.xml config file to maintain the configuration based flexibility. I am looking for suggestions if there is an alternate approach. I will continue to extend the functionality to include CipherSuites as well.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Thanks for the feedback. I will include the property for both to include and exclude ciphers. Since all these services are based on jetty and since jetty first covers included ciphers followed by excluded ciphers causing the excluded ciphers to take precedence and override included ciphers selection in case of conflict, similar behavior will be observed in hadoop services as well.
          Please refer the following link for jetty cipher selection behavior.
          https://wiki.eclipse.org/Jetty/Howto/CipherSuites
          Please read Disabling Cipher Suites Section for verifying jetty behavior. I will work on this request and submit the updated patch tonight.

          Show
          SINGHVJD Vijay Singh added a comment - Thanks for the feedback. I will include the property for both to include and exclude ciphers. Since all these services are based on jetty and since jetty first covers included ciphers followed by excluded ciphers causing the excluded ciphers to take precedence and override included ciphers selection in case of conflict, similar behavior will be observed in hadoop services as well. Please refer the following link for jetty cipher selection behavior. https://wiki.eclipse.org/Jetty/Howto/CipherSuites Please read Disabling Cipher Suites Section for verifying jetty behavior. I will work on this request and submit the updated patch tonight.
          Hide
          wheat9 Haohui Mai added a comment -

          Thanks for the patch.

          The configuration should be a list of allowed ciphers, and the effort needs to be aligned with how httpfs fixes this issue.

          Show
          wheat9 Haohui Mai added a comment - Thanks for the patch. The configuration should be a list of allowed ciphers, and the effort needs to be aligned with how httpfs fixes this issue.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Please note that between patch 5 and patch 6 . I only added changes to ssl-server.xml.example file which is not utilized for any test execution and the set of test that failed were mutually exclusive leading me to strongly believe that these failures are intermittent failures rather than caused by code itself.
          Additionally, the code does not alter or touch any of the functionality for failed test cases. I suggest the code changes be reviewed and feedback be provided. I will appreciate feedback if any and will work on resolving them if there are any issues in the contributed patch. Looking forward to suggestions if any.

          Show
          SINGHVJD Vijay Singh added a comment - Please note that between patch 5 and patch 6 . I only added changes to ssl-server.xml.example file which is not utilized for any test execution and the set of test that failed were mutually exclusive leading me to strongly believe that these failures are intermittent failures rather than caused by code itself. Additionally, the code does not alter or touch any of the functionality for failed test cases. I suggest the code changes be reviewed and feedback be provided. I will appreciate feedback if any and will work on resolving them if there are any issues in the contributed patch. Looking forward to suggestions if any.
          Hide
          SINGHVJD Vijay Singh added a comment -

          We ran the following command initially to test if RC4-SHA cipher was available during SSL handshake negotiation on cloudcat cluster.

          [root@vjs-1 hadoop-hdfs]# openssl s_client -connect vjs-1.gce.amintor.com:20102 -cipher RC4-SHA
          CONNECTED(00000003)
          depth=0 O = Hadoop, CN = vjs-1.gce.amintor.com
          verify error:num=18:self signed certificate
          verify return:1
          depth=0 O = Hadoop, CN = vjs-1.gce.amintor.com
          verify return:1
          ---
          Certificate chain
           0 s:/O=Hadoop/CN=vjs-1.gce.amintor.com
             i:/O=Hadoop/CN=vjs-1.gce.amintor.com
          ---
          Server certificate
          -----BEGIN CERTIFICATE-----
          MIIDAzCCAeugAwIBAgIEfCfmWjANBgkqhkiG9w0BAQsFADAyMQ8wDQYDVQQKEwZI
          YWRvb3AxHzAdBgNVBAMTFnZqcy0xLnZwYy5jbG91ZGVyYS5jb20wHhcNMTYwMTEw
          MTEwMDE2WhcNMjEwMTA4MTEwMDE2WjAyMQ8wDQYDVQQKEwZIYWRvb3AxHzAdBgNV
          BAMTFnZqcy0xLnZwYy5jbG91ZGVyYS5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IB
          DwAwggEKAoIBAQC+VTL4nPsdUr6ArEFRoxGlLgdo6/CyaOK5ZDAAymsXlk2hme9w
          FZS3HgYcTknKTlbbU3qX6p/xLECPEigozEcls3SD8EjtOXyl9ieAOixB7UpQHFXQ
          wLhVlYpNEA46mo3Zh3KUXRjRV4UVPqSz3EZQYzy0YlVfafgbqwOid30N3U+sq6ix
          JxoeeIcJpVJHPTPVyHSFVh85U/cUvH6usgVd5V3Y2rRY9zaKkPGsYD5wdr1GPsGM
          4PHD1ZCzDS1yzDettI4yF0quAcrifYNVrCB6iCmRRJqKL2Yr1s0J0rLcFXvhK0tl
          shthKU7CM1ho+7tpco+JoS58nUTpE6kveXS/AgMBAAGjITAfMB0GA1UdDgQWBBT0
          duhrSkY4yuXtv7EWGuKJVONADDANBgkqhkiG9w0BAQsFAAOCAQEAOb23t4qRRrHJ
          YSwRbhRZTNd6qkvtiLeNK7jh2otz7CxqlJZ2O6G62hde4MvdIwVjv4zgSVVPEi0X
          9VWdu4Sg2LoTF7qUt7RrXnxt0Cxy8Jrpt4ijNFZ7wyldtep8/KNO21kMmLBU/24v
          A7w+KELa+Y0cX5lly78MprM5OhRPqAN3MYwXEyz+rA/R/9FoE9sL0CkAYN3sZx0e
          xe9qxgpVNyZE1loiwfkBU8O5Dkpg3iwqLLEhYiry6yRYcB7f1yRSRvtYQMlujqli
          tUg7XY6WXrK39m1O67cOWEM1mzd18wt76codlpsdtfj970SG5x8znnFhaIuBtfP7
          jOjhwjgrBw==
          -----END CERTIFICATE-----
          subject=/O=Hadoop/CN=vjs-1.gce.amintor.com
          issuer=/O=Hadoop/CN=vjs-1.gce.amintor.com
          ---
          No client certificate CA names sent
          ---
          SSL handshake has read 922 bytes and written 413 bytes
          ---
          New, TLSv1/SSLv3, Cipher is RC4-SHA
          Server public key is 2048 bit
          Secure Renegotiation IS supported
          Compression: NONE
          Expansion: NONE
          SSL-Session:
              Protocol  : TLSv1.2
              Cipher    : RC4-SHA
              Session-ID: 569600FDDBA888F6F90F5EAC103FDB45E25F338F38C796D9A8C1E1ACF6E48E4D
              Session-ID-ctx: 
              Master-Key: 3A7A5E1CEDDD7F93D8818F3324CEA91E0265805AE78098D6BA56AF764BA8CD7FD6DEAFC2E44D7AEB81095A46D4ECAF4B
              Key-Arg   : None
              Krb5 Principal: None
              PSK identity: None
              PSK identity hint: None
              Start Time: 1452671229
              Timeout   : 300 (sec)
              Verify return code: 18 (self signed certificate)
          ---
          

          Before deploying the safety valve ssl-server.xml RC4-SHA was available. However once the safety valve was deployed as follows, the cipher was not considered for negotiation.

          <property>
            <name>ssl.server.exclude.cipher.list</name>
           <value>SSL_RSA_WITH_RC4_128_SHA,TLS_ECDH_ECDSA_WITH_RC4_128_SHA,TLS_ECDH_RSA_WITH_RC4_128_SHA,TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,TLS_ECDHE_RSA_WITH_RC4_128_SHA</value>
            <description>Optional. The weak security cipher suites that you want excluded
            from SSL communication.</description>
          </property>
          

          The output of earlier command after deploying safety valve and restarting HDFS in cloudcat.

          [root@vjs-1 hadoop-hdfs]# openssl s_client -connect vjs-1.gce.amintor.com:20102 -cipher RC4-SHA
          CONNECTED(00000003)
          140163289794376:error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure:s23_clnt.c:744:
          ---
          no peer certificate available
          ---
          No client certificate CA names sent
          ---
          SSL handshake has read 7 bytes and written 99 bytes
          ---
          New, (NONE), Cipher is (NONE)
          Secure Renegotiation IS NOT supported
          Compression: NONE
          Expansion: NONE
          ---
          
          Show
          SINGHVJD Vijay Singh added a comment - We ran the following command initially to test if RC4-SHA cipher was available during SSL handshake negotiation on cloudcat cluster. [root@vjs-1 hadoop-hdfs]# openssl s_client -connect vjs-1.gce.amintor.com:20102 -cipher RC4-SHA CONNECTED(00000003) depth=0 O = Hadoop, CN = vjs-1.gce.amintor.com verify error:num=18:self signed certificate verify return :1 depth=0 O = Hadoop, CN = vjs-1.gce.amintor.com verify return :1 --- Certificate chain 0 s:/O=Hadoop/CN=vjs-1.gce.amintor.com i:/O=Hadoop/CN=vjs-1.gce.amintor.com --- Server certificate -----BEGIN CERTIFICATE----- MIIDAzCCAeugAwIBAgIEfCfmWjANBgkqhkiG9w0BAQsFADAyMQ8wDQYDVQQKEwZI YWRvb3AxHzAdBgNVBAMTFnZqcy0xLnZwYy5jbG91ZGVyYS5jb20wHhcNMTYwMTEw MTEwMDE2WhcNMjEwMTA4MTEwMDE2WjAyMQ8wDQYDVQQKEwZIYWRvb3AxHzAdBgNV BAMTFnZqcy0xLnZwYy5jbG91ZGVyYS5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IB DwAwggEKAoIBAQC+VTL4nPsdUr6ArEFRoxGlLgdo6/CyaOK5ZDAAymsXlk2hme9w FZS3HgYcTknKTlbbU3qX6p/xLECPEigozEcls3SD8EjtOXyl9ieAOixB7UpQHFXQ wLhVlYpNEA46mo3Zh3KUXRjRV4UVPqSz3EZQYzy0YlVfafgbqwOid30N3U+sq6ix JxoeeIcJpVJHPTPVyHSFVh85U/cUvH6usgVd5V3Y2rRY9zaKkPGsYD5wdr1GPsGM 4PHD1ZCzDS1yzDettI4yF0quAcrifYNVrCB6iCmRRJqKL2Yr1s0J0rLcFXvhK0tl shthKU7CM1ho+7tpco+JoS58nUTpE6kveXS/AgMBAAGjITAfMB0GA1UdDgQWBBT0 duhrSkY4yuXtv7EWGuKJVONADDANBgkqhkiG9w0BAQsFAAOCAQEAOb23t4qRRrHJ YSwRbhRZTNd6qkvtiLeNK7jh2otz7CxqlJZ2O6G62hde4MvdIwVjv4zgSVVPEi0X 9VWdu4Sg2LoTF7qUt7RrXnxt0Cxy8Jrpt4ijNFZ7wyldtep8/KNO21kMmLBU/24v A7w+KELa+Y0cX5lly78MprM5OhRPqAN3MYwXEyz+rA/R/9FoE9sL0CkAYN3sZx0e xe9qxgpVNyZE1loiwfkBU8O5Dkpg3iwqLLEhYiry6yRYcB7f1yRSRvtYQMlujqli tUg7XY6WXrK39m1O67cOWEM1mzd18wt76codlpsdtfj970SG5x8znnFhaIuBtfP7 jOjhwjgrBw== -----END CERTIFICATE----- subject=/O=Hadoop/CN=vjs-1.gce.amintor.com issuer=/O=Hadoop/CN=vjs-1.gce.amintor.com --- No client certificate CA names sent --- SSL handshake has read 922 bytes and written 413 bytes --- New, TLSv1/SSLv3, Cipher is RC4-SHA Server public key is 2048 bit Secure Renegotiation IS supported Compression: NONE Expansion: NONE SSL-Session: Protocol : TLSv1.2 Cipher : RC4-SHA Session-ID: 569600FDDBA888F6F90F5EAC103FDB45E25F338F38C796D9A8C1E1ACF6E48E4D Session-ID-ctx: Master-Key: 3A7A5E1CEDDD7F93D8818F3324CEA91E0265805AE78098D6BA56AF764BA8CD7FD6DEAFC2E44D7AEB81095A46D4ECAF4B Key-Arg : None Krb5 Principal: None PSK identity: None PSK identity hint: None Start Time: 1452671229 Timeout : 300 (sec) Verify return code: 18 (self signed certificate) --- Before deploying the safety valve ssl-server.xml RC4-SHA was available. However once the safety valve was deployed as follows, the cipher was not considered for negotiation. <property> <name>ssl.server.exclude.cipher.list</name> <value>SSL_RSA_WITH_RC4_128_SHA,TLS_ECDH_ECDSA_WITH_RC4_128_SHA,TLS_ECDH_RSA_WITH_RC4_128_SHA,TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,TLS_ECDHE_RSA_WITH_RC4_128_SHA</value> <description>Optional. The weak security cipher suites that you want excluded from SSL communication.</description> </property> The output of earlier command after deploying safety valve and restarting HDFS in cloudcat. [root@vjs-1 hadoop-hdfs]# openssl s_client -connect vjs-1.gce.amintor.com:20102 -cipher RC4-SHA CONNECTED(00000003) 140163289794376:error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure:s23_clnt.c:744: --- no peer certificate available --- No client certificate CA names sent --- SSL handshake has read 7 bytes and written 99 bytes --- New, (NONE), Cipher is (NONE) Secure Renegotiation IS NOT supported Compression: NONE Expansion: NONE ---
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 8m 42s trunk passed
          +1 compile 7m 56s trunk passed with JDK v1.8.0_66
          +1 compile 8m 39s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 59s trunk passed
          +1 mvnsite 2m 27s trunk passed
          +1 mvneclipse 0m 43s trunk passed
          +1 findbugs 4m 56s trunk passed
          +1 javadoc 2m 31s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 42s trunk passed with JDK v1.7.0_91
          +1 mvninstall 3m 1s the patch passed
          +1 compile 8m 34s the patch passed with JDK v1.8.0_66
          +1 javac 8m 34s the patch passed
          +1 compile 9m 3s the patch passed with JDK v1.7.0_91
          +1 javac 9m 3s the patch passed
          +1 checkstyle 1m 0s the patch passed
          +1 mvnsite 2m 28s the patch passed
          +1 mvneclipse 0m 45s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 5m 24s the patch passed
          +1 javadoc 2m 29s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 23s the patch passed with JDK v1.7.0_91
          -1 unit 21m 6s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 65m 47s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 7m 13s hadoop-common in the patch passed with JDK v1.7.0_91.
          -1 unit 62m 52s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          240m 7s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestRollingUpgrade



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781448/Hadoop-12668.006.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 4cee176b7c78 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0e76f1f
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 42s trunk passed +1 compile 7m 56s trunk passed with JDK v1.8.0_66 +1 compile 8m 39s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 59s trunk passed +1 mvnsite 2m 27s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 4m 56s trunk passed +1 javadoc 2m 31s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 42s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 1s the patch passed +1 compile 8m 34s the patch passed with JDK v1.8.0_66 +1 javac 8m 34s the patch passed +1 compile 9m 3s the patch passed with JDK v1.7.0_91 +1 javac 9m 3s the patch passed +1 checkstyle 1m 0s the patch passed +1 mvnsite 2m 28s the patch passed +1 mvneclipse 0m 45s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 24s the patch passed +1 javadoc 2m 29s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 23s the patch passed with JDK v1.7.0_91 -1 unit 21m 6s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 65m 47s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 7m 13s hadoop-common in the patch passed with JDK v1.7.0_91. -1 unit 62m 52s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 240m 7s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180   hadoop.hdfs.server.datanode.TestDataNodeMetrics JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781448/Hadoop-12668.006.patch JIRA Issue HADOOP-12668 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux 4cee176b7c78 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0e76f1f Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8377/console This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Added Patch-6 that includes modified SSL-SERVER.XML file for excluding weak ciphers by default.

          Show
          SINGHVJD Vijay Singh added a comment - Added Patch-6 that includes modified SSL-SERVER.XML file for excluding weak ciphers by default.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 8m 50s trunk passed
          +1 compile 10m 9s trunk passed with JDK v1.8.0_66
          +1 compile 10m 29s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 8s trunk passed
          +1 mvnsite 2m 49s trunk passed
          +1 mvneclipse 0m 45s trunk passed
          +1 findbugs 5m 40s trunk passed
          +1 javadoc 2m 38s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 36s trunk passed with JDK v1.7.0_91
          +1 mvninstall 3m 6s the patch passed
          +1 compile 8m 43s the patch passed with JDK v1.8.0_66
          +1 javac 8m 43s the patch passed
          +1 compile 9m 26s the patch passed with JDK v1.7.0_91
          +1 javac 9m 26s the patch passed
          +1 checkstyle 1m 2s the patch passed
          +1 mvnsite 2m 35s the patch passed
          +1 mvneclipse 0m 44s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 5m 45s the patch passed
          +1 javadoc 2m 38s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 34s the patch passed with JDK v1.7.0_91
          -1 unit 7m 50s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 57m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 10s hadoop-common in the patch failed with JDK v1.7.0_91.
          -1 unit 53m 52s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          217m 10s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.TestLocalFsFCStatistics
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          JDK v1.7.0_91 Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.fs.TestLocalFsFCStatistics
            hadoop.hdfs.TestBlockReaderLocal
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.shortcircuit.TestShortCircuitCache



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779451/Hadoop-12668_version5.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8b6d250edef9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6553784
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 50s trunk passed +1 compile 10m 9s trunk passed with JDK v1.8.0_66 +1 compile 10m 29s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 8s trunk passed +1 mvnsite 2m 49s trunk passed +1 mvneclipse 0m 45s trunk passed +1 findbugs 5m 40s trunk passed +1 javadoc 2m 38s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 36s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 6s the patch passed +1 compile 8m 43s the patch passed with JDK v1.8.0_66 +1 javac 8m 43s the patch passed +1 compile 9m 26s the patch passed with JDK v1.7.0_91 +1 javac 9m 26s the patch passed +1 checkstyle 1m 2s the patch passed +1 mvnsite 2m 35s the patch passed +1 mvneclipse 0m 44s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 45s the patch passed +1 javadoc 2m 38s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 34s the patch passed with JDK v1.7.0_91 -1 unit 7m 50s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 57m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 10s hadoop-common in the patch failed with JDK v1.7.0_91. -1 unit 53m 52s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 217m 10s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.TestLocalFsFCStatistics   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark JDK v1.7.0_91 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.fs.TestLocalFsFCStatistics   hadoop.hdfs.TestBlockReaderLocal   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.shortcircuit.TestShortCircuitCache Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779451/Hadoop-12668_version5.patch JIRA Issue HADOOP-12668 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8b6d250edef9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6553784 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8312/console This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Added 2 spaces for indentation checkstyle error.

          Show
          SINGHVJD Vijay Singh added a comment - Added 2 spaces for indentation checkstyle error.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 36s trunk passed
          +1 compile 8m 6s trunk passed with JDK v1.8.0_66
          +1 compile 9m 4s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 59s trunk passed
          +1 mvnsite 2m 29s trunk passed
          +1 mvneclipse 0m 43s trunk passed
          +1 findbugs 5m 8s trunk passed
          +1 javadoc 2m 33s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 30s trunk passed with JDK v1.7.0_91
          +1 mvninstall 3m 11s the patch passed
          +1 compile 8m 3s the patch passed with JDK v1.8.0_66
          +1 javac 8m 3s the patch passed
          +1 compile 9m 2s the patch passed with JDK v1.7.0_91
          +1 javac 9m 2s the patch passed
          -1 checkstyle 0m 58s Patch generated 1 new checkstyle issues in root (total was 149, now 150).
          +1 mvnsite 2m 28s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 5m 20s the patch passed
          +1 javadoc 2m 29s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 27s the patch passed with JDK v1.7.0_91
          +1 unit 7m 47s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 69m 18s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 24s hadoop-common in the patch failed with JDK v1.7.0_91.
          -1 unit 69m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 26s Patch generated 1 ASF License warnings.
          237m 18s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.TestFileAppend2
            hadoop.hdfs.server.namenode.TestNameNodeAcl
          JDK v1.7.0_91 Failed junit tests hadoop.ipc.TestRPCWaitForProxy
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
            hadoop.hdfs.server.datanode.TestBlockReplacement



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779381/Hadoop-12668_version5.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bcc9968423eb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0af492b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 36s trunk passed +1 compile 8m 6s trunk passed with JDK v1.8.0_66 +1 compile 9m 4s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 59s trunk passed +1 mvnsite 2m 29s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 5m 8s trunk passed +1 javadoc 2m 33s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 30s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 11s the patch passed +1 compile 8m 3s the patch passed with JDK v1.8.0_66 +1 javac 8m 3s the patch passed +1 compile 9m 2s the patch passed with JDK v1.7.0_91 +1 javac 9m 2s the patch passed -1 checkstyle 0m 58s Patch generated 1 new checkstyle issues in root (total was 149, now 150). +1 mvnsite 2m 28s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 20s the patch passed +1 javadoc 2m 29s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 27s the patch passed with JDK v1.7.0_91 +1 unit 7m 47s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 69m 18s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 24s hadoop-common in the patch failed with JDK v1.7.0_91. -1 unit 69m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 26s Patch generated 1 ASF License warnings. 237m 18s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.server.namenode.TestNameNodeAcl JDK v1.7.0_91 Failed junit tests hadoop.ipc.TestRPCWaitForProxy   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.server.datanode.TestBlockReplacement Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779381/Hadoop-12668_version5.patch JIRA Issue HADOOP-12668 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bcc9968423eb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0af492b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8309/console This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Looked at the checkstyle issues. All of them are false positives. Please review and provide suggestions if any. Also the failed jUnit cases are not related to patch. ASF license warning is related to some other commit from yarn-4234

          Please review the changes and provide suggestions if any.

          Show
          SINGHVJD Vijay Singh added a comment - Looked at the checkstyle issues. All of them are false positives. Please review and provide suggestions if any. Also the failed jUnit cases are not related to patch. ASF license warning is related to some other commit from yarn-4234 Please review the changes and provide suggestions if any.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 8m 52s trunk passed
          +1 compile 9m 41s trunk passed with JDK v1.8.0_66
          +1 compile 9m 50s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 8s trunk passed
          +1 mvnsite 2m 47s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 5m 44s trunk passed
          +1 javadoc 2m 50s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 56s trunk passed with JDK v1.7.0_91
          +1 mvninstall 3m 21s the patch passed
          +1 compile 9m 41s the patch passed with JDK v1.8.0_66
          +1 javac 9m 41s the patch passed
          +1 compile 9m 50s the patch passed with JDK v1.7.0_91
          +1 javac 9m 50s the patch passed
          -1 checkstyle 1m 7s Patch generated 11 new checkstyle issues in root (total was 150, now 161).
          +1 mvnsite 2m 46s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 12s the patch passed
          +1 javadoc 2m 56s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 8s the patch passed with JDK v1.7.0_91
          -1 unit 9m 2s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 65m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 24s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 9m 7s hadoop-common in the patch passed with JDK v1.7.0_91.
          -1 unit 59m 29s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 unit 2m 18s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 27s Patch generated 1 ASF License warnings.
          235m 42s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.TestLeaseRecovery2
            hadoop.hdfs.TestDFSStripedOutputStream
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.TestNameNodeAcl
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779369/Hadoop-12668_version4.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7a039ccc562f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0af492b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 52s trunk passed +1 compile 9m 41s trunk passed with JDK v1.8.0_66 +1 compile 9m 50s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 8s trunk passed +1 mvnsite 2m 47s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 5m 44s trunk passed +1 javadoc 2m 50s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 56s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 21s the patch passed +1 compile 9m 41s the patch passed with JDK v1.8.0_66 +1 javac 9m 41s the patch passed +1 compile 9m 50s the patch passed with JDK v1.7.0_91 +1 javac 9m 50s the patch passed -1 checkstyle 1m 7s Patch generated 11 new checkstyle issues in root (total was 150, now 161). +1 mvnsite 2m 46s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 12s the patch passed +1 javadoc 2m 56s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 8s the patch passed with JDK v1.7.0_91 -1 unit 9m 2s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 65m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 2m 24s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 9m 7s hadoop-common in the patch passed with JDK v1.7.0_91. -1 unit 59m 29s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 unit 2m 18s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 27s Patch generated 1 ASF License warnings. 235m 42s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestLeaseRecovery2   hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.TestNameNodeAcl   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779369/Hadoop-12668_version4.patch JIRA Issue HADOOP-12668 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7a039ccc562f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0af492b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8307/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 8m 7s trunk passed
          +1 compile 10m 4s trunk passed with JDK v1.8.0_66
          +1 compile 10m 7s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 2m 41s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 5m 39s trunk passed
          +1 javadoc 2m 52s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 46s trunk passed with JDK v1.7.0_91
          +1 mvninstall 3m 12s the patch passed
          +1 compile 9m 54s the patch passed with JDK v1.8.0_66
          +1 javac 9m 54s the patch passed
          +1 compile 10m 6s the patch passed with JDK v1.7.0_91
          +1 javac 10m 6s the patch passed
          -1 checkstyle 1m 7s Patch generated 14 new checkstyle issues in root (total was 150, now 164).
          +1 mvnsite 2m 40s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 11s the patch passed
          +1 javadoc 2m 49s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 48s the patch passed with JDK v1.7.0_91
          +1 unit 9m 0s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 65m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 25s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 37s hadoop-common in the patch failed with JDK v1.7.0_91.
          -1 unit 60m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 unit 2m 30s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 27s Patch generated 1 ASF License warnings.
          235m 29s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.TestWriteReadStripedFile
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
            hadoop.hdfs.server.namenode.snapshot.TestSnapshot
          JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.server.datanode.TestFsDatasetCache
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
            hadoop.hdfs.shortcircuit.TestShortCircuitCache



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779366/Hadoop-12668_version3.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 72d45377a92e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0af492b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 7s trunk passed +1 compile 10m 4s trunk passed with JDK v1.8.0_66 +1 compile 10m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 5s trunk passed +1 mvnsite 2m 41s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 5m 39s trunk passed +1 javadoc 2m 52s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 46s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 12s the patch passed +1 compile 9m 54s the patch passed with JDK v1.8.0_66 +1 javac 9m 54s the patch passed +1 compile 10m 6s the patch passed with JDK v1.7.0_91 +1 javac 10m 6s the patch passed -1 checkstyle 1m 7s Patch generated 14 new checkstyle issues in root (total was 150, now 164). +1 mvnsite 2m 40s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 11s the patch passed +1 javadoc 2m 49s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 48s the patch passed with JDK v1.7.0_91 +1 unit 9m 0s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 65m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 2m 25s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 37s hadoop-common in the patch failed with JDK v1.7.0_91. -1 unit 60m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 unit 2m 30s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 27s Patch generated 1 ASF License warnings. 235m 29s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.TestWriteReadStripedFile   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.namenode.snapshot.TestSnapshot JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.shortcircuit.TestShortCircuitCache Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779366/Hadoop-12668_version3.patch JIRA Issue HADOOP-12668 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 72d45377a92e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0af492b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8306/console This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Attached hadoop-12268_version5.patch for indentation correction for checkstyle.

          Show
          SINGHVJD Vijay Singh added a comment - Attached hadoop-12268_version5.patch for indentation correction for checkstyle.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Attaching patch version 4 for checkstyle on "{" character.

          Show
          SINGHVJD Vijay Singh added a comment - Attaching patch version 4 for checkstyle on "{" character.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Added new patch file to remove whitespaces to address checkstyle errors.

          Show
          SINGHVJD Vijay Singh added a comment - Added new patch file to remove whitespaces to address checkstyle errors.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 26s trunk passed
          +1 compile 7m 36s trunk passed with JDK v1.8.0_66
          +1 compile 8m 32s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 58s trunk passed
          +1 mvnsite 2m 25s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 4m 57s trunk passed
          +1 javadoc 2m 31s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 18s trunk passed with JDK v1.7.0_91
          +1 mvninstall 3m 2s the patch passed
          +1 compile 7m 37s the patch passed with JDK v1.8.0_66
          +1 javac 7m 37s the patch passed
          +1 compile 8m 33s the patch passed with JDK v1.7.0_91
          +1 javac 8m 32s the patch passed
          -1 checkstyle 0m 58s Patch generated 14 new checkstyle issues in root (total was 149, now 163).
          +1 mvnsite 2m 23s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          -1 whitespace 0m 0s The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 5m 17s the patch passed
          +1 javadoc 2m 23s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 19s the patch passed with JDK v1.7.0_91
          +1 unit 6m 32s hadoop-common in the patch passed with JDK v1.8.0_66.
          -1 unit 50m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 6m 51s hadoop-common in the patch passed with JDK v1.7.0_91.
          -1 unit 51m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 26s Patch generated 1 ASF License warnings.
          194m 30s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
            hadoop.hdfs.server.datanode.TestBpServiceActorScheduler
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
            hadoop.hdfs.TestWriteReadStripedFile
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779311/Hadoop-11268_version2.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 47f9d9f51a4f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bb5df27
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 26s trunk passed +1 compile 7m 36s trunk passed with JDK v1.8.0_66 +1 compile 8m 32s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 58s trunk passed +1 mvnsite 2m 25s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 4m 57s trunk passed +1 javadoc 2m 31s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 18s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 2s the patch passed +1 compile 7m 37s the patch passed with JDK v1.8.0_66 +1 javac 7m 37s the patch passed +1 compile 8m 33s the patch passed with JDK v1.7.0_91 +1 javac 8m 32s the patch passed -1 checkstyle 0m 58s Patch generated 14 new checkstyle issues in root (total was 149, now 163). +1 mvnsite 2m 23s the patch passed +1 mvneclipse 0m 42s the patch passed -1 whitespace 0m 0s The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 5m 17s the patch passed +1 javadoc 2m 23s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 19s the patch passed with JDK v1.7.0_91 +1 unit 6m 32s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 50m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 6m 51s hadoop-common in the patch passed with JDK v1.7.0_91. -1 unit 51m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 26s Patch generated 1 ASF License warnings. 194m 30s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.datanode.TestBpServiceActorScheduler   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.TestWriteReadStripedFile   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779311/Hadoop-11268_version2.patch JIRA Issue HADOOP-12668 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 47f9d9f51a4f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bb5df27 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8303/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 8m 2s trunk passed
          +1 compile 8m 56s trunk passed with JDK v1.8.0_66
          +1 compile 9m 40s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 2m 5s trunk passed
          +1 mvneclipse 0m 30s trunk passed
          +1 findbugs 4m 0s trunk passed
          +1 javadoc 2m 12s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 59s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 36s the patch passed
          +1 compile 8m 56s the patch passed with JDK v1.8.0_66
          +1 javac 8m 56s the patch passed
          +1 compile 9m 33s the patch passed with JDK v1.7.0_91
          +1 javac 9m 33s the patch passed
          -1 checkstyle 1m 2s Patch generated 14 new checkstyle issues in root (total was 138, now 152).
          +1 mvnsite 2m 6s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          -1 whitespace 0m 0s The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 4m 18s the patch passed
          +1 javadoc 2m 10s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 4s the patch passed with JDK v1.7.0_91
          -1 unit 7m 48s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 58m 10s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 8m 0s hadoop-common in the patch failed with JDK v1.7.0_91.
          -1 unit 56m 10s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 28s Patch generated 1 ASF License warnings.
          205m 35s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.shell.TestCopyPreserveFlag
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
            hadoop.hdfs.TestErasureCodingPolicies



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779287/Hadoop-12668.patch
          JIRA Issue HADOOP-12668
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 88c40be18d2d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bb5df27
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 2s trunk passed +1 compile 8m 56s trunk passed with JDK v1.8.0_66 +1 compile 9m 40s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 4s trunk passed +1 mvnsite 2m 5s trunk passed +1 mvneclipse 0m 30s trunk passed +1 findbugs 4m 0s trunk passed +1 javadoc 2m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 59s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 36s the patch passed +1 compile 8m 56s the patch passed with JDK v1.8.0_66 +1 javac 8m 56s the patch passed +1 compile 9m 33s the patch passed with JDK v1.7.0_91 +1 javac 9m 33s the patch passed -1 checkstyle 1m 2s Patch generated 14 new checkstyle issues in root (total was 138, now 152). +1 mvnsite 2m 6s the patch passed +1 mvneclipse 0m 29s the patch passed -1 whitespace 0m 0s The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 4m 18s the patch passed +1 javadoc 2m 10s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 4s the patch passed with JDK v1.7.0_91 -1 unit 7m 48s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 58m 10s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 8m 0s hadoop-common in the patch failed with JDK v1.7.0_91. -1 unit 56m 10s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 28s Patch generated 1 ASF License warnings. 205m 35s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.shell.TestCopyPreserveFlag   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.TestErasureCodingPolicies Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779287/Hadoop-12668.patch JIRA Issue HADOOP-12668 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 88c40be18d2d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bb5df27 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8300/console This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Thanks Vinod for information. I will ensure this now that I know it.

          Show
          SINGHVJD Vijay Singh added a comment - Thanks Vinod for information. I will ensure this now that I know it.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Vijay Singh, please don't set fix-version. Committers set that to appropriate values at commit time. You should instead use target-version to express your intention. Fixing it myself now, but FYI.

          Also, 2.7.2 release is being voted on, so it cannot go there. Given that this is a new improvement, 2.8.0 is the nearest release this can be included in. Setting target-version as such.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Vijay Singh , please don't set fix-version. Committers set that to appropriate values at commit time. You should instead use target-version to express your intention. Fixing it myself now, but FYI. Also, 2.7.2 release is being voted on, so it cannot go there. Given that this is a new improvement, 2.8.0 is the nearest release this can be included in. Setting target-version as such.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Modified the patch to include new commits. Added HADOOP-12668.patch file. Please review and approve.

          Show
          SINGHVJD Vijay Singh added a comment - Modified the patch to include new commits. Added HADOOP-12668 .patch file. Please review and approve.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 3s HADOOP-12668 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779252/excludeCipher.patch
          JIRA Issue HADOOP-12668
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8298/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 3s HADOOP-12668 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779252/excludeCipher.patch JIRA Issue HADOOP-12668 Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8298/console This message was automatically generated.
          Hide
          SINGHVJD Vijay Singh added a comment -

          Please approve the changes. Thanks.

          Show
          SINGHVJD Vijay Singh added a comment - Please approve the changes. Thanks.
          Hide
          SINGHVJD Vijay Singh added a comment -

          The patch has been attached for your review and reference. Please let me know if there are any concerns and I will be happy to make the changes again.

          Show
          SINGHVJD Vijay Singh added a comment - The patch has been attached for your review and reference. Please let me know if there are any concerns and I will be happy to make the changes again.

            People

            • Assignee:
              SINGHVJD Vijay Singh
              Reporter:
              SINGHVJD Vijay Singh
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development