Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: util
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Added JavaDoc to getTrimmedStrings() to explain what happens with NULL input

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 41s trunk passed
        +1 compile 7m 49s trunk passed with JDK v1.8.0_66
        +1 compile 8m 37s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 50s trunk passed
        +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 2s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 43s the patch passed
        +1 compile 7m 44s the patch passed with JDK v1.8.0_66
        +1 javac 7m 44s the patch passed
        +1 compile 8m 47s the patch passed with JDK v1.7.0_91
        +1 javac 8m 47s the patch passed
        -1 checkstyle 0m 14s Patch generated 2 new checkstyle issues in hadoop-common-project/hadoop-common (total was 92, now 94).
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 55s the patch passed
        +1 javadoc 0m 51s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 2s the patch passed with JDK v1.7.0_91
        +1 unit 6m 44s hadoop-common in the patch passed with JDK v1.8.0_66.
        -1 unit 6m 36s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        67m 57s



        Reason Tests
        JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777587/StringUtils.patch
        JIRA Issue HADOOP-12639
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5c6c2eaa64d9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0c3a53e
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 75MB
        Powered by Apache Yetus 0.1.0 http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 41s trunk passed +1 compile 7m 49s trunk passed with JDK v1.8.0_66 +1 compile 8m 37s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 50s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 43s the patch passed +1 compile 7m 44s the patch passed with JDK v1.8.0_66 +1 javac 7m 44s the patch passed +1 compile 8m 47s the patch passed with JDK v1.7.0_91 +1 javac 8m 47s the patch passed -1 checkstyle 0m 14s Patch generated 2 new checkstyle issues in hadoop-common-project/hadoop-common (total was 92, now 94). +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 55s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_91 +1 unit 6m 44s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 6m 36s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 67m 57s Reason Tests JDK v1.7.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777587/StringUtils.patch JIRA Issue HADOOP-12639 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5c6c2eaa64d9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0c3a53e findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8243/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 4s trunk passed
        +1 compile 8m 42s trunk passed with JDK v1.8.0_66
        +1 compile 9m 25s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 1m 6s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 55s trunk passed
        +1 javadoc 0m 57s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 8s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 40s the patch passed
        +1 compile 10m 0s the patch passed with JDK v1.8.0_66
        +1 javac 10m 0s the patch passed
        +1 compile 10m 59s the patch passed with JDK v1.7.0_91
        +1 javac 10m 59s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 1m 19s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 2m 13s the patch passed
        +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91
        -1 unit 8m 1s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 unit 7m 53s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        78m 13s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestIPC
        JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.security.ssl.TestReloadingX509TrustManager



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777783/StringUtils.patch
        JIRA Issue HADOOP-12639
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a8c9ab56887f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0c3a53e
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 75MB
        Powered by Apache Yetus 0.1.0 http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 4s trunk passed +1 compile 8m 42s trunk passed with JDK v1.8.0_66 +1 compile 9m 25s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 8s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 40s the patch passed +1 compile 10m 0s the patch passed with JDK v1.8.0_66 +1 javac 10m 0s the patch passed +1 compile 10m 59s the patch passed with JDK v1.7.0_91 +1 javac 10m 59s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 16s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 13s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91 -1 unit 8m 1s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 7m 53s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 78m 13s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestIPC JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777783/StringUtils.patch JIRA Issue HADOOP-12639 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a8c9ab56887f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0c3a53e findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8245/console This message was automatically generated.
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        +1 thanks for your contribution. From next time you don't need to remove already uploaded patches. You can just upload new one.
        Also please keep JIRA number in Patch name from next time when you create patches.. ex: HADOOP-12639.00.patch

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - +1 thanks for your contribution. From next time you don't need to remove already uploaded patches. You can just upload new one. Also please keep JIRA number in Patch name from next time when you create patches.. ex: HADOOP-12639 .00.patch
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Just committed to trunk and branch-2. Thanks for the contribution.

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Just committed to trunk and branch-2. Thanks for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8972 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8972/)
        HADOOP-12639. Improve JavaDoc for getTrimmedStrings. (BELUGA BEHR via (umamahesh: rev ae67c8424c188a2b00920108e6104690137c61b7)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8972 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8972/ ) HADOOP-12639 . Improve JavaDoc for getTrimmedStrings. (BELUGA BEHR via (umamahesh: rev ae67c8424c188a2b00920108e6104690137c61b7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #697 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/697/)
        HADOOP-12639. Improve JavaDoc for getTrimmedStrings. (BELUGA BEHR via (umamahesh: rev ae67c8424c188a2b00920108e6104690137c61b7)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #697 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/697/ ) HADOOP-12639 . Improve JavaDoc for getTrimmedStrings. (BELUGA BEHR via (umamahesh: rev ae67c8424c188a2b00920108e6104690137c61b7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            belugabehr BELUGA BEHR
            Reporter:
            belugabehr BELUGA BEHR
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development