Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      NPE thrown which is hiding actual error...Here it should throw numberformatexpection since count exceeds integer range.

      host-1:/opt/Hadoop-Trunk/install/hadoop/bin # ./yarn jar ../share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-3.0.0-SNAPSHOT.jar testsequencefile -count 1000000000000 hadoop
      java.lang.NullPointerException
      	at org.apache.hadoop.io.TestSequenceFile.main(TestSequenceFile.java:754)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:497)
      	at org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:71)
      	at org.apache.hadoop.util.ProgramDriver.run(ProgramDriver.java:144)
      	at org.apache.hadoop.test.MapredTestDriver.run(MapredTestDriver.java:136)
      	at org.apache.hadoop.test.MapredTestDriver.main(MapredTestDriver.java:144)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:497)
      	at org.apache.hadoop.util.RunJar.run(RunJar.java:222)
      	at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
      
      1. HADOOP-12618.patch
        5 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded patch to fix NPE..Now it will give actual error..

        host-1:/opt/Hadoop-Trunk/install/hadoop/bin #./yarn jar ../share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-3.0.0-SNAPSHOT.jar testsequencefile -count 1000000000000 hadoop
        java.lang.NumberFormatException: For input string: "1000000000000"
        	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
        	at java.lang.Integer.parseInt(Integer.java:583)
        	at java.lang.Integer.parseInt(Integer.java:615)
        	at org.apache.hadoop.io.TestSequenceFile.main(TestSequenceFile.java:681)
        

        Apart from NPE..Fixed usage message And javadoc error(deprecate warnings.)

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded patch to fix NPE..Now it will give actual error.. host-1:/opt/Hadoop-Trunk/install/hadoop/bin #./yarn jar ../share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-3.0.0-SNAPSHOT.jar testsequencefile -count 1000000000000 hadoop java.lang.NumberFormatException: For input string: "1000000000000" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) at java.lang.Integer.parseInt(Integer.java:583) at java.lang.Integer.parseInt(Integer.java:615) at org.apache.hadoop.io.TestSequenceFile.main(TestSequenceFile.java:681) Apart from NPE..Fixed usage message And javadoc error(deprecate warnings.)
        Hide
        xiaochen Xiao Chen added a comment -

        LGTM, +1 (non-binding). Thanks Brahma Reddy Battula for the fix.

        Show
        xiaochen Xiao Chen added a comment - LGTM, +1 (non-binding). Thanks Brahma Reddy Battula for the fix.
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        +1 Thanks Brahma, committing it shortly.

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - +1 Thanks Brahma, committing it shortly.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 24s trunk passed
        +1 compile 9m 7s trunk passed with JDK v1.8.0_66
        +1 compile 9m 25s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 1m 7s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 55s trunk passed
        +1 javadoc 0m 58s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 5s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 37s the patch passed
        +1 compile 9m 3s the patch passed with JDK v1.8.0_66
        +1 javac 9m 3s the patch passed
        +1 compile 9m 29s the patch passed with JDK v1.7.0_85
        +1 javac 9m 29s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 1m 4s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 6s the patch passed
        +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 9s the patch passed with JDK v1.7.0_85
        -1 unit 17m 16s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 unit 8m 1s hadoop-common in the patch failed with JDK v1.7.0_85.
        -1 asflicense 0m 21s Patch generated 3 ASF License warnings.
        85m 15s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestMetricsSystemImpl
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
        JDK v1.7.0_85 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
          hadoop.fs.TestLocalFsFCStatistics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776024/HADOOP-12618.patch
        JIRA Issue HADOOP-12618
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 886fbd9baa42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / fc47084
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 24s trunk passed +1 compile 9m 7s trunk passed with JDK v1.8.0_66 +1 compile 9m 25s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 16s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 0m 58s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 37s the patch passed +1 compile 9m 3s the patch passed with JDK v1.8.0_66 +1 javac 9m 3s the patch passed +1 compile 9m 29s the patch passed with JDK v1.7.0_85 +1 javac 9m 29s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_85 -1 unit 17m 16s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 8m 1s hadoop-common in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 21s Patch generated 3 ASF License warnings. 85m 15s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestMetricsSystemImpl JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_85 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.fs.TestLocalFsFCStatistics Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776024/HADOOP-12618.patch JIRA Issue HADOOP-12618 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 886fbd9baa42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fc47084 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8199/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Test failures are unrelated..Uma Maheswara Rao G can you please look once..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Test failures are unrelated.. Uma Maheswara Rao G can you please look once..?
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Committed to trunk and branch-2

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Committed to trunk and branch-2
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8946 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8946/)
        HADOOP-12618. Fix NPE in TestSequenceFile. (Brahma Reddy Battula via (umamahesh: rev ad53c520630847834b3e68b7f41aa88ee10b3300)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8946 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8946/ ) HADOOP-12618 . Fix NPE in TestSequenceFile. (Brahma Reddy Battula via (umamahesh: rev ad53c520630847834b3e68b7f41aa88ee10b3300) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #679 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/679/)
        HADOOP-12618. Fix NPE in TestSequenceFile. (Brahma Reddy Battula via (umamahesh: rev ad53c520630847834b3e68b7f41aa88ee10b3300)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #679 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/679/ ) HADOOP-12618 . Fix NPE in TestSequenceFile. (Brahma Reddy Battula via (umamahesh: rev ad53c520630847834b3e68b7f41aa88ee10b3300) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development