Masatake Iwasaki added a comment - 01/Dec/15 08:48 testAccumulate(org.apache.hadoop.ipc.TestDecayRpcScheduler) Time elapsed: 0.1 sec <<< FAILURE! java.lang.AssertionError: expected:<3> but was:<2> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.ipc.TestDecayRpcScheduler.testAccumulate(TestDecayRpcScheduler.java:136) testPriority(org.apache.hadoop.ipc.TestDecayRpcScheduler) Time elapsed: 0.119 sec <<< FAILURE! java.lang.AssertionError: expected:<2> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.ipc.TestDecayRpcScheduler.testPriority(TestDecayRpcScheduler.java:195)

Masatake Iwasaki added a comment - 01/Dec/15 15:29 Timer timer = new Timer(); DecayTask task = new DecayTask( this , timer); timer.scheduleAtFixedRate(task, 0, this .decayPeriodMillis); In the constructor of DecayRpcScheduler, DecayTask is scheduled without initial delay. This makes testAccumulate and testPriority non-deterministic. Calling decayCurrentCounts immediately after initialization should have no practical meanings. Attached 001 sets the initial delay to decayPeriodMillis .

Hadoop QA added a comment - 01/Dec/15 16:53 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 1s trunk passed +1 compile 8m 39s trunk passed with JDK v1.8.0_66 +1 compile 9m 14s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 0m 58s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 41s the patch passed +1 compile 8m 35s the patch passed with JDK v1.8.0_66 +1 javac 8m 35s the patch passed +1 compile 9m 19s the patch passed with JDK v1.7.0_85 +1 javac 9m 19s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_85 -1 unit 7m 52s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 7m 51s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 74m 17s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.TestLocalFsFCStatistics JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775048/HADOOP-12609.001.patch JIRA Issue HADOOP-12609 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4cf480504ba2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1c05393 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8171/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8171/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8171/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8171/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8171/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8171/console This message was automatically generated.

Arpit Agarwal added a comment - 01/Dec/15 17:24 Nice catch. +1 for the patch. I will commit it shortly. Thanks for fixing this Masatake Iwasaki .

Arpit Agarwal added a comment - 01/Dec/15 17:31 Committed this to trunk and branch-2. I left out the whitespace-only change to TestDecayRpcScheduler.java.

Hudson added a comment - 01/Dec/15 17:45 FAILURE: Integrated in Hadoop-trunk-Commit #8904 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8904/ ) HADOOP-12609 . Fix intermittent failure of TestDecayRpcScheduler. (arp: rev 485c3468a8520fcde14800af3e4a075231c946de) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java

Kihwal Lee added a comment - 01/Dec/15 22:39 Don't forget to put into branch-2.8.

Arpit Agarwal added a comment - 01/Dec/15 23:31 Done. Thanks Kihwal Lee .

Hudson added a comment - 02/Dec/15 00:40 FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #655 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/655/ ) HADOOP-12609 . Fix intermittent failure of TestDecayRpcScheduler. (arp: rev 485c3468a8520fcde14800af3e4a075231c946de) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java