[HADOOP-12604] Exception may be swallowed in KMSClientProvider

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: kms
• Labels: supportability
• Hadoop Flags: Reviewed
• Assignee: Yongjun Zhang
• Reporter: Yongjun Zhang
• Created: 26/Nov/15 16:44
• Updated: 30/Aug/16 01:21
• Resolved: 05/Jan/16 19:39

Description

In KMSClientProvider# createConnection

      try {
        is = conn.getInputStream();
        ret = mapper.readValue(is, klass);
      } catch (IOException ex) {
        if (is != null) {
          is.close(); <== close may throw exception
        }
        throw ex;
      } finally {
        if (is != null) {
          is.close();
        }
      }
    }

ex may be swallowed when close highlighted in the code throws exception. Thanks qwertymaniac for pointing this out.

BTW, I think we should be able to consolidate the two is.close() in the above code, so we don't close the same stream twice. The one in the finally block may be called after an exception is thrown or not, and it may throw exception too, we need to be careful not to swallow exception here too.