Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12597

In kms-site.xml configuration "hadoop.security.keystore.JavaKeyStoreProvider.password" should be updated with new name

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In http://hadoop.apache.org/docs/r2.7.0/hadoop-kms/index.html :
      it mentioned as

       
      <property>
          <name>hadoop.security.keystore.java-keystore-provider.password-file</name>
          <value>kms.keystore.password</value>
        </property>
      

      But in kms-site.xml the configuration name is wrong.

      <property> <name>hadoop.security.keystore.JavaKeyStoreProvider.password</name>
          <value>none</value>
          <description>
            If using the JavaKeyStoreProvider, the password for the keystore file.
          </description>
        </property>
      
      1. HADOOP-12597-branch-2.7.patch
        0.9 kB
        Brahma Reddy Battula
      2. HDFS-8534.patch
        0.9 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Brahma Reddy Battula for review and commit. Thanks Steve Loughran for review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Brahma Reddy Battula for review and commit. Thanks Steve Loughran for review..
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Pushed to branch-2.7..thanks to huangyitian for reporting ,Surendra Singh Lilhore for contribution.and thanks to Steve Loughran for review.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Pushed to branch-2.7..thanks to huangyitian for reporting , Surendra Singh Lilhore for contribution.and thanks to Steve Loughran for review.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LGTM: +1

          Show
          stevel@apache.org Steve Loughran added a comment - LGTM: +1
          Hide
          brahmareddy Brahma Reddy Battula added a comment - - edited

          whitespace is unrelated.Steve Loughran can you take look at branch-2.7 patch..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - - edited whitespace is unrelated. Steve Loughran can you take look at branch-2.7 patch..?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 10s branch-2.7 passed
          +1 mvnsite 0m 23s branch-2.7 passed
          +1 mvnsite 0m 21s the patch passed
          -1 whitespace 0m 0s The patch has 1540 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 39s The patch 20 line(s) with tabs.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 unit 0m 14s hadoop-kms in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          9m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HADOOP-12597
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830194/HADOOP-12597-branch-2.7.patch
          Optional Tests asflicense mvnsite unit xml
          uname Linux db412aa12117 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 66ee9f5
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10588/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10588/artifact/patchprocess/whitespace-tabs.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10588/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10588/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 10s branch-2.7 passed +1 mvnsite 0m 23s branch-2.7 passed +1 mvnsite 0m 21s the patch passed -1 whitespace 0m 0s The patch has 1540 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 39s The patch 20 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. +1 unit 0m 14s hadoop-kms in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 9m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-12597 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830194/HADOOP-12597-branch-2.7.patch Optional Tests asflicense mvnsite unit xml uname Linux db412aa12117 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 66ee9f5 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10588/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10588/artifact/patchprocess/whitespace-tabs.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10588/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10588/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Steve Loughran thanks for response.. Uploaded the branch-2.7 patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Steve Loughran thanks for response.. Uploaded the branch-2.7 patch..
          Hide
          stevel@apache.org Steve Loughran added a comment -

          (but before you apply, do submit a patch against 2.7 just for the yetus check)

          Show
          stevel@apache.org Steve Loughran added a comment - (but before you apply, do submit a patch against 2.7 just for the yetus check)
          Hide
          stevel@apache.org Steve Loughran added a comment -

          sure, backport it & set the fix version to 2.7.4

          Show
          stevel@apache.org Steve Loughran added a comment - sure, backport it & set the fix version to 2.7.4
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 6s HADOOP-12597 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HADOOP-12597
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12737914/HDFS-8534.patch
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10587/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HADOOP-12597 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-12597 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12737914/HDFS-8534.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10587/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          I think, this is required in branch-2.7 also...Steve Loughran can we merge and close this jira..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - I think, this is required in branch-2.7 also... Steve Loughran can we merge and close this jira..?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Steve Loughran for committing in branch-2!

          One doubt..

          Is this fix not required in trunk ?

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Steve Loughran for committing in branch-2! One doubt.. Is this fix not required in trunk ?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9070 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9070/)
          HADOOP-12597. In kms-site.xml configuration (stevel: rev bac798abfcaf651db2e8c1a33c661da0c22d42ab)

          • hadoop-common-project/hadoop-kms/src/main/conf/kms-site.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9070 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9070/ ) HADOOP-12597 . In kms-site.xml configuration (stevel: rev bac798abfcaf651db2e8c1a33c661da0c22d42ab) hadoop-common-project/hadoop-kms/src/main/conf/kms-site.xml hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1 - committed to branch-2. Thanks!

          Show
          stevel@apache.org Steve Loughran added a comment - +1 - committed to branch-2. Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvnsite 0m 33s trunk passed
          +1 mvnsite 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 unit 0m 16s hadoop-kms in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 16s hadoop-kms in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 33s Patch does not generate ASF License warnings.
          2m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12737914/HDFS-8534.patch
          JIRA Issue HADOOP-12597
          Optional Tests asflicense mvnsite unit xml
          uname Linux a72bc291bc6e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 23c625e
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8150/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Max memory used 31MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8150/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvnsite 0m 33s trunk passed +1 mvnsite 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 unit 0m 16s hadoop-kms in the patch passed with JDK v1.8.0_66. +1 unit 0m 16s hadoop-kms in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 33s Patch does not generate ASF License warnings. 2m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12737914/HDFS-8534.patch JIRA Issue HADOOP-12597 Optional Tests asflicense mvnsite unit xml uname Linux a72bc291bc6e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 23c625e JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8150/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Max memory used 31MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8150/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 50s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 8m 57s There were no new javac warning messages.
          +1 javadoc 11m 49s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 51s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 common tests 2m 3s Tests passed in hadoop-kms.
              43m 32s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12737914/HDFS-8534.patch
          Optional Tests javadoc javac unit
          git revision trunk / 790a861
          hadoop-kms test log https://builds.apache.org/job/PreCommit-HDFS-Build/11240/artifact/patchprocess/testrun_hadoop-kms.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11240/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11240/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 50s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 57s There were no new javac warning messages. +1 javadoc 11m 49s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 51s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 common tests 2m 3s Tests passed in hadoop-kms.     43m 32s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12737914/HDFS-8534.patch Optional Tests javadoc javac unit git revision trunk / 790a861 hadoop-kms test log https://builds.apache.org/job/PreCommit-HDFS-Build/11240/artifact/patchprocess/testrun_hadoop-kms.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11240/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11240/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached patch , please review

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached patch , please review

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              oneday huangyitian
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development