Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12584

Disable browsing the static directory in HttpServer2

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      We found a minor security issue with the Yarn Web UIs (or anything using HttpServer2. Currently, you can list the contents of the /static directory for the RM, NM, and JHS. This isn't a huge deal, but there are some ways to abuse this to get access to files on the host, though it would be pretty difficult. It's also good practice to disable directory listing on web apps.

      Here are the URLs:

      1. HADOOP-12584.001.patch
        0.8 kB
        Robert Kanter
      2. HADOOP-12584.002.patch
        0.9 kB
        Robert Kanter
      3. HADOOP-12584_branch-2.003.patch
        2 kB
        Robert Kanter
      4. HADOOP-12584.003.patch
        2 kB
        Robert Kanter

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9089 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9089/)
          HADOOP-12584. Disable browsing the static directory in HttpServer2. (aajisaka: rev 56b9500bbd44b79c3c3be84a17c97502f923c6f8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9089 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9089/ ) HADOOP-12584 . Disable browsing the static directory in HttpServer2. (aajisaka: rev 56b9500bbd44b79c3c3be84a17c97502f923c6f8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, and branch-2.8. Thanks Robert Kanter for updating the patch and thanks Steve Loughran for your review.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Robert Kanter for updating the patch and thanks Steve Loughran for your review.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1 from me, too

          Show
          stevel@apache.org Steve Loughran added a comment - +1 from me, too
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          rkanter Robert Kanter added a comment -

          Those test failures were unrelated, and don't seem to be failing now when I run it locally. I ran all of the tests in hadoop-common-project, hadoop-yarn-project, hadoop-mapreduce-project, and hadoop-hdfs-project and they all passed.

          Steve Loughran, Varun Saxena, can one of your review the updated patch?

          Show
          rkanter Robert Kanter added a comment - Those test failures were unrelated, and don't seem to be failing now when I run it locally. I ran all of the tests in hadoop-common-project, hadoop-yarn-project, hadoop-mapreduce-project, and hadoop-hdfs-project and they all passed. Steve Loughran , Varun Saxena , can one of your review the updated patch?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 19s trunk passed
          +1 compile 8m 59s trunk passed with JDK v1.8.0_66
          +1 compile 9m 32s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 2s trunk passed
          +1 mvnsite 1m 44s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 25s trunk passed
          +1 javadoc 1m 28s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 43s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 11s the patch passed
          +1 compile 9m 50s the patch passed with JDK v1.8.0_66
          +1 javac 9m 50s the patch passed
          +1 compile 10m 13s the patch passed with JDK v1.7.0_91
          +1 javac 10m 13s the patch passed
          +1 checkstyle 1m 5s the patch passed
          +1 mvnsite 1m 39s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 39s the patch passed
          +1 javadoc 1m 31s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 44s the patch passed with JDK v1.7.0_91
          -1 unit 7m 53s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 7m 55s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          90m 44s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.shell.TestCopyPreserveFlag
          JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777795/HADOOP-12584.003.patch
          JIRA Issue HADOOP-12584
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 65b2de5a6afa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8602692
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 75MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 19s trunk passed +1 compile 8m 59s trunk passed with JDK v1.8.0_66 +1 compile 9m 32s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 2s trunk passed +1 mvnsite 1m 44s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 25s trunk passed +1 javadoc 1m 28s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 43s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 11s the patch passed +1 compile 9m 50s the patch passed with JDK v1.8.0_66 +1 javac 9m 50s the patch passed +1 compile 10m 13s the patch passed with JDK v1.7.0_91 +1 javac 10m 13s the patch passed +1 checkstyle 1m 5s the patch passed +1 mvnsite 1m 39s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 39s the patch passed +1 javadoc 1m 31s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_91 -1 unit 7m 53s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 7m 55s hadoop-common in the patch failed with JDK v1.7.0_91. +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 90m 44s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.shell.TestCopyPreserveFlag JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777795/HADOOP-12584.003.patch JIRA Issue HADOOP-12584 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 65b2de5a6afa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8602692 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 75MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8251/console This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          The 003 patch fixes the unit test failure found in YARN-4379. trunk and branch-2 have no diverged there, so I also had to make a separate branch-2 patch.

          Show
          rkanter Robert Kanter added a comment - The 003 patch fixes the unit test failure found in YARN-4379 . trunk and branch-2 have no diverged there, so I also had to make a separate branch-2 patch.
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #627 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/627/)
          Revert "HADOOP-12584. Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #627 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/627/ ) Revert " HADOOP-12584 . Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2565 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2565/)
          Revert "HADOOP-12584. Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2565 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2565/ ) Revert " HADOOP-12584 . Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #706 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/706/)
          Revert "HADOOP-12584. Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #706 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/706/ ) Revert " HADOOP-12584 . Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1431 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1431/)
          Revert "HADOOP-12584. Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1431 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1431/ ) Revert " HADOOP-12584 . Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2635 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2635/)
          Revert "HADOOP-12584. Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2635 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2635/ ) Revert " HADOOP-12584 . Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #694 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/694/)
          Revert "HADOOP-12584. Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #694 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/694/ ) Revert " HADOOP-12584 . Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8838 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8838/)
          Revert "HADOOP-12584. Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8838 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8838/ ) Revert " HADOOP-12584 . Disable browsing the static directory in (stevel: rev a6f20d80de3adbebacd586a534b474030ff608e9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I'm re-opening this briefly until a patch including the YARN-4379 diff is merged in, with a test run against YARN too. Sorry, but I'm getting fed up with the fact that hadoop jenkins builds are so unreliable that them and patch test runs are essentially meaningless

          Show
          stevel@apache.org Steve Loughran added a comment - I'm re-opening this briefly until a patch including the YARN-4379 diff is merged in, with a test run against YARN too. Sorry, but I'm getting fed up with the fact that hadoop jenkins builds are so unreliable that them and patch test runs are essentially meaningless
          Hide
          stevel@apache.org Steve Loughran added a comment -

          This broke YARN test runs: YARN-4379

          please, for changes to Hadoop where the code is used most in hdfs and yarn, test those things as well as the core

          Show
          stevel@apache.org Steve Loughran added a comment - This broke YARN test runs: YARN-4379 please, for changes to Hadoop where the code is used most in hdfs and yarn, test those things as well as the core
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2560 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2560/)
          HADOOP-12584. Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2560 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2560/ ) HADOOP-12584 . Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #622 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/622/)
          HADOOP-12584. Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #622 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/622/ ) HADOOP-12584 . Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #700 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/700/)
          HADOOP-12584. Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #700 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/700/ ) HADOOP-12584 . Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #688 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/688/)
          HADOOP-12584. Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #688 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/688/ ) HADOOP-12584 . Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1426 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1426/)
          HADOOP-12584. Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1426 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1426/ ) HADOOP-12584 . Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2629 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2629/)
          HADOOP-12584. Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2629 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2629/ ) HADOOP-12584 . Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8832 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8832/)
          HADOOP-12584. Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8832 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8832/ ) HADOOP-12584 . Disable browsing the static directory in HttpServer2. (wheat9: rev 4539131102e01bd150d147c16e33d0dd1e9a031a) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          Hide
          rkanter Robert Kanter added a comment -

          Thanks for reviewing and committing Haohui Mai

          Show
          rkanter Robert Kanter added a comment - Thanks for reviewing and committing Haohui Mai
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Robert Kanter for the contribution.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Robert Kanter for the contribution.
          Hide
          wheat9 Haohui Mai added a comment -

          I'll commit it shortly.

          Show
          wheat9 Haohui Mai added a comment - I'll commit it shortly.
          Hide
          rkanter Robert Kanter added a comment -

          Test failure unrelated

          Show
          rkanter Robert Kanter added a comment - Test failure unrelated
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 10m 51s trunk passed
          +1 compile 13m 0s trunk passed with JDK v1.8.0_66
          +1 compile 11m 19s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 2m 31s trunk passed
          +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 27s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 8s the patch passed
          +1 compile 14m 6s the patch passed with JDK v1.8.0_66
          +1 javac 14m 6s the patch passed
          +1 compile 11m 16s the patch passed with JDK v1.7.0_85
          +1 javac 11m 16s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 1m 15s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 28s the patch passed
          +1 javadoc 1m 13s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 19s the patch passed with JDK v1.7.0_85
          -1 unit 8m 51s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 8m 26s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 31s Patch does not generate ASF License warnings.
          96m 10s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestIPC
            hadoop.test.TestTimedOutTestsListener
          JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestMetricsSystemImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-19
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773324/HADOOP-12584.002.patch
          JIRA Issue HADOOP-12584
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a5ab0136edac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build@2/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 747455a
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 78MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 10m 51s trunk passed +1 compile 13m 0s trunk passed with JDK v1.8.0_66 +1 compile 11m 19s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 2m 31s trunk passed +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 27s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 8s the patch passed +1 compile 14m 6s the patch passed with JDK v1.8.0_66 +1 javac 14m 6s the patch passed +1 compile 11m 16s the patch passed with JDK v1.7.0_85 +1 javac 11m 16s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_85 -1 unit 8m 51s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 8m 26s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 31s Patch does not generate ASF License warnings. 96m 10s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestIPC   hadoop.test.TestTimedOutTestsListener JDK v1.7.0_85 Failed junit tests hadoop.metrics2.impl.TestMetricsSystemImpl Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773324/HADOOP-12584.002.patch JIRA Issue HADOOP-12584 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a5ab0136edac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build@2/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 747455a findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8110/console This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          002 patch fixes warnings and checkstyle.

          Show
          rkanter Robert Kanter added a comment - 002 patch fixes warnings and checkstyle.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 34s trunk passed
          +1 compile 10m 11s trunk passed with JDK v1.8.0_66
          +1 compile 9m 57s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 1m 9s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 59s trunk passed
          +1 javadoc 1m 0s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 43s the patch passed
          +1 compile 9m 42s the patch passed with JDK v1.8.0_66
          -1 javac 15m 34s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 779, now 779).
          +1 javac 9m 42s the patch passed
          +1 compile 10m 0s the patch passed with JDK v1.7.0_85
          -1 javac 25m 34s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 772, now 772).
          +1 javac 10m 0s the patch passed
          -1 checkstyle 0m 19s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 63, now 64).
          +1 mvnsite 1m 10s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 25s the patch passed
          +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 12s the patch passed with JDK v1.7.0_85
          +1 unit 8m 29s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 19s hadoop-common in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          80m 48s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-19
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773109/HADOOP-12584.001.patch
          JIRA Issue HADOOP-12584
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 39edfd8f8142 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 23a130a
          findbugs v3.0.0
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 77MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 34s trunk passed +1 compile 10m 11s trunk passed with JDK v1.8.0_66 +1 compile 9m 57s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 0s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 43s the patch passed +1 compile 9m 42s the patch passed with JDK v1.8.0_66 -1 javac 15m 34s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 779, now 779). +1 javac 9m 42s the patch passed +1 compile 10m 0s the patch passed with JDK v1.7.0_85 -1 javac 25m 34s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 772, now 772). +1 javac 10m 0s the patch passed -1 checkstyle 0m 19s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 63, now 64). +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 25s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 12s the patch passed with JDK v1.7.0_85 +1 unit 8m 29s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 19s hadoop-common in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 80m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773109/HADOOP-12584.001.patch JIRA Issue HADOOP-12584 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 39edfd8f8142 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 23a130a findbugs v3.0.0 javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8086/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          +1

          Show
          wheat9 Haohui Mai added a comment - +1
          Hide
          rkanter Robert Kanter added a comment -

          This should fix anything using HttpServer2.

          Show
          rkanter Robert Kanter added a comment - This should fix anything using HttpServer2 .
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          I remember this was always the case with all of our daemons, not just YARN UIs, isn't it?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - I remember this was always the case with all of our daemons, not just YARN UIs, isn't it?
          Hide
          kasha Karthik Kambatla added a comment -

          +1

          Show
          kasha Karthik Kambatla added a comment - +1
          Hide
          rkanter Robert Kanter added a comment -

          Simple fix sets org.eclipse.jetty.servlet.Default.dirAllowed to false. I verified that with the patch you can't browse the files anymore.

          Show
          rkanter Robert Kanter added a comment - Simple fix sets org.eclipse.jetty.servlet.Default.dirAllowed to false . I verified that with the patch you can't browse the files anymore.

            People

            • Assignee:
              rkanter Robert Kanter
              Reporter:
              rkanter Robert Kanter
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development