Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      BytesWritable's deprecated methods, get() and getSize(), are still used in some tests: TestTFileSeek, TestTFileSeqFileComparison, TestSequenceFile, and so on. We can also remove them if targeting this to 3.0.0

      https://builds.apache.org/job/PreCommit-HADOOP-Build/8084/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt

        Activity

        Hide
        aw Allen Wittenauer added a comment -

        Honestly, we need a massive "remove usage of deprecated methods" patch for all of Hadoop.

        Show
        aw Allen Wittenauer added a comment - Honestly, we need a massive "remove usage of deprecated methods" patch for all of Hadoop.
        Hide
        eepayne Eric Payne added a comment -

        Honestly, we need a massive "remove usage of deprecated methods" patch for all of Hadoop.

        I think it would be better to do it piecemeal. Easier to review, easier to test.

        Show
        eepayne Eric Payne added a comment - Honestly, we need a massive "remove usage of deprecated methods" patch for all of Hadoop. I think it would be better to do it piecemeal. Easier to review, easier to test.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I think it would be better to do it piecemeal. Easier to review, easier to test.

        Agree.

        Show
        ajisakaa Akira Ajisaka added a comment - I think it would be better to do it piecemeal. Easier to review, easier to test. Agree.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 8s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        +1 mvninstall 9m 21s trunk passed
        +1 compile 9m 21s trunk passed with JDK v1.8.0_66
        +1 compile 9m 46s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 1m 14s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 2m 18s trunk passed
        +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 15s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 57s the patch passed
        +1 compile 11m 23s the patch passed with JDK v1.8.0_66
        +1 javac 11m 23s the patch passed
        +1 compile 11m 10s the patch passed with JDK v1.7.0_85
        +1 javac 11m 10s the patch passed
        +1 checkstyle 0m 19s the patch passed
        +1 mvnsite 1m 18s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 42s the patch passed
        +1 javadoc 1m 10s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 19s the patch passed with JDK v1.7.0_85
        -1 unit 9m 35s hadoop-common in the patch failed with JDK v1.8.0_66.
        +1 unit 9m 10s hadoop-common in the patch passed with JDK v1.7.0_85.
        +1 asflicense 0m 28s Patch does not generate ASF License warnings.
        87m 4s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
          hadoop.test.TestTimedOutTestsListener



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:date2015-11-19
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773161/HADOOP-12582.00.patch
        JIRA Issue HADOOP-12582
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7f8895fad0b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
        git revision trunk / 23a130a
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8087/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8087/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8087/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 77MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8087/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 9m 21s trunk passed +1 compile 9m 21s trunk passed with JDK v1.8.0_66 +1 compile 9m 46s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 17s trunk passed +1 mvnsite 1m 14s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 18s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 15s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 57s the patch passed +1 compile 11m 23s the patch passed with JDK v1.8.0_66 +1 javac 11m 23s the patch passed +1 compile 11m 10s the patch passed with JDK v1.7.0_85 +1 javac 11m 10s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 42s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_85 -1 unit 9m 35s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 9m 10s hadoop-common in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 87m 4s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.test.TestTimedOutTestsListener Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773161/HADOOP-12582.00.patch JIRA Issue HADOOP-12582 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7f8895fad0b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 23a130a findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8087/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8087/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8087/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8087/console This message was automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        +1, checking this in.

        Show
        ozawa Tsuyoshi Ozawa added a comment - +1, checking this in.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Committed this to trunk and branch-2. Thanks Akira Ajisaka for your contribution, and thanks Allen Wittenauer and Eric Payne for your suggestions.

        Opened HADOOP-12585 as a umbrella jira to address the problem.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Akira Ajisaka for your contribution, and thanks Allen Wittenauer and Eric Payne for your suggestions. Opened HADOOP-12585 as a umbrella jira to address the problem.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8824 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8824/)
        HADOOP-12582. Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8824 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8824/ ) HADOOP-12582 . Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #694 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/694/)
        HADOOP-12582. Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #694 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/694/ ) HADOOP-12582 . Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2623 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2623/)
        HADOOP-12582. Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2623 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2623/ ) HADOOP-12582 . Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #682 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/682/)
        HADOOP-12582. Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #682 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/682/ ) HADOOP-12582 . Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thank you, Tsuyoshi!

        Show
        ajisakaa Akira Ajisaka added a comment - Thank you, Tsuyoshi!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1421 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1421/)
        HADOOP-12582. Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1421 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1421/ ) HADOOP-12582 . Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2556 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2556/)
        HADOOP-12582. Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2556 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2556/ ) HADOOP-12582 . Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #618 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/618/)
        HADOOP-12582. Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #618 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/618/ ) HADOOP-12582 . Using BytesWritable's getLength() and getBytes() instead (ozawa: rev bd166f0eed058795dd70b2ee019356c55422173c) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KeySampler.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeek.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/KVGenerator.java

          People

          • Assignee:
            ajisakaa Akira Ajisaka
            Reporter:
            ozawa Tsuyoshi Ozawa
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development