Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12519

hadoop-azure tests should avoid creating a metrics configuration file in the module root directory.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: fs/azure, test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The hadoop-azure JUnit tests create a metrics configuration file. This file gets saved in the root directory of the hadoop-azure module. This dirties the git workspace and won't get removed by mvn clean, because it's outside of the build target directory. It also can cause the pre-commit license check step to fail, because this ends up looking like the patch added a new file without the Apache license header.

        Activity

        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #547 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/547/)
        HADOOP-12519. hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf)

        • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #547 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/547/ ) HADOOP-12519 . hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2485 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2485/)
        HADOOP-12519. hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf)

        • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2485 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2485/ ) HADOOP-12519 . hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2538 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2538/)
        HADOOP-12519. hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2538 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2538/ ) HADOOP-12519 . hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1332 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1332/)
        HADOOP-12519. hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1332 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1332/ ) HADOOP-12519 . hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #609 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/609/)
        HADOOP-12519. hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #609 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/609/ ) HADOOP-12519 . hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8720 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8720/)
        HADOOP-12519. hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8720 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8720/ ) HADOOP-12519 . hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #595 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/595/)
        HADOOP-12519. hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf)

        • hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #595 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/595/ ) HADOOP-12519 . hadoop-azure tests should avoid creating a metrics (cnauroth: rev 2d10cb8e00fd84be26b51f9fba819e3e5b6cdcbf) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AzureBlobStorageTestAccount.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        cnauroth Chris Nauroth added a comment -

        Thanks very much for the review, Xiaoyu. I have committed this to trunk and branch-2.

        Show
        cnauroth Chris Nauroth added a comment - Thanks very much for the review, Xiaoyu. I have committed this to trunk and branch-2.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Chris Nauroth for fixing this. The patch looks good to me. +1

        Show
        xyao Xiaoyu Yao added a comment - Thanks Chris Nauroth for fixing this. The patch looks good to me. +1
        Hide
        cnauroth Chris Nauroth added a comment -

        In addition to the Jenkins +1, I've also done a full test run of hadoop-azure integrated with the real service.

        Xiaoyu Yao, could you please code review this one? Thanks!

        Show
        cnauroth Chris Nauroth added a comment - In addition to the Jenkins +1, I've also done a full test run of hadoop-azure integrated with the real service. Xiaoyu Yao , could you please code review this one? Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 15s trunk passed
        +1 compile 0m 13s trunk passed with JDK v1.8.0_60
        +1 compile 0m 13s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 8s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 31s trunk passed
        +1 javadoc 0m 13s trunk passed with JDK v1.8.0_60
        +1 javadoc 0m 14s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 15s the patch passed
        +1 compile 0m 12s the patch passed with JDK v1.8.0_60
        +1 javac 0m 12s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.7.0_79
        +1 javac 0m 13s the patch passed
        +1 checkstyle 0m 8s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 38s the patch passed
        +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60
        +1 javadoc 0m 14s the patch passed with JDK v1.7.0_79
        +1 unit 1m 2s hadoop-azure in the patch passed with JDK v1.8.0_60.
        +1 unit 1m 14s hadoop-azure in the patch passed with JDK v1.7.0_79.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        10m 54s



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-28
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769125/HADOOP-12519.001.patch
        JIRA Issue HADOOP-12519
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 5ec0d7de8491 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-2392ab4/dev-support/personality/hadoop.sh
        git revision trunk / 68ce93c
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7956/testReport/
        modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
        Max memory used 225MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7956/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 15s trunk passed +1 compile 0m 13s trunk passed with JDK v1.8.0_60 +1 compile 0m 13s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 8s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 15s the patch passed +1 compile 0m 12s the patch passed with JDK v1.8.0_60 +1 javac 0m 12s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_79 +1 javac 0m 13s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 14s the patch passed with JDK v1.7.0_79 +1 unit 1m 2s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 14s hadoop-azure in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 10m 54s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-28 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769125/HADOOP-12519.001.patch JIRA Issue HADOOP-12519 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 5ec0d7de8491 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-2392ab4/dev-support/personality/hadoop.sh git revision trunk / 68ce93c Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7956/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7956/console This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        The attached patch moves the metrics configuration file into target/test-classes, so it's still available on the runtime classpath for tests, but it doesn't dirty the workspace. This is the same approach used by hadoop-common tests, like TestMetricsSystemImpl.

        Show
        cnauroth Chris Nauroth added a comment - The attached patch moves the metrics configuration file into target/test-classes, so it's still available on the runtime classpath for tests, but it doesn't dirty the workspace. This is the same approach used by hadoop-common tests, like TestMetricsSystemImpl .

          People

          • Assignee:
            cnauroth Chris Nauroth
            Reporter:
            cnauroth Chris Nauroth
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development