Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12514

Make static fields in GenericTestUtils for assertExceptionContains() package-private and final

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.8.0
    • 2.8.0, 3.0.0-alpha1
    • test
    • None

    Description

      This is a follow up of HADOOP-12472.

      It makes sense to make the following static fields package private instead of protected, as they are for test purpose and TestGenericTestUtils is in the same package as GenericTestUtils.

      • protected static String E_NULL_THROWABLE = "Null Throwable";
      • protected static String E_NULL_THROWABLE_STRING = "Null Throwable.toString() value";
      • protected static String E_UNEXPECTED_EXCEPTION = "but got unexpected exception";

      Meanwhile, we may need to make them final.

      Attachments

        1. HADOOP-12514.000.patch
          1 kB
          Mingliang Liu

        Issue Links

          Activity

            People

              liuml07 Mingliang Liu
              liuml07 Mingliang Liu
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: