Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12484

Single File Rename Throws Incorrectly In Potential Race Condition Scenarios

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tools
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FinishSingleFileRename function - in the case where src and dst both exist gets a lease on src blob to block write access and then deletes the file. However in the time between checking existence of source file and acquiring lease the file may be deleted by another process (race condition). Presently the function simply throws in this scenario. In this case the function should treat this as a case where rename is complete; i.e. catch the exception and if this is the cause exit gracefully with the result that the rename is complete

      1. HADOOP-12484.01.patch
        2 kB
        Gaurav Kanade
      2. HADOOP-12484.02.patch
        4 kB
        Gaurav Kanade
      3. HADOOP-12484.03.patch
        2 kB
        Chris Nauroth
      4. HADOOP-12484.04.patch
        2 kB
        Gaurav Kanade
      5. HADOOP-12484.05.patch
        2 kB
        Gaurav Kanade
      6. HADOOP-12484.06.patch
        2 kB
        Chris Nauroth

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 36s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 56s There were no new javac warning messages.
        +1 javadoc 10m 25s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 22s The applied patch generated 3 new checkstyle issues (total was 26, now 29).
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 0m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 tools/hadoop tests 1m 13s Tests passed in hadoop-azure.
            39m 50s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12766929/HADOOP-12484.01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / cf23f2c
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/artifact/patchprocess/diffcheckstylehadoop-azure.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/artifact/patchprocess/whitespace.txt
        hadoop-azure test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/artifact/patchprocess/testrun_hadoop-azure.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 36s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 56s There were no new javac warning messages. +1 javadoc 10m 25s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 22s The applied patch generated 3 new checkstyle issues (total was 26, now 29). -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 1m 13s Tests passed in hadoop-azure.     39m 50s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766929/HADOOP-12484.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cf23f2c checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/artifact/patchprocess/diffcheckstylehadoop-azure.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/artifact/patchprocess/whitespace.txt hadoop-azure test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/artifact/patchprocess/testrun_hadoop-azure.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7828/console This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        Hello Gaurav Kanade.

                try {
                    SelfRenewingLease lease = fs.acquireLease(srcFile);
        
                    // Delete the file. This will free the lease too.
                    fs.getStoreInterface().delete(srcName, lease);
                  } catch(AzureException e) {
        

        If acquireLease succeeds, but then the delete fails, then this will leak the lease. Can you please use a finally block to guarantee that the lease gets released in all code paths? You can look at other points in the class that acquire and free a lease for an existing example.

        Could you please review the checkstyle and whitespace warnings from the pre-commit run and fix them?

        If it's not feasible to write a unit test to simulate the race condition, then can you please describe any manual testing that you've done to verify the change?

        Thank you!

        Show
        cnauroth Chris Nauroth added a comment - Hello Gaurav Kanade . try { SelfRenewingLease lease = fs.acquireLease(srcFile); // Delete the file. This will free the lease too. fs.getStoreInterface().delete(srcName, lease); } catch (AzureException e) { If acquireLease succeeds, but then the delete fails, then this will leak the lease. Can you please use a finally block to guarantee that the lease gets released in all code paths? You can look at other points in the class that acquire and free a lease for an existing example. Could you please review the checkstyle and whitespace warnings from the pre-commit run and fix them? If it's not feasible to write a unit test to simulate the race condition, then can you please describe any manual testing that you've done to verify the change? Thank you!
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767135/HADOOP-12484.02.patch
        Optional Tests  
        git revision trunk / 79b8d60
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7836/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767135/HADOOP-12484.02.patch Optional Tests   git revision trunk / 79b8d60 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7836/console This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        Gaurav Kanade, it looks like patch v02 was in UTF-16 encoding. Patch files need to use ASCII encoding. I'm attaching patch v03, which is the same thing in ASCII encoding.

        Show
        cnauroth Chris Nauroth added a comment - Gaurav Kanade , it looks like patch v02 was in UTF-16 encoding. Patch files need to use ASCII encoding. I'm attaching patch v03, which is the same thing in ASCII encoding.
        Hide
        cnauroth Chris Nauroth added a comment -

        Gaurav Kanade, there is one more problem here:

                } finally {
                  try {
                    lease.free();
                  } catch(StorageException e){
                    LOG.warn("Unable to free lease because: " + e.getMessage()); 
                  }
                }
        

        At this point, it's possible that lease is still null if the earlier acquireLease call threw an exception. I recommend checking this for null before calling free. Otherwise, it will cause a NullPointerException.

        Show
        cnauroth Chris Nauroth added a comment - Gaurav Kanade , there is one more problem here: } finally { try { lease.free(); } catch (StorageException e){ LOG.warn( "Unable to free lease because: " + e.getMessage()); } } At this point, it's possible that lease is still null if the earlier acquireLease call threw an exception. I recommend checking this for null before calling free . Otherwise, it will cause a NullPointerException .
        Hide
        gouravk Gaurav Kanade added a comment -

        Sorry for that Chris Nauroth; yes you are right. Im continuing to work on this for now and also explore the testing options.

        Show
        gouravk Gaurav Kanade added a comment - Sorry for that Chris Nauroth ; yes you are right. Im continuing to work on this for now and also explore the testing options.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 14s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 17s There were no new javac warning messages.
        +1 javadoc 10m 37s There were no new javadoc warning messages.
        +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 tools/hadoop tests 1m 13s Tests passed in hadoop-azure.
            38m 58s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767149/HADOOP-12484.03.patch
        Optional Tests javadoc javac unit
        git revision trunk / f9da5cd
        hadoop-azure test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7837/artifact/patchprocess/testrun_hadoop-azure.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7837/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7837/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 14s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 17s There were no new javac warning messages. +1 javadoc 10m 37s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 tools/hadoop tests 1m 13s Tests passed in hadoop-azure.     38m 58s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767149/HADOOP-12484.03.patch Optional Tests javadoc javac unit git revision trunk / f9da5cd hadoop-azure test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7837/artifact/patchprocess/testrun_hadoop-azure.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7837/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7837/console This message was automatically generated.
        Hide
        gouravk Gaurav Kanade added a comment -

        Chris Nauroth Addressed your comments above.

        With respect to tests: In this particular case the patch seems extremely straightforward but hard to test with unit tests or custom patch tests as this issue is exposed by hDP 2.3 integration tests that inject random failures.

        It would be good to have a thorough code review instead. Lin Chan, Pravin Mittal for reference

        Show
        gouravk Gaurav Kanade added a comment - Chris Nauroth Addressed your comments above. With respect to tests: In this particular case the patch seems extremely straightforward but hard to test with unit tests or custom patch tests as this issue is exposed by hDP 2.3 integration tests that inject random failures. It would be good to have a thorough code review instead. Lin Chan , Pravin Mittal for reference
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 6s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 mvninstall 1m 34s root in trunk failed.
        +1 compile 0m 12s trunk passed with JDK v1.8.0_60
        +1 compile 0m 10s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 9s trunk passed
        +1 mvneclipse 0m 10s trunk passed
        +1 findbugs 0m 27s trunk passed
        +1 javadoc 0m 10s trunk passed with JDK v1.8.0_60
        +1 javadoc 0m 11s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 13s the patch passed
        +1 compile 0m 9s the patch passed with JDK v1.8.0_60
        +1 javac 0m 9s the patch passed
        +1 compile 0m 11s the patch passed with JDK v1.7.0_79
        +1 javac 0m 11s the patch passed
        -1 checkstyle 0m 7s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-azure (total was 26, now 27).
        +1 mvneclipse 0m 9s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 0m 36s the patch passed
        +1 javadoc 0m 10s the patch passed with JDK v1.8.0_60
        +1 javadoc 0m 10s the patch passed with JDK v1.7.0_79
        +1 unit 0m 58s hadoop-azure in the patch passed with JDK v1.8.0_60.
        +1 unit 1m 11s hadoop-azure in the patch passed with JDK v1.7.0_79.
        -1 asflicense 0m 20s Patch generated 1 ASF License warnings.
        8m 10s



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-19
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767484/HADOOP-12484.04.patch
        JIRA Issue HADOOP-12484
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 849f8301e60b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build@2/patchprocess/apache-yetus-30c4bc4/dev-support/personality/hadoop.sh
        git revision trunk / 5068a25
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/artifact/patchprocess/branch-mvninstall-root.txt
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/artifact/patchprocess/whitespace-eol.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/artifact/patchprocess/patch-asflicense-problems.txt
        Max memory used 66MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 1m 34s root in trunk failed. +1 compile 0m 12s trunk passed with JDK v1.8.0_60 +1 compile 0m 10s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 9s trunk passed +1 mvneclipse 0m 10s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 10s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 11s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 13s the patch passed +1 compile 0m 9s the patch passed with JDK v1.8.0_60 +1 javac 0m 9s the patch passed +1 compile 0m 11s the patch passed with JDK v1.7.0_79 +1 javac 0m 11s the patch passed -1 checkstyle 0m 7s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-azure (total was 26, now 27). +1 mvneclipse 0m 9s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 36s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 10s the patch passed with JDK v1.7.0_79 +1 unit 0m 58s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 11s hadoop-azure in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 20s Patch generated 1 ASF License warnings. 8m 10s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767484/HADOOP-12484.04.patch JIRA Issue HADOOP-12484 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 849f8301e60b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build@2/patchprocess/apache-yetus-30c4bc4/dev-support/personality/hadoop.sh git revision trunk / 5068a25 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/artifact/patchprocess/patch-asflicense-problems.txt Max memory used 66MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7874/console This message was automatically generated.
        Hide
        gouravk Gaurav Kanade added a comment -

        Chris Nauroth Addressed your comments above but I seem to be facing a mvninstall error. Please check

        Show
        gouravk Gaurav Kanade added a comment - Chris Nauroth Addressed your comments above but I seem to be facing a mvninstall error. Please check
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 4s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 mvninstall 1m 26s root in trunk failed.
        +1 compile 0m 10s trunk passed with JDK v1.8.0_60
        +1 compile 0m 11s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 8s trunk passed
        +1 mvneclipse 0m 10s trunk passed
        +1 findbugs 0m 26s trunk passed
        +1 javadoc 0m 10s trunk passed with JDK v1.8.0_60
        +1 javadoc 0m 11s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 16s the patch passed
        +1 compile 0m 10s the patch passed with JDK v1.8.0_60
        +1 javac 0m 10s the patch passed
        +1 compile 0m 11s the patch passed with JDK v1.7.0_79
        +1 javac 0m 11s the patch passed
        -1 checkstyle 0m 7s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-azure (total was 26, now 27).
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 33s the patch passed
        +1 javadoc 0m 10s the patch passed with JDK v1.8.0_60
        +1 javadoc 0m 11s the patch passed with JDK v1.7.0_79
        +1 unit 0m 57s hadoop-azure in the patch passed with JDK v1.8.0_60.
        +1 unit 1m 11s hadoop-azure in the patch passed with JDK v1.7.0_79.
        -1 asflicense 0m 17s Patch generated 1 ASF License warnings.
        7m 54s



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-19
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767498/HADOOP-12484.04.patch
        JIRA Issue HADOOP-12484
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 1431124e329f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-30c4bc4/dev-support/personality/hadoop.sh
        git revision trunk / 8175c4f
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/artifact/patchprocess/branch-mvninstall-root.txt
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/artifact/patchprocess/patch-asflicense-problems.txt
        Max memory used 66MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 4s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 1m 26s root in trunk failed. +1 compile 0m 10s trunk passed with JDK v1.8.0_60 +1 compile 0m 11s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 8s trunk passed +1 mvneclipse 0m 10s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 10s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 11s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 16s the patch passed +1 compile 0m 10s the patch passed with JDK v1.8.0_60 +1 javac 0m 10s the patch passed +1 compile 0m 11s the patch passed with JDK v1.7.0_79 +1 javac 0m 11s the patch passed -1 checkstyle 0m 7s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-azure (total was 26, now 27). +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 33s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 11s the patch passed with JDK v1.7.0_79 +1 unit 0m 57s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 11s hadoop-azure in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 17s Patch generated 1 ASF License warnings. 7m 54s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767498/HADOOP-12484.04.patch JIRA Issue HADOOP-12484 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 1431124e329f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-30c4bc4/dev-support/personality/hadoop.sh git revision trunk / 8175c4f Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/artifact/patchprocess/patch-asflicense-problems.txt Max memory used 66MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7882/console This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -
                  if (errorCode.equals("BlobNotFound")) {
                    // The rename already finished, so do nothing.
                    ;
                  } else {
                    throw e;
                  }
        

        This part is triggering a Checkstyle warning:

        ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java:580:9: Empty statement.
        

        We can clean that up by changing to:

                  // If the rename already finished, do nothing.
                  if (!errorCode.equals("BlobNotFound")) {
                    throw e;
                  }
        

        I realize there are existing instances of empty statements like this in the NativeAzureFileSystem class, but let's avoid introducing new instances.

        The mvninstall failure appears to be a side effect of something in the bats testing of the bash scripts. It's unrelated to this patch. Since you need to upload one more patch revision to address the Checkstyle warning, let's do one more test run and see if it happens again. If it does, then I'll follow up.

        The license check warning is caused by a test copying a file to a location that it shouldn't, which is then covered by the license check. I'll follow up separately on that.

        Show
        cnauroth Chris Nauroth added a comment - if (errorCode.equals( "BlobNotFound" )) { // The rename already finished, so do nothing. ; } else { throw e; } This part is triggering a Checkstyle warning: ./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java:580:9: Empty statement. We can clean that up by changing to: // If the rename already finished, do nothing. if (!errorCode.equals( "BlobNotFound" )) { throw e; } I realize there are existing instances of empty statements like this in the NativeAzureFileSystem class, but let's avoid introducing new instances. The mvninstall failure appears to be a side effect of something in the bats testing of the bash scripts. It's unrelated to this patch. Since you need to upload one more patch revision to address the Checkstyle warning, let's do one more test run and see if it happens again. If it does, then I'll follow up. The license check warning is caused by a test copying a file to a location that it shouldn't, which is then covered by the license check. I'll follow up separately on that.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 7s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 3m 40s trunk passed
        +1 compile 0m 15s trunk passed with JDK v1.8.0_60
        +1 compile 0m 12s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 8s trunk passed
        +1 mvneclipse 0m 48s trunk passed
        +1 findbugs 0m 32s trunk passed
        +1 javadoc 0m 12s trunk passed with JDK v1.8.0_60
        +1 javadoc 0m 15s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 15s the patch passed
        +1 compile 0m 11s the patch passed with JDK v1.8.0_60
        +1 javac 0m 11s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.7.0_79
        +1 javac 0m 13s the patch passed
        -1 checkstyle 0m 8s Patch generated 2 new checkstyle issues in hadoop-tools/hadoop-azure (total was 26, now 28).
        +1 mvneclipse 0m 11s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 0m 0s The patch has 2 line(s) with tabs.
        +1 findbugs 0m 36s the patch passed
        +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60
        +1 javadoc 0m 13s the patch passed with JDK v1.7.0_79
        +1 unit 1m 0s hadoop-azure in the patch passed with JDK v1.8.0_60.
        +1 unit 1m 13s hadoop-azure in the patch passed with JDK v1.7.0_79.
        -1 asflicense 0m 23s Patch generated 1 ASF License warnings.
        11m 49s



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768084/HADOOP-12484.05.patch
        JIRA Issue HADOOP-12484
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux a75a89e6f000 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh
        git revision trunk / 4c0bae2
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/artifact/patchprocess/whitespace-tabs.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/artifact/patchprocess/patch-asflicense-problems.txt
        Max memory used 229MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 40s trunk passed +1 compile 0m 15s trunk passed with JDK v1.8.0_60 +1 compile 0m 12s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 8s trunk passed +1 mvneclipse 0m 48s trunk passed +1 findbugs 0m 32s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 15s the patch passed +1 compile 0m 11s the patch passed with JDK v1.8.0_60 +1 javac 0m 11s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_79 +1 javac 0m 13s the patch passed -1 checkstyle 0m 8s Patch generated 2 new checkstyle issues in hadoop-tools/hadoop-azure (total was 26, now 28). +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 0s The patch has 2 line(s) with tabs. +1 findbugs 0m 36s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_79 +1 unit 1m 0s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 13s hadoop-azure in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 23s Patch generated 1 ASF License warnings. 11m 49s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768084/HADOOP-12484.05.patch JIRA Issue HADOOP-12484 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux a75a89e6f000 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh git revision trunk / 4c0bae2 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-azure.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/artifact/patchprocess/whitespace-tabs.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/artifact/patchprocess/patch-asflicense-problems.txt Max memory used 229MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7913/console This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        This looks good overall, aside from the remaining whitespace and Checkstyle problems. I'm attaching patch v06, which is the same thing with the whitespace and Checkstyle warnings fixed.

        Show
        cnauroth Chris Nauroth added a comment - This looks good overall, aside from the remaining whitespace and Checkstyle problems. I'm attaching patch v06, which is the same thing with the whitespace and Checkstyle warnings fixed.
        Hide
        gouravk Gaurav Kanade added a comment -

        Thanks a lot Chris. Apologise for the whitespace and checkstyle issues; I was about to put in a new patch myself but since you have already done it I will let Jenkins run again. What are the next steps here after this? Is any further action required from my end?

        Show
        gouravk Gaurav Kanade added a comment - Thanks a lot Chris. Apologise for the whitespace and checkstyle issues; I was about to put in a new patch myself but since you have already done it I will let Jenkins run again. What are the next steps here after this? Is any further action required from my end?
        Hide
        cnauroth Chris Nauroth added a comment -

        Gaurav Kanade, thank you. There is no further action required right now. We'll just wait for Jenkins.

        Show
        cnauroth Chris Nauroth added a comment - Gaurav Kanade , thank you. There is no further action required right now. We'll just wait for Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 3m 25s trunk passed
        +1 compile 0m 15s trunk passed with JDK v1.8.0_60
        +1 compile 0m 14s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 10s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 33s trunk passed
        +1 javadoc 0m 14s trunk passed with JDK v1.8.0_60
        +1 javadoc 0m 15s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 14s the patch passed with JDK v1.8.0_60
        +1 javac 0m 14s the patch passed
        +1 compile 0m 15s the patch passed with JDK v1.7.0_79
        +1 javac 0m 15s the patch passed
        +1 checkstyle 0m 9s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 43s the patch passed
        +1 javadoc 0m 13s the patch passed with JDK v1.8.0_60
        +1 javadoc 0m 15s the patch passed with JDK v1.7.0_79
        +1 unit 1m 11s hadoop-azure in the patch passed with JDK v1.8.0_60.
        +1 unit 1m 21s hadoop-azure in the patch passed with JDK v1.7.0_79.
        -1 asflicense 0m 25s Patch generated 1 ASF License warnings.
        11m 49s



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768120/HADOOP-12484.06.patch
        JIRA Issue HADOOP-12484
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 7ed03ddc2a6d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh
        git revision trunk / 0fce5f9
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7914/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7914/artifact/patchprocess/patch-asflicense-problems.txt
        Max memory used 227MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7914/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 25s trunk passed +1 compile 0m 15s trunk passed with JDK v1.8.0_60 +1 compile 0m 14s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 10s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 33s trunk passed +1 javadoc 0m 14s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 17s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_60 +1 javac 0m 14s the patch passed +1 compile 0m 15s the patch passed with JDK v1.7.0_79 +1 javac 0m 15s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 43s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_79 +1 unit 1m 11s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 1m 21s hadoop-azure in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 25s Patch generated 1 ASF License warnings. 11m 49s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768120/HADOOP-12484.06.patch JIRA Issue HADOOP-12484 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 7ed03ddc2a6d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh git revision trunk / 0fce5f9 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7914/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7914/artifact/patchprocess/patch-asflicense-problems.txt Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7914/console This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for patch v06 now that the style problems have been fixed. I have committed this to trunk and branch-2. Gaurav Kanade, thank you for contributing the patch.

        Show
        cnauroth Chris Nauroth added a comment - +1 for patch v06 now that the style problems have been fixed. I have committed this to trunk and branch-2. Gaurav Kanade , thank you for contributing the patch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8692 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8692/)
        HADOOP-12484. Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534)

        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8692 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8692/ ) HADOOP-12484 . Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #571 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/571/)
        HADOOP-12484. Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #571 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/571/ ) HADOOP-12484 . Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1307 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1307/)
        HADOOP-12484. Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1307 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1307/ ) HADOOP-12484 . Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2517/)
        HADOOP-12484. Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534)

        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2517/ ) HADOOP-12484 . Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #586 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/586/)
        HADOOP-12484. Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #586 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/586/ ) HADOOP-12484 . Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2465 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2465/)
        HADOOP-12484. Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2465 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2465/ ) HADOOP-12484 . Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #528 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/528/)
        HADOOP-12484. Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534)

        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #528 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/528/ ) HADOOP-12484 . Single File Rename Throws Incorrectly In Potential Race (cnauroth: rev cb282d5b89fdece4719cc4ad37a6e27f13371534) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            gouravk Gaurav Kanade
            Reporter:
            gouravk Gaurav Kanade
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development