Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12483

Maintain wrapped SASL ordering for postponed IPC responses

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      A SASL encryption algorithm (wrapping) may have a required ordering for encrypted responses. The IPC layer encrypts when the response is set based on the assumption it is being immediately sent. Postponed responses violate that assumption.

        Issue Links

          Activity

          Hide
          daryn Daryn Sharp added a comment -

          Maintain order by wrapping calls when added to the connection's response queue.

          Show
          daryn Daryn Sharp added a comment - Maintain order by wrapping calls when added to the connection's response queue.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 38s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 10m 1s There were no new javac warning messages.
          +1 javadoc 10m 23s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 44s The applied patch generated 1 new checkstyle issues (total was 214, now 214).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 8m 42s Tests passed in hadoop-common.
              55m 54s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766852/HADOOP-12483.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / cf23f2c
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/artifact/patchprocess/diffcheckstylehadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 10m 1s There were no new javac warning messages. +1 javadoc 10m 23s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 44s The applied patch generated 1 new checkstyle issues (total was 214, now 214). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 8m 42s Tests passed in hadoop-common.     55m 54s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766852/HADOOP-12483.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cf23f2c checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7835/console This message was automatically generated.
          Hide
          daryn Daryn Sharp added a comment -

          Yi Liu, can you please take a look since you reviewed the original? The style stuff is about file too long and a whitespace on a line I didn't touch (getting pretty annoyed by it).

          Show
          daryn Daryn Sharp added a comment - Yi Liu , can you please take a look since you reviewed the original? The style stuff is about file too long and a whitespace on a line I didn't touch (getting pretty annoyed by it).
          Hide
          hitliuyi Yi Liu added a comment -

          +1, looks good to me. Thanks Daryn Sharp, will commit shortly.

          Show
          hitliuyi Yi Liu added a comment - +1, looks good to me. Thanks Daryn Sharp , will commit shortly.
          Hide
          hitliuyi Yi Liu added a comment -

          Committed to trunk and branch-2.

          Show
          hitliuyi Yi Liu added a comment - Committed to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8659 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8659/)
          HADOOP-12483. Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8659 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8659/ ) HADOOP-12483 . Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #563 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/563/)
          HADOOP-12483. Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #563 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/563/ ) HADOOP-12483 . Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #548 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/548/)
          HADOOP-12483. Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #548 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/548/ ) HADOOP-12483 . Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1285 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1285/)
          HADOOP-12483. Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1285 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1285/ ) HADOOP-12483 . Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2497 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2497/)
          HADOOP-12483. Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2497 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2497/ ) HADOOP-12483 . Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2448 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2448/)
          HADOOP-12483. Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2448 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2448/ ) HADOOP-12483 . Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #511 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/511/)
          HADOOP-12483. Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #511 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/511/ ) HADOOP-12483 . Maintain wrapped SASL ordering for postponed IPC (yliu: rev 476a251e5efe5e5850671f924e622b587c262653) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          zhz Zhe Zhang added a comment -

          I backported this bug fix to branch-2.7 since I just backported HADOOP-10300.

          Show
          zhz Zhe Zhang added a comment - I backported this bug fix to branch-2.7 since I just backported HADOOP-10300 .

            People

            • Assignee:
              daryn Daryn Sharp
              Reporter:
              daryn Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development