Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      updateJmxCache() was updated in HADOOP-11301. However the patch introduced a race condition. In updateJmxCache() function in MetricsSourceAdapter.java:

        private void updateJmxCache() {
          boolean getAllMetrics = false;
          synchronized (this) {
            if (Time.now() - jmxCacheTS >= jmxCacheTTL) {
              // temporarilly advance the expiry while updating the cache
              jmxCacheTS = Time.now() + jmxCacheTTL;
              if (lastRecs == null) {
                getAllMetrics = true;
              }
            } else {
              return;
            }
      
            if (getAllMetrics) {
              MetricsCollectorImpl builder = new MetricsCollectorImpl();
              getMetrics(builder, true);
            }
      
            updateAttrCache();
            if (getAllMetrics) {
              updateInfoCache();
            }
            jmxCacheTS = Time.now();
            lastRecs = null; // in case regular interval update is not running
          }
        }
      

      Notice that getAllMetrics is set to true when:

      1. jmxCacheTTL has passed
      2. lastRecs == null

      lastRecs is set to null in the same function, but gets reassigned by getMetrics().

      However getMetrics() can be called from a different thread:

      1. MetricsSystemImpl.onTimerEvent()
      2. MetricsSystemImpl.publishMetricsNow()

      Consider the following sequence:

      1. updateJmxCache() is called by getMBeanInfo() from a thread getting cached info.
        • lastRecs is set to null.
      2. metrics sources is updated with new value/field.
      3. getMetrics() is called by publishMetricsNow() or onTimerEvent() from a different thread getting the latest metrics.
        • lastRecs is updated (!= null).
      4. jmxCacheTTL passed.
      5. updateJmxCache() is called again via getMBeanInfo().
        • However because lastRecs is already updated (!= null), getAllMetrics will not be set to true. So updateInfoCache() is not called and getMBeanInfo() returns the old cached info.

      We ran into this issue on a cluster where a new metric did not get published until much later.

      The case can be made worse by a periodic call to getMetrics() (driven by an external program or script). In such case getMBeanInfo() may never be able to retrieve the new record.

      The desired behavior should be that updateJmxCache() will guarantee to call updateInfoCache() once after jmxCacheTTL, if lastRecs has been set to null by updateJmxCache() itself.

      1. HADOOP-12482.001.patch
        6 kB
        Tony Wu
      2. HADOOP-12482.002.patch
        6 kB
        Tony Wu
      3. HADOOP-12482.003.patch
        6 kB
        Tony Wu
      4. HADOOP-12482.004.patch
        10 kB
        Tony Wu
      5. HADOOP-12482.005.patch
        10 kB
        Tony Wu
      6. HADOOP-12482.006.patch
        10 kB
        Tony Wu

        Activity

        Hide
        twu Tony Wu added a comment -

        In this patch:

        • Addressed the problem by adding a new variable to track lastRecs has been cleared by updateJmxCache().
        • Change updateJmxCache() to use the new variable to track when to refresh the info cache.
        • Add a test to simulate multiple thread accessing/updating the cache and make sure:
          • The new test does capture the original problem.
          • The hew test verifies the problem is fixed.

        Also run a few additional tests and make sure they pass:

        • org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
        • org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainerMetrics
        Show
        twu Tony Wu added a comment - In this patch: Addressed the problem by adding a new variable to track lastRecs has been cleared by updateJmxCache(). Change updateJmxCache() to use the new variable to track when to refresh the info cache. Add a test to simulate multiple thread accessing/updating the cache and make sure: The new test does capture the original problem. The hew test verifies the problem is fixed. Also run a few additional tests and make sure they pass: org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainerMetrics
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 7s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 19s trunk passed
        +1 compile 4m 52s trunk passed with JDK v1.8.0_60
        +1 compile 4m 46s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 17s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 50s trunk passed
        +1 javadoc 0m 58s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 10s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 30s the patch passed
        +1 compile 4m 49s the patch passed with JDK v1.8.0_60
        +1 javac 4m 49s the patch passed
        +1 compile 4m 52s the patch passed with JDK v1.7.0_79
        +1 javac 4m 52s the patch passed
        +1 checkstyle 0m 16s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 8s the patch passed
        +1 javadoc 1m 6s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 19s the patch passed with JDK v1.7.0_79
        -1 unit 8m 2s hadoop-common in the patch failed with JDK v1.8.0_60.
        -1 unit 7m 39s hadoop-common in the patch failed with JDK v1.7.0_79.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        51m 11s



        Reason Tests
        JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
          hadoop.fs.shell.TestCopyPreserveFlag
          hadoop.security.ssl.TestReloadingX509TrustManager
          hadoop.metrics2.impl.TestGangliaMetrics



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-23
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12766823/HADOOP-12482.001.patch
        JIRA Issue HADOOP-12482
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 815b6bc23c30 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh
        git revision trunk / 15eb84b
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/testReport/
        Max memory used 225MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 19s trunk passed +1 compile 4m 52s trunk passed with JDK v1.8.0_60 +1 compile 4m 46s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 17s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 50s trunk passed +1 javadoc 0m 58s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 10s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 30s the patch passed +1 compile 4m 49s the patch passed with JDK v1.8.0_60 +1 javac 4m 49s the patch passed +1 compile 4m 52s the patch passed with JDK v1.7.0_79 +1 javac 4m 52s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_79 -1 unit 8m 2s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 7m 39s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 51m 11s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.fs.shell.TestCopyPreserveFlag   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12766823/HADOOP-12482.001.patch JIRA Issue HADOOP-12482 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 815b6bc23c30 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh git revision trunk / 15eb84b Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/testReport/ Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7921/console This message was automatically generated.
        Hide
        twu Tony Wu added a comment -

        Manually ran the failed unit tests on OS X using JDK 1.7 and they all pass without error.

        Show
        twu Tony Wu added a comment - Manually ran the failed unit tests on OS X using JDK 1.7 and they all pass without error.
        Hide
        twu Tony Wu added a comment -

        Manually ran the failed tests on Linux using JDK 1.7, all tests pass without error.

        Show
        twu Tony Wu added a comment - Manually ran the failed tests on Linux using JDK 1.7, all tests pass without error.
        Hide
        twu Tony Wu added a comment -

        In v2 patch:

        • Rebased to latest trunk.

        Manually verified the reported failed test cases again (on Linux and with native option) and they pass without error:

        $ mvn -Dtest=TestMetricsSourceAdapter,TestDecayRpcScheduler,TestCopyPreserveFlag,TestReloadingX509TrustManager,TestGangliaMetrics test -Pnative
        ...
        -------------------------------------------------------
         T E S T S
        -------------------------------------------------------
        Running org.apache.hadoop.fs.shell.TestCopyPreserveFlag
        Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.77 sec - in org.apache.hadoop.fs.shell.TestCopyPreserveFlag
        Running org.apache.hadoop.metrics2.impl.TestGangliaMetrics
        Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.504 sec - in org.apache.hadoop.metrics2.impl.TestGangliaMetrics
        Running org.apache.hadoop.metrics2.impl.TestMetricsSourceAdapter
        Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.447 sec - in org.apache.hadoop.metrics2.impl.TestMetricsSourceAdapter
        Running org.apache.hadoop.ipc.TestDecayRpcScheduler
        Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.98 sec - in org.apache.hadoop.ipc.TestDecayRpcScheduler
        Running org.apache.hadoop.security.ssl.TestReloadingX509TrustManager
        Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.538 sec - in org.apache.hadoop.security.ssl.TestReloadingX509TrustManager
        
        Results :
        
        Tests run: 27, Failures: 0, Errors: 0, Skipped: 0
        
        Show
        twu Tony Wu added a comment - In v2 patch: Rebased to latest trunk. Manually verified the reported failed test cases again (on Linux and with native option) and they pass without error: $ mvn -Dtest=TestMetricsSourceAdapter,TestDecayRpcScheduler,TestCopyPreserveFlag,TestReloadingX509TrustManager,TestGangliaMetrics test -Pnative ... ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.fs.shell.TestCopyPreserveFlag Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.77 sec - in org.apache.hadoop.fs.shell.TestCopyPreserveFlag Running org.apache.hadoop.metrics2.impl.TestGangliaMetrics Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.504 sec - in org.apache.hadoop.metrics2.impl.TestGangliaMetrics Running org.apache.hadoop.metrics2.impl.TestMetricsSourceAdapter Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.447 sec - in org.apache.hadoop.metrics2.impl.TestMetricsSourceAdapter Running org.apache.hadoop.ipc.TestDecayRpcScheduler Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.98 sec - in org.apache.hadoop.ipc.TestDecayRpcScheduler Running org.apache.hadoop.security.ssl.TestReloadingX509TrustManager Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.538 sec - in org.apache.hadoop.security.ssl.TestReloadingX509TrustManager Results : Tests run: 27, Failures: 0, Errors: 0, Skipped: 0
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 8s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 58s trunk passed
        +1 compile 5m 30s trunk passed with JDK v1.8.0_60
        +1 compile 5m 1s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 19s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 59s trunk passed
        +1 javadoc 1m 15s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 17s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 49s the patch passed
        +1 compile 5m 36s the patch passed with JDK v1.8.0_60
        +1 javac 5m 36s the patch passed
        +1 compile 5m 19s the patch passed with JDK v1.7.0_79
        +1 javac 5m 19s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 16s the patch passed
        +1 javadoc 1m 12s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 21s the patch passed with JDK v1.7.0_79
        -1 unit 9m 1s hadoop-common in the patch failed with JDK v1.8.0_60.
        -1 unit 8m 47s hadoop-common in the patch failed with JDK v1.7.0_79.
        -1 asflicense 0m 19s Patch generated 1 ASF License warnings.
        57m 13s



        Reason Tests
        JDK v1.7.0_79 Failed junit tests hadoop.test.TestTimedOutTestsListener
          hadoop.fs.shell.find.TestFind
          hadoop.test.TestTimedOutTestsListener



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-29
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769580/HADOOP-12482.002.patch
        JIRA Issue HADOOP-12482
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux a55b6186f10d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-c3a2069/precommit/personality/hadoop.sh
        git revision trunk / ecad125
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 225MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 58s trunk passed +1 compile 5m 30s trunk passed with JDK v1.8.0_60 +1 compile 5m 1s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 19s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 15s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 17s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 49s the patch passed +1 compile 5m 36s the patch passed with JDK v1.8.0_60 +1 javac 5m 36s the patch passed +1 compile 5m 19s the patch passed with JDK v1.7.0_79 +1 javac 5m 19s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 16s the patch passed +1 javadoc 1m 12s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 21s the patch passed with JDK v1.7.0_79 -1 unit 9m 1s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 8m 47s hadoop-common in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 19s Patch generated 1 ASF License warnings. 57m 13s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.test.TestTimedOutTestsListener   hadoop.fs.shell.find.TestFind   hadoop.test.TestTimedOutTestsListener Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-29 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769580/HADOOP-12482.002.patch JIRA Issue HADOOP-12482 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux a55b6186f10d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-c3a2069/precommit/personality/hadoop.sh git revision trunk / ecad125 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7971/console This message was automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Tony Wu Thank you for taking this issue. LGTM overall. Minor nits: could you rename lasRecsCleared to lastRecsCleared?(t is missing)

        +  private boolean lasRecsCleared;
        
        Show
        ozawa Tsuyoshi Ozawa added a comment - Tony Wu Thank you for taking this issue. LGTM overall. Minor nits: could you rename lasRecsCleared to lastRecsCleared ?(t is missing) + private boolean lasRecsCleared;
        Hide
        twu Tony Wu added a comment -

        Oops. I will correct it and post a new patch. Thanks a lot for looking at the patch!

        Show
        twu Tony Wu added a comment - Oops. I will correct it and post a new patch. Thanks a lot for looking at the patch!
        Hide
        twu Tony Wu added a comment -

        In v3 patch:

        • Address review comments by fixing a typo.
        Show
        twu Tony Wu added a comment - In v3 patch: Address review comments by fixing a typo.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 7s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 35s trunk passed
        +1 compile 4m 24s trunk passed with JDK v1.8.0_60
        +1 compile 4m 8s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 14s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 37s trunk passed
        +1 javadoc 0m 55s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 2s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 23s the patch passed
        +1 compile 4m 18s the patch passed with JDK v1.8.0_60
        +1 javac 4m 18s the patch passed
        +1 compile 4m 7s the patch passed with JDK v1.7.0_79
        +1 javac 4m 7s the patch passed
        +1 checkstyle 0m 14s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 0m 52s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 0s the patch passed with JDK v1.7.0_79
        +1 unit 6m 37s hadoop-common in the patch passed with JDK v1.8.0_60.
        -1 unit 6m 31s hadoop-common in the patch failed with JDK v1.7.0_79.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        44m 39s



        Reason Tests
        JDK v1.7.0_79 Failed junit tests hadoop.security.TestShellBasedIdMapping



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769820/HADOOP-12482.003.patch
        JIRA Issue HADOOP-12482
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 8d99547a218b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
        git revision trunk / 45d3967
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7980/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7980/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7980/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 227MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7980/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 35s trunk passed +1 compile 4m 24s trunk passed with JDK v1.8.0_60 +1 compile 4m 8s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 14s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 23s the patch passed +1 compile 4m 18s the patch passed with JDK v1.8.0_60 +1 javac 4m 18s the patch passed +1 compile 4m 7s the patch passed with JDK v1.7.0_79 +1 javac 4m 7s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 0s the patch passed with JDK v1.7.0_79 +1 unit 6m 37s hadoop-common in the patch passed with JDK v1.8.0_60. -1 unit 6m 31s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 44m 39s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.security.TestShellBasedIdMapping Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769820/HADOOP-12482.003.patch JIRA Issue HADOOP-12482 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 8d99547a218b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / 45d3967 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7980/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7980/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7980/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7980/console This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks a lot for working on this, Tony Wu. A few comments

        private static class readThread
        

        class name should be CamelCase.

        class TsSource implements MetricsSource
        

        Can it be private static class, it is better to be named as MatricsSource or similar.

         for (MBeanAttributeInfo mBeanAttributeInfo : info.getAttributes()) {
             found = mBeanAttributeInfo.getName().equals(key);
        }
        assertTrue("Key " + key + " not found", found);
        

        It is not clear to me that, 1) are you suggesting they are all true, or at least one of them are true ? 2) is there only one mBeamAttributeInfo?

        Instead of sleeping in RepeatingTesetThread, can we use ScheduledExecutorService#scheduleAtFixedRate?

        Finally, it might be nice to have some documents in TestMetricsSourceAdapter to describe how the Race condition might happen.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks a lot for working on this, Tony Wu . A few comments private static class readThread class name should be CamelCase . class TsSource implements MetricsSource Can it be private static class , it is better to be named as MatricsSource or similar. for (MBeanAttributeInfo mBeanAttributeInfo : info.getAttributes()) { found = mBeanAttributeInfo.getName().equals(key); } assertTrue( "Key " + key + " not found" , found); It is not clear to me that, 1) are you suggesting they are all true , or at least one of them are true ? 2) is there only one mBeamAttributeInfo ? Instead of sleeping in RepeatingTesetThread , can we use ScheduledExecutorService#scheduleAtFixedRate ? Finally, it might be nice to have some documents in TestMetricsSourceAdapter to describe how the Race condition might happen.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Good catch. updateThread should be also UpdateThread(using CamelCase).

        Show
        ozawa Tsuyoshi Ozawa added a comment - Good catch. updateThread should be also UpdateThread(using CamelCase).
        Hide
        twu Tony Wu added a comment -

        Thanks Lei (Eddy) Xu for reviewing my patch. Please take a look at the update patch and kindly let me know if you have any further comments.

        Show
        twu Tony Wu added a comment - Thanks Lei (Eddy) Xu for reviewing my patch. Please take a look at the update patch and kindly let me know if you have any further comments.
        Hide
        twu Tony Wu added a comment -

        In v4 patch:

        • Addressed Tsuyoshi Ozawa and Lei (Eddy) Xu's review comments.
        • Reworked the test to make use of ScheduledExecutorService #scheduleAtFixedRate.
        Show
        twu Tony Wu added a comment - In v4 patch: Addressed Tsuyoshi Ozawa and Lei (Eddy) Xu 's review comments. Reworked the test to make use of ScheduledExecutorService #scheduleAtFixedRate .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 14s trunk passed
        +1 compile 4m 28s trunk passed with JDK v1.8.0_60
        +1 compile 4m 24s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 14s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 37s trunk passed
        +1 javadoc 0m 59s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 3s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 28s the patch passed
        +1 compile 4m 17s the patch passed with JDK v1.8.0_60
        +1 javac 4m 17s the patch passed
        +1 compile 4m 10s the patch passed with JDK v1.7.0_79
        +1 javac 4m 10s the patch passed
        +1 checkstyle 0m 16s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 46s the patch passed
        +1 javadoc 0m 51s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 0s the patch passed with JDK v1.7.0_79
        -1 unit 6m 28s hadoop-common in the patch failed with JDK v1.8.0_60.
        +1 unit 7m 18s hadoop-common in the patch passed with JDK v1.7.0_79.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        45m 32s



        Reason Tests
        JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-02
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770181/HADOOP-12482.004.patch
        JIRA Issue HADOOP-12482
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux cbdd175c7cdc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh
        git revision trunk / 78d6890
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8001/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8001/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8001/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 223MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8001/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 14s trunk passed +1 compile 4m 28s trunk passed with JDK v1.8.0_60 +1 compile 4m 24s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 14s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 59s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 28s the patch passed +1 compile 4m 17s the patch passed with JDK v1.8.0_60 +1 javac 4m 17s the patch passed +1 compile 4m 10s the patch passed with JDK v1.7.0_79 +1 javac 4m 10s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 0s the patch passed with JDK v1.7.0_79 -1 unit 6m 28s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 7m 18s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 45m 32s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-02 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770181/HADOOP-12482.004.patch JIRA Issue HADOOP-12482 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux cbdd175c7cdc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh git revision trunk / 78d6890 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8001/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8001/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8001/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 223MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8001/console This message was automatically generated.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3. Please revert back if you disagree.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3. Please revert back if you disagree.
        Hide
        twu Tony Wu added a comment -

        The failed test hadoop.ipc.TestDecayRpcScheduler is not relevant to the change.

        Show
        twu Tony Wu added a comment - The failed test hadoop.ipc.TestDecayRpcScheduler is not relevant to the change.
        Hide
        twu Tony Wu added a comment -

        Hi Tsuyoshi Ozawa & Lei (Eddy) Xu,

        Please kindly take a look at the latest patch (v4) and let me know if you have any comments.

        Thanks,
        Tony

        Show
        twu Tony Wu added a comment - Hi Tsuyoshi Ozawa & Lei (Eddy) Xu , Please kindly take a look at the latest patch (v4) and let me know if you have any comments. Thanks, Tony
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Hi, Tony Wu

        Thanks for the update, a few final comments:

        • Please replace e.printStackTrace(); with LOG.error().
        • Please change class TsSource name as I suggested above.

        The rest LGTM. pending +1 once the above comments being addressed.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Hi, Tony Wu Thanks for the update, a few final comments: Please replace e.printStackTrace(); with LOG.error() . Please change class TsSource name as I suggested above. The rest LGTM. pending +1 once the above comments being addressed.
        Hide
        twu Tony Wu added a comment -

        In v5 patch:

        • Addressed Lei (Eddy) Xu's review comments: rename TsSource and use LOG.error for printing exception.
        Show
        twu Tony Wu added a comment - In v5 patch: Addressed Lei (Eddy) Xu 's review comments: rename TsSource and use LOG.error for printing exception.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 6s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 9s trunk passed
        +1 compile 4m 44s trunk passed with JDK v1.8.0_60
        +1 compile 4m 31s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 16s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 51s trunk passed
        +1 javadoc 1m 2s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 10s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 31s the patch passed
        +1 compile 5m 0s the patch passed with JDK v1.8.0_60
        +1 javac 5m 0s the patch passed
        +1 compile 4m 46s the patch passed with JDK v1.7.0_79
        +1 javac 4m 46s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 3s the patch passed
        +1 javadoc 1m 1s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 12s the patch passed with JDK v1.7.0_79
        -1 unit 7m 17s hadoop-common in the patch failed with JDK v1.8.0_60.
        +1 unit 7m 51s hadoop-common in the patch passed with JDK v1.7.0_79.
        +1 asflicense 0m 26s Patch does not generate ASF License warnings.
        49m 46s



        Reason Tests
        JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
          hadoop.security.ssl.TestReloadingX509TrustManager



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-10
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771473/HADOOP-12482.005.patch
        JIRA Issue HADOOP-12482
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux b934b603cc7f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
        git revision trunk / 94a1833
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8058/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8058/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8058/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 225MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8058/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 9s trunk passed +1 compile 4m 44s trunk passed with JDK v1.8.0_60 +1 compile 4m 31s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 16s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 1m 2s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 10s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 31s the patch passed +1 compile 5m 0s the patch passed with JDK v1.8.0_60 +1 javac 5m 0s the patch passed +1 compile 4m 46s the patch passed with JDK v1.7.0_79 +1 javac 4m 46s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 3s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 12s the patch passed with JDK v1.7.0_79 -1 unit 7m 17s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 7m 51s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 49m 46s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-10 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771473/HADOOP-12482.005.patch JIRA Issue HADOOP-12482 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux b934b603cc7f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / 94a1833 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8058/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8058/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8058/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8058/console This message was automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Tony Wu thank you for updating. The patch looks to be almost there:

        • SourceUpdater still have e.printStackTrace()

          + e.printStackTrace();

        Show
        ozawa Tsuyoshi Ozawa added a comment - Tony Wu thank you for updating. The patch looks to be almost there: SourceUpdater still have e.printStackTrace() + e.printStackTrace();
        Hide
        twu Tony Wu added a comment -

        In v6 patch:

        • Fix a missed printStackTrace() in previous patch and convert it to LOG.error().
        Show
        twu Tony Wu added a comment - In v6 patch: Fix a missed printStackTrace() in previous patch and convert it to LOG.error() .
        Hide
        twu Tony Wu added a comment -

        Thanks a lot to Tsuyoshi Ozawa for your thorough review. Please kindly take a look at the new patch.

        Show
        twu Tony Wu added a comment - Thanks a lot to Tsuyoshi Ozawa for your thorough review. Please kindly take a look at the new patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 6s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 12s trunk passed
        +1 compile 4m 49s trunk passed with JDK v1.8.0_60
        +1 compile 4m 36s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 15s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 48s trunk passed
        +1 javadoc 1m 1s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 9s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 32s the patch passed
        +1 compile 4m 49s the patch passed with JDK v1.8.0_60
        +1 javac 4m 49s the patch passed
        +1 compile 4m 37s the patch passed with JDK v1.7.0_79
        +1 javac 4m 37s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 0s the patch passed
        +1 javadoc 0m 57s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 9s the patch passed with JDK v1.7.0_79
        -1 unit 7m 11s hadoop-common in the patch failed with JDK v1.8.0_60.
        +1 unit 7m 46s hadoop-common in the patch passed with JDK v1.7.0_79.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        49m 10s



        Reason Tests
        JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-10
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771489/HADOOP-12482.006.patch
        JIRA Issue HADOOP-12482
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 1ae7148e1f43 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
        git revision trunk / 94a1833
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8059/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8059/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8059/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 228MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8059/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 12s trunk passed +1 compile 4m 49s trunk passed with JDK v1.8.0_60 +1 compile 4m 36s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 15s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 1m 1s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 9s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 32s the patch passed +1 compile 4m 49s the patch passed with JDK v1.8.0_60 +1 javac 4m 49s the patch passed +1 compile 4m 37s the patch passed with JDK v1.7.0_79 +1 javac 4m 37s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 0s the patch passed +1 javadoc 0m 57s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_79 -1 unit 7m 11s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 7m 46s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 49m 10s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.ipc.TestDecayRpcScheduler Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-10 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771489/HADOOP-12482.006.patch JIRA Issue HADOOP-12482 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 1ae7148e1f43 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / 94a1833 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8059/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8059/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8059/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8059/console This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Nice work, Tony Wu.

        The failure is not relevant to this patch. +1 and committed.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Nice work, Tony Wu . The failure is not relevant to this patch. +1 and committed.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8784 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8784/)
        HADOOP-12482. Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8784 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8784/ ) HADOOP-12482 . Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #650 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/650/)
        HADOOP-12482. Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #650 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/650/ ) HADOOP-12482 . Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1385 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1385/)
        HADOOP-12482. Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1385 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1385/ ) HADOOP-12482 . Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2590 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2590/)
        HADOOP-12482. Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2590 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2590/ ) HADOOP-12482 . Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #661 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/661/)
        HADOOP-12482. Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #661 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/661/ ) HADOOP-12482 . Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2530 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2530/)
        HADOOP-12482. Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2530 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2530/ ) HADOOP-12482 . Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #591 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/591/)
        HADOOP-12482. Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #591 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/591/ ) HADOOP-12482 . Race condition in JMX cache update. (Tony Wu via lei) (lei: rev 0eb9c60c5bec79f531da8cb3226d7e8b1d7e6639) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSourceAdapter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSourceAdapter.java
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Cherrypicked this to branch-2.7 with HADOOP-12348 and HADOOP-11361.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Cherrypicked this to branch-2.7 with HADOOP-12348 and HADOOP-11361 .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8804 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8804/)
        Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8804 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8804/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2608/)
        Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2608/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #679 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/679/)
        Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #679 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/679/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1403 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1403/)
        Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1403 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1403/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #667 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/667/)
        Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #667 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/667/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Tsuyoshi Ozawa, thank you for backporting these to branch-2.7 but CHANGES.txt looks to be rebased incorrectly. Would you fix it?

        Show
        ajisakaa Akira Ajisaka added a comment - Tsuyoshi Ozawa , thank you for backporting these to branch-2.7 but CHANGES.txt looks to be rebased incorrectly. Would you fix it?
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #606 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/606/)
        Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #606 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/606/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2543 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2543/)
        Move HADOOP-11361, HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2543 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2543/ ) Move HADOOP-11361 , HADOOP-12348 and HADOOP-12482 from 2.8.0 to 2.7.3 in (ozawa: rev c753617a48bffed491b9ca7a5ca6b3d2df5721bf) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Fixed.

        Show
        ajisakaa Akira Ajisaka added a comment - Fixed.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Oops, it's my mistake. Thank you for fixing it, Akira.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Oops, it's my mistake. Thank you for fixing it, Akira.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
        Hide
        sjlee0 Sangjin Lee added a comment -

        Cherry-picked it to 2.6.5 (trivial).

        Show
        sjlee0 Sangjin Lee added a comment - Cherry-picked it to 2.6.5 (trivial).

          People

          • Assignee:
            twu Tony Wu
            Reporter:
            twu Tony Wu
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development