[HADOOP-12472] Make GenericTestUtils.assertExceptionContains robust

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.8.0, 3.0.0-alpha1, 2.7.6
• Component/s: test
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 10/Oct/15 12:10
• Updated: 07/Mar/18 02:43
• Resolved: 26/Oct/15 21:05

Description

GenericTestUtils.assertExceptionContains calls Exception.getMessage(), followed by msg.contains().

This will NPE for an exception with a null message, such as NPE.

1. it should call toString()
2. and do an assertNotNull on the result in case some subclass does something very bad
3. and for safety, check the asser

Issue Links

• is depended upon by: HADOOP-13105 Support timeouts in LDAP queries in LdapGroupsMapping.
• relates to: HADOOP-12514 Make static fields in GenericTestUtils for assertExceptionContains() package-private and final