Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12468

Partial group resolution failure should not result in user lockout

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Environment:

      Linux

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      If a Hadoop cluster is configured to use ShellBasedUnixGroupsMapping for user/group name mapping, occasionally some group names may become unresolvable (for example, using SSSD).

      ShellBasedUnixGroupsMapping uses shell command "id -Gn" to retrieve the group name of a user; however, the existing logic assumes that if the exit code of the command is non-zero, the user has no group name at all. The shell command in Linux returns non-zero exit code if a group name is not resolvable. Unfortunately, it is possible that a user belongs to multiple groups, and any partial failure in group name resolution would denied the user's access.

      On the other hand, the JNI implementation (JniBasedUnixGroupsMapping) is more resilient. If any group name is unresolvable, it is simply ignored, and whatever are resolvable are returned.

      It is arguable that if the group name is not resolvable, the administrator should configure their directory/authentication service correctly, and Hadoop is in no position to handle it, but since the existing unit tests assume the output of JNI-based and shell-based implementation are the same, we should improve the shell-based group name resolution, and make it as resilient as the JNI-based one.

      1. HADOOP-12468.010.patch
        18 kB
        Wei-Chiu Chuang
      2. HADOOP-12468.009.patch
        18 kB
        Wei-Chiu Chuang
      3. HADOOP-12468.008.patch
        18 kB
        Wei-Chiu Chuang
      4. HADOOP-12468.007.patch
        17 kB
        Wei-Chiu Chuang
      5. HADOOP-12468.006.patch
        17 kB
        Wei-Chiu Chuang
      6. HADOOP-12468.005.patch
        17 kB
        Wei-Chiu Chuang
      7. HADOOP-12468.004.patch
        17 kB
        Wei-Chiu Chuang
      8. HADOOP-12468.003.patch
        10 kB
        Wei-Chiu Chuang
      9. HADOOP-12468.002.patch
        9 kB
        Wei-Chiu Chuang
      10. HADOOP-12468.001.patch
        9 kB
        Wei-Chiu Chuang

        Issue Links

          Activity

          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Kihwal Lee. Just cherry-picked to branch-2.8.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Kihwal Lee . Just cherry-picked to branch-2.8.
          Hide
          kihwal Kihwal Lee added a comment -

          Looks like it missed branch-2.8. Please cherry-pick to branch-2.8 as well.

          Show
          kihwal Kihwal Lee added a comment - Looks like it missed branch-2.8. Please cherry-pick to branch-2.8 as well.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #646 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/646/)
          HADOOP-12468. Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #646 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/646/ ) HADOOP-12468 . Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2669 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2669/)
          HADOOP-12468. Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2669 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2669/ ) HADOOP-12468 . Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2582/)
          HADOOP-12468. Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2582/ ) HADOOP-12468 . Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #727 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/727/)
          HADOOP-12468. Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #727 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/727/ ) HADOOP-12468 . Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #737 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/737/)
          HADOOP-12468. Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #737 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/737/ ) HADOOP-12468 . Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8895 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8895/)
          HADOOP-12468. Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8895 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8895/ ) HADOOP-12468 . Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1457 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1457/)
          HADOOP-12468. Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1457 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1457/ ) HADOOP-12468 . Partial group resolution failure should not result in user (yzhang: rev 0348e769abc507c69d644db7bc56d31d971c51d1) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          yzhangal Yongjun Zhang added a comment -

          BTW Wei-Chiu Chuang, would you please put a description in the "Release Notes" section about the group resolution? Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - BTW Wei-Chiu Chuang , would you please put a description in the "Release Notes" section about the group resolution? Thanks.
          Hide
          yzhangal Yongjun Zhang added a comment -

          I committed to trunk and branch-2.

          Thanks Wei-Chiu Chuang for the contribution, Benoy Antony and Harsh J for the review!

          Show
          yzhangal Yongjun Zhang added a comment - I committed to trunk and branch-2. Thanks Wei-Chiu Chuang for the contribution, Benoy Antony and Harsh J for the review!
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Benoy Antony for the further review, and Wei-Chiu for the updated patch. +1 on rev 10. will commit soon.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Benoy Antony for the further review, and Wei-Chiu for the updated patch. +1 on rev 10. will commit soon.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          HDFS-9451 fixed TestFsPermission failure.
          The rest of failures are mostly related to shell, and unrelated to this patch.

          Show
          jojochuang Wei-Chiu Chuang added a comment - HDFS-9451 fixed TestFsPermission failure. The rest of failures are mostly related to shell, and unrelated to this patch.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          The findbug warning is unrelated.

          Show
          jojochuang Wei-Chiu Chuang added a comment - The findbug warning is unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 11m 55s trunk passed
          +1 compile 15m 40s trunk passed with JDK v1.8.0_66
          +1 compile 13m 2s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 29s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          -1 findbugs 2m 39s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 27s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 28s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 2s the patch passed
          +1 compile 17m 45s the patch passed with JDK v1.8.0_66
          +1 javac 17m 45s the patch passed
          +1 compile 14m 15s the patch passed with JDK v1.7.0_85
          +1 javac 14m 15s the patch passed
          +1 checkstyle 0m 26s the patch passed
          +1 mvnsite 1m 39s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 12s the patch passed
          +1 javadoc 1m 34s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 36s the patch passed with JDK v1.7.0_85
          -1 unit 11m 58s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 11m 8s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 33s Patch does not generate ASF License warnings.
          116m 26s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.TestLocalFsFCStatistics
            hadoop.fs.shell.find.TestPrint
            hadoop.test.TestTimedOutTestsListener
            hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestName
            hadoop.fs.shell.find.TestFind
            hadoop.fs.permission.TestFsPermission
            hadoop.ipc.TestRPCWaitForProxy
          JDK v1.7.0_85 Failed junit tests hadoop.fs.shell.find.TestPrint0
            hadoop.fs.permission.TestFsPermission



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774377/HADOOP-12468.010.patch
          JIRA Issue HADOOP-12468
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 487a1518cfb5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 84d01ad
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 11m 55s trunk passed +1 compile 15m 40s trunk passed with JDK v1.8.0_66 +1 compile 13m 2s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 29s trunk passed +1 mvneclipse 0m 18s trunk passed -1 findbugs 2m 39s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 27s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 28s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 2s the patch passed +1 compile 17m 45s the patch passed with JDK v1.8.0_66 +1 javac 17m 45s the patch passed +1 compile 14m 15s the patch passed with JDK v1.7.0_85 +1 javac 14m 15s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 1m 39s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 12s the patch passed +1 javadoc 1m 34s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 36s the patch passed with JDK v1.7.0_85 -1 unit 11m 58s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 11m 8s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 33s Patch does not generate ASF License warnings. 116m 26s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.TestLocalFsFCStatistics   hadoop.fs.shell.find.TestPrint   hadoop.test.TestTimedOutTestsListener   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestName   hadoop.fs.shell.find.TestFind   hadoop.fs.permission.TestFsPermission   hadoop.ipc.TestRPCWaitForProxy JDK v1.7.0_85 Failed junit tests hadoop.fs.shell.find.TestPrint0   hadoop.fs.permission.TestFsPermission Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774377/HADOOP-12468.010.patch JIRA Issue HADOOP-12468 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 487a1518cfb5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 84d01ad findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8155/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          It has happened a few times recently to me. I simply didn't do a good job managing patches. Here's rev10. I'll double check after it is uploaded. Thanks for checking that for me!

          Show
          jojochuang Wei-Chiu Chuang added a comment - It has happened a few times recently to me. I simply didn't do a good job managing patches. Here's rev10. I'll double check after it is uploaded. Thanks for checking that for me!
          Hide
          benoyantony Benoy Antony added a comment -

          Just to let you know , there are a few places which still has username.

          Show
          benoyantony Benoy Antony added a comment - Just to let you know , there are a few places which still has username .
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Test failures are unrelated and are being tracked in HDFS-9451.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Test failures are unrelated and are being tracked in HDFS-9451 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 56s trunk passed
          +1 compile 8m 12s trunk passed with JDK v1.8.0_66
          +1 compile 8m 47s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 17s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          -1 findbugs 1m 50s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 4s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 43s the patch passed
          +1 compile 8m 1s the patch passed with JDK v1.8.0_66
          +1 javac 8m 1s the patch passed
          +1 compile 8m 47s the patch passed with JDK v1.7.0_85
          +1 javac 8m 47s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 57s the patch passed
          +1 javadoc 0m 51s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_85
          -1 unit 6m 46s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 7m 3s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          69m 29s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission
            hadoop.fs.TestLocalFsFCStatistics
          JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774250/HADOOP-12468.009.patch
          JIRA Issue HADOOP-12468
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5707795edc64 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b4c6b51
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 56s trunk passed +1 compile 8m 12s trunk passed with JDK v1.8.0_66 +1 compile 8m 47s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 17s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed -1 findbugs 1m 50s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 55s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 43s the patch passed +1 compile 8m 1s the patch passed with JDK v1.8.0_66 +1 javac 8m 1s the patch passed +1 compile 8m 47s the patch passed with JDK v1.7.0_85 +1 javac 8m 47s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_85 -1 unit 6m 46s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 7m 3s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 69m 29s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.fs.TestLocalFsFCStatistics JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774250/HADOOP-12468.009.patch JIRA Issue HADOOP-12468 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5707795edc64 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b4c6b51 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8152/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 41s trunk passed
          +1 compile 10m 1s trunk passed with JDK v1.8.0_66
          +1 compile 10m 12s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 1m 11s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          -1 findbugs 2m 7s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 11s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 44s the patch passed
          +1 compile 11m 13s the patch passed with JDK v1.8.0_66
          +1 javac 11m 13s the patch passed
          +1 compile 11m 29s the patch passed with JDK v1.7.0_85
          +1 javac 11m 29s the patch passed
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 1m 25s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 27s the patch passed
          +1 javadoc 1m 11s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 20s the patch passed with JDK v1.7.0_85
          -1 unit 8m 23s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 8m 29s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 34s Patch does not generate ASF License warnings.
          85m 16s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.fs.permission.TestFsPermission
            hadoop.ipc.TestCallQueueManager
            hadoop.crypto.key.TestValueQueue
          JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission
            hadoop.metrics2.impl.TestMetricsSystemImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774225/HADOOP-12468.008.patch
          JIRA Issue HADOOP-12468
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2d8f032f6d63 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 23c625e
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 41s trunk passed +1 compile 10m 1s trunk passed with JDK v1.8.0_66 +1 compile 10m 12s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 15s trunk passed -1 findbugs 2m 7s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 11s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 44s the patch passed +1 compile 11m 13s the patch passed with JDK v1.8.0_66 +1 javac 11m 13s the patch passed +1 compile 11m 29s the patch passed with JDK v1.7.0_85 +1 javac 11m 29s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 1m 25s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 1m 11s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 20s the patch passed with JDK v1.7.0_85 -1 unit 8m 23s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 8m 29s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 34s Patch does not generate ASF License warnings. 85m 16s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.fs.permission.TestFsPermission   hadoop.ipc.TestCallQueueManager   hadoop.crypto.key.TestValueQueue JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.metrics2.impl.TestMetricsSystemImpl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774225/HADOOP-12468.008.patch JIRA Issue HADOOP-12468 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2d8f032f6d63 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 23c625e findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8151/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Oops. It's actually Rev09

          Show
          jojochuang Wei-Chiu Chuang added a comment - Oops. It's actually Rev09
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Good catch! Rev10 replaces username with userName.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Good catch! Rev10 replaces username with userName.
          Hide
          benoyantony Benoy Antony added a comment -

          A coding convention related issue:

          username should be camelCased as userName. (like groupName)

          Show
          benoyantony Benoy Antony added a comment - A coding convention related issue: username should be camelCased as userName. (like groupName)
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Wei-Chiu Chuang. +1 on rev 008 pending jenkins.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Wei-Chiu Chuang . +1 on rev 008 pending jenkins.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Failed tests are unrelated to the patch. The findbug warning is a false positive and not related to this patch.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Failed tests are unrelated to the patch. The findbug warning is a false positive and not related to this patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 3s trunk passed
          +1 compile 8m 49s trunk passed with JDK v1.8.0_66
          +1 compile 9m 21s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          -1 findbugs 1m 55s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 0m 59s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 8s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 43s the patch passed
          +1 compile 8m 54s the patch passed with JDK v1.8.0_66
          +1 javac 8m 54s the patch passed
          +1 compile 9m 22s the patch passed with JDK v1.7.0_85
          +1 javac 9m 22s the patch passed
          +1 checkstyle 0m 16s the patch passed
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 3s the patch passed
          +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 8s the patch passed with JDK v1.7.0_85
          -1 unit 8m 4s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 7m 53s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          75m 4s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor
          JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission
            hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773891/HADOOP-12468.008.patch
          JIRA Issue HADOOP-12468
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 421491da9dc9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 298a8cb
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 78MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 3s trunk passed +1 compile 8m 49s trunk passed with JDK v1.8.0_66 +1 compile 9m 21s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 15s trunk passed -1 findbugs 1m 55s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. +1 javadoc 0m 59s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 8s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 43s the patch passed +1 compile 8m 54s the patch passed with JDK v1.8.0_66 +1 javac 8m 54s the patch passed +1 compile 9m 22s the patch passed with JDK v1.7.0_85 +1 javac 9m 22s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 3s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_85 -1 unit 8m 4s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 7m 53s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 75m 4s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.io.compress.TestCompressorDecompressor JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.metrics2.impl.TestGangliaMetrics   hadoop.io.compress.TestCompressorDecompressor JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773891/HADOOP-12468.008.patch JIRA Issue HADOOP-12468 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 421491da9dc9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 298a8cb findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8141/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Yongjun Zhang for another round of review. I am attaching rev08. The code should look better now.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Yongjun Zhang for another round of review. I am attaching rev08. The code should look better now.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi Wei-Chiu Chuang,

          Thanks for the new rev (07), it looks good, some nits, +1 after that:

          • Notation "@Test" needs its own line, and add a empty line before each test method
          • Suggest to change the order of test method and the class definition used by the test method (for each test method), so the test method appears after the definition of the used classes.
          • add one comment for TestGroupNotResolvable, stating that "There is both a group name 9999 and a group ID 9999, this is treated as unresolvable group".
          • add one comment to TestNumericGroupResolvable, stating that "There is a numerical group 23, and there is no group name 23, thus 23 is treated as resolvable group name".

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Hi Wei-Chiu Chuang , Thanks for the new rev (07), it looks good, some nits, +1 after that: Notation "@Test" needs its own line, and add a empty line before each test method Suggest to change the order of test method and the class definition used by the test method (for each test method), so the test method appears after the definition of the used classes. add one comment for TestGroupNotResolvable, stating that "There is both a group name 9999 and a group ID 9999, this is treated as unresolvable group". add one comment to TestNumericGroupResolvable, stating that "There is a numerical group 23, and there is no group name 23, thus 23 is treated as resolvable group name". Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 39s trunk passed
          +1 compile 11m 44s trunk passed with JDK v1.8.0_66
          +1 compile 11m 8s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 1m 16s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 2m 15s trunk passed
          +1 javadoc 1m 9s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 19s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 59s the patch passed
          +1 compile 11m 41s the patch passed with JDK v1.8.0_66
          +1 javac 11m 41s the patch passed
          +1 compile 11m 6s the patch passed with JDK v1.7.0_85
          +1 javac 11m 6s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 29s the patch passed
          +1 javadoc 1m 13s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 19s the patch passed with JDK v1.7.0_85
          -1 unit 8m 47s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 8m 23s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          102m 2s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestIPC
            hadoop.metrics2.impl.TestMetricsSystemImpl
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.test.TestTimedOutTestsListener
          JDK v1.7.0_85 Failed junit tests hadoop.ipc.TestDecayRpcScheduler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773434/HADOOP-12468.007.patch
          JIRA Issue HADOOP-12468
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8418eb5cab37 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4539131
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 39s trunk passed +1 compile 11m 44s trunk passed with JDK v1.8.0_66 +1 compile 11m 8s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 16s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 2m 15s trunk passed +1 javadoc 1m 9s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 19s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 59s the patch passed +1 compile 11m 41s the patch passed with JDK v1.8.0_66 +1 javac 11m 41s the patch passed +1 compile 11m 6s the patch passed with JDK v1.7.0_85 +1 javac 11m 6s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 29s the patch passed +1 javadoc 1m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_85 -1 unit 8m 47s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 8m 23s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 102m 2s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestIPC   hadoop.metrics2.impl.TestMetricsSystemImpl   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.test.TestTimedOutTestsListener JDK v1.7.0_85 Failed junit tests hadoop.ipc.TestDecayRpcScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773434/HADOOP-12468.007.patch JIRA Issue HADOOP-12468 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8418eb5cab37 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4539131 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8114/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks to Yongjun Zhang for the valuable and detailed feedbacks!
          I am attaching rev7, which is based on Yongjun's comments with a few more code style changes.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks to Yongjun Zhang for the valuable and detailed feedbacks! I am attaching rev7, which is based on Yongjun's comments with a few more code style changes.
          Hide
          yzhangal Yongjun Zhang added a comment -

          HI Wei-Chiu Chuang,

          Thanks much for the new rev and sorry for late review. It looks good except I have some cosmetic comments:

          • import statements should be alphabetically ordered
            import org.apache.hadoop.util.Shell.ShellCommandExecutor;
            import org.apache.commons.lang.StringUtils;
            
          • It's better not to add new class member user, instead, use parameter passing for it, like what the current implementation does.
          • Better names for createShellCommandExecutor() / createGroupIDExecutor() are createGroupExecutor() / createGroupIDExecutor()
          • Seems to me that it's better to inline getUnixGroupsWithCommandExecutor() into getUnixGroups so not to have two methods here.
          • Shorten the leading comment in resolvePartialGroupNames to (I think we don't have to
            mention TestJNIGroupsMapping here, you may add comment to this test code if prefer):
            // Exception may indicate that some group names are not resolvable. Shell-based
            // implementation should tolerate unresolvable groups names, and return resolvable
            // ones, similar to what JNI-based implementation does.
            
          • Better to include the "user" info in logs, for example, add user name to the following exception (some other places too):
            throw new PartialGroupNameException("failed to get group id list");
            
          • add cause when throwing exception
            change
             throw new PartialGroupNameException("failed to get group id list");
            

            to

             throw new PartialGroupNameException("Failed to get group id list for " + user, ece);
            

            Similarly other places.

          • Suggest to move the class PartialGroupNameException to earlier in the code instead of at the end.
          • In PartialGroupNameException, do something like (refer to KerberosName#BadFormatString) :
              @SuppressWarnings("serial")
              private static class PartialGroupNameException extends IOException {
                PartialGroupNameException(String msg) {
                  super(msg);
                }
                PartialGroupNameException(String msg, Throwable err) {
                  super(msg, err);
                }
              }
            

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - HI Wei-Chiu Chuang , Thanks much for the new rev and sorry for late review. It looks good except I have some cosmetic comments: import statements should be alphabetically ordered import org.apache.hadoop.util.Shell.ShellCommandExecutor; import org.apache.commons.lang.StringUtils; It's better not to add new class member user , instead, use parameter passing for it, like what the current implementation does. Better names for createShellCommandExecutor() / createGroupIDExecutor() are createGroupExecutor() / createGroupIDExecutor() Seems to me that it's better to inline getUnixGroupsWithCommandExecutor() into getUnixGroups so not to have two methods here. Shorten the leading comment in resolvePartialGroupNames to (I think we don't have to mention TestJNIGroupsMapping here, you may add comment to this test code if prefer): // Exception may indicate that some group names are not resolvable. Shell-based // implementation should tolerate unresolvable groups names, and return resolvable // ones, similar to what JNI-based implementation does. Better to include the "user" info in logs, for example, add user name to the following exception (some other places too): throw new PartialGroupNameException( "failed to get group id list" ); add cause when throwing exception change throw new PartialGroupNameException( "failed to get group id list" ); to throw new PartialGroupNameException( "Failed to get group id list for " + user, ece); Similarly other places. Suggest to move the class PartialGroupNameException to earlier in the code instead of at the end. In PartialGroupNameException, do something like (refer to KerberosName#BadFormatString ) : @SuppressWarnings( "serial" ) private static class PartialGroupNameException extends IOException { PartialGroupNameException( String msg) { super (msg); } PartialGroupNameException( String msg, Throwable err) { super (msg, err); } } Thanks.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          the test failure is a known to be sporadic.

          Show
          jojochuang Wei-Chiu Chuang added a comment - the test failure is a known to be sporadic.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 6s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 21s trunk passed
          +1 compile 4m 51s trunk passed with JDK v1.8.0_60
          +1 compile 4m 28s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 15s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 55s trunk passed
          +1 javadoc 0m 56s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 6s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 35s the patch passed
          +1 compile 4m 41s the patch passed with JDK v1.8.0_60
          +1 javac 4m 41s the patch passed
          +1 compile 4m 32s the patch passed with JDK v1.7.0_79
          +1 javac 4m 32s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 1s the patch passed
          +1 javadoc 0m 58s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_79
          -1 unit 6m 44s hadoop-common in the patch failed with JDK v1.8.0_60.
          +1 unit 6m 56s hadoop-common in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          47m 47s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769703/HADOOP-12468.006.patch
          JIRA Issue HADOOP-12468
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 718b2c4a540c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision trunk / d2e01f4
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7978/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7978/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7978/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 226MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7978/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 21s trunk passed +1 compile 4m 51s trunk passed with JDK v1.8.0_60 +1 compile 4m 28s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 15s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 35s the patch passed +1 compile 4m 41s the patch passed with JDK v1.8.0_60 +1 javac 4m 41s the patch passed +1 compile 4m 32s the patch passed with JDK v1.7.0_79 +1 javac 4m 32s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 1s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_79 -1 unit 6m 44s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 6m 56s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 47m 47s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769703/HADOOP-12468.006.patch JIRA Issue HADOOP-12468 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 718b2c4a540c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / d2e01f4 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7978/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7978/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7978/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7978/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          the test failures are unrelated. Here's rev6 that fixed the code style issue.

          Show
          jojochuang Wei-Chiu Chuang added a comment - the test failures are unrelated. Here's rev6 that fixed the code style issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 25s trunk passed
          +1 compile 4m 50s trunk passed with JDK v1.8.0_60
          +1 compile 4m 30s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 17s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 10s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 26s the patch passed
          +1 compile 4m 52s the patch passed with JDK v1.8.0_60
          +1 javac 4m 52s the patch passed
          +1 compile 4m 34s the patch passed with JDK v1.7.0_79
          +1 javac 4m 34s the patch passed
          -1 checkstyle 0m 16s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 45, now 43).
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 59s the patch passed
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 17s the patch passed with JDK v1.7.0_79
          -1 unit 8m 13s hadoop-common in the patch failed with JDK v1.8.0_60.
          -1 unit 8m 24s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          51m 16s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          JDK v1.7.0_79 Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.ipc.TestIPC



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769689/HADOOP-12468.005.patch
          JIRA Issue HADOOP-12468
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux dd5936d63675 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision trunk / 7412ff4
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 25s trunk passed +1 compile 4m 50s trunk passed with JDK v1.8.0_60 +1 compile 4m 30s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 17s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 10s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 26s the patch passed +1 compile 4m 52s the patch passed with JDK v1.8.0_60 +1 javac 4m 52s the patch passed +1 compile 4m 34s the patch passed with JDK v1.7.0_79 +1 javac 4m 34s the patch passed -1 checkstyle 0m 16s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 45, now 43). +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 59s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 17s the patch passed with JDK v1.7.0_79 -1 unit 8m 13s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 8m 24s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 51m 16s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.7.0_79 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.ipc.TestIPC Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769689/HADOOP-12468.005.patch JIRA Issue HADOOP-12468 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux dd5936d63675 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / 7412ff4 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7976/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          rev 5: fixed code style issue.

          Show
          jojochuang Wei-Chiu Chuang added a comment - rev 5: fixed code style issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 3s trunk passed
          +1 compile 4m 22s trunk passed with JDK v1.8.0_60
          +1 compile 4m 9s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 13s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 36s trunk passed
          +1 javadoc 0m 53s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 1s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 29s the patch passed
          +1 compile 4m 21s the patch passed with JDK v1.8.0_60
          +1 javac 4m 21s the patch passed
          +1 compile 4m 10s the patch passed with JDK v1.7.0_79
          +1 javac 4m 10s the patch passed
          -1 checkstyle 0m 13s Patch generated 5 new checkstyle issues in hadoop-common-project/hadoop-common (total was 45, now 49).
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_79
          +1 unit 6m 26s hadoop-common in the patch passed with JDK v1.8.0_60.
          +1 unit 6m 52s hadoop-common in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          44m 28s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769668/HADOOP-12468.004.patch
          JIRA Issue HADOOP-12468
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 102804ec50c1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh
          git revision trunk / 7412ff4
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7975/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7975/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 226MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7975/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 3s trunk passed +1 compile 4m 22s trunk passed with JDK v1.8.0_60 +1 compile 4m 9s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 13s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 1s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 29s the patch passed +1 compile 4m 21s the patch passed with JDK v1.8.0_60 +1 javac 4m 21s the patch passed +1 compile 4m 10s the patch passed with JDK v1.7.0_79 +1 javac 4m 10s the patch passed -1 checkstyle 0m 13s Patch generated 5 new checkstyle issues in hadoop-common-project/hadoop-common (total was 45, now 49). +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_79 +1 unit 6m 26s hadoop-common in the patch passed with JDK v1.8.0_60. +1 unit 6m 52s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 44m 28s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-30 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12769668/HADOOP-12468.004.patch JIRA Issue HADOOP-12468 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 102804ec50c1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e77b1ce/precommit/personality/hadoop.sh git revision trunk / 7412ff4 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7975/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7975/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7975/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev4 is a complete rewrite to address several concerns:
          (1) Primary group is place at the first of all groups.
          (2) Support numeric group names
          by adopting Harsh's suggestion. If some group names are not resolvable, get the list of group id, and compare them one by one. For each group name/id pair, if both are the same, regard it as not resolved; otherwise, put the name in the list of group names.

          This support of numeric group name is still not complete: it does not support Windows; also, if some group names are not resolved, and some group names are numeric, and also the group name is the same as the group id, they will be discarded. But this case should be extremely rare.

          Ultimately, I think we should consider support a wider range of character subset for group/user names as defined by POSIX ("Portable Operating System Interface for Unix") standard (IEEE Standard 1003.1 2008) which includes:
          A B C D E F G H I J K L M N O P Q R S T U V W X Y Z
          a b c d e f g h i j k l m n o p q r s t u v w x y z
          0 1 2 3 4 5 6 7 8 9 . _ -
          (The <hyphen> character should not be used as the first character of a portable user name)

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev4 is a complete rewrite to address several concerns: (1) Primary group is place at the first of all groups. (2) Support numeric group names by adopting Harsh's suggestion. If some group names are not resolvable, get the list of group id, and compare them one by one. For each group name/id pair, if both are the same, regard it as not resolved; otherwise, put the name in the list of group names. This support of numeric group name is still not complete: it does not support Windows; also, if some group names are not resolved, and some group names are numeric, and also the group name is the same as the group id, they will be discarded. But this case should be extremely rare. Ultimately, I think we should consider support a wider range of character subset for group/user names as defined by POSIX ("Portable Operating System Interface for Unix") standard (IEEE Standard 1003.1 2008) which includes: A B C D E F G H I J K L M N O P Q R S T U V W X Y Z a b c d e f g h i j k l m n o p q r s t u v w x y z 0 1 2 3 4 5 6 7 8 9 . _ - (The <hyphen> character should not be used as the first character of a portable user name)
          Hide
          qwertymaniac Harsh J added a comment -

          The stderr seems worthy to parse to spot the bad groups specifically and ignore them (vs. ignoring all numeric groups, which may result in a regression in some user clusters).

          Alternatively, the command id -G (no -n) returns numeric IDs. We could match its results against id -Gn output to filter out unknown groups. The assumption here is that the ordering will be the same.

          Show
          qwertymaniac Harsh J added a comment - The stderr seems worthy to parse to spot the bad groups specifically and ignore them (vs. ignoring all numeric groups, which may result in a regression in some user clusters). Alternatively, the command id -G (no -n ) returns numeric IDs. We could match its results against id -Gn output to filter out unknown groups. The assumption here is that the ordering will be the same.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks for the valuable comments!

          I. Yes you are right: Linux does allow numerical group names.
          So looking at the standard output, there is no way to tell whether the returned output represents group names or group ids, unless we look at the output of standard error and then parse it.

          2. The change to the shell command is necessary:
          Without the change, if the primary group name does not resolve, the command bash -c "id -gn && id -Gn <user>" will only return the primary group id, nothing else.

          3. True

          4. good find! Thanks

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks for the valuable comments! I. Yes you are right: Linux does allow numerical group names. So looking at the standard output, there is no way to tell whether the returned output represents group names or group ids, unless we look at the output of standard error and then parse it. 2. The change to the shell command is necessary: Without the change, if the primary group name does not resolve, the command bash -c "id -gn && id -Gn <user>" will only return the primary group id, nothing else. 3. True 4. good find! Thanks
          Hide
          benoyantony Benoy Antony added a comment - - edited

          We have faced this issue a few time on our cluster. The user was blocked and we have to fix the issue on a high priority. But in a healthy system , this issue should not occur.

          I have the following comments on this patch.

          1. The implementation makes an assumption that the groupname cannot be numeric. While a groupname consisting solely of digits is bad idea, systems allow groupnames consisting solely of digits. So the following check is not a good one. We need a better check to determine whether a group is unresolvable than isNumeric.

          if (!groupName.isEmpty() && !StringUtils.isNumeric(groupName)) {
                  groups.add(groupName);
           }
          

          2. Unnecessary modification. I believe the reason to have run "id -gn" is to keep primary group name as the first entry.

                : new String [] {"bash", "-c", "id -gn " + user + "&& id -Gn " + user};
                : new String [] {"bash", "-c", "id -Gn " + user};
          

          3. Logging groupnames is not a good idea as the groupnames for some users could be a very long list.

          4.String errMeessage = e.getMessage();
          There is a typo in variable name.
          This variable is not used anywhere. But I believe the error message should be logged.

          Show
          benoyantony Benoy Antony added a comment - - edited We have faced this issue a few time on our cluster. The user was blocked and we have to fix the issue on a high priority. But in a healthy system , this issue should not occur. I have the following comments on this patch. 1. The implementation makes an assumption that the groupname cannot be numeric. While a groupname consisting solely of digits is bad idea, systems allow groupnames consisting solely of digits. So the following check is not a good one. We need a better check to determine whether a group is unresolvable than isNumeric. if (!groupName.isEmpty() && !StringUtils.isNumeric(groupName)) { groups.add(groupName); } 2. Unnecessary modification. I believe the reason to have run "id -gn" is to keep primary group name as the first entry. : new String [] { "bash" , "-c" , "id -gn " + user + "&& id -Gn " + user}; : new String [] { "bash" , "-c" , "id -Gn " + user}; 3. Logging groupnames is not a good idea as the groupnames for some users could be a very long list. 4.String errMeessage = e.getMessage(); There is a typo in variable name. This variable is not used anywhere. But I believe the error message should be logged.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          To Yongjun Zhang, to address your comment #1,
          (1) I can not make an end-to-end test case, because the group resolution is the output from shell command 'id'. To reproduce the scenario where the group id does not resolve, I must manually tweak /etc/group to make it happen.

          (2) Fortunately, by tweaking /etc/group, I was able to reproduce the scenario, such that part of "id -Gn" output is numerical group id. In addition, the test case emulates the output from the shell command. By piecing together the two parts, I can verify the fix is valid.

          Show
          jojochuang Wei-Chiu Chuang added a comment - To Yongjun Zhang , to address your comment #1, (1) I can not make an end-to-end test case, because the group resolution is the output from shell command 'id'. To reproduce the scenario where the group id does not resolve, I must manually tweak /etc/group to make it happen. (2) Fortunately, by tweaking /etc/group, I was able to reproduce the scenario, such that part of "id -Gn" output is numerical group id. In addition, the test case emulates the output from the shell command. By piecing together the two parts, I can verify the fix is valid.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          The failed test case looks unrelated.]]

          Show
          jojochuang Wei-Chiu Chuang added a comment - The failed test case looks unrelated.]]
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 45s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 5s There were no new javac warning messages.
          +1 javadoc 10m 34s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 10s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 7m 49s Tests failed in hadoop-common.
              49m 49s  



          Reason Tests
          Failed unit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766938/HADOOP-12468.003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / cf23f2c
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7830/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7830/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7830/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 45s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 5s There were no new javac warning messages. +1 javadoc 10m 34s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 10s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 7m 49s Tests failed in hadoop-common.     49m 49s   Reason Tests Failed unit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766938/HADOOP-12468.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cf23f2c hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7830/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7830/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7830/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          rev3: allow partial group resolution even if the primary group is not resolvable.

          Show
          jojochuang Wei-Chiu Chuang added a comment - rev3: allow partial group resolution even if the primary group is not resolvable.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 50s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          -1 javac 0m 59s The patch appears to cause the build to fail.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766882/HADOOP-12468.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 8d2d3eb
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7827/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 50s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. -1 javac 0m 59s The patch appears to cause the build to fail. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766882/HADOOP-12468.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8d2d3eb Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7827/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          I am adding rev2 to address the code style issue.

          Show
          jojochuang Wei-Chiu Chuang added a comment - I am adding rev2 to address the code style issue.
          Hide
          yzhangal Yongjun Zhang added a comment -

          HI Wei-Chiu Chuang,

          Thanks for reporting and working on the issue. Some comments on the patch, mostly cosmetic:

          1. Are we sure this is what happened in real cluster environment?

          2. Formating. reateShellCommandExecutor(String[] cmd){ to reateShellCommandExecutor(String[] cmd) {, and if(x){ to if (x) {

          3. Change

          LOG.warn("got exception trying to get groups: "
                    + e.getMessage() + ". " + reason);
          

          to

          LOG.warn("Got exception trying to get groups: " + reason, e);
          

          4. change ShellBasedUnixGroupsMappingTest.java to TestShellBasedUnixGroupsMapping.java

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - HI Wei-Chiu Chuang , Thanks for reporting and working on the issue. Some comments on the patch, mostly cosmetic: 1. Are we sure this is what happened in real cluster environment? 2. Formating. reateShellCommandExecutor(String[] cmd){ to reateShellCommandExecutor(String[] cmd) { , and if(x){ to if (x) { 3. Change LOG.warn( "got exception trying to get groups: " + e.getMessage() + ". " + reason); to LOG.warn( "Got exception trying to get groups: " + reason, e); 4. change ShellBasedUnixGroupsMappingTest.java to TestShellBasedUnixGroupsMapping.java Thanks.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          The release audit warning comes from an unrelated file hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/util/tree.h where there is no Apache license header.
          The test failure in TestGangliaMetrics is unrelated.

          Show
          jojochuang Wei-Chiu Chuang added a comment - The release audit warning comes from an unrelated file hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/util/tree.h where there is no Apache license header. The test failure in TestGangliaMetrics is unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 33s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 3s There were no new javac warning messages.
          +1 javadoc 10m 24s There were no new javadoc warning messages.
          -1 release audit 0m 19s The applied patch generated 1 release audit warnings.
          +1 checkstyle 1m 9s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 7m 37s Tests failed in hadoop-common.
              49m 4s  



          Reason Tests
          Failed unit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765706/HADOOP-12468.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 8d22622
          Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7785/artifact/patchprocess/patchReleaseAuditProblems.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7785/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7785/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7785/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 3s There were no new javac warning messages. +1 javadoc 10m 24s There were no new javadoc warning messages. -1 release audit 0m 19s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 9s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 7m 37s Tests failed in hadoop-common.     49m 4s   Reason Tests Failed unit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765706/HADOOP-12468.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8d22622 Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7785/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7785/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7785/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7785/console This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          First version of patch

          Show
          jojochuang Wei-Chiu Chuang added a comment - First version of patch

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              jojochuang Wei-Chiu Chuang
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development