Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12467

Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop scripts

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Currently, on Windows the hadoop wrapper script (hadoop-config.cmd) assumes its the only place that uses JAVA_LIBRARY_PATH and initializes it to a blank line.

      set JAVA_LIBRARY_PATH=

      This prevents anyone from setting this outside of the hadoop wrapper (say hadoop-config.cmd) for their own native libraries.

      The fix is pretty simple. Don't initialize it to '' and append the native libs like normal.

      This is the same fix that was done for *nix as part of HADOOP-6453.

      1. HADOOP-12467-v2.patch
        0.7 kB
        Radhey Shah
      2. HADOOP-12467-v3.patch
        1 kB
        Radhey Shah

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 release audit 0m 13s The applied patch generated 1 release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 18s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765894/HADOOP-12467-v2.patch
          Optional Tests  
          git revision trunk / 4f6e842
          Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7787/artifact/patchprocess/patchReleaseAuditProblems.txt
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7787/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 release audit 0m 13s The applied patch generated 1 release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765894/HADOOP-12467-v2.patch Optional Tests   git revision trunk / 4f6e842 Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7787/artifact/patchprocess/patchReleaseAuditProblems.txt Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7787/console This message was automatically generated.
          Hide
          radhey Radhey Shah added a comment -

          The release audit is not related to my change. I looked at Console output, and the issue seems to be no test cases. Since this change is in cmd file, there are no tests.

          Show
          radhey Radhey Shah added a comment - The release audit is not related to my change. I looked at Console output, and the issue seems to be no test cases. Since this change is in cmd file, there are no tests.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Radhey Shah for taking this up. The patch LGTM.
          Just a minor comment, can you check if %JAVA_LIBRARY_PATH% is not empty before prep-ending it.

          Show
          subru Subru Krishnan added a comment - Thanks Radhey Shah for taking this up. The patch LGTM. Just a minor comment, can you check if %JAVA_LIBRARY_PATH% is not empty before prep-ending it.
          Hide
          radhey Radhey Shah added a comment -

          Added suggestion by Subru

          Show
          radhey Radhey Shah added a comment - Added suggestion by Subru
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 28s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766450/HADOOP-12467-v3.patch
          Optional Tests  
          git revision trunk / 40cac59
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7808/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 28s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766450/HADOOP-12467-v3.patch Optional Tests   git revision trunk / 40cac59 Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7808/console This message was automatically generated.
          Hide
          ivanmi Ivan Mitic added a comment -

          Thanks Radhey Shah for reporting and posting a patch. Fix looks good, +1

          Show
          ivanmi Ivan Mitic added a comment - Thanks Radhey Shah for reporting and posting a patch. Fix looks good, +1
          Hide
          wheat9 Haohui Mai added a comment -

          +1. Committing shortly.

          Show
          wheat9 Haohui Mai added a comment - +1. Committing shortly.
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Radhey Shah for the contribution.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Radhey Shah for the contribution.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #8842 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8842/)
          HADOOP-12467. Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8842 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8842/ ) HADOOP-12467 . Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #696 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/696/)
          HADOOP-12467. Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #696 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/696/ ) HADOOP-12467 . Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2637 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2637/)
          HADOOP-12467. Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2637 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2637/ ) HADOOP-12467 . Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #708 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/708/)
          HADOOP-12467. Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #708 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/708/ ) HADOOP-12467 . Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1433 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1433/)
          HADOOP-12467. Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1433 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1433/ ) HADOOP-12467 . Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2567 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2567/)
          HADOOP-12467. Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2567 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2567/ ) HADOOP-12467 . Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/)
          HADOOP-12467. Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/ ) HADOOP-12467 . Respect user-defined JAVA_LIBRARY_PATH in Windows Hadoop (wheat9: rev f0cd903866850cf40f9300289ba57472c9072cd7) hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              radhey Radhey Shah
              Reporter:
              radhey Radhey Shah
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development