Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tracing
    • Labels:
      None
    • Target Version/s:

      Description

      Clean up some htrace integration issues

        Issue Links

          Activity

          Hide
          cmccabe Colin P. McCabe added a comment -
          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Masatake Iwasaki .
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I'm sorry not able to comment in time here. I filed HADOOP-12452 as a follow-up.

          Show
          iwasakims Masatake Iwasaki added a comment - I'm sorry not able to comment in time here. I filed HADOOP-12452 as a follow-up.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #435 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/435/)
          HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
          • hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
            Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #435 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/435/ ) HADOOP-12447 . Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2375 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2375/)
          HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
          • hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
            Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2375 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2375/ ) HADOOP-12447 . Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2403 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2403/)
          HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
            Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2403 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2403/ ) HADOOP-12447 . Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1199 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1199/)
          HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
            Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1199 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1199/ ) HADOOP-12447 . Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #468 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/468/)
          HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
            Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #468 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/468/ ) HADOOP-12447 . Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #460 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/460/)
          HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
          • hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
            Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #460 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/460/ ) HADOOP-12447 . Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8541 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8541/)
          HADOOP-12447. Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468)

          • hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
            Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f)
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8541 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8541/ ) HADOOP-12447 . Clean up some htrace integration issues (cmccabe) (cmccabe: rev 850d679acb935a6a6b0e6cb6f69d998e99395468) hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java Add HADOOP-12447 to CHANGES.txt (cmccabe: rev a2efb945e31700ae9a5afecf9f24294cff39a14f) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          cmccabe Colin P. McCabe added a comment -

          Test issues are not related. Findbugs output is empty. Committed to 2.8. Thanks, stack.

          Show
          cmccabe Colin P. McCabe added a comment - Test issues are not related. Findbugs output is empty. Committed to 2.8. Thanks, stack .
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 22m 49s Findbugs (version 3.0.0) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 7m 54s There were no new javac warning messages.
          +1 javadoc 10m 13s There were no new javadoc warning messages.
          +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 6s Site still builds.
          +1 checkstyle 3m 12s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          -1 findbugs 6m 24s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
          -1 common tests 6m 18s Tests failed in hadoop-common.
          -1 hdfs tests 173m 12s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 38s Tests passed in hadoop-hdfs-client.
              236m 25s  



          Reason Tests
          FindBugs module:hadoop-hdfs
          Failed unit tests hadoop.metrics2.sink.TestFileSink
            hadoop.hdfs.server.namenode.TestFSNamesystem
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.ha.TestHAAppend



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764212/HADOOP-12447.002.patch
          Optional Tests site javadoc javac unit findbugs checkstyle
          git revision trunk / d6fa34e
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
          Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 22m 49s Findbugs (version 3.0.0) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 10m 13s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 site 3m 6s Site still builds. +1 checkstyle 3m 12s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. -1 findbugs 6m 24s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. -1 common tests 6m 18s Tests failed in hadoop-common. -1 hdfs tests 173m 12s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 38s Tests passed in hadoop-hdfs-client.     236m 25s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.metrics2.sink.TestFileSink   hadoop.hdfs.server.namenode.TestFSNamesystem   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.ha.TestHAAppend Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764212/HADOOP-12447.002.patch Optional Tests site javadoc javac unit findbugs checkstyle git revision trunk / d6fa34e Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7732/console This message was automatically generated.
          Hide
          stack stack added a comment -

          +1 from me. Cleans up doc so it refers to 4.0.1 htrace API. Fixes configs removing no longer referenced keys.

          Show
          stack stack added a comment - +1 from me. Cleans up doc so it refers to 4.0.1 htrace API. Fixes configs removing no longer referenced keys.
          Hide
          cmccabe Colin P. McCabe added a comment -

          hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md: update the documentation to remove references to the obsolete dfs.htrace configuration keys and the deprecated no-argument Tracer#Builder constructor. Update the configuration keys described here to be their modern equivalents.

          HdfsClientConfigKeys.java, DFSConfigKeys.java, hdfs-default.xml: remove references to the unused obsolete configuration key dfs.client.htrace.sampler.classes

          NameNodeRpcServer.java: we should set the Tracer for the serviceRpcServer (the RPC server which DNs talk to) as well as the for clientRpcServer. Due to a typo, only one of them was getting set.

          NamenodeFsck.java: we should construct a Tracer using the configuration prefix namenode.fsck.htrace so that tracing can be enabled specifically for fsck.

          TestBlockTokenWithDFS.java, TestDataNodeVolumeFailure.java: set the Tracer object when constructing a BlockReader. It isn't strictly necessary, but it is awkward to have tracer be a null pointer, and it will be helpful if these tests need to be extended in the future. (Note: may need to be done on JspHelper in older branches)

          Show
          cmccabe Colin P. McCabe added a comment - hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md : update the documentation to remove references to the obsolete dfs.htrace configuration keys and the deprecated no-argument Tracer#Builder constructor. Update the configuration keys described here to be their modern equivalents. HdfsClientConfigKeys.java , DFSConfigKeys.java , hdfs-default.xml : remove references to the unused obsolete configuration key dfs.client.htrace.sampler.classes NameNodeRpcServer.java : we should set the Tracer for the serviceRpcServer (the RPC server which DNs talk to) as well as the for clientRpcServer . Due to a typo, only one of them was getting set. NamenodeFsck.java : we should construct a Tracer using the configuration prefix namenode.fsck.htrace so that tracing can be enabled specifically for fsck. TestBlockTokenWithDFS.java , TestDataNodeVolumeFailure.java : set the Tracer object when constructing a BlockReader . It isn't strictly necessary, but it is awkward to have tracer be a null pointer, and it will be helpful if these tests need to be extended in the future. (Note: may need to be done on JspHelper in older branches)

            People

            • Assignee:
              cmccabe Colin P. McCabe
              Reporter:
              cmccabe Colin P. McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development