Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12438

Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      A test written as part of HDFS-8767 uses Mockito's Whitebox#setInternalState to force the static RawLocalFileSystem#useDeprecatedFileStatus to false. On systems that don't implement a stat call (notably Windows), this leaves the class in a state where it will attempt the stat call anyway during subsequent tests. This ultimately causes tests to fail with UnsupportedOperationException.

        Issue Links

          Activity

          Hide
          cnauroth Chris Nauroth added a comment -

          Here is a one-liner patch that restores the correct internal state after testFileStatusPipeFile changes it. I did this during tear-down, so that it's resilient to any future tests added that try to do the same thing.

          Show
          cnauroth Chris Nauroth added a comment - Here is a one-liner patch that restores the correct internal state after testFileStatusPipeFile changes it. I did this during tear-down, so that it's resilient to any future tests added that try to do the same thing.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          +1

          Show
          jnp Jitendra Nath Pandey added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 8m 30s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 9m 3s There were no new javac warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 17s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
          +1 findbugs 2m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 24m 4s Tests failed in hadoop-common.
              47m 41s  



          Reason Tests
          Failed unit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12761997/HADOOP-12438.001.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / 1f707ec
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7696/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7696/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7696/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 8m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 9m 3s There were no new javac warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 17s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 24m 4s Tests failed in hadoop-common.     47m 41s   Reason Tests Failed unit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761997/HADOOP-12438.001.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 1f707ec hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7696/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7696/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7696/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          Thanks Chris for reporting. I'll commit the patch shortly.

          Show
          wheat9 Haohui Mai added a comment - Thanks Chris for reporting. I'll commit the patch shortly.
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Chris Nauroth for the contribution.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Chris Nauroth for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8507 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8507/)
          HADOOP-12438. Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8507 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8507/ ) HADOOP-12438 . Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1171 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1171/)
          HADOOP-12438. Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1171 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1171/ ) HADOOP-12438 . Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #430 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/430/)
          HADOOP-12438. Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #430 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/430/ ) HADOOP-12438 . Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #438 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/438/)
          HADOOP-12438. Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #438 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/438/ ) HADOOP-12438 . Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2376 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2376/)
          HADOOP-12438. Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2376 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2376/ ) HADOOP-12438 . Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2349 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2349/)
          HADOOP-12438. Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2349 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2349/ ) HADOOP-12438 . Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #411 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/411/)
          HADOOP-12438. Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #411 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/411/ ) HADOOP-12438 . Reset RawLocalFileSystem.useDeprecatedFileStatus in TestLocalFileSystem. Contributed by Chris Nauroth. (wheat9: rev 0ef7ff47d5d031783ce61e93d36dc30703b5b28b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java

            People

            • Assignee:
              cnauroth Chris Nauroth
              Reporter:
              cnauroth Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development