Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12436

GlobPattern regex library has performance issues with wildcard characters

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0, 2.7.1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      GlobFilter and RegexFilter.compile() now returns com.google.re2j.pattern.Pattern instead of java.util.regex.Pattern

      Description

      java.util.regex classes have performance problems with certain wildcard patterns. Namely, consecutive * characters in a file name (not properly escaped as literals) will cause commands such as "hadoop fs -ls file******name" to consume 100% CPU and probably never return in a reasonable time (time scales with number of *'s).

      Here is an example:

      hadoop fs -touchz /user/mattp/job_1429571161900_4222-1430338332599-tda%2D%2D\\\+\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\*\\\+\\\+\\\+...%270%27%28Stage-1430338580443-39-2000-SUCCEEDED-production%2Dhigh-1430338340360.jhist
      hadoop fs -ls /user/mattp/job_1429571161900_4222-1430338332599-tda%2D%2D+******************************+++...%270%27%28Stage-1430338580443-39-2000-SUCCEEDED-production%2Dhigh-1430338340360.jhist
      

      causes:

      PID    COMMAND      %CPU   TIME  
      14526  java         100.0  01:18.85 
      

      Not every string of *'s causes this, but the above filename reproduces this reliably.

      1. HADOOP-12436.01.patch
        6 kB
        Matthew Paduano
      2. HADOOP-12436.02.patch
        7 kB
        Matthew Paduano
      3. HADOOP-12436.03.patch
        9 kB
        Matthew Paduano
      4. HADOOP-12436.04.patch
        9 kB
        Matthew Paduano
      5. HADOOP-12436.05.patch
        10 kB
        Matthew Paduano

        Issue Links

          Activity

          Hide
          mattpaduano Matthew Paduano added a comment -

          Propose switching the java.util.regex library for com.google.re2j.

          One possible concern: The public interface of GlobPattern does permit
          users to obtain a reference to the Pattern objects. re2j does not claim
          to be a drop in replacement, so this might break something somewhere.

          Please find proposed patchfile attached.

          Show
          mattpaduano Matthew Paduano added a comment - Propose switching the java.util.regex library for com.google.re2j. One possible concern: The public interface of GlobPattern does permit users to obtain a reference to the Pattern objects. re2j does not claim to be a drop in replacement, so this might break something somewhere. Please find proposed patchfile attached.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 24s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 53s There were no new javac warning messages.
          +1 javadoc 10m 4s There were no new javadoc warning messages.
          +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 11s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
          +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 21s Tests passed in hadoop-common.
              64m 18s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12761973/HADOOP-12436.01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1f707ec
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7695/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7695/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7695/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 24s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 53s There were no new javac warning messages. +1 javadoc 10m 4s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 11s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 21s Tests passed in hadoop-common.     64m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761973/HADOOP-12436.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1f707ec hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7695/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7695/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7695/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          The tests passed, so that's a good sign. Have you tried spinning up a cluster with the patch and banging on it a bit?

          Show
          templedf Daniel Templeton added a comment - The tests passed, so that's a good sign. Have you tried spinning up a cluster with the patch and banging on it a bit?
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks for this, Matthew Paduano.

          I don't think there are any API issues since GlobPattern has InterfaceAnnotation private.

          I do think adding a new dependency could be messy and we should consider shading it, since it seems like a small utility library.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks for this, Matthew Paduano . I don't think there are any API issues since GlobPattern has InterfaceAnnotation private . I do think adding a new dependency could be messy and we should consider shading it, since it seems like a small utility library.
          Hide
          aw Allen Wittenauer added a comment -

          + <version>1.0</version>

          This should be parameterized from hadoop-project/pom.xml.

          Show
          aw Allen Wittenauer added a comment - + <version>1.0</version> This should be parameterized from hadoop-project/pom.xml.
          Hide
          aw Allen Wittenauer added a comment -

          Argh. I forgot to mention the 'paperwork' component. The re2 license should be added to the LICENSE file at the root of the tree. There are some examples there for other, non-Apache projects.

          Show
          aw Allen Wittenauer added a comment - Argh. I forgot to mention the 'paperwork' component. The re2 license should be added to the LICENSE file at the root of the tree. There are some examples there for other, non-Apache projects.
          Hide
          mattpaduano Matthew Paduano added a comment -

          added license

          Show
          mattpaduano Matthew Paduano added a comment - added license
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 27s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 17s There were no new javac warning messages.
          +1 javadoc 10m 31s There were no new javadoc warning messages.
          -1 release audit 0m 18s The applied patch generated 1 release audit warnings.
          +1 checkstyle 1m 10s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
          +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 6m 36s Tests failed in hadoop-common.
              51m 28s  



          Reason Tests
          Failed unit tests hadoop.net.TestDNS



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765930/HADOOP-12436.03.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / def374e
          Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7790/artifact/patchprocess/patchReleaseAuditProblems.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7790/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7790/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7790/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 27s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 17s There were no new javac warning messages. +1 javadoc 10m 31s There were no new javadoc warning messages. -1 release audit 0m 18s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 10s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 6m 36s Tests failed in hadoop-common.     51m 28s   Reason Tests Failed unit tests hadoop.net.TestDNS Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765930/HADOOP-12436.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / def374e Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7790/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7790/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7790/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7790/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 41s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 4s There were no new javac warning messages.
          +1 javadoc 10m 24s There were no new javadoc warning messages.
          -1 release audit 0m 20s The applied patch generated 1 release audit warnings.
          +1 checkstyle 1m 6s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 6m 54s Tests passed in hadoop-common.
              48m 27s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765930/HADOOP-12436.03.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / def374e
          Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7792/artifact/patchprocess/patchReleaseAuditProblems.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7792/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7792/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7792/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 41s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 4s There were no new javac warning messages. +1 javadoc 10m 24s There were no new javadoc warning messages. -1 release audit 0m 20s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 6m 54s Tests passed in hadoop-common.     48m 27s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765930/HADOOP-12436.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / def374e Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7792/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7792/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7792/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7792/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          sigh

          Need a rebase'd patch.

          Show
          aw Allen Wittenauer added a comment - sigh Need a rebase'd patch.
          Hide
          mattpaduano Matthew Paduano added a comment -

          fix release audit error

          Show
          mattpaduano Matthew Paduano added a comment - fix release audit error
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 21m 19s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 9m 3s There were no new javac warning messages.
          +1 javadoc 12m 46s There were no new javadoc warning messages.
          +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 28s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 2m 4s mvn install still works.
          +1 eclipse:eclipse 0m 49s The patch built with eclipse:eclipse.
          +1 findbugs 2m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 8m 46s Tests passed in hadoop-common.
              59m 10s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766441/HADOOP-12436.04.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 40cac59
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7807/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7807/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7807/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 19s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 9m 3s There were no new javac warning messages. +1 javadoc 12m 46s There were no new javadoc warning messages. +1 release audit 0m 30s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 28s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 2m 4s mvn install still works. +1 eclipse:eclipse 0m 49s The patch built with eclipse:eclipse. +1 findbugs 2m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 8m 46s Tests passed in hadoop-common.     59m 10s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766441/HADOOP-12436.04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 40cac59 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7807/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7807/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7807/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          +1 committed to trunk.

          thanks!

          Show
          aw Allen Wittenauer added a comment - +1 committed to trunk. thanks!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8632 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8632/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8632 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8632/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java LICENSE.txt hadoop-common-project/hadoop-common/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2477 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2477/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073)

          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2477 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2477/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073) hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #541 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/541/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #541 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/541/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #529 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/529/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #529 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/529/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java LICENSE.txt hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1265 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1265/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073)

          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • LICENSE.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1265 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1265/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073) hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java LICENSE.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2433 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2433/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2433 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2433/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/CHANGES.txt LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-project/pom.xml
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #496 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/496/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-project/pom.xml
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #496 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/496/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 0d77e85f0aa503fdb826886d867fe61c9e984073) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-project/pom.xml LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          Hide
          aw Allen Wittenauer added a comment -

          I've reverted this patch.

          It appears to have broken the HDFS unit test TestGlobPaths.pTestCurlyBracket:
          com.google.re2j.PatternSyntaxException: error parsing regexp: Unclosed group at pos 10: `myuser}{bc`
          at org.apache.hadoop.fs.GlobPattern.error(GlobPattern.java:168)
          at org.apache.hadoop.fs.GlobPattern.set(GlobPattern.java:154)
          at org.apache.hadoop.fs.GlobPattern.<init>(GlobPattern.java:42)
          at org.apache.hadoop.fs.GlobFilter.init(GlobFilter.java:67)
          at org.apache.hadoop.fs.GlobFilter.<init>(GlobFilter.java:50)
          at org.apache.hadoop.fs.Globber.doGlob(Globber.java:209)
          at org.apache.hadoop.fs.Globber.glob(Globber.java:148)
          at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:1664)
          at org.apache.hadoop.fs.TestGlobPaths.prepareTesting(TestGlobPaths.java:758)
          at org.apache.hadoop.fs.TestGlobPaths.pTestCurlyBracket(TestGlobPaths.java:724)

          Show
          aw Allen Wittenauer added a comment - I've reverted this patch. It appears to have broken the HDFS unit test TestGlobPaths.pTestCurlyBracket: com.google.re2j.PatternSyntaxException: error parsing regexp: Unclosed group at pos 10: `myuser}{bc` at org.apache.hadoop.fs.GlobPattern.error(GlobPattern.java:168) at org.apache.hadoop.fs.GlobPattern.set(GlobPattern.java:154) at org.apache.hadoop.fs.GlobPattern.<init>(GlobPattern.java:42) at org.apache.hadoop.fs.GlobFilter.init(GlobFilter.java:67) at org.apache.hadoop.fs.GlobFilter.<init>(GlobFilter.java:50) at org.apache.hadoop.fs.Globber.doGlob(Globber.java:209) at org.apache.hadoop.fs.Globber.glob(Globber.java:148) at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:1664) at org.apache.hadoop.fs.TestGlobPaths.prepareTesting(TestGlobPaths.java:758) at org.apache.hadoop.fs.TestGlobPaths.pTestCurlyBracket(TestGlobPaths.java:724)
          Hide
          aw Allen Wittenauer added a comment -

          So a few things:

          a) we are clearly missing test coverage in common, since this issue wasn't detected there. Those tests should probably be either moved or at least replicated over in common for better, more complete testing.

          b) we're hitting a (documented!) incompatibility between com.google.re2j.PatternSyntaxException and java.util.regex.PatternSyntaxException

          c) GlobPattern is Private, Evolving . GlobFilter is Public, Evolving but it converts the PatternSyntaxException to IOException, so even though this is an incompatibility, no deprecation should be required. That said, we should definitely scan the source for any other calls into GlobPattern to see if they are processing PatternSyntaxException.

          Show
          aw Allen Wittenauer added a comment - So a few things: a) we are clearly missing test coverage in common, since this issue wasn't detected there. Those tests should probably be either moved or at least replicated over in common for better, more complete testing. b) we're hitting a (documented!) incompatibility between com.google.re2j.PatternSyntaxException and java.util.regex.PatternSyntaxException c) GlobPattern is Private, Evolving . GlobFilter is Public, Evolving but it converts the PatternSyntaxException to IOException, so even though this is an incompatibility, no deprecation should be required. That said, we should definitely scan the source for any other calls into GlobPattern to see if they are processing PatternSyntaxException.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8644 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8644/)
          Revert "HADOOP-12436. GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • LICENSE.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8644 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8644/ ) Revert " HADOOP-12436 . GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java LICENSE.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #550 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/550/)
          Revert "HADOOP-12436. GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #550 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/550/ ) Revert " HADOOP-12436 . GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/pom.xml hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1273 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1273/)
          Revert "HADOOP-12436. GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • LICENSE.txt
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1273 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1273/ ) Revert " HADOOP-12436 . GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java LICENSE.txt hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2486 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2486/)
          Revert "HADOOP-12436. GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2)

          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2486 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2486/ ) Revert " HADOOP-12436 . GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2) hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/pom.xml LICENSE.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #537 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/537/)
          Revert "HADOOP-12436. GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-project/pom.xml
          • LICENSE.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #537 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/537/ ) Revert " HADOOP-12436 . GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml LICENSE.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2439 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2439/)
          Revert "HADOOP-12436. GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2439 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2439/ ) Revert " HADOOP-12436 . GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #502 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/502/)
          Revert "HADOOP-12436. GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-project/pom.xml
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #502 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/502/ ) Revert " HADOOP-12436 . GlobPattern regex library has performance issues (aw: rev dc45a7a7c4920a60424d60aca07a72a9eb909fe2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          Hide
          mattpaduano Matthew Paduano added a comment -

          Fix missed file import in GlobFilter

          Show
          mattpaduano Matthew Paduano added a comment - Fix missed file import in GlobFilter
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 20s trunk passed
          +1 compile 4m 20s trunk passed with JDK v1.8.0_60
          +1 compile 4m 3s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 14s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 33s trunk passed
          +1 javadoc 0m 50s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 1s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 44s the patch passed
          +1 compile 4m 11s the patch passed with JDK v1.8.0_60
          +1 javac 4m 11s the patch passed
          +1 compile 4m 3s the patch passed with JDK v1.7.0_79
          +1 javac 4m 3s the patch passed
          +1 checkstyle 0m 14s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 42s the patch passed
          +1 javadoc 0m 50s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 1s the patch passed with JDK v1.7.0_79
          +1 unit 7m 17s hadoop-common in the patch passed with JDK v1.8.0_60.
          +1 unit 8m 0s hadoop-common in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          46m 30s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767470/HADOOP-12436.05.patch
          JIRA Issue HADOOP-12436
          Optional Tests asflicense javac javadoc mvninstall unit xml findbugs checkstyle compile
          uname Linux c46774885f7c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh
          git revision trunk / 381610d
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7911/testReport/
          Max memory used 225MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7911/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 20s trunk passed +1 compile 4m 20s trunk passed with JDK v1.8.0_60 +1 compile 4m 3s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 14s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 50s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 1s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 44s the patch passed +1 compile 4m 11s the patch passed with JDK v1.8.0_60 +1 javac 4m 11s the patch passed +1 compile 4m 3s the patch passed with JDK v1.7.0_79 +1 javac 4m 3s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 42s the patch passed +1 javadoc 0m 50s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 1s the patch passed with JDK v1.7.0_79 +1 unit 7m 17s hadoop-common in the patch passed with JDK v1.8.0_60. +1 unit 8m 0s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 46m 30s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767470/HADOOP-12436.05.patch JIRA Issue HADOOP-12436 Optional Tests asflicense javac javadoc mvninstall unit xml findbugs checkstyle compile uname Linux c46774885f7c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh git revision trunk / 381610d Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7911/testReport/ Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7911/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          +1 committed to trunk.

          Thanks!

          Show
          aw Allen Wittenauer added a comment - +1 committed to trunk. Thanks!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8689 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8689/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5)

          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8689 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8689/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5) hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #584 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/584/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5)

          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #584 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/584/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5) hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java LICENSE.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1305 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1305/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-project/pom.xml
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1305 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1305/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-project/pom.xml LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #569 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/569/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5)

          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #569 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/569/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5) LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #527 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/527/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #527 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/527/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java LICENSE.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2516 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2516/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • LICENSE.txt
          • hadoop-project/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2516 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2516/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java LICENSE.txt hadoop-project/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2464 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2464/)
          HADOOP-12436. GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java
          • LICENSE.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
          • hadoop-common-project/hadoop-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java
          • hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2464 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2464/ ) HADOOP-12436 . GlobPattern regex library has performance issues with (aw: rev 4c0bae240bea9a475e8ee9a0b081bfce6d1cd1e5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/AbstractPatternFilter.java LICENSE.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobPattern.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGlobPattern.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/GlobFilter.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/filter/RegexFilter.java hadoop-project/pom.xml
          Hide
          qwertymaniac Harsh J added a comment -

          This change subtly fixes the issue described in HADOOP-13051 (test-case added there for regression's sake)

          Show
          qwertymaniac Harsh J added a comment - This change subtly fixes the issue described in HADOOP-13051 (test-case added there for regression's sake)
          Hide
          haibochen Haibo Chen added a comment -

          Allen Wittenauer Matthew Paduano This seems an incompatible change given GlobFilter and RegexFilter are Public Evolving. Hence, I have added an incompatible tag. Feel free to remove it if you disagree

          Show
          haibochen Haibo Chen added a comment - Allen Wittenauer Matthew Paduano This seems an incompatible change given GlobFilter and RegexFilter are Public Evolving. Hence, I have added an incompatible tag. Feel free to remove it if you disagree

            People

            • Assignee:
              mattpaduano Matthew Paduano
              Reporter:
              mattpaduano Matthew Paduano
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development