Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12418

TestRPC.testRPCInterruptedSimple fails intermittently

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Environment:

      Jenkins, Java 8

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Jenkins trunk + java 8 saw a failure of TestRPC.testRPCInterruptedSimple; the interrupt wasn't picked up. Race in test -or a surfacing of a bug in RPC where at some points interrupt exceptions are not picked up?

      1. HADOOP-12418.patch
        0.8 kB
        Kihwal Lee
      2. HADOOP-12418.v2.patch
        1 kB
        Kihwal Lee

        Issue Links

          Activity

          Hide
          eepayne Eric Payne added a comment -

          Thanks Kihwal Lee and Steve Loughran for your work on this issue. This patch backports cleanly to 2.7 (with only contextual diffs). We would like this fix in 2.7, so I backported it.

          Show
          eepayne Eric Payne added a comment - Thanks Kihwal Lee and Steve Loughran for your work on this issue. This patch backports cleanly to 2.7 (with only contextual diffs). We would like this fix in 2.7, so I backported it.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2456 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2456/)
          HADOOP-12418. TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2456 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2456/ ) HADOOP-12418 . TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2507 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2507/)
          HADOOP-12418. TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2507 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2507/ ) HADOOP-12418 . TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #519 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/519/)
          HADOOP-12418. TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #519 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/519/ ) HADOOP-12418 . TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1294 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1294/)
          HADOOP-12418. TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1294 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1294/ ) HADOOP-12418 . TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #574 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/574/)
          HADOOP-12418. TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #574 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/574/ ) HADOOP-12418 . TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #559 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/559/)
          HADOOP-12418. TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #559 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/559/ ) HADOOP-12418 . TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8672 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8672/)
          HADOOP-12418. TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8672 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8672/ ) HADOOP-12418 . TestRPC.testRPCInterruptedSimple fails intermittently. (kihwal: rev 01b103f4ff2e8ee7e71d082885436c5cb7c6be0b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
          Hide
          kihwal Kihwal Lee added a comment -

          Thanks for the reviews, Steve. I've committed this to trunk and branch-2.

          Show
          kihwal Kihwal Lee added a comment - Thanks for the reviews, Steve. I've committed this to trunk and branch-2.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LGTM

          +1

          Show
          stevel@apache.org Steve Loughran added a comment - LGTM +1
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 23s trunk passed
          +1 compile 4m 17s trunk passed with JDK v1.8.0_60
          +1 compile 4m 8s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 14s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 33s trunk passed
          +1 javadoc 0m 49s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 0s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 35s the patch passed
          +1 compile 4m 9s the patch passed with JDK v1.8.0_60
          +1 javac 4m 9s the patch passed
          +1 compile 4m 3s the patch passed with JDK v1.7.0_79
          +1 javac 4m 3s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 42s the patch passed
          +1 javadoc 0m 51s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 1s the patch passed with JDK v1.7.0_79
          +1 unit 7m 18s hadoop-common in the patch passed with JDK v1.8.0_60.
          -1 unit 7m 22s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          45m 37s



          Reason Tests
          JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-20
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767611/HADOOP-12418.v2.patch
          JIRA Issue HADOOP-12418
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 0583cc7a58e2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee2a191/dev-support/personality/hadoop.sh
          git revision trunk / 9cb5d35
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7891/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7891/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7891/testReport/
          Max memory used 225MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7891/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 23s trunk passed +1 compile 4m 17s trunk passed with JDK v1.8.0_60 +1 compile 4m 8s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 14s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 49s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 0s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 35s the patch passed +1 compile 4m 9s the patch passed with JDK v1.8.0_60 +1 javac 4m 9s the patch passed +1 compile 4m 3s the patch passed with JDK v1.7.0_79 +1 javac 4m 3s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 42s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 1s the patch passed with JDK v1.7.0_79 +1 unit 7m 18s hadoop-common in the patch passed with JDK v1.8.0_60. -1 unit 7m 22s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 45m 37s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-20 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767611/HADOOP-12418.v2.patch JIRA Issue HADOOP-12418 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 0583cc7a58e2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee2a191/dev-support/personality/hadoop.sh git revision trunk / 9cb5d35 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7891/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7891/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7891/testReport/ Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7891/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I could leave it as is and add an explicit check for InterruptedIOException, if you think that's cleaner.

          yes please

          Show
          stevel@apache.org Steve Loughran added a comment - I could leave it as is and add an explicit check for InterruptedIOException, if you think that's cleaner. yes please
          Hide
          kihwal Kihwal Lee added a comment -

          Would it possible just to intercept InterruptedIOException rather than scan the string?

          call() can throw either an InterruptedIOException or InterruptedException wrapped in IOException. The string scan was originally there for the latter. I could leave it as is and add an explicit check for InterruptedIOException, if you think that's cleaner.

          Show
          kihwal Kihwal Lee added a comment - Would it possible just to intercept InterruptedIOException rather than scan the string? call() can throw either an InterruptedIOException or InterruptedException wrapped in IOException . The string scan was originally there for the latter. I could leave it as is and add an explicit check for InterruptedIOException , if you think that's cleaner.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Bit of an ugly test. Would it possible just to intercept InterruptedIOException rather than scan the string?

          Show
          stevel@apache.org Steve Loughran added a comment - Bit of an ugly test. Would it possible just to intercept InterruptedIOException rather than scan the string?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          -1 mvninstall 1m 25s root in trunk failed.
          +1 compile 4m 26s trunk passed with JDK v1.8.0_60
          +1 compile 4m 2s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 14s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 48s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 0s trunk passed with JDK v1.7.0_79
          -1 mvninstall 1m 27s hadoop-common in the patch failed.
          +1 compile 4m 16s the patch passed with JDK v1.8.0_60
          +1 javac 4m 16s the patch passed
          +1 compile 4m 7s the patch passed with JDK v1.7.0_79
          +1 javac 4m 7s the patch passed
          +1 checkstyle 0m 14s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 49s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 0s the patch passed with JDK v1.7.0_79
          -1 unit 16m 50s hadoop-common in the patch failed with JDK v1.8.0_60.
          +1 unit 6m 45s hadoop-common in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          52m 38s



          Reason Tests
          JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.ipc.TestIPC
          JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-19
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767489/HADOOP-12418.patch
          JIRA Issue HADOOP-12418
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 4e533b047f39 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build@2/patchprocess/apache-yetus-30c4bc4/dev-support/personality/hadoop.sh
          git revision trunk / 5068a25
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/testReport/
          Max memory used 204MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvninstall 1m 25s root in trunk failed. +1 compile 4m 26s trunk passed with JDK v1.8.0_60 +1 compile 4m 2s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 14s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 48s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 0s trunk passed with JDK v1.7.0_79 -1 mvninstall 1m 27s hadoop-common in the patch failed. +1 compile 4m 16s the patch passed with JDK v1.8.0_60 +1 javac 4m 16s the patch passed +1 compile 4m 7s the patch passed with JDK v1.7.0_79 +1 javac 4m 7s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 49s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 0s the patch passed with JDK v1.7.0_79 -1 unit 16m 50s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 6m 45s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 52m 38s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.ipc.TestIPC JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767489/HADOOP-12418.patch JIRA Issue HADOOP-12418 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 4e533b047f39 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build@2/patchprocess/apache-yetus-30c4bc4/dev-support/personality/hadoop.sh git revision trunk / 5068a25 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/testReport/ Max memory used 204MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7877/console This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          Made it work for both InterruptedException and InterruptedIOException.

          Show
          kihwal Kihwal Lee added a comment - Made it work for both InterruptedException and InterruptedIOException .
          Hide
          kihwal Kihwal Lee added a comment -

          I think it is affected by HADOOP-12464. After HADOOP-12464, this test case has occasionally been failing differently.

          This is what the test expects:

          java.io.IOException: java.lang.InterruptedException
          	at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:404)
          	at java.util.concurrent.FutureTask.get(FutureTask.java:191)
          	at org.apache.hadoop.ipc.Client$Connection.sendRpcRequest(Client.java:1084)
          	at org.apache.hadoop.ipc.Client.call(Client.java:1433)
          	at org.apache.hadoop.ipc.Client.call(Client.java:1391)
          	at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:248)
          	at com.sun.proxy.$Proxy8.ping(Unknown Source)
          	at org.apache.hadoop.ipc.TestRPC.testRPCInterruptedSimple(TestRPC.java:885)
          

          After HADOOP-12464, test occasionally fails becuase the call is stopped with a different exception. This was where interruption used to be ignored, which now throws after HADOOP-12464. I think when the test hits this, it used to fail as reported originally since the exception was swallowed.

          java.io.InterruptedIOException: Call interrupted
          	at org.apache.hadoop.ipc.Client.call(Client.java:1448)
          	at org.apache.hadoop.ipc.Client.call(Client.java:1391)
          	at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:247)
          	at com.sun.proxy.$Proxy9.ping(Unknown Source)
          	at org.apache.hadoop.ipc.TestRPC.testRPCInterruptedSimple(TestRPC.java:885)
          

          I think the original bug is fixed by HADOOP-12464 and now the test case needs an update.

          Show
          kihwal Kihwal Lee added a comment - I think it is affected by HADOOP-12464 . After HADOOP-12464 , this test case has occasionally been failing differently. This is what the test expects: java.io.IOException: java.lang.InterruptedException at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:404) at java.util.concurrent.FutureTask.get(FutureTask.java:191) at org.apache.hadoop.ipc.Client$Connection.sendRpcRequest(Client.java:1084) at org.apache.hadoop.ipc.Client.call(Client.java:1433) at org.apache.hadoop.ipc.Client.call(Client.java:1391) at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:248) at com.sun.proxy.$Proxy8.ping(Unknown Source) at org.apache.hadoop.ipc.TestRPC.testRPCInterruptedSimple(TestRPC.java:885) After HADOOP-12464 , test occasionally fails becuase the call is stopped with a different exception. This was where interruption used to be ignored, which now throws after HADOOP-12464 . I think when the test hits this, it used to fail as reported originally since the exception was swallowed. java.io.InterruptedIOException: Call interrupted at org.apache.hadoop.ipc.Client.call(Client.java:1448) at org.apache.hadoop.ipc.Client.call(Client.java:1391) at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:247) at com.sun.proxy.$Proxy9.ping(Unknown Source) at org.apache.hadoop.ipc.TestRPC.testRPCInterruptedSimple(TestRPC.java:885) I think the original bug is fixed by HADOOP-12464 and now the test case needs an update.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          OK, let's close this as cannot reproduce until it surfaces again

          Show
          stevel@apache.org Steve Loughran added a comment - OK, let's close this as cannot reproduce until it surfaces again
          Hide
          kihwal Kihwal Lee added a comment -

          I am using jdk8, but cannot reproduce this. It interrupts after getting the response to the first call, so I don't see any race in the test case itself. The thread interrupt state is not set when the client is making the second call. It's either cleared by something or not set from the beginning. Neither is supposed to happen!

          Show
          kihwal Kihwal Lee added a comment - I am using jdk8, but cannot reproduce this. It interrupts after getting the response to the first call, so I don't see any race in the test case itself. The thread interrupt state is not set when the client is making the second call. It's either cleared by something or not set from the beginning. Neither is supposed to happen!
          Hide
          stevel@apache.org Steve Loughran added a comment -
          Error Message
          
          Interruption did not cause IPC to fail
          Stacktrace
          
          java.lang.AssertionError: Interruption did not cause IPC to fail
          	at org.junit.Assert.fail(Assert.java:88)
          	at org.apache.hadoop.ipc.TestRPC.testRPCInterruptedSimple(TestRPC.java:886)
          Standard Output
          
          2015-09-16 10:17:21,950 INFO  ipc.CallQueueManager (CallQueueManager.java:<init>(60)) - Using callQueue class java.util.concurrent.LinkedBlockingQueue
          2015-09-16 10:17:21,950 INFO  ipc.Server (Server.java:run(678)) - Starting Socket Reader #1 for port 41571
          2015-09-16 10:17:21,953 INFO  ipc.Server (Server.java:run(908)) - IPC Server Responder: starting
          2015-09-16 10:17:21,953 INFO  ipc.Server (Server.java:run(748)) - IPC Server listener on 41571: starting
          2015-09-16 10:17:21,961 INFO  ipc.Server (WritableRpcEngine.java:log(440)) - Call: ping(), rpc version=2, client version=1, methodsF...
          2015-09-16 10:17:21,962 INFO  ipc.Server (WritableRpcEngine.java:log(440)) - Return: null
          2015-09-16 10:17:21,962 INFO  ipc.Server (WritableRpcEngine.java:log(440)) - Call: ping(), rpc version=2, client version=1, methodsF...
          2015-09-16 10:17:21,962 INFO  ipc.Server (WritableRpcEngine.java:log(440)) - Return: null
          2015-09-16 10:17:21,964 INFO  ipc.Server (Server.java:stop(2632)) - Stopping server on 41571
          2015-09-16 10:17:21,966 INFO  ipc.Server (Server.java:run(780)) - Stopping IPC Server listener on 41571
          2015-09-16 10:17:21,966 INFO  ipc.Server (Server.java:run(913)) - Stopping IPC Server Responder
          
          Show
          stevel@apache.org Steve Loughran added a comment - Error Message Interruption did not cause IPC to fail Stacktrace java.lang.AssertionError: Interruption did not cause IPC to fail at org.junit.Assert.fail(Assert.java:88) at org.apache.hadoop.ipc.TestRPC.testRPCInterruptedSimple(TestRPC.java:886) Standard Output 2015-09-16 10:17:21,950 INFO ipc.CallQueueManager (CallQueueManager.java:<init>(60)) - Using callQueue class java.util.concurrent.LinkedBlockingQueue 2015-09-16 10:17:21,950 INFO ipc.Server (Server.java:run(678)) - Starting Socket Reader #1 for port 41571 2015-09-16 10:17:21,953 INFO ipc.Server (Server.java:run(908)) - IPC Server Responder: starting 2015-09-16 10:17:21,953 INFO ipc.Server (Server.java:run(748)) - IPC Server listener on 41571: starting 2015-09-16 10:17:21,961 INFO ipc.Server (WritableRpcEngine.java:log(440)) - Call: ping(), rpc version=2, client version=1, methodsF... 2015-09-16 10:17:21,962 INFO ipc.Server (WritableRpcEngine.java:log(440)) - Return: null 2015-09-16 10:17:21,962 INFO ipc.Server (WritableRpcEngine.java:log(440)) - Call: ping(), rpc version=2, client version=1, methodsF... 2015-09-16 10:17:21,962 INFO ipc.Server (WritableRpcEngine.java:log(440)) - Return: null 2015-09-16 10:17:21,964 INFO ipc.Server (Server.java:stop(2632)) - Stopping server on 41571 2015-09-16 10:17:21,966 INFO ipc.Server (Server.java:run(780)) - Stopping IPC Server listener on 41571 2015-09-16 10:17:21,966 INFO ipc.Server (Server.java:run(913)) - Stopping IPC Server Responder

            People

            • Assignee:
              kihwal Kihwal Lee
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development