Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12388

Fix components' version information in the web page 'About the Cluster'

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: util
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the web page 'About the Cluster', YARN's component's build version(e.g. ResourceManager) is the same as Hadoop version now. It is caused by calling getVersion() instead of _getVersion() in VersionInfo.java by mistake.

        Activity

        Hide
        hex108 Jun Gong added a comment -

        Thanks zhihai xu for the review and commit!

        Show
        hex108 Jun Gong added a comment - Thanks zhihai xu for the review and commit!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #345 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/345/)
        HADOOP-12388. Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #345 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/345/ ) HADOOP-12388 . Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2284 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2284/)
        HADOOP-12388. Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2284 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2284/ ) HADOOP-12388 . Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1096 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1096/)
        HADOOP-12388. Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1096 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1096/ ) HADOOP-12388 . Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2307 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2307/)
        HADOOP-12388. Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2307 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2307/ ) HADOOP-12388 . Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #357 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/357/)
        HADOOP-12388. Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #357 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/357/ ) HADOOP-12388 . Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 24s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 46s There were no new javac warning messages.
        +1 javadoc 10m 12s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 6s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 23m 6s Tests passed in hadoop-common.
            63m 52s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12650794/YARN-2170.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 16b9037
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7619/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7619/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7619/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 24s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 10m 12s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 6s Tests passed in hadoop-common.     63m 52s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12650794/YARN-2170.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 16b9037 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7619/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7619/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7619/console This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #365 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/365/)
        HADOOP-12388. Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #365 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/365/ ) HADOOP-12388 . Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8417 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8417/)
        HADOOP-12388. Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8417 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8417/ ) HADOOP-12388 . Fix components' version information in the web page About the Cluster. Contributed by Jun Gong. (zxu: rev d9c1fab2ec2930a011b7cca4a393881d39b8f6ec) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        zxu zhihai xu added a comment -

        Thanks Jun Gong for the contribution! Committed it to branch-2 and trunk.

        Show
        zxu zhihai xu added a comment - Thanks Jun Gong for the contribution! Committed it to branch-2 and trunk.
        Hide
        zxu zhihai xu added a comment -

        This is a very minor and safe change.
        +1 for the patch. I'll commit this tomorrow if no one objects.

        Show
        zxu zhihai xu added a comment - This is a very minor and safe change. +1 for the patch. I'll commit this tomorrow if no one objects.
        Hide
        hex108 Jun Gong added a comment -

        Thanks zhihai xu for the review.

        Show
        hex108 Jun Gong added a comment - Thanks zhihai xu for the review.
        Hide
        zxu zhihai xu added a comment -

        Hi Jun Gong, It is a good catch. Java doesn't allow overriding of static methods. That is why getVersion always get the version of hadoop common.

        Show
        zxu zhihai xu added a comment - Hi Jun Gong , It is a good catch. Java doesn't allow overriding of static methods. That is why getVersion always get the version of hadoop common.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 2s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 51s There were no new javac warning messages.
        +1 javadoc 10m 2s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 10s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 27s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 57s Tests passed in hadoop-common.
            63m 22s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12650794/YARN-2170.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 65ccf2b
        hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8968/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8968/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8968/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 51s There were no new javac warning messages. +1 javadoc 10m 2s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 10s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 57s Tests passed in hadoop-common.     63m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12650794/YARN-2170.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 65ccf2b hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8968/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8968/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8968/console This message was automatically generated.

          People

          • Assignee:
            hex108 Jun Gong
            Reporter:
            hex108 Jun Gong
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development