Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12386

RetryPolicies.RETRY_FOREVER should be able to specify a retry interval

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Problems mentioned in YARN-4113, We should be able to specify retry interval in RetryPolicies.RETRY_FOREVER.

      1. 0001-HADOOP-12386.patch
        4 kB
        Sunil G
      2. 0002-HADOOP-12386.patch
        3 kB
        Sunil G

        Issue Links

          Activity

          Hide
          sunilg Sunil G added a comment -

          Thanks Wangda Tan for filing this.
          I have done some initial work in this in YARN-4113, pls reassign otherwise.

          Show
          sunilg Sunil G added a comment - Thanks Wangda Tan for filing this. I have done some initial work in this in YARN-4113 , pls reassign otherwise.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Sunil G! Please go ahead.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Sunil G ! Please go ahead.
          Hide
          sunilg Sunil G added a comment -

          Attaching an initial version. Kindly help to check.

          Show
          sunilg Sunil G added a comment - Attaching an initial version. Kindly help to check.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 37s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 41s There were no new javac warning messages.
          +1 javadoc 9m 47s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 5s The applied patch generated 2 new checkstyle issues (total was 40, now 42).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 55s Tests passed in hadoop-common.
              62m 22s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754890/0001-HADOOP-12386.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 0113e45
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7622/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7622/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7622/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7622/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 2 new checkstyle issues (total was 40, now 42). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 55s Tests passed in hadoop-common.     62m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754890/0001-HADOOP-12386.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0113e45 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7622/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7622/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7622/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7622/console This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Sunil G,
          Thanks for working on this,
          I think retryForeverWithFixedSleep could reuse retryUpToMaximumCountWithFixedSleep, and just pass the Long.max_value as maxRetries. Which can avoid maintain two separate logics. Is this reasonable to you?

          Show
          leftnoteasy Wangda Tan added a comment - Sunil G , Thanks for working on this, I think retryForeverWithFixedSleep could reuse retryUpToMaximumCountWithFixedSleep, and just pass the Long.max_value as maxRetries. Which can avoid maintain two separate logics. Is this reasonable to you?
          Hide
          sunilg Sunil G added a comment -

          Thank you Wangda Tan
          I think that makes sense to me. It will help to avoid duplicate handling. Updating a patch for same.

          Show
          sunilg Sunil G added a comment - Thank you Wangda Tan I think that makes sense to me. It will help to avoid duplicate handling. Updating a patch for same.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 34s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 9s There were no new javac warning messages.
          +1 javadoc 10m 9s There were no new javadoc warning messages.
          +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 10s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
          +1 findbugs 1m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 22m 42s Tests failed in hadoop-common.
              64m 24s  



          Reason Tests
          Failed unit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.fs.TestSymlinkLocalFSFileContext



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755185/0002-HADOOP-12386.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 7766610
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7624/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7624/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7624/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 9s There were no new javac warning messages. +1 javadoc 10m 9s There were no new javadoc warning messages. +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 10s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 1m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 22m 42s Tests failed in hadoop-common.     64m 24s   Reason Tests Failed unit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.fs.TestSymlinkLocalFSFileContext Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755185/0002-HADOOP-12386.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7766610 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7624/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7624/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7624/console This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          Test case passed locally. Wangda Tan could you please take a look.

          Show
          sunilg Sunil G added a comment - Test case passed locally. Wangda Tan could you please take a look.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Patch looks good, committing...

          Show
          leftnoteasy Wangda Tan added a comment - Patch looks good, committing...
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to trunk/branch-2, thanks Sunil G!

          Show
          leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2, thanks Sunil G !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8474 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8474/)
          HADOOP-12386. RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8474 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8474/ ) HADOOP-12386 . RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #404 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/404/)
          HADOOP-12386. RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #404 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/404/ ) HADOOP-12386 . RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #411 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/411/)
          HADOOP-12386. RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #411 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/411/ ) HADOOP-12386 . RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1145 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1145/)
          HADOOP-12386. RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1145 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1145/ ) HADOOP-12386 . RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #387 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/387/)
          HADOOP-12386. RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #387 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/387/ ) HADOOP-12386 . RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2351 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2351/)
          HADOOP-12386. RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2351 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2351/ ) HADOOP-12386 . RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2326 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2326/)
          HADOOP-12386. RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2326 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2326/ ) HADOOP-12386 . RetryPolicies.RETRY_FOREVER should be able to specify a retry interval. (Sunil G via wangda) (wangda: rev 6b97fa6652da29a203f1537508b43333633eb760) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestRetryProxy.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java

            People

            • Assignee:
              sunilg Sunil G
              Reporter:
              leftnoteasy Wangda Tan
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development