Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12378

Fix findbugs warnings in hadoop-tools module

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tools
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are 2 warnings in hadoop-datajoin module and 4 warnings in hadoop-ant module.

      1. HADOOP-12378.002.patch
        5 kB
        Akira Ajisaka
      2. HADOOP-12378.001.patch
        5 kB
        Akira Ajisaka
      3. findbugsDatajoin.html
        5 kB
        Akira Ajisaka
      4. findbugsAnt.html
        6 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks, Masatake.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks, Masatake.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Committed. Thanks, Akira Ajisaka.

          Show
          iwasakims Masatake Iwasaki added a comment - Committed. Thanks, Akira Ajisaka .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9692 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9692/)
          HADOOP-12378. Fix findbugs warnings in hadoop-tools module. Contributed (iwasakims: rev ef0870ad038a1b72ea14ce550e34139b81eb901b)

          • hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsZeroLen.java
          • hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsIsDir.java
          • hadoop-tools/hadoop-datajoin/pom.xml
          • hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsExists.java
          • hadoop-tools/hadoop-datajoin/dev-support/findbugs-exclude.xml
          • hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/DfsTask.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9692 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9692/ ) HADOOP-12378 . Fix findbugs warnings in hadoop-tools module. Contributed (iwasakims: rev ef0870ad038a1b72ea14ce550e34139b81eb901b) hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsZeroLen.java hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsIsDir.java hadoop-tools/hadoop-datajoin/pom.xml hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/condition/DfsExists.java hadoop-tools/hadoop-datajoin/dev-support/findbugs-exclude.xml hadoop-tools/hadoop-ant/src/main/java/org/apache/hadoop/ant/DfsTask.java
          Hide
          iwasakims Masatake Iwasaki added a comment -

          +1, committing this.

          Show
          iwasakims Masatake Iwasaki added a comment - +1, committing this.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I will look into this tomorrow.

          Show
          iwasakims Masatake Iwasaki added a comment - I will look into this tomorrow.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Tsuyoshi Ozawa and Masatake Iwasaki, would you review the latest patch?

          Show
          ajisakaa Akira Ajisaka added a comment - Hi Tsuyoshi Ozawa and Masatake Iwasaki , would you review the latest patch?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Tsuyoshi Ozawa, would you review the latest patch?

          Show
          ajisakaa Akira Ajisaka added a comment - Hi Tsuyoshi Ozawa , would you review the latest patch?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 29s Maven dependency ordering for branch
          -1 mvninstall 6m 38s root in trunk failed.
          +1 compile 1m 3s trunk passed with JDK v1.8.0_74
          +1 compile 1m 16s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 33s trunk passed
          +1 mvneclipse 0m 24s trunk passed
          -1 findbugs 0m 23s hadoop-tools/hadoop-datajoin in trunk has 2 extant Findbugs warnings.
          -1 findbugs 0m 21s hadoop-tools/hadoop-ant in trunk has 4 extant Findbugs warnings.
          +1 javadoc 0m 22s trunk passed with JDK v1.8.0_74
          +1 javadoc 0m 27s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 25s the patch passed
          +1 compile 0m 58s the patch passed with JDK v1.8.0_74
          +1 javac 0m 58s the patch passed
          +1 compile 1m 14s the patch passed with JDK v1.7.0_95
          +1 javac 1m 14s the patch passed
          -1 checkstyle 0m 24s hadoop-tools: patch generated 3 new + 36 unchanged - 3 fixed = 39 total (was 39)
          +1 mvnsite 0m 32s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 0m 34s hadoop-tools/hadoop-datajoin generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 findbugs 0m 31s hadoop-tools/hadoop-ant generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
          +1 javadoc 0m 18s the patch passed with JDK v1.8.0_74
          +1 javadoc 0m 22s the patch passed with JDK v1.7.0_95
          +1 unit 0m 19s hadoop-datajoin in the patch passed with JDK v1.8.0_74.
          +1 unit 0m 8s hadoop-ant in the patch passed with JDK v1.8.0_74.
          +1 unit 0m 21s hadoop-datajoin in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 10s hadoop-ant in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          20m 53s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773179/HADOOP-12378.002.patch
          JIRA Issue HADOOP-12378
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 375c48c087d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2e1d0ff
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-datajoin-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-ant-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/artifact/patchprocess/diff-checkstyle-hadoop-tools.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/testReport/
          modules C: hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-ant U: hadoop-tools
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 29s Maven dependency ordering for branch -1 mvninstall 6m 38s root in trunk failed. +1 compile 1m 3s trunk passed with JDK v1.8.0_74 +1 compile 1m 16s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 33s trunk passed +1 mvneclipse 0m 24s trunk passed -1 findbugs 0m 23s hadoop-tools/hadoop-datajoin in trunk has 2 extant Findbugs warnings. -1 findbugs 0m 21s hadoop-tools/hadoop-ant in trunk has 4 extant Findbugs warnings. +1 javadoc 0m 22s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 27s trunk passed with JDK v1.7.0_95 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 25s the patch passed +1 compile 0m 58s the patch passed with JDK v1.8.0_74 +1 javac 0m 58s the patch passed +1 compile 1m 14s the patch passed with JDK v1.7.0_95 +1 javac 1m 14s the patch passed -1 checkstyle 0m 24s hadoop-tools: patch generated 3 new + 36 unchanged - 3 fixed = 39 total (was 39) +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 34s hadoop-tools/hadoop-datajoin generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 findbugs 0m 31s hadoop-tools/hadoop-ant generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) +1 javadoc 0m 18s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 22s the patch passed with JDK v1.7.0_95 +1 unit 0m 19s hadoop-datajoin in the patch passed with JDK v1.8.0_74. +1 unit 0m 8s hadoop-ant in the patch passed with JDK v1.8.0_74. +1 unit 0m 21s hadoop-datajoin in the patch passed with JDK v1.7.0_95. +1 unit 0m 10s hadoop-ant in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 20m 53s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773179/HADOOP-12378.002.patch JIRA Issue HADOOP-12378 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 375c48c087d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2e1d0ff Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-datajoin-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-ant-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/artifact/patchprocess/diff-checkstyle-hadoop-tools.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/testReport/ modules C: hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-ant U: hadoop-tools Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8920/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Jenkins build seems to be broken.

          I've misunderstood. -1 is the report for trunk.

          +1 findbugs 1m 8s the patch passed

          This is the report for the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Jenkins build seems to be broken. I've misunderstood. -1 is the report for trunk. +1 findbugs 1m 8s the patch passed This is the report for the patch.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          -1 findbugs

          Jenkins build seems to be broken. I tested the patch manually, and the number of warnings became 0 with the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - -1 findbugs Jenkins build seems to be broken. I tested the patch manually, and the number of warnings became 0 with the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 6s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 45s trunk passed
          +1 compile 1m 20s trunk passed with JDK v1.8.0_66
          +1 compile 1m 29s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 38s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          -1 findbugs 0m 25s hadoop-tools/hadoop-ant in trunk has 4 extant Findbugs warnings.
          -1 findbugs 0m 25s hadoop-tools/hadoop-datajoin in trunk has 2 extant Findbugs warnings.
          +1 javadoc 0m 25s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 29s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 34s the patch passed
          +1 compile 1m 20s the patch passed with JDK v1.8.0_66
          +1 javac 1m 20s the patch passed
          +1 compile 1m 29s the patch passed with JDK v1.7.0_85
          +1 javac 1m 29s the patch passed
          -1 checkstyle 0m 23s Patch generated 3 new checkstyle issues in hadoop-tools (total was 41, now 41).
          +1 mvnsite 0m 38s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 8s the patch passed
          +1 javadoc 0m 26s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 29s the patch passed with JDK v1.7.0_85
          +1 unit 0m 11s hadoop-ant in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 24s hadoop-datajoin in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 13s hadoop-ant in the patch passed with JDK v1.7.0_85.
          +1 unit 0m 25s hadoop-datajoin in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          24m 42s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-19
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773179/HADOOP-12378.002.patch
          JIRA Issue HADOOP-12378
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux c30e64123d66 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 23a130a
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-ant-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-datajoin-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/artifact/patchprocess/diff-checkstyle-hadoop-tools.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/testReport/
          modules C: hadoop-tools/hadoop-ant hadoop-tools/hadoop-datajoin U: hadoop-tools
          Max memory used 78MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 45s trunk passed +1 compile 1m 20s trunk passed with JDK v1.8.0_66 +1 compile 1m 29s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 38s trunk passed +1 mvneclipse 0m 28s trunk passed -1 findbugs 0m 25s hadoop-tools/hadoop-ant in trunk has 4 extant Findbugs warnings. -1 findbugs 0m 25s hadoop-tools/hadoop-datajoin in trunk has 2 extant Findbugs warnings. +1 javadoc 0m 25s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 29s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 34s the patch passed +1 compile 1m 20s the patch passed with JDK v1.8.0_66 +1 javac 1m 20s the patch passed +1 compile 1m 29s the patch passed with JDK v1.7.0_85 +1 javac 1m 29s the patch passed -1 checkstyle 0m 23s Patch generated 3 new checkstyle issues in hadoop-tools (total was 41, now 41). +1 mvnsite 0m 38s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 8s the patch passed +1 javadoc 0m 26s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 29s the patch passed with JDK v1.7.0_85 +1 unit 0m 11s hadoop-ant in the patch passed with JDK v1.8.0_66. +1 unit 0m 24s hadoop-datajoin in the patch passed with JDK v1.8.0_66. +1 unit 0m 13s hadoop-ant in the patch passed with JDK v1.7.0_85. +1 unit 0m 25s hadoop-datajoin in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 24m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773179/HADOOP-12378.002.patch JIRA Issue HADOOP-12378 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux c30e64123d66 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 23a130a findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-ant-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-datajoin-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/artifact/patchprocess/diff-checkstyle-hadoop-tools.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/testReport/ modules C: hadoop-tools/hadoop-ant hadoop-tools/hadoop-datajoin U: hadoop-tools Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8089/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          v2 patch: Ignored findbugs warnings in hadoop-datajoin module.

          Show
          ajisakaa Akira Ajisaka added a comment - v2 patch: Ignored findbugs warnings in hadoop-datajoin module.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 6s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 51s trunk passed
          +1 compile 1m 28s trunk passed with JDK v1.8.0_66
          +1 compile 1m 30s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 39s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          -1 findbugs 0m 25s hadoop-tools/hadoop-ant in trunk has 4 extant Findbugs warnings.
          -1 findbugs 0m 27s hadoop-tools/hadoop-datajoin in trunk has 2 extant Findbugs warnings.
          +1 javadoc 0m 26s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 30s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 34s the patch passed
          +1 compile 1m 20s the patch passed with JDK v1.8.0_66
          -1 javac 3m 18s hadoop-tools-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 153, now 153).
          +1 javac 1m 20s the patch passed
          +1 compile 1m 30s the patch passed with JDK v1.7.0_85
          +1 javac 1m 30s the patch passed
          -1 checkstyle 0m 23s Patch generated 4 new checkstyle issues in hadoop-tools (total was 50, now 46).
          +1 mvnsite 0m 39s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 10s the patch passed
          +1 javadoc 0m 26s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 29s the patch passed with JDK v1.7.0_85
          +1 unit 0m 11s hadoop-ant in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 24s hadoop-datajoin in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 13s hadoop-ant in the patch passed with JDK v1.7.0_85.
          +1 unit 0m 25s hadoop-datajoin in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          25m 4s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-19
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12754169/HADOOP-12378.001.patch
          JIRA Issue HADOOP-12378
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6d511cd1af25 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 23a130a
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-ant-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-datajoin-warnings.html
          javac hadoop-tools-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/artifact/patchprocess/diff-compile-javac-hadoop-tools-jdk1.8.0_66.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/artifact/patchprocess/diff-checkstyle-hadoop-tools.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/testReport/
          modules C: hadoop-tools/hadoop-ant hadoop-tools/hadoop-datajoin U: hadoop-tools
          Max memory used 78MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 51s trunk passed +1 compile 1m 28s trunk passed with JDK v1.8.0_66 +1 compile 1m 30s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 28s trunk passed -1 findbugs 0m 25s hadoop-tools/hadoop-ant in trunk has 4 extant Findbugs warnings. -1 findbugs 0m 27s hadoop-tools/hadoop-datajoin in trunk has 2 extant Findbugs warnings. +1 javadoc 0m 26s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 30s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 34s the patch passed +1 compile 1m 20s the patch passed with JDK v1.8.0_66 -1 javac 3m 18s hadoop-tools-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 153, now 153). +1 javac 1m 20s the patch passed +1 compile 1m 30s the patch passed with JDK v1.7.0_85 +1 javac 1m 30s the patch passed -1 checkstyle 0m 23s Patch generated 4 new checkstyle issues in hadoop-tools (total was 50, now 46). +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 10s the patch passed +1 javadoc 0m 26s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 29s the patch passed with JDK v1.7.0_85 +1 unit 0m 11s hadoop-ant in the patch passed with JDK v1.8.0_66. +1 unit 0m 24s hadoop-datajoin in the patch passed with JDK v1.8.0_66. +1 unit 0m 13s hadoop-ant in the patch passed with JDK v1.7.0_85. +1 unit 0m 25s hadoop-datajoin in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 25m 4s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12754169/HADOOP-12378.001.patch JIRA Issue HADOOP-12378 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6d511cd1af25 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 23a130a findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-ant-warnings.html findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-datajoin-warnings.html javac hadoop-tools-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/artifact/patchprocess/diff-compile-javac-hadoop-tools-jdk1.8.0_66.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/artifact/patchprocess/diff-checkstyle-hadoop-tools.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/testReport/ modules C: hadoop-tools/hadoop-ant hadoop-tools/hadoop-datajoin U: hadoop-tools Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8088/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          For the reason, we can ignore the warning here. Could you update to create findbugs-exclude.xml?

          Thanks Tsuyoshi Ozawa for your reply. I'll update the patch to ignore the warnings.

          Show
          ajisakaa Akira Ajisaka added a comment - For the reason, we can ignore the warning here. Could you update to create findbugs-exclude.xml? Thanks Tsuyoshi Ozawa for your reply. I'll update the patch to ignore the warnings.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -
          the patch removes protected fields in abstract class 
          

          In this case, DataJoinMapperBase class is a public class which assumes to be extended. These fields are useful from MapReduce jobs, so we can say the warnings are false-positive. For the reason, we can ignore the warning here. Could you update to create findbugs-exclude.xml?

          Show
          ozawa Tsuyoshi Ozawa added a comment - the patch removes protected fields in abstract class In this case, DataJoinMapperBase class is a public class which assumes to be extended. These fields are useful from MapReduce jobs, so we can say the warnings are false-positive. For the reason, we can ignore the warning here. Could you update to create findbugs-exclude.xml?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Attaching a patch. This patch will fix the findbugs warnings, however, the patch removes protected fields in abstract class (The class is not annotated @Public or @Stable). Therefore if an user extends the class and relies on the fields, the user's application will fail.
          Would you tell me which way is better to do?

          • Fix the warnings by removing protected fields.
          • Ignore the warnings by creating findbugs-exclude.xml.
          Show
          ajisakaa Akira Ajisaka added a comment - Attaching a patch. This patch will fix the findbugs warnings, however, the patch removes protected fields in abstract class (The class is not annotated @Public or @Stable ). Therefore if an user extends the class and relies on the fields, the user's application will fail. Would you tell me which way is better to do? Fix the warnings by removing protected fields. Ignore the warnings by creating findbugs-exclude.xml.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Attaching the reports.

          Show
          ajisakaa Akira Ajisaka added a comment - Attaching the reports.

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development