Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12369

Point hadoop-project/pom.xml java.security.krb5.conf within target folder

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      This is used in the unit test environment, pointing within the src tree is naughty. The fix is simply to update to point within the target directory instead:

      -            <java.security.krb5.conf>${basedir}/src/test/resources/krb5.conf</java.security.krb5.conf>
      +            <java.security.krb5.conf>${test.cache.data}/krb5.conf</java.security.krb5.conf>
      

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2260 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2260/)
        HADOOP-12369. Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-project/pom.xml
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2260 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2260/ ) HADOOP-12369 . Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #321 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/321/)
        HADOOP-12369. Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #321 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/321/ ) HADOOP-12369 . Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2278 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2278/)
        HADOOP-12369. Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2278 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2278/ ) HADOOP-12369 . Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #329 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/329/)
        HADOOP-12369. Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #329 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/329/ ) HADOOP-12369 . Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #337 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/337/)
        HADOOP-12369. Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #337 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/337/ ) HADOOP-12369 . Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1064 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1064/)
        HADOOP-12369. Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc)

        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1064 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1064/ ) HADOOP-12369 . Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8381 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8381/)
        HADOOP-12369. Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8381 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8381/ ) HADOOP-12369 . Point hadoop-project/pom.xml java.security.krb5.conf within target folder. (wang: rev 0eb9b1932590ba6c60ac996d03269dffb4e095cc) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        andrew.wang Andrew Wang added a comment -

        thanks for reviewing Steve, committed to trunk and branch-2

        Show
        andrew.wang Andrew Wang added a comment - thanks for reviewing Steve, committed to trunk and branch-2
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1

        Show
        stevel@apache.org Steve Loughran added a comment - +1
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 7s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 38s There were no new javac warning messages.
        +1 javadoc 9m 51s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 yarn tests 0m 58s Tests passed in hadoop-yarn-registry.
            36m 1s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12753460/hadoop-12369.001.patch
        Optional Tests javadoc javac unit
        git revision trunk / 7ad3556
        hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7570/artifact/patchprocess/testrun_hadoop-yarn-registry.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7570/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7570/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 51s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 yarn tests 0m 58s Tests passed in hadoop-yarn-registry.     36m 1s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753460/hadoop-12369.001.patch Optional Tests javadoc javac unit git revision trunk / 7ad3556 hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7570/artifact/patchprocess/testrun_hadoop-yarn-registry.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7570/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7570/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Patch attached. Found the same issue in the yarn registry pom (it has quite some dupes with hadoop-project's pom for some reason) and fixed it there too.

        Ran a few assorted tests to get a feel, passed:

        -> % mvn test -Dtest=TestBlockToken,TestCredentials,TestAMRMTokens,TestRPC,TestWebHdfsUrl
        
        Show
        andrew.wang Andrew Wang added a comment - Patch attached. Found the same issue in the yarn registry pom (it has quite some dupes with hadoop-project's pom for some reason) and fixed it there too. Ran a few assorted tests to get a feel, passed: -> % mvn test -Dtest=TestBlockToken,TestCredentials,TestAMRMTokens,TestRPC,TestWebHdfsUrl

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development