Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12368

Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      These are test base classes that need to be subclassed to run, can mark as abstract.

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2255 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2255/)
        HADOOP-12368. Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2255 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2255/ ) HADOOP-12368 . Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #316 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/316/)
        HADOOP-12368. Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #316 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/316/ ) HADOOP-12368 . Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2274 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2274/)
        HADOOP-12368. Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2274 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2274/ ) HADOOP-12368 . Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #332 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/332/)
        HADOOP-12368. Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #332 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/332/ ) HADOOP-12368 . Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #325 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/325/)
        HADOOP-12368. Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #325 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/325/ ) HADOOP-12368 . Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1059 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1059/)
        HADOOP-12368. Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1059 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1059/ ) HADOOP-12368 . Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8376 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8376/)
        HADOOP-12368. Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8376 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8376/ ) HADOOP-12368 . Mark ViewFileSystemBaseTest and ViewFsBaseTest as abstract. (wang: rev 7ad3556ed38560585579172aa68356f37b2288c8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks Yi for reviewing, committed to trunk and branch-2.

        Show
        andrew.wang Andrew Wang added a comment - Thanks Yi for reviewing, committed to trunk and branch-2.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 7m 11s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 50s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 7s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 23m 1s Tests passed in hadoop-common.
            43m 24s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12753414/hdfs-8997.001.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 826ae1c
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12223/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12223/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12223/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 7m 11s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 7s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 1s Tests passed in hadoop-common.     43m 24s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753414/hdfs-8997.001.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 826ae1c hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12223/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12223/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12223/console This message was automatically generated.
        Hide
        hitliuyi Yi Liu added a comment -

        +1, pending Jenkins. Thanks Andrew.

        Show
        hitliuyi Yi Liu added a comment - +1, pending Jenkins. Thanks Andrew.
        Hide
        andrew.wang Andrew Wang added a comment -

        Trivial patch attached

        Show
        andrew.wang Andrew Wang added a comment - Trivial patch attached

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development