Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12367

Move TestFileUtil's test resources to resources folder

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Little cleanup. Right now we do an antrun step to copy the tar and tgz from the source folder to target folder. We can skip this by just putting it in the resources folder like all the other test resources.

      1. HADOOP-12367.001.patch
        13 kB
        Andrew Wang
      2. HADOOP-12367.002.patch
        14 kB
        Andrew Wang

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Patch attached, binary rename then removing the antrun step.

        Show
        andrew.wang Andrew Wang added a comment - Patch attached, binary rename then removing the antrun step.
        Hide
        hitliuyi Yi Liu added a comment -

        +1 pending Jenkins. Thanks for the cleanup.

        Show
        hitliuyi Yi Liu added a comment - +1 pending Jenkins. Thanks for the cleanup.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 23s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 54s There were no new javac warning messages.
        +1 javadoc 9m 57s There were no new javadoc warning messages.
        -1 release audit 0m 16s The applied patch generated 1 release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        -1 common tests 22m 12s Tests failed in hadoop-common.
            57m 52s  



        Reason Tests
        Failed unit tests hadoop.io.compress.TestCodec



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12753433/HADOOP-12367.001.patch
        Optional Tests javadoc javac unit
        git revision trunk / 7ad3556
        Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7566/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7566/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7566/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7566/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 23s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 9m 57s There were no new javadoc warning messages. -1 release audit 0m 16s The applied patch generated 1 release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 common tests 22m 12s Tests failed in hadoop-common.     57m 52s   Reason Tests Failed unit tests hadoop.io.compress.TestCodec Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753433/HADOOP-12367.001.patch Optional Tests javadoc javac unit git revision trunk / 7ad3556 Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7566/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7566/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7566/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7566/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        New patch attached, forgot to update the rat exclude. TestCodec also passed for me locally, Jenkins is still hung archiving the test results.

        Show
        andrew.wang Andrew Wang added a comment - New patch attached, forgot to update the rat exclude. TestCodec also passed for me locally, Jenkins is still hung archiving the test results.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 6s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 38s There were no new javac warning messages.
        +1 javadoc 9m 47s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 common tests 23m 5s Tests passed in hadoop-common.
            58m 2s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12753456/HADOOP-12367.002.patch
        Optional Tests javadoc javac unit
        git revision trunk / 7ad3556
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7568/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7568/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7568/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 6s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 common tests 23m 5s Tests passed in hadoop-common.     58m 2s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753456/HADOOP-12367.002.patch Optional Tests javadoc javac unit git revision trunk / 7ad3556 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7568/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7568/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7568/console This message was automatically generated.
        Hide
        hitliuyi Yi Liu added a comment -

        Committed to trunk and branch-2, thanks Andrew Wang.

        Show
        hitliuyi Yi Liu added a comment - Committed to trunk and branch-2, thanks Andrew Wang .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8377 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8377/)
        HADOOP-12367. Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8377 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8377/ ) HADOOP-12367 . Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #333 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/333/)
        HADOOP-12367. Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #333 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/333/ ) HADOOP-12367 . Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1060 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1060/)
        HADOOP-12367. Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229)

        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1060 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1060/ ) HADOOP-12367 . Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229) hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2256 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2256/)
        HADOOP-12367. Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229)

        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2256 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2256/ ) HADOOP-12367 . Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229) hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #326 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/326/)
        HADOOP-12367. Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229)

        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #326 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/326/ ) HADOOP-12367 . Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229) hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #317 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/317/)
        HADOOP-12367. Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #317 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/317/ ) HADOOP-12367 . Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2275 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2275/)
        HADOOP-12367. Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar
        • hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2275 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2275/ ) HADOOP-12367 . Move TestFileUtil's test resources to resources folder. (wang via yliu) (yliu: rev f4d96be6c637ff54903615cff04b365e25bb3229) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tar hadoop-common-project/hadoop-common/src/test/resources/test-untar.tar hadoop-common-project/hadoop-common/src/test/resources/test-untar.tgz hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/test-untar.tgz hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development