Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12362

Set hadoop.tmp.dir and hadoop.log.dir in pom

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      There are some compelling features in later version of surefire which lets one exclude/include tests based the content of a file, re-running of test case etc.

      However introduced in Surefire 2.18 is also https://issues.apache.org/jira/browse/SUREFIRE-649. Which changed the convention of null properties to empty string values (""). This only applies to forked tests such as the MapReduce tests and cause a couple of them to fail because of functionality that is directly or indirectly dependent on the value being null. One such example is Configuration.substituteVars() and TaskLog.getBaseLogDir().

      substituteVars() shows the issue when the getProperty returns empty String, skipping the getRaw(var) expression. One way to work around this could be

       
         if (val == null || val.isEmpty()) {
              String raw = getRaw(var);
              if (raw != null) {
                // raw contains a value, otherwise default to whatever System.getProperty returned
                // since it could be an empty string
                val = raw;
              }
            }
      

      getBaseLogDir, similarly when returns an empty string the schematics of java.io.File differs dependent on whether parent is null or "". A null value is interpreted as new File(file); whereas "" will be interpreted as new File(defaultParent /* / */, file);

      This could simply be addressed with

        static String getBaseLogDir() {
          String logDir = System.getProperty("hadoop.log.dir");
          // there is a difference how null and "" is treated as a parent
          // directory when creating a file
          return logDir == null || logDir.isEmpty() ? null : logDir;
        }
      
      1. mr-6455.4.patch
        2 kB
        Charlie Helin
      2. mr-6455.3.patch
        2 kB
        Charlie Helin
      3. mr-6455.2.patch
        2 kB
        Charlie Helin
      4. mr-6455.2.patch
        2 kB
        Karthik Kambatla
      5. mr-6455.1.patch
        2 kB
        Charlie Helin

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2242 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2242/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-project/pom.xml
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2242 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2242/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2242 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2242/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-project/pom.xml
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2242 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2242/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2261 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2261/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2261 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2261/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2261 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2261/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2261 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2261/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #304 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/304/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #304 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/304/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #304 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/304/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #304 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/304/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #312 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/312/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #312 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/312/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #312 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/312/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #312 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/312/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1045 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1045/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1045 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1045/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1045 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1045/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1045 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1045/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #317 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/317/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #317 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/317/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #317 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/317/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #317 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/317/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8357 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8357/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8357 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8357/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-project/pom.xml
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8357 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8357/)
        HADOOP-12362. Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml
        • hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8357 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8357/ ) HADOOP-12362 . Set hadoop.tmp.dir and hadoop.log.dir in pom. Contributed by Charlie Helin. (wang: rev 90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/pom.xml hadoop-project/pom.xml
        Hide
        andrew.wang Andrew Wang added a comment -

        Reverted trunk commit and committed the new fix to trunk and branch-2. Glad we found a compatible solution, thx for digging in deeper like this Charlie.

        Show
        andrew.wang Andrew Wang added a comment - Reverted trunk commit and committed the new fix to trunk and branch-2. Glad we found a compatible solution, thx for digging in deeper like this Charlie.
        Hide
        andrew.wang Andrew Wang added a comment -

        LGTM! Thanks Charlie, I'll revert the original and commit this one down.

        Show
        andrew.wang Andrew Wang added a comment - LGTM! Thanks Charlie, I'll revert the original and commit this one down.
        Hide
        chelin Charlie Helin added a comment -

        Andrew Wang How about now?

        Show
        chelin Charlie Helin added a comment - Andrew Wang How about now?
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 18s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 42s There were no new javac warning messages.
        +1 javadoc 9m 49s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 yarn tests 0m 58s Tests passed in hadoop-yarn-registry.
            36m 15s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12752746/mr-6455.4.patch
        Optional Tests javadoc javac unit
        git revision trunk / 0bf2854
        hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5958/artifact/patchprocess/testrun_hadoop-yarn-registry.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5958/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5958/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 18s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 49s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 yarn tests 0m 58s Tests passed in hadoop-yarn-registry.     36m 15s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752746/mr-6455.4.patch Optional Tests javadoc javac unit git revision trunk / 0bf2854 hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5958/artifact/patchprocess/testrun_hadoop-yarn-registry.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5958/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5958/console This message was automatically generated.
        Hide
        chelin Charlie Helin added a comment -

        Yeah the fixes to the POM appears to do the trick.

        Ahh, yes fixing!

        Show
        chelin Charlie Helin added a comment - Yeah the fixes to the POM appears to do the trick. Ahh, yes fixing!
        Hide
        andrew.wang Andrew Wang added a comment -

        Nice, this pom change fixes it? Only nit is that we should keep test.build.dir with its comment, broken by the reordering, i.e.:

        <!-- TODO: all references in testcases should be updated to this default -->
        <test.build.dir>${test.build.dir}</test.build.dir>
        
        Show
        andrew.wang Andrew Wang added a comment - Nice, this pom change fixes it? Only nit is that we should keep test.build.dir with its comment, broken by the reordering, i.e.: <!-- TODO: all references in testcases should be updated to this default --> <test.build.dir>${test.build.dir}</test.build.dir>
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 9s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 10m 37s There were no new javac warning messages.
        +1 javadoc 13m 8s There were no new javadoc warning messages.
        +1 release audit 0m 36s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 54s mvn install still works.
        +1 eclipse:eclipse 0m 47s The patch built with eclipse:eclipse.
        +1 yarn tests 1m 15s Tests passed in hadoop-yarn-registry.
            44m 30s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12752582/mr-6455.3.patch
        Optional Tests javadoc javac unit
        git revision trunk / c992bcf
        hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5956/artifact/patchprocess/testrun_hadoop-yarn-registry.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5956/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5956/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 10m 37s There were no new javac warning messages. +1 javadoc 13m 8s There were no new javadoc warning messages. +1 release audit 0m 36s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 54s mvn install still works. +1 eclipse:eclipse 0m 47s The patch built with eclipse:eclipse. +1 yarn tests 1m 15s Tests passed in hadoop-yarn-registry.     44m 30s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752582/mr-6455.3.patch Optional Tests javadoc javac unit git revision trunk / c992bcf hadoop-yarn-registry test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5956/artifact/patchprocess/testrun_hadoop-yarn-registry.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5956/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5956/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        I talked with Charlie Helin about this offline, seems pretty complex. Charlie's current thinking is that surefire is somehow passing some properties incorrectly when running in fork mode, leading to some expected variables like hadoop.log.dir being unset, and then us running into this surefire behavior change. That sounds like a more fundamental issue than null vs. "". The cleaner fix seems like setting these variables properly rather than relying on null/""/default parsing, and will avoid modifying non-test and non-pom code.

        Thanks again to Charlie Helin for the discussion and working on this issue.

        Show
        andrew.wang Andrew Wang added a comment - I talked with Charlie Helin about this offline, seems pretty complex. Charlie's current thinking is that surefire is somehow passing some properties incorrectly when running in fork mode, leading to some expected variables like hadoop.log.dir being unset, and then us running into this surefire behavior change. That sounds like a more fundamental issue than null vs. "" . The cleaner fix seems like setting these variables properly rather than relying on null/ "" /default parsing, and will avoid modifying non-test and non-pom code. Thanks again to Charlie Helin for the discussion and working on this issue.
        Hide
        chelin Charlie Helin added a comment -

        Andrew Wang So one of the changes in Surefire pertains to how it treat null value properties what it does is that it takes these system properties and turns them into empty strings.

        Allen Wittenauer I agree that there is a change in semantics, I was unable to figure out though how these were supposed to work in the case of substitueVars, as the documentation states:

        Value strings are first processed for variable expansion. The available properties are:

        1) Other properties defined in this Configuration; and, if a name is undefined here,
        2) Properties in System.getProperties().

        which appears to be completely reversed to how the current implementation actually works? As for the getBaseLogDir() the difference between null and "" is:

        • "" will be treated as the root of the filesystem, '/'
        • null will be treated as the current working directory
        Show
        chelin Charlie Helin added a comment - Andrew Wang So one of the changes in Surefire pertains to how it treat null value properties what it does is that it takes these system properties and turns them into empty strings. Allen Wittenauer I agree that there is a change in semantics, I was unable to figure out though how these were supposed to work in the case of substitueVars, as the documentation states: Value strings are first processed for variable expansion. The available properties are: 1) Other properties defined in this Configuration; and, if a name is undefined here, 2) Properties in System.getProperties(). which appears to be completely reversed to how the current implementation actually works? As for the getBaseLogDir() the difference between null and "" is: "" will be treated as the root of the filesystem, '/' null will be treated as the current working directory
        Hide
        andrew.wang Andrew Wang added a comment -

        Sorry if I'm missing something, but IIUC that surefire change affects parsing of java system properties when running a test. Why are the fixes happening in Configuration, vs. in a test class or the pom or something?

        Show
        andrew.wang Andrew Wang added a comment - Sorry if I'm missing something, but IIUC that surefire change affects parsing of java system properties when running a test. Why are the fixes happening in Configuration, vs. in a test class or the pom or something?
        Hide
        aw Allen Wittenauer added a comment -

        This appears to be a subtle change to the semantics of probably one of the most important APIs in Hadoop. I don't think it's a backward compatible change that can go into branch-2. So, at least for me, I'd be against it.

        Show
        aw Allen Wittenauer added a comment - This appears to be a subtle change to the semantics of probably one of the most important APIs in Hadoop. I don't think it's a backward compatible change that can go into branch-2. So, at least for me, I'd be against it.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2243 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2243/)
        MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2243 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2243/ ) MAPREDUCE-6455 . Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2224 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2224/)
        MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2224 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2224/ ) MAPREDUCE-6455 . Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018) hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #286 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/286/)
        MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #286 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/286/ ) MAPREDUCE-6455 . Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #298 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/298/)
        MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #298 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/298/ ) MAPREDUCE-6455 . Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #294 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/294/)
        MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #294 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/294/ ) MAPREDUCE-6455 . Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018) hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1027 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1027/)
        MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1027 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1027/ ) MAPREDUCE-6455 . Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8338 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8338/)
        MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8338 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8338/ ) MAPREDUCE-6455 . Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        kasha Karthik Kambatla added a comment -

        Patch looks good. Note that the behavior changes ever so slightly. Setting an empty value is the same as not setting the value at all. I feel that should be okay.

        +1. Checking this to trunk.

        I think we should get this to branch-2 as well, but will wait for more inputs. Allen Wittenauer, Andrew Wang - thoughts on inclusion in branch-2?

        Show
        kasha Karthik Kambatla added a comment - Patch looks good. Note that the behavior changes ever so slightly. Setting an empty value is the same as not setting the value at all. I feel that should be okay. +1. Checking this to trunk. I think we should get this to branch-2 as well, but will wait for more inputs. Allen Wittenauer , Andrew Wang - thoughts on inclusion in branch-2?
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 48s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 36s There were no new javac warning messages.
        +1 javadoc 9m 41s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 27s The applied patch generated 1 new checkstyle issues (total was 176, now 176).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 27s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 30s Tests passed in hadoop-common.
        +1 mapreduce tests 1m 47s Tests passed in hadoop-mapreduce-client-core.
            66m 58s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751354/mr-6455.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0bc15cb
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 48s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 27s The applied patch generated 1 new checkstyle issues (total was 176, now 176). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 30s Tests passed in hadoop-common. +1 mapreduce tests 1m 47s Tests passed in hadoop-mapreduce-client-core.     66m 58s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751354/mr-6455.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0bc15cb checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5946/console This message was automatically generated.
        Hide
        chelin Charlie Helin added a comment -

        On the TestNetUtils issue, this is an infrastructure issue where a hostname is resolved regardless if it exists on not. This is currently being looked at by Apache infra.

        Show
        chelin Charlie Helin added a comment - On the TestNetUtils issue, this is an infrastructure issue where a hostname is resolved regardless if it exists on not. This is currently being looked at by Apache infra.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 18s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 18s There were no new javac warning messages.
        +1 javadoc 10m 12s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 41s The applied patch generated 1 new checkstyle issues (total was 176, now 176).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 23m 37s Tests failed in hadoop-common.
        +1 mapreduce tests 1m 52s Tests passed in hadoop-mapreduce-client-core.
            71m 38s  



        Reason Tests
        Failed unit tests hadoop.net.TestNetUtils
          hadoop.ha.TestZKFailoverController



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751354/mr-6455.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4e14f79
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 18s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 18s There were no new javac warning messages. +1 javadoc 10m 12s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 41s The applied patch generated 1 new checkstyle issues (total was 176, now 176). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 23m 37s Tests failed in hadoop-common. +1 mapreduce tests 1m 52s Tests passed in hadoop-mapreduce-client-core.     71m 38s   Reason Tests Failed unit tests hadoop.net.TestNetUtils   hadoop.ha.TestZKFailoverController Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751354/mr-6455.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4e14f79 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5941/console This message was automatically generated.
        Hide
        kasha Karthik Kambatla added a comment -

        Re-uploading patch to kick Jenkins.

        Show
        kasha Karthik Kambatla added a comment - Re-uploading patch to kick Jenkins.
        Hide
        chelin Charlie Helin added a comment -

        Build error due to Jenkins running low on resources.

        Show
        chelin Charlie Helin added a comment - Build error due to Jenkins running low on resources.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 0m 48s trunk compilation may be broken.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 javac 0m 14s The patch appears to cause the build to fail.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751129/mr-6455.1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7ecbfd4
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5939/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 0m 48s trunk compilation may be broken. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac 0m 14s The patch appears to cause the build to fail. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751129/mr-6455.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7ecbfd4 Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5939/console This message was automatically generated.
        Hide
        chelin Charlie Helin added a comment -

        Sure

        I've run the complete set of tests (mvn test) for MapReduce but also the Common, HDFS and Yarn, with both surefire 2.18.1 and 2.17 without any regressions between the two different versions.but also no regressions compared to the HEAD of trunk.

        Show
        chelin Charlie Helin added a comment - Sure I've run the complete set of tests (mvn test) for MapReduce but also the Common, HDFS and Yarn, with both surefire 2.18.1 and 2.17 without any regressions between the two different versions.but also no regressions compared to the HEAD of trunk.
        Hide
        kasha Karthik Kambatla added a comment -

        Charlie Helin - thanks for reporting and working on this. Could you comment on any testing done to verify the patch works?

        Show
        kasha Karthik Kambatla added a comment - Charlie Helin - thanks for reporting and working on this. Could you comment on any testing done to verify the patch works?
        Hide
        chelin Charlie Helin added a comment -

        Please review.

        I also would like to see this back ported to the 2.8.0 branch.

        Show
        chelin Charlie Helin added a comment - Please review. I also would like to see this back ported to the 2.8.0 branch.
        Hide
        chelin Charlie Helin added a comment -

        I'd be happy to work on this.

        Show
        chelin Charlie Helin added a comment - I'd be happy to work on this.

          People

          • Assignee:
            chelin Charlie Helin
            Reporter:
            chelin Charlie Helin
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development