[HADOOP-12316] Potential false-positive and false-negative in parsing TAP output

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: HADOOP-12111
• Fix Version/s: HADOOP-12111
• Component/s: yetus
• Assignee: Kengo Seki
• Reporter: Kengo Seki
• Created: 12/Aug/15 16:00
• Updated: 13/Aug/15 20:56
• Resolved: 13/Aug/15 20:35

Description

In tap.sh, TAP results are parsed as follows:

  filenames=$(find "${TAP_LOG_DIR}" -type f -exec "${GREP}" -l -E "not ok " {} \;)

But this regex seems to have the following problems:

1. According to the TAP specification, "ok" / "not ok" is only required in the test line and others are optional. So each line can be terminated with just "ok" or "not ok", without trailing spaces. In that case, the regex "not ok " will miss test failures.

2. TAP output can contain descriptions and diagnostics. If they contains the string "not ok ", a false-alarm will be raised.

They won't occur as far as we are using only bats, but considering supporting other test tools in the future, the regex should be replaced with "^not ok".