[HADOOP-12295] Improve NetworkTopology#InnerNode#remove logic

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Yi Liu
• Reporter: Yi Liu
• Created: 03/Aug/15 12:51
• Updated: 30/Aug/16 01:24
• Resolved: 13/Aug/15 08:52

Description

In NetworkTopology#InnerNode#remove, We can use childrenMap to get the parent node, no need to loop the children list. Then it is more efficient since in most cases deleting parent node doesn't happen.
Another nit in current code is:

  String parent = n.getNetworkLocation();
  String currentPath = getPath(this);

can be in closure of !isAncestor(n)