Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.8.0, 3.0.0-alpha1
-
Component/s: test
-
Labels:None
-
Target Version/s:
-
Hadoop Flags:Reviewed
Description
3 tests in TestSequenceFileAppend require native library.
Issue Links
- is related to
-
HADOOP-12200
TestCryptoStreamsWithOpensslAesCtrCryptoCodec should be skipped in non-native profile
-
- Resolved
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
 +1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | pre-patch | 7m 0s | Pre-patch trunk compilation is healthy. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 3 new or modified test files. |
| +1 | javac | 7m 34s | There were no new javac warning messages. |
| +1 | release audit | 0m 20s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 1m 7s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 21s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 1m 49s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | common tests | 22m 17s | Tests passed in hadoop-common. |
| 42m 3s |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12745579/HADOOP-12240.001.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / 111e6a3 |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7290/artifact/patchprocess/testrun_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7290/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7290/console |
This message was automatically generated.
+1
Committed this to trunk and branch-2, thanks Masatake Iwasaki for your contribution.
FAILURE: Integrated in Hadoop-trunk-Commit #8172 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8172/)
HADOOP-12240. Fix tests requiring native library to be skipped in non-native profile. Contributed by Masatake Iwasaki. (ozawa: rev 90bda9c6110f0344104b8ae96ea6999770ebb391)
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
- hadoop-common-project/hadoop-common/CHANGES.txt
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestCryptoStreamsWithOpensslAesCtrCryptoCodec.java
SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #258 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/258/)
HADOOP-12240. Fix tests requiring native library to be skipped in non-native profile. Contributed by Masatake Iwasaki. (ozawa: rev 90bda9c6110f0344104b8ae96ea6999770ebb391)
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
- hadoop-common-project/hadoop-common/CHANGES.txt
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestCryptoStreamsWithOpensslAesCtrCryptoCodec.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
SUCCESS: Integrated in Hadoop-Yarn-trunk #988 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/988/)
HADOOP-12240. Fix tests requiring native library to be skipped in non-native profile. Contributed by Masatake Iwasaki. (ozawa: rev 90bda9c6110f0344104b8ae96ea6999770ebb391)
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestCryptoStreamsWithOpensslAesCtrCryptoCodec.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
- hadoop-common-project/hadoop-common/CHANGES.txt
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
ABORTED: Integrated in Hadoop-Hdfs-trunk #2185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2185/)
HADOOP-12240. Fix tests requiring native library to be skipped in non-native profile. Contributed by Masatake Iwasaki. (ozawa: rev 90bda9c6110f0344104b8ae96ea6999770ebb391)
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestCryptoStreamsWithOpensslAesCtrCryptoCodec.java
- hadoop-common-project/hadoop-common/CHANGES.txt
ABORTED: Integrated in Hadoop-Mapreduce-trunk #2204 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2204/)
HADOOP-12240. Fix tests requiring native library to be skipped in non-native profile. Contributed by Masatake Iwasaki. (ozawa: rev 90bda9c6110f0344104b8ae96ea6999770ebb391)
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestCryptoStreamsWithOpensslAesCtrCryptoCodec.java
- hadoop-common-project/hadoop-common/CHANGES.txt
ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #246 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/246/)
HADOOP-12240. Fix tests requiring native library to be skipped in non-native profile. Contributed by Masatake Iwasaki. (ozawa: rev 90bda9c6110f0344104b8ae96ea6999770ebb391)
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestCryptoStreamsWithOpensslAesCtrCryptoCodec.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
- hadoop-common-project/hadoop-common/CHANGES.txt
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/256/)
HADOOP-12240. Fix tests requiring native library to be skipped in non-native profile. Contributed by Masatake Iwasaki. (ozawa: rev 90bda9c6110f0344104b8ae96ea6999770ebb391)
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
- hadoop-common-project/hadoop-common/CHANGES.txt
- hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestCryptoStreamsWithOpensslAesCtrCryptoCodec.java
I'm a bit concerned about this change, since it seems to skip the tests whenever the native library can't be loaded. It would be better to check whether the native profile was activated in Maven directly in the test. We've had problems in the past where Jenkins has misplaced the native library and huge numbers of tests have been silently disabled, and it seems like with this patch, that could happen again.
Thanks for the comment, Colin P. McCabe.
It would be better to check whether the native profile was activated in Maven directly in the test
I filed HADOOP-12280.
Thanks, Masatake Iwasaki. That would be the best of both worlds.
Running org.apache.hadoop.io.TestSequenceFileAppend Tests run: 4, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 1.203 sec <<< FAILURE! - in org.apache.hadoop.io.TestSequenceFileAppend testAppendBlockCompression(org.apache.hadoop.io.TestSequenceFileAppend) Time elapsed: 0.118 sec <<< ERROR! java.lang.IllegalArgumentException: SequenceFile doesn't work with GzipCodec without native-hadoop code! at org.apache.hadoop.io.SequenceFile$Writer.<init>(SequenceFile.java:1152) at org.apache.hadoop.io.SequenceFile$BlockCompressWriter.<init>(SequenceFile.java:1511) at org.apache.hadoop.io.SequenceFile.createWriter(SequenceFile.java:277) at org.apache.hadoop.io.TestSequenceFileAppend.testAppendBlockCompression(TestSequenceFileAppend.java:182) testAppendSort(org.apache.hadoop.io.TestSequenceFileAppend) Time elapsed: 0.011 sec <<< ERROR! java.lang.IllegalArgumentException: SequenceFile doesn't work with GzipCodec without native-hadoop code! at org.apache.hadoop.io.SequenceFile$Writer.<init>(SequenceFile.java:1152) at org.apache.hadoop.io.SequenceFile$BlockCompressWriter.<init>(SequenceFile.java:1511) at org.apache.hadoop.io.SequenceFile.createWriter(SequenceFile.java:277) at org.apache.hadoop.io.TestSequenceFileAppend.testAppendSort(TestSequenceFileAppend.java:261) testAppendRecordCompression(org.apache.hadoop.io.TestSequenceFileAppend) Time elapsed: 0.006 sec <<< ERROR! java.lang.IllegalArgumentException: SequenceFile doesn't work with GzipCodec without native-hadoop code! at org.apache.hadoop.io.SequenceFile$Writer.<init>(SequenceFile.java:1152) at org.apache.hadoop.io.SequenceFile$RecordCompressWriter.<init>(SequenceFile.java:1441) at org.apache.hadoop.io.SequenceFile.createWriter(SequenceFile.java:275) at org.apache.hadoop.io.TestSequenceFileAppend.testAppendRecordCompression(TestSequenceFileAppend.java:149)