Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12201

Add tracing to FileSystem#createFileSystem and Globber#glob

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Add tracing to FileSystem#createFileSystem and Glober#glob

      1. createfilesystem.png
        108 kB
        Colin P. McCabe
      2. HADOOP-12201.001.patch
        3 kB
        Colin P. McCabe
      3. HADOOP-12201.001-reupload.patch
        3 kB
        Colin P. McCabe

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Patch,LGTM +1 ( non-binding).

        Show
        brahmareddy Brahma Reddy Battula added a comment - Patch,LGTM +1 ( non-binding).
        Hide
        cmccabe Colin P. McCabe added a comment -

        Thanks, Brahma. createFileSystem generally happens only once and it seems to take a long time (about a second), so it seems like a great candidate for tracing. Globber#glob also can be time-consuming so there is value in tracing it. I've been looking at a lot of FsShell traces lately and this came out of that.

        Show
        cmccabe Colin P. McCabe added a comment - Thanks, Brahma. createFileSystem generally happens only once and it seems to take a long time (about a second), so it seems like a great candidate for tracing. Globber#glob also can be time-consuming so there is value in tracing it. I've been looking at a lot of FsShell traces lately and this came out of that.
        Hide
        hitliuyi Yi Liu added a comment -

        +1, thanks Colin.

        Show
        hitliuyi Yi Liu added a comment - +1, thanks Colin.
        Hide
        stack stack added a comment -

        +1

        I like the pretty picture Colin P. McCabe

        Show
        stack stack added a comment - +1 I like the pretty picture Colin P. McCabe
        Hide
        cmccabe Colin P. McCabe added a comment -

        re-uploading same patch to get a jenkins run.

        Show
        cmccabe Colin P. McCabe added a comment - re-uploading same patch to get a jenkins run.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 31s Pre-patch trunk compilation is healthy.
        +1 @author 0m 1s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 42s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 7s The applied patch generated 1 new checkstyle issues (total was 145, now 145).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 20s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 21s Tests passed in hadoop-common.
            61m 32s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744332/HADOOP-12201.001-reupload.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2e3d83f
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 31s Pre-patch trunk compilation is healthy. +1 @author 0m 1s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 7s The applied patch generated 1 new checkstyle issues (total was 145, now 145). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 21s Tests passed in hadoop-common.     61m 32s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744332/HADOOP-12201.001-reupload.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2e3d83f checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Thanks, guys.

        checkstyle issue is something we can't do anything about: ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:1: File length is 3,412 lines (max allowed is 2,000).

        Committed to 2.8.

        Show
        cmccabe Colin P. McCabe added a comment - Thanks, guys. checkstyle issue is something we can't do anything about: ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:1: File length is 3,412 lines (max allowed is 2,000). Committed to 2.8.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8136 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8136/)
        HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8136 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8136/ ) HADOOP-12201 . Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #251 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/251/)
        HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #251 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/251/ ) HADOOP-12201 . Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #981 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/981/)
        HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #981 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/981/ ) HADOOP-12201 . Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/239/)
        HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/239/ ) HADOOP-12201 . Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2178/)
        HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2178/ ) HADOOP-12201 . Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #249 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/249/)
        HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #249 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/249/ ) HADOOP-12201 . Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2197 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2197/)
        HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2197 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2197/ ) HADOOP-12201 . Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java

          People

          • Assignee:
            cmccabe Colin P. McCabe
            Reporter:
            cmccabe Colin P. McCabe
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development