Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12186

ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 2.7.2, 3.0.0-alpha1
    • Component/s: ha
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ActiveStandbyElector shouldn't call monitorLockNodeAsync before StatCallback for previous zkClient.exists is received.
      We saw RM shutdown because ActiveStandbyElector retrying monitorLockNodeAsync exceeded limit. The following is the logs.
      Based on the log, it looks like multiple monitorLockNodeAsync are called at the same time due to back-to-back SyncConnected event received.
      The current code doesn't prevent zkClient.exists from being called before AsyncCallback.StatCallback for previous zkClient.exists is received.
      So the retry for monitorLockNodeAsync doesn't work correctly sometimes.

      2015-07-01 19:24:12,806 INFO org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard from server in 6674ms for sessionid 0x14e47693cc20007, closing socket connection and attempting reconnect
      2015-07-01 19:24:12,919 INFO org.apache.hadoop.ha.ActiveStandbyElector: Session disconnected. Entering neutral mode...
      2015-07-01 19:24:14,704 INFO org.apache.zookeeper.ClientCnxn: Opening socket connection to server node-1.internal/192.168.123.3:2181. Will not attempt to authenticate using SASL (unknown error)
      2015-07-01 19:24:14,704 INFO org.apache.zookeeper.ClientCnxn: Socket connection established, initiating session, client: /192.168.123.3:43487, server: node-1.internal/192.168.123.3:2181
      2015-07-01 19:24:14,707 INFO org.apache.zookeeper.ClientCnxn: Session establishment complete on server node-1.internal/192.168.123.3:2181, sessionid = 0x14e47693cc20007, negotiated timeout = 10000
      2015-07-01 19:24:14,712 INFO org.apache.hadoop.ha.ActiveStandbyElector: Session connected.
      2015-07-01 19:24:21,374 INFO org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard from server in 6667ms for sessionid 0x14e47693cc20007, closing socket connection and attempting reconnect
      2015-07-01 19:24:21,477 INFO org.apache.hadoop.ha.ActiveStandbyElector: Session disconnected. Entering neutral mode...
      2015-07-01 19:24:22,640 INFO org.apache.zookeeper.ClientCnxn: Opening socket connection to server node-1.internal/192.168.123.3:2181. Will not attempt to authenticate using SASL (unknown error)
      2015-07-01 19:24:22,640 INFO org.apache.zookeeper.ClientCnxn: Socket connection established, initiating session, client: /192.168.123.3:43526, server: node-1.internal/192.168.123.3:2181
      2015-07-01 19:24:22,641 INFO org.apache.zookeeper.ClientCnxn: Session establishment complete on server node-1.internal/192.168.123.3:2181, sessionid = 0x14e47693cc20007, negotiated timeout = 10000
      2015-07-01 19:24:22,642 INFO org.apache.hadoop.ha.ActiveStandbyElector: Session connected.
      2015-07-01 19:24:29,310 INFO org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard from server in 6669ms for sessionid 0x14e47693cc20007, closing socket connection and attempting reconnect
      2015-07-01 19:24:29,413 INFO org.apache.hadoop.ha.ActiveStandbyElector: Session disconnected. Entering neutral mode...
      2015-07-01 19:24:30,738 INFO org.apache.zookeeper.ClientCnxn: Opening socket connection to server node-1.internal/192.168.123.3:2181. Will not attempt to authenticate using SASL (unknown error)
      2015-07-01 19:24:30,739 INFO org.apache.zookeeper.ClientCnxn: Socket connection established, initiating session, client: /192.168.123.3:43574, server: node-1.internal/192.168.123.3:2181
      2015-07-01 19:24:30,739 INFO org.apache.zookeeper.ClientCnxn: Session establishment complete on server node-1.internal/192.168.123.3:2181, sessionid = 0x14e47693cc20007, negotiated timeout = 10000
      2015-07-01 19:24:30,740 INFO org.apache.hadoop.ha.ActiveStandbyElector: Session connected.
      2015-07-01 19:24:37,409 INFO org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard from server in 6670ms for sessionid 0x14e47693cc20007, closing socket connection and attempting reconnect
      2015-07-01 19:24:37,512 INFO org.apache.hadoop.ha.ActiveStandbyElector: Session disconnected. Entering neutral mode...
      2015-07-01 19:24:38,979 INFO org.apache.zookeeper.ClientCnxn: Opening socket connection to server node-1.internal/192.168.123.3:2181. Will not attempt to authenticate using SASL (unknown error)
      2015-07-01 19:24:38,979 INFO org.apache.zookeeper.ClientCnxn: Socket connection established, initiating session, client: /192.168.123.3:43598, server: node-1.internal/192.168.123.3:2181
      2015-07-01 19:24:38,980 INFO org.apache.zookeeper.ClientCnxn: Session establishment complete on server node-1.internal/192.168.123.3:2181, sessionid = 0x14e47693cc20007, negotiated timeout = 10000
      2015-07-01 19:24:38,981 INFO org.apache.hadoop.ha.ActiveStandbyElector: Session connected.
      2015-07-01 19:24:45,649 INFO org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard from server in 6669ms for sessionid 0x14e47693cc20007, closing socket connection and attempting reconnect
      2015-07-01 19:24:45,752 FATAL org.apache.hadoop.ha.ActiveStandbyElector: Received stat error from Zookeeper. code:CONNECTIONLOSS. Not retrying further znode monitoring connection errors.
      2015-07-01 19:24:45,855 INFO org.apache.zookeeper.ZooKeeper: Session: 0x14e47693cc20007 closed
      2015-07-01 19:25:07,932 WARN org.apache.hadoop.ha.ActiveStandbyElector: Ignoring stale result from old client with sessionId 0x14e47693cc20007
      2015-07-01 19:25:07,932 FATAL org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: Received a org.apache.hadoop.yarn.server.resourcemanager.RMFatalEvent of type EMBEDDED_ELECTOR_FAILED. Cause:
      Received stat error from Zookeeper. code:CONNECTIONLOSS. Not retrying further znode monitoring connection errors.
      2015-07-01 19:25:07,932 WARN org.apache.hadoop.ha.ActiveStandbyElector: Ignoring stale result from old client with sessionId 0x14e47693cc20007
      2015-07-01 19:25:07,932 WARN org.apache.hadoop.ha.ActiveStandbyElector: Ignoring stale result from old client with sessionId 0x14e47693cc20007
      2015-07-01 19:25:07,933 WARN org.apache.hadoop.ha.ActiveStandbyElector: Ignoring stale result from old client with sessionId 0x14e47693cc20007
      2015-07-01 19:25:07,933 INFO org.apache.zookeeper.ClientCnxn: EventThread shut down
      2015-07-01 19:25:08,036 INFO org.apache.hadoop.util.ExitUtil: Exiting with status 1
      

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/238/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/238/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2177/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2177/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #980 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/980/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #980 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/980/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/250/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/250/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        zxu zhihai xu added a comment -

        thanks Vinayakumar B for the review and committing the patch!

        Show
        zxu zhihai xu added a comment - thanks Vinayakumar B for the review and committing the patch!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2195/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2195/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #247 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/247/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #247 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/247/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8124 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8124/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8124 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8124/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev e0febce0e74ec69597376774f771da46834c42b1) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        vinayrpet Vinayakumar B added a comment -

        merged to 2.7.2.

        Show
        vinayrpet Vinayakumar B added a comment - merged to 2.7.2.
        Hide
        vinayrpet Vinayakumar B added a comment -

        I will cherry-pick it to 2.7.2.
        Thanks Karthik Kambatla for the reminder.

        Show
        vinayrpet Vinayakumar B added a comment - I will cherry-pick it to 2.7.2. Thanks Karthik Kambatla for the reminder.
        Hide
        kasha Karthik Kambatla added a comment -

        Should we include this in 2.7.2 as well?

        Show
        kasha Karthik Kambatla added a comment - Should we include this in 2.7.2 as well?
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #236 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/236/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #236 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/236/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2175 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2175/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2175 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2175/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2194/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2194/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #246 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/246/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #246 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/246/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #248 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/248/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #248 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/248/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #978 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/978/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #978 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/978/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8115 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8115/)
        HADOOP-12186. ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8115 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8115/ ) HADOOP-12186 . ActiveStandbyElector shouldn't call monitorLockNodeAsync multiple times (Contributed by zhihai xu) (vinayakumarb: rev 233cab89adb6bae21d7e171f2af516b92266242c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2.
        Thanks for the contribution zhihai xu.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks for the contribution zhihai xu .
        Hide
        vinayrpet Vinayakumar B added a comment -

        Patch looks good to me.
        +1.
        Will commit soon.

        Show
        vinayrpet Vinayakumar B added a comment - Patch looks good to me. +1. Will commit soon.
        Hide
        zxu zhihai xu added a comment -

        The test failure(TestCallQueueManager) is due to an issue at CallQueueManager, I created HADOOP-12189 to fix this issue.

        Show
        zxu zhihai xu added a comment - The test failure(TestCallQueueManager) is due to an issue at CallQueueManager, I created HADOOP-12189 to fix this issue.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 46s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 41s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 7s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 21m 30s Tests failed in hadoop-common.
            61m 6s  



        Reason Tests
        Failed unit tests hadoop.ipc.TestCallQueueManager



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12743616/HADOOP-12186.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 688617d
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7150/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7150/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7150/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 46s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 7s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 21m 30s Tests failed in hadoop-common.     61m 6s   Reason Tests Failed unit tests hadoop.ipc.TestCallQueueManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743616/HADOOP-12186.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 688617d hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7150/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7150/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7150/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 17s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 32s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 3s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 21m 53s Tests passed in hadoop-common.
            60m 35s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12743613/HADOOP-12186.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 688617d
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7149/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7149/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7149/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 17s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 3s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 21m 53s Tests passed in hadoop-common.     60m 35s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743613/HADOOP-12186.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 688617d hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7149/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7149/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7149/console This message was automatically generated.
        Hide
        zxu zhihai xu added a comment -

        I attached a patch HADOOP-12186.000.patch which prevent zkClient.exists from being called before AsyncCallback.StatCallback for previous zkClient.exists is received.

        Show
        zxu zhihai xu added a comment - I attached a patch HADOOP-12186 .000.patch which prevent zkClient.exists from being called before AsyncCallback.StatCallback for previous zkClient.exists is received.

          People

          • Assignee:
            zxu zhihai xu
            Reporter:
            zxu zhihai xu
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development