Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12161

Add getStoragePolicy API to the FileSystem interface

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-8345 added FileSystem#getAllStoragePolicies and FileSystem#setStoragePolicy. Jira to

      1. Add a corresponding FileSystem#getStoragePolicy to query the storage policy for a given file/directory.
      2. Add corresponding implementation for HDFS i.e. DistributedFileSystem#getStoragePolicy.
      3. Update the FileSystem specification. This will require editing hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md.
      1. HADOOP-12161-001.patch
        5 kB
        Brahma Reddy Battula
      2. HADOOP-12161-002.patch
        13 kB
        Brahma Reddy Battula
      3. HADOOP-12161-003.patch
        13 kB
        Brahma Reddy Battula
      4. HADOOP-12161-004.patch
        14 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Arpit Agarwal thanks for reporting this jira.. Attached the patch to address the following.Kindly Review.

          Add a corresponding FileSystem#getStoragePolicy to query the storage policy for a given file/directory.
          Add corresponding implementation for HDFS i.e. DistributedFileSystem#getStoragePolicy.

          As we are planning all the filesystem specifications as part of HADOOP-12177,will raise seperate jira to following.please let me know your opinion..

          Update the FileSystem specification. This will require editing hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal thanks for reporting this jira.. Attached the patch to address the following.Kindly Review. Add a corresponding FileSystem#getStoragePolicy to query the storage policy for a given file/directory. Add corresponding implementation for HDFS i.e. DistributedFileSystem#getStoragePolicy. As we are planning all the filesystem specifications as part of HADOOP-12177 ,will raise seperate jira to following.please let me know your opinion.. Update the FileSystem specification. This will require editing hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 18m 45s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 43s The applied patch generated 1 new checkstyle issues (total was 140, now 140).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 21m 33s Tests failed in hadoop-common.
          -1 hdfs tests 160m 1s Tests failed in hadoop-hdfs.
              226m 18s  



          Reason Tests
          Failed unit tests hadoop.fs.TestFilterFileSystem
            hadoop.fs.TestHarFileSystem
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.server.namenode.ha.TestStandbyIsHot



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744520/HADOOP-12161-001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ac60483
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 45s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 43s The applied patch generated 1 new checkstyle issues (total was 140, now 140). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 21m 33s Tests failed in hadoop-common. -1 hdfs tests 160m 1s Tests failed in hadoop-hdfs.     226m 18s   Reason Tests Failed unit tests hadoop.fs.TestFilterFileSystem   hadoop.fs.TestHarFileSystem   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744520/HADOOP-12161-001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ac60483 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7211/console This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Hi Brahma, thanks for picking up this task.

          We should also make corresponding changes in AbstractFileSystem, FileContext, ViewFs to keep them in sync with FileSystem. You can take a look at HDFS-8345 as a guideline. Sorry I should have made it clearer in the description.

          I'll review the DistributedFileSystem implementation in your patch. +1 for updating FileSystem documentation in a separate patch.

          Show
          arpitagarwal Arpit Agarwal added a comment - Hi Brahma , thanks for picking up this task. We should also make corresponding changes in AbstractFileSystem, FileContext, ViewFs to keep them in sync with FileSystem. You can take a look at HDFS-8345 as a guideline. Sorry I should have made it clearer in the description. I'll review the DistributedFileSystem implementation in your patch. +1 for updating FileSystem documentation in a separate patch.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          We can just return the policy id and leave the translation to the client. This avoids a second RPC call for each file since the client can cache the policy suite. We also don't need to throw for BLOCK_STORAGE_POLICY_ID_UNSPECIFIED.

          Show
          arpitagarwal Arpit Agarwal added a comment - We can just return the policy id and leave the translation to the client. This avoids a second RPC call for each file since the client can cache the policy suite. We also don't need to throw for BLOCK_STORAGE_POLICY_ID_UNSPECIFIED .
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Arpit Agarwal thanks a lot for review.Even I thought of asking same,but I forgot to ping..Will update changes in AbstractFileSystem, FileContext, ViewFs to keep them in sync with FileSystem.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal thanks a lot for review.Even I thought of asking same,but I forgot to ping..Will update changes in AbstractFileSystem, FileContext, ViewFs to keep them in sync with FileSystem.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Arpit Agarwal thanks a lot for review..Updated patch,kindly review..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal thanks a lot for review..Updated patch,kindly review..
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for updating the patch Brahma Reddy Battula. The changes look good.

          Perhaps we can make the Javadoc little more descriptive since it may not be obvious what the byte return type means. e.g. Query the effective storage policy ID for the given file or directory. The storage policy ID to storage policy name mapping for the filesystem implementation can be retrieved using {@link #getAllStoragePolicies}

          +1 from me otherwise. Jing Zhao, do you have any comments on this API since you worked on the storage policy implementation? Thanks.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for updating the patch Brahma Reddy Battula . The changes look good. Perhaps we can make the Javadoc little more descriptive since it may not be obvious what the byte return type means. e.g. Query the effective storage policy ID for the given file or directory. The storage policy ID to storage policy name mapping for the filesystem implementation can be retrieved using {@link #getAllStoragePolicies} +1 from me otherwise. Jing Zhao , do you have any comments on this API since you worked on the storage policy implementation? Thanks.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for working on this, Brahma Reddy Battula. And thanks for the review, Arpit! So one question here is that the storage policy byte may be more like an internal implementation inside of HDFS. For other FileSystems, it is possible that they can use other types to indicate the policy or the id of the policy. So I think here maybe it's better to use BlockStoragePolicySpi as the return type.

          Show
          jingzhao Jing Zhao added a comment - Thanks for working on this, Brahma Reddy Battula . And thanks for the review, Arpit! So one question here is that the storage policy byte may be more like an internal implementation inside of HDFS. For other FileSystems, it is possible that they can use other types to indicate the policy or the id of the policy. So I think here maybe it's better to use BlockStoragePolicySpi as the return type.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for taking a look Jing Zhao. Good point, I just realized we are not exposing the storage policy IDs any where else publicly so it makes sense to return the BlockStoragePolicySpi object instead. We'd have to add a NameNode RPC call to return the policy object else we'd need two RPC calls per getStoragePolicy call.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for taking a look Jing Zhao . Good point, I just realized we are not exposing the storage policy IDs any where else publicly so it makes sense to return the BlockStoragePolicySpi object instead. We'd have to add a NameNode RPC call to return the policy object else we'd need two RPC calls per getStoragePolicy call.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 46s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 33s There were no new javac warning messages.
          -1 javadoc 9m 38s The applied patch generated 1 additional warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 42s The applied patch generated 3 new checkstyle issues (total was 284, now 285).
          -1 whitespace 0m 1s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 31s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 7s Tests passed in hadoop-common.
          -1 hdfs tests 160m 40s Tests failed in hadoop-hdfs.
              227m 34s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.server.namenode.ha.TestStandbyIsHot



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12745081/HADOOP-12161-002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 19295b3
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/diffJavadocWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/diffcheckstylehadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 46s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. -1 javadoc 9m 38s The applied patch generated 1 additional warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 42s The applied patch generated 3 new checkstyle issues (total was 284, now 285). -1 whitespace 0m 1s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 7s Tests passed in hadoop-common. -1 hdfs tests 160m 40s Tests failed in hadoop-hdfs.     227m 34s   Reason Tests Failed unit tests hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745081/HADOOP-12161-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 19295b3 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7264/console This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Jing Zhao and Arpit Agarwal thanks a lot for review.Updated the patch as per above comments.Now it's take two RPC calls and it is same as shell command..Kindly review.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Jing Zhao and Arpit Agarwal thanks a lot for review.Updated the patch as per above comments.Now it's take two RPC calls and it is same as shell command..Kindly review.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 11s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 40s There were no new javac warning messages.
          -1 javadoc 9m 42s The applied patch generated 1 additional warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 26s The applied patch generated 2 new checkstyle issues (total was 284, now 284).
          -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 31s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 4m 22s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 9s Tests passed in hadoop-common.
          -1 hdfs tests 172m 17s Tests failed in hadoop-hdfs.
              237m 35s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestBlockStoragePolicy
          Timed out tests org.apache.hadoop.hdfs.server.namenode.TestCheckpoint



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12745171/HADOOP-12161-003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / a431ed9
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/diffJavadocWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/diffcheckstylehadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 11s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. -1 javadoc 9m 42s The applied patch generated 1 additional warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 26s The applied patch generated 2 new checkstyle issues (total was 284, now 284). -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 4m 22s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 9s Tests passed in hadoop-common. -1 hdfs tests 172m 17s Tests failed in hadoop-hdfs.     237m 35s   Reason Tests Failed unit tests hadoop.hdfs.TestBlockStoragePolicy Timed out tests org.apache.hadoop.hdfs.server.namenode.TestCheckpoint Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745171/HADOOP-12161-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a431ed9 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7273/console This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks Brahma Reddy Battula for working on this.

          You might need to add actual implementation of AbstractFileSystem#getStoragePolicy(..) in Hdfs#getStoragePolicy(..), This is public API, FileContext will access in case of HDFS.

          Show
          vinayrpet Vinayakumar B added a comment - Thanks Brahma Reddy Battula for working on this. You might need to add actual implementation of AbstractFileSystem#getStoragePolicy(..) in Hdfs#getStoragePolicy(..) , This is public API, FileContext will access in case of HDFS.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Vinayakumar B thanks a lot for taking a look into this issue.Attached the patch to address your comments.. Kindly Review..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Vinayakumar B thanks a lot for taking a look into this issue.Attached the patch to address your comments.. Kindly Review..
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 19s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 36s There were no new javac warning messages.
          -1 javadoc 9m 41s The applied patch generated 1 additional warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 22s The applied patch generated 2 new checkstyle issues (total was 284, now 284).
          -1 whitespace 0m 1s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 10s Tests passed in hadoop-common.
          -1 hdfs tests 161m 30s Tests failed in hadoop-hdfs.
              226m 51s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
            hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746521/HADOOP-12161-004.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 4025326
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/diffJavadocWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/diffcheckstylehadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 19s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. -1 javadoc 9m 41s The applied patch generated 1 additional warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 22s The applied patch generated 2 new checkstyle issues (total was 284, now 284). -1 whitespace 0m 1s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 10s Tests passed in hadoop-common. -1 hdfs tests 161m 30s Tests failed in hadoop-hdfs.     226m 51s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746521/HADOOP-12161-004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4025326 javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7323/console This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment - - edited

          +1 for the v004 patch. I am still concerned about requiring two RPCs per call but I don't see an easy workaround. A mitigation could be for the DFSClient to cache the policies locally. I will delay committing until tomorrow in case Vinayakumar B/Jing Zhao have more comments.

          Thanks for your patience with this Brahma Reddy Battula.

          Show
          arpitagarwal Arpit Agarwal added a comment - - edited +1 for the v004 patch. I am still concerned about requiring two RPCs per call but I don't see an easy workaround. A mitigation could be for the DFSClient to cache the policies locally. I will delay committing until tomorrow in case Vinayakumar B / Jing Zhao have more comments. Thanks for your patience with this Brahma Reddy Battula .
          Hide
          vinayrpet Vinayakumar B added a comment -

          I am still concerned about requiring two RPCs per call but I don't see an easy workaround. A mitigation could be for the DFSClient to cache the policies locally

          This seems to be good. whether needs to update the cached policies periodically?
          How about adding a separate protocol method getStoragePolicy() in ClientProtocol similar to setStoragePolicy() dedicated for this purpose? I feel it just looks good to get in terms of code, since this is going to be a public API, and no. of RPCs will be 1.
          I feel this improvement could go in separate followup jira in HDFS, agree?

          If agree, I am also +1 for 004 patch.

          Show
          vinayrpet Vinayakumar B added a comment - I am still concerned about requiring two RPCs per call but I don't see an easy workaround. A mitigation could be for the DFSClient to cache the policies locally This seems to be good. whether needs to update the cached policies periodically? How about adding a separate protocol method getStoragePolicy() in ClientProtocol similar to setStoragePolicy() dedicated for this purpose? I feel it just looks good to get in terms of code, since this is going to be a public API, and no. of RPCs will be 1. I feel this improvement could go in separate followup jira in HDFS, agree? If agree, I am also +1 for 004 patch.
          Hide
          jingzhao Jing Zhao added a comment -

          Agree, we can do it in a followup jira. +1 for 004 patch.

          Show
          jingzhao Jing Zhao added a comment - Agree, we can do it in a followup jira. +1 for 004 patch.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          I committed it for 2.8.0.

          Thanks a lot for the reviews and feedback Jing and Vinayakumar. We can either cache policies on the client or add a new getStoragePolicy RPC to the NN as Vinayakumar suggested in a followup task.

          Show
          arpitagarwal Arpit Agarwal added a comment - I committed it for 2.8.0. Thanks a lot for the reviews and feedback Jing and Vinayakumar. We can either cache policies on the client or add a new getStoragePolicy RPC to the NN as Vinayakumar suggested in a followup task.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Filed HDFS-8815 for followup work. Documentation can be fixed as part of HADOOP-11981.

          Show
          arpitagarwal Arpit Agarwal added a comment - Filed HDFS-8815 for followup work. Documentation can be fixed as part of HADOOP-11981 .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8206 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8206/)
          HADOOP-12161. Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8206 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8206/ ) HADOOP-12161 . Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Arpit Agarwal thanks a lot for review and committing and thanks to Jing Zhao and Vinayakumar B for additional review.

          Agree to handle to follow up Jira . Will raise for same.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal thanks a lot for review and committing and thanks to Jing Zhao and Vinayakumar B for additional review. Agree to handle to follow up Jira . Will raise for same.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #996 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/996/)
          HADOOP-12161. Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #996 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/996/ ) HADOOP-12161 . Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/266/)
          HADOOP-12161. Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/266/ ) HADOOP-12161 . Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2193/)
          HADOOP-12161. Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2193/ ) HADOOP-12161 . Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #255 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/255/)
          HADOOP-12161. Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #255 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/255/ ) HADOOP-12161 . Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2212 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2212/)
          HADOOP-12161. Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2212 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2212/ ) HADOOP-12161 . Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/263/)
          HADOOP-12161. Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/263/ ) HADOOP-12161 . Add getStoragePolicy API to the FileSystem interface. (Contributed by Brahma Reddy Battula) (arp: rev adfa34ff9992295a6d2496b259d8c483ed90b566) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/Hdfs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFs.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              arpitagarwal Arpit Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development