Hadoop Common
  1. Hadoop Common
  2. HADOOP-1213

When RPC call fails then log call message detail

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.12.2
    • Fix Version/s: 0.13.0
    • Component/s: ipc
    • Labels:
      None

      Description

      When an RPC call fails, it would be helpful to have more information about the call. Currently, this is all I get.

      [junit] 2007-04-05 06:19:19,518 WARN ipc.Server (Server.java:run(594)) - handler output error
      [junit] java.nio.channels.ClosedChannelException
      [junit] at sun.nio.ch.SocketChannelImpl.ensureWriteOpen(SocketChannelImpl.java:125)
      [junit] at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:294)
      [junit] at org.apache.hadoop.ipc.SocketChannelOutputStream.flushBuffer(SocketChannelOutputStream.java:108)
      [junit] at org.apache.hadoop.ipc.SocketChannelOutputStream.write(SocketChannelOutputStream.java:89)
      [junit] at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:65)
      [junit] at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:123)
      [junit] at java.io.DataOutputStream.flush(DataOutputStream.java:106)
      [junit] at org.apache.hadoop.ipc.Server$Handler.run(Server.java:592)

        Activity

        Hide
        Hadoop QA added a comment -
        Show
        Hadoop QA added a comment - Integrated in Hadoop-Nightly #55 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/55/ )
        Hide
        Doug Cutting added a comment -

        I just committed this.

        Show
        Doug Cutting added a comment - I just committed this.
        Hide
        Hadoop QA added a comment -
        Show
        Hadoop QA added a comment - +1 http://issues.apache.org/jira/secure/attachment/12355357/HADOOP-1213.patch applied and successfully tested against trunk revision r527632. Results are at http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/28/console
        Hide
        Doug Cutting added a comment -

        Nigel reviewed this and gave it a +1.

        Show
        Doug Cutting added a comment - Nigel reviewed this and gave it a +1.
        Hide
        Doug Cutting added a comment -

        Here's a patch that cleans up the messages logged by the IPC server's handler thread, so that both the handler's name and the call are consistently logged for this and other errors.

        Show
        Doug Cutting added a comment - Here's a patch that cleans up the messages logged by the IPC server's handler thread, so that both the handler's name and the call are consistently logged for this and other errors.

          People

          • Assignee:
            Doug Cutting
            Reporter:
            Nigel Daley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development