[HADOOP-12122] Fix Hadoop should avoid unsafe split and append on fields that might be IPv6 literals

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: HADOOP-11890
• Target Version/s: HADOOP-11890
• Assignee: Nemanja Matkovic
• Reporter: Nate Edel
• Created: 26/Jun/15 01:42
• Updated: 20/Oct/15 20:32
• Resolved: 20/Oct/15 20:32

Description

There are a fairly extensive number of locations found via code inspection which use unsafe methods of handling addresses in a dual-stack or IPv6-only world:

• splits on the first ":" assuming that delimits a host from a port
• produces a host port pair by appending :port blindly (Java prefers [ipv6]:port which is the standard for IPv6 URIs)
• depends on the behavior of InetSocketAddress.toString() which produces the above.

This patch fixes those metaphors that I can find above, and replaces calls to InetSocketAddress.toString() with a wrapper that properly brackets the IPv6 address if there is one.

Issue Links

• depends upon: HADOOP-12430 Fix HDFS client gets errors trying to to connect to IPv6 DataNode