+1 for the patch. I tested it on Windows. I have committed this to trunk and branch-2. Thank you for the contribution, Andrew.
I'm sorry for the delay. I ran into some problems with TestDatanodeLayoutUpgrade. Those problems turned out to be unrelated to this patch, so I filed a new patch on
HDFS-8554 to fix it.
I don't have a Windows dev environment.
All Apache committers have been offered a free MSDN license. The details are documented here.
After getting the free MSDN license, you can download the installation iso for Windows Server 2008 or 2010 and run it in a VirtualBox VM (or your hypervisor of choice). Instructions for setting up a Windows development environment have been in BUILDING.txt for a few years.
This would prevent situations where patches are blocked from getting committed while waiting for me or any other individual to test. I'm not sure if the MSDN license information is widely known, so I'll send a reminder on the dev mailing lists.