Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12054

RPC client should not retry for InvalidToken exceptions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      An InvalidToken exception is thrown for expired or cancelled tokens. An InvalidToken not wrapped in a RetriableException must be considered fatal by the retry proxies or clients will spam the service with failed connections. Depending on the context, a service may be degraded when spammed with thousands of connection failures.

      1. HADOOP-12054.01.patch
        5 kB
        Varun Saxena
      2. HADOOP-12054.02.patch
        6 kB
        Varun Saxena

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 21s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 30s There were no new javac warning messages.
          +1 javadoc 9m 41s There were no new javadoc warning messages.
          +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 4s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 36m 51s Tests failed in hadoop-common.
              75m 47s  



          Reason Tests
          Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken
          Timed out tests org.apache.hadoop.http.TestHttpCookieFlag



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12737025/HADOOP-12054.01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 03fb5c6
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 21s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 36m 51s Tests failed in hadoop-common.     75m 47s   Reason Tests Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken Timed out tests org.apache.hadoop.http.TestHttpCookieFlag Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12737025/HADOOP-12054.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 03fb5c6 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6897/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1

          test failures are HADOOP-11486 & something else with no IPC-related code

          Show
          stevel@apache.org Steve Loughran added a comment - +1 test failures are HADOOP-11486 & something else with no IPC-related code
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Hi Varun Saxena, thanks for taking this up.

          It looks like the new test case passes even after reverting the change to RetryPolicies.java. I did not spend any time debugging it though. Do you see the same?

          Show
          arpitagarwal Arpit Agarwal added a comment - Hi Varun Saxena , thanks for taking this up. It looks like the new test case passes even after reverting the change to RetryPolicies.java. I did not spend any time debugging it though. Do you see the same?
          Hide
          varun_saxena Varun Saxena added a comment -

          Yes you are correct. The test case would require some change. Will look into it.

          Show
          varun_saxena Varun Saxena added a comment - Yes you are correct. The test case would require some change. Will look into it.
          Hide
          varun_saxena Varun Saxena added a comment -

          Arpit Agarwal / Steve Loughran, fixed the test case. Kindly review.

          Show
          varun_saxena Varun Saxena added a comment - Arpit Agarwal / Steve Loughran , fixed the test case. Kindly review.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 20s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 javadoc 9m 36s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 4s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 19s Tests passed in hadoop-common.
              62m 8s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12737667/HADOOP-12054.02.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 9f6d678
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6924/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6924/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6924/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 20s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 19s Tests passed in hadoop-common.     62m 8s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12737667/HADOOP-12054.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 9f6d678 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6924/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6924/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6924/console This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 for the updated patch and test case. I will commit it shortly.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 for the updated patch and test case. I will commit it shortly.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Committed for 2.8.0.

          Thanks for the contribution Varun and thanks Steve for the code review.

          Show
          arpitagarwal Arpit Agarwal added a comment - Committed for 2.8.0. Thanks for the contribution Varun and thanks Steve for the code review.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          The Target Version was set to 2.7.1 but I am not sure this meets the bar.

          Daryn Sharp, if you think this needs to be in 2.7.1 let me know or feel free to cherry-pick. Thanks.

          Show
          arpitagarwal Arpit Agarwal added a comment - The Target Version was set to 2.7.1 but I am not sure this meets the bar. Daryn Sharp , if you think this needs to be in 2.7.1 let me know or feel free to cherry-pick. Thanks.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7991 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7991/)
          HADOOP-12054. RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7991 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7991/ ) HADOOP-12054 . RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #223 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/223/)
          HADOOP-12054. RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #223 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/223/ ) HADOOP-12054 . RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #953 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/953/)
          HADOOP-12054. RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #953 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/953/ ) HADOOP-12054 . RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          varun_saxena Varun Saxena added a comment -

          Thanks for the review and commit, Arpit Agarwal

          Show
          varun_saxena Varun Saxena added a comment - Thanks for the review and commit, Arpit Agarwal
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2151 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2151/)
          HADOOP-12054. RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2151 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2151/ ) HADOOP-12054 . RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #212 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/212/)
          HADOOP-12054. RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #212 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/212/ ) HADOOP-12054 . RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #221 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/221/)
          HADOOP-12054. RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #221 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/221/ ) HADOOP-12054 . RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2169 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2169/)
          HADOOP-12054. RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2169 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2169/ ) HADOOP-12054 . RPC client should not retry for InvalidToken exceptions. (Contributed by Varun Saxena) (arp: rev 84ba1a75b6bcd696dfc20aeabb6f19cb4eff6011) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java

            People

            • Assignee:
              varun_saxena Varun Saxena
              Reporter:
              daryn Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development