Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12043

Display warning if defaultFs is not set when running fs commands.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: fs
    • Labels:
      None
    • Target Version/s:

      Description

      Using LocalFileSystem is rarely the intention of running hadoop fs -ls.

      This JIRA proposes displaying a warning message if hadoop fs -ls is showing the local filesystem or using default fs.

      1. HDFS-8322.006.patch
        7 kB
        Lei (Eddy) Xu
      2. HDFS-8322.005.patch
        7 kB
        Lei (Eddy) Xu
      3. HDFS-8322.004.patch
        7 kB
        Lei (Eddy) Xu
      4. HDFS-8322.003.patch
        6 kB
        Lei (Eddy) Xu
      5. HDFS-8322.003.patch
        6 kB
        Lei (Eddy) Xu
      6. HDFS-8322.002.patch
        5 kB
        Lei (Eddy) Xu
      7. HDFS-8322.001.patch
        5 kB
        Lei (Eddy) Xu
      8. HDFS-8322.000.patch
        1 kB
        Lei (Eddy) Xu

        Activity

        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        The patch checks the file system from every expended arguments. If the file system LocalFileSystem, a warning message is printed:

        $ hdfs dfs -ls /
        Warning: running "hadoop fs -ls" on local file system: /
        Found 28 items
        drwx------   - root wheel        170 2014-08-13 22:21 /.Spotlight-V100
        d-wx-wx-wt   - root wheel         68 2014-08-15 23:21 /.Trashes
        drwxr-xr-x   - root wheel        136 2014-10-13 12:30 /System
        drwxr-xr-x   - root admin        204 2014-08-15 23:14 /Users
        ...
        drwxrwxrwt   - root wheel        442 2015-05-04 16:26 /tmp
        drwxr-xr-x   - root wheel        442 2015-02-03 12:27 /usr
        drwxr-xr-x   - root wheel        884 2015-03-16 14:43 /var
        
        Show
        eddyxu Lei (Eddy) Xu added a comment - The patch checks the file system from every expended arguments. If the file system LocalFileSystem , a warning message is printed: $ hdfs dfs -ls / Warning: running "hadoop fs -ls" on local file system: / Found 28 items drwx------ - root wheel 170 2014-08-13 22:21 /.Spotlight-V100 d-wx-wx-wt - root wheel 68 2014-08-15 23:21 /.Trashes drwxr-xr-x - root wheel 136 2014-10-13 12:30 / System drwxr-xr-x - root admin 204 2014-08-15 23:14 /Users ... drwxrwxrwt - root wheel 442 2015-05-04 16:26 /tmp drwxr-xr-x - root wheel 442 2015-02-03 12:27 /usr drwxr-xr-x - root wheel 884 2015-03-16 14:43 / var
        Hide
        aw Allen Wittenauer added a comment -

        The base assumption proposed in this JIRA is that the distributed file system in use is HDFS. If I'm using a distributed file system such as lustre or glustre or any number of other mountable distributed file systems, using hadoop fs -ls using LocalFileSystem is completely normal.

        So, -1 from me.

        Show
        aw Allen Wittenauer added a comment - The base assumption proposed in this JIRA is that the distributed file system in use is HDFS. If I'm using a distributed file system such as lustre or glustre or any number of other mountable distributed file systems, using hadoop fs -ls using LocalFileSystem is completely normal. So, -1 from me.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 54s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 34s There were no new javac warning messages.
        -1 javadoc 9m 47s The applied patch generated 62 additional warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 8s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        -1 findbugs 1m 44s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.
        +1 common tests 23m 49s Tests passed in hadoop-common.
            61m 34s  



        Reason Tests
        FindBugs module:hadoop-common
          Format string should use %n rather than n in org.apache.hadoop.fs.shell.Ls.processRawArguments(LinkedList) At Ls.java:rather than n in org.apache.hadoop.fs.shell.Ls.processRawArguments(LinkedList) At Ls.java:[line 135]



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730328/HDFS-8322.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 551615f
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/10801/artifact/patchprocess/diffJavadocWarnings.txt
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/10801/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10801/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10801/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10801/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 54s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 34s There were no new javac warning messages. -1 javadoc 9m 47s The applied patch generated 62 additional warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 8s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. -1 findbugs 1m 44s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 common tests 23m 49s Tests passed in hadoop-common.     61m 34s   Reason Tests FindBugs module:hadoop-common   Format string should use %n rather than n in org.apache.hadoop.fs.shell.Ls.processRawArguments(LinkedList) At Ls.java:rather than n in org.apache.hadoop.fs.shell.Ls.processRawArguments(LinkedList) At Ls.java: [line 135] Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730328/HDFS-8322.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 551615f javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/10801/artifact/patchprocess/diffJavadocWarnings.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/10801/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10801/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10801/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10801/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Eddy, if you really want to put this in, let's do it behind a configuration option which defaults to not printing.

        Show
        andrew.wang Andrew Wang added a comment - Eddy, if you really want to put this in, let's do it behind a configuration option which defaults to not printing.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks for suggestions, Allen Wittenauer and Andrew Wang. I closed this JIRA as wont fix.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks for suggestions, Allen Wittenauer and Andrew Wang . I closed this JIRA as wont fix.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Hey, Allen Wittenauer. We'd still like to have this warnings capability, as it is useful for some customers.
        Would you give a +0 if we display a warning behind an optional configuration, which disables the warnings by default, as Andrew Wang suggested.

        Looking forward to hear from you.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Hey, Allen Wittenauer . We'd still like to have this warnings capability, as it is useful for some customers. Would you give a +0 if we display a warning behind an optional configuration, which disables the warnings by default, as Andrew Wang suggested. Looking forward to hear from you.
        Hide
        aw Allen Wittenauer added a comment -

        Frankly, this seems like unnecessary complexity, but whatever. Yes, I'll +0 if you lock it behind a config option that defaults to off.

        Show
        aw Allen Wittenauer added a comment - Frankly, this seems like unnecessary complexity, but whatever. Yes, I'll +0 if you lock it behind a config option that defaults to off.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Re-open to put warnings behind an optional configuration.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Re-open to put warnings behind an optional configuration.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Updated the patch to add an optional configuration, to disable warnings message by default.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Updated the patch to add an optional configuration, to disable warnings message by default.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks a lot, Allen Wittenauer. I uploaded a new patch to address the concerns.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks a lot, Allen Wittenauer . I uploaded a new patch to address the concerns.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 57s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 42s There were no new javac warning messages.
        +1 javadoc 9m 53s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 6s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        -1 findbugs 1m 48s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 common tests 23m 36s Tests passed in hadoop-common.
            61m 32s  



        Reason Tests
        FindBugs module:hadoop-common
          Format string should use %n rather than n in org.apache.hadoop.fs.shell.Ls.processRawArguments(LinkedList) At Ls.java:rather than n in org.apache.hadoop.fs.shell.Ls.processRawArguments(LinkedList) At Ls.java:[line 162]



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735405/HDFS-8322.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / bb18163
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11139/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11139/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11139/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11139/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 57s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 53s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. -1 findbugs 1m 48s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 common tests 23m 36s Tests passed in hadoop-common.     61m 32s   Reason Tests FindBugs module:hadoop-common   Format string should use %n rather than n in org.apache.hadoop.fs.shell.Ls.processRawArguments(LinkedList) At Ls.java:rather than n in org.apache.hadoop.fs.shell.Ls.processRawArguments(LinkedList) At Ls.java: [line 162] Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735405/HDFS-8322.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / bb18163 Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11139/artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11139/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11139/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11139/console This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Update the patch to address findbug warnings.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Update the patch to address findbug warnings.
        Hide
        aw Allen Wittenauer added a comment -

        So question: why single out ls? Shouldn't this apply to all of the fs shell commands?

        Show
        aw Allen Wittenauer added a comment - So question: why single out ls? Shouldn't this apply to all of the fs shell commands?
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 31s There were no new javac warning messages.
        +1 javadoc 9m 32s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 5s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 53s Tests passed in hadoop-common.
            59m 47s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735654/HDFS-8322.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / ec0a852
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11141/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11141/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11141/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 31s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 5s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 53s Tests passed in hadoop-common.     59m 47s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735654/HDFS-8322.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ec0a852 hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11141/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11141/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11141/console This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Allen Wittenauer Thanks a lot for this great suggestion. I updated the patch to display such warnings for all commands except copy commands.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Allen Wittenauer Thanks a lot for this great suggestion. I updated the patch to display such warnings for all commands except copy commands.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Allen Wittenauer Thanks a lot for this great suggestion. I updated the patch to display such warnings for all commands except copy commands.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Allen Wittenauer Thanks a lot for this great suggestion. I updated the patch to display such warnings for all commands except copy commands.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Allen Wittenauer Thanks a lot for this great suggestion. I updated the patch to display such warnings for all commands except copy commands.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Allen Wittenauer Thanks a lot for this great suggestion. I updated the patch to display such warnings for all commands except copy commands.
        Hide
        andrew.wang Andrew Wang added a comment -

        Hi Eddy, taking a first look now. At a high-level, I think the issue we're trying to solve is users not having a defaultFS setup and then picking up the default value of

        {file:///}

        . I think we could do that check instead: if the user has or hasn't set a defaultFS, print a warning. You can get a configuration without defaults loaded and then do a get() to check this.

        Few nitty review comments, might not matter after fixing the above:

        • Need to document this config parameter in core-default.xml, turn the - into a . also
        • typo "Dose" -> "Does
        • the default value should end in _DEFAULT per convention
        Show
        andrew.wang Andrew Wang added a comment - Hi Eddy, taking a first look now. At a high-level, I think the issue we're trying to solve is users not having a defaultFS setup and then picking up the default value of {file:///} . I think we could do that check instead: if the user has or hasn't set a defaultFS, print a warning. You can get a configuration without defaults loaded and then do a get() to check this. Few nitty review comments, might not matter after fixing the above: Need to document this config parameter in core-default.xml, turn the - into a . also typo "Dose" -> "Does the default value should end in _DEFAULT per convention
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 24s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 6s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 22m 27s Tests failed in hadoop-common.
            61m 25s  



        Reason Tests
        Failed unit tests hadoop.fs.shell.TestLs



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735964/HDFS-8322.003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 9acd24f
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11156/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11156/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11156/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 24s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 22m 27s Tests failed in hadoop-common.     61m 25s   Reason Tests Failed unit tests hadoop.fs.shell.TestLs Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735964/HDFS-8322.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 9acd24f hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11156/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11156/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11156/console This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks a lot, Andrew Wang. It is a great suggestion. I have modified the patch to address your comments.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks a lot, Andrew Wang . It is a great suggestion. I have modified the patch to address your comments.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 35s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 46s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 13s The applied patch generated 1 new checkstyle issues (total was 190, now 191).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 23m 11s Tests failed in hadoop-common.
            62m 48s  



        Reason Tests
        Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736192/HDFS-8322.004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7817674
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11165/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11165/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11165/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11165/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 13s The applied patch generated 1 new checkstyle issues (total was 190, now 191). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 23m 11s Tests failed in hadoop-common.     62m 48s   Reason Tests Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736192/HDFS-8322.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7817674 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11165/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11165/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11165/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11165/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        I noticed you changed the name of the config parameter, and it's different in the code vs. core-default.xml. +1 pending fixing that though.

        Show
        andrew.wang Andrew Wang added a comment - I noticed you changed the name of the config parameter, and it's different in the code vs. core-default.xml. +1 pending fixing that though.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Address checkstyle warning.

        The test failure is not relevant.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Address checkstyle warning. The test failure is not relevant.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Good findings, Andrew Wang. Updated accordingly.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Good findings, Andrew Wang . Updated accordingly.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 29s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 9m 29s There were no new javac warning messages.
        +1 javadoc 11m 7s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 26s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 2m 7s mvn install still works.
        +1 eclipse:eclipse 0m 39s The patch built with eclipse:eclipse.
        +1 findbugs 3m 0s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 24m 41s Tests failed in hadoop-common.
            70m 29s  



        Reason Tests
        Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736262/HDFS-8322.006.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 3ae2a62
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11167/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11167/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11167/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 9m 29s There were no new javac warning messages. +1 javadoc 11m 7s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 26s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 2m 7s mvn install still works. +1 eclipse:eclipse 0m 39s The patch built with eclipse:eclipse. +1 findbugs 3m 0s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 24m 41s Tests failed in hadoop-common.     70m 29s   Reason Tests Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736262/HDFS-8322.006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3ae2a62 hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11167/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11167/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11167/console This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Andrew Wang I think TestWebDelegationToken is not relevant, I ran this test locally and successed.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Andrew Wang I think TestWebDelegationToken is not relevant, I ran this test locally and successed.
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to trunk and branch-2, thanks Eddy for the patch, Allen for reviewing too.

        Show
        andrew.wang Andrew Wang added a comment - Committed to trunk and branch-2, thanks Eddy for the patch, Allen for reviewing too.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks for reviews and suggestions, Andrew Wang and Allen Wittenauer

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks for reviews and suggestions, Andrew Wang and Allen Wittenauer
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7930 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7930/)
        HADOOP-12043. Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7930 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7930/ ) HADOOP-12043 . Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #943 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/943/)
        HADOOP-12043. Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420)

        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #943 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/943/ ) HADOOP-12043 . Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/213/)
        HADOOP-12043. Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/213/ ) HADOOP-12043 . Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2141/)
        HADOOP-12043. Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2141/ ) HADOOP-12043 . Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/202/)
        HADOOP-12043. Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420)

        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/202/ ) HADOOP-12043 . Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/211/)
        HADOOP-12043. Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/211/ ) HADOOP-12043 . Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2159/)
        HADOOP-12043. Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420)

        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2159/ ) HADOOP-12043 . Display warning if defaultFs is not set when running fs commands. Contributed by Eddy Xu. (wang: rev 374ddd9f9ea43b0e730a7baab3e51e6893d40420) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeysPublic.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestLs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/FsCommand.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
        Hide
        adamos94 joel belafa added a comment -

        Hi ,

        this message is a problem with automation tools (such as ansible ) as they are generally configured to retrieve (and fail finding) any messages in stderr.

        So could you please provide a way to disable these messages ?

        This is critical for us.

        Thanks

        Show
        adamos94 joel belafa added a comment - Hi , this message is a problem with automation tools (such as ansible ) as they are generally configured to retrieve (and fail finding) any messages in stderr. So could you please provide a way to disable these messages ? This is critical for us. Thanks
        Hide
        andrew.wang Andrew Wang added a comment -

        Hi Joel, this print is off by default, so it must have been turned on in your environment. Check this config key: hadoop.shell.missing.defaultFs.warning

        Show
        andrew.wang Andrew Wang added a comment - Hi Joel, this print is off by default, so it must have been turned on in your environment. Check this config key: hadoop.shell.missing.defaultFs.warning
        Hide
        fjk Kazuho Fujii added a comment -

        Hi,

        This function is useful. But, I think "fs.defaultFs" in the warning message should be the correct name "fs.defaultFS". A user who does not set fs.defaultFS property or mistypes the property name gets confused when seeing the message. At least I was misled.

        How do you think?

        Show
        fjk Kazuho Fujii added a comment - Hi, This function is useful. But, I think "fs.defaultFs" in the warning message should be the correct name "fs.defaultFS". A user who does not set fs.defaultFS property or mistypes the property name gets confused when seeing the message. At least I was misled. How do you think?
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for the find Kazuho Fujii, I filed HADOOP-12755 to fix the typo.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for the find Kazuho Fujii , I filed HADOOP-12755 to fix the typo.

          People

          • Assignee:
            eddyxu Lei (Eddy) Xu
            Reporter:
            eddyxu Lei (Eddy) Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development