[HADOOP-12018] smart-apply-patch.sh fails if the patch edits CR+LF files and is created by 'git diff --no-prefix'

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: build
• Hadoop Flags: Reviewed
• Assignee: Kengo Seki
• Reporter: Akira Ajisaka
• Created: 22/May/15 05:32
• Updated: 30/Aug/16 01:27
• Resolved: 04/Jun/15 02:17

Description

If the patch edits a file includes CR+LF and created by "git diff --no-prefix", smart-apply-patch.sh fails to patch. smart-apply-patch.sh checks if the patch is created by "git diff" or "patch", however, if a patch is created by "git diff --no-prefix", smart-apply-patch.sh detects the patch is created by "patch" command. That's why https://builds.apache.org/job/PreCommit-HADOOP-Build/6800/console fails.
A workaround is to use "git diff" for creating patch if a file includes CR+LF is edited.

Issue Links

• is blocked by: HADOOP-11991 test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified