Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12017

Hadoop archives command should use configurable replication factor when closing

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HadoopArchives#HArchivesReducer#close uses hard-coded replication factor. It should use repl instead, which is parsed from command line parameters.

            // try increasing the replication 
            fs.setReplication(index, (short) 5);
            fs.setReplication(masterIndex, (short) 5);
          }
      
      1. 0002-HADOOP-12017.patch
        4 kB
        Bibin A Chundatt
      2. 0003-HADOOP-12017.patch
        4 kB
        Bibin A Chundatt
      3. 0003-HADOOP-12017.patch
        4 kB
        Bibin A Chundatt
      4. 0004-HADOOP-12017.patch
        4 kB
        Bibin A Chundatt
      5. 0005-HADOOP-12017.patch
        6 kB
        Bibin A Chundatt
      6. 0006-HADOOP-12017.patch
        6 kB
        Bibin A Chundatt
      7. 0007-HADOOP-12017.patch
        6 kB
        Bibin A Chundatt
      8. 0008-HADOOP-12017.patch
        6 kB
        Bibin A Chundatt
      9. 0009-HADOOP-12017.patch
        7 kB
        Bibin A Chundatt
      10. 0010-HADOOP-12017.patch
        7 kB
        Bibin A Chundatt
      11. 0011-HADOOP-12017.patch
        7 kB
        Bibin A Chundatt
      12. 0012-HADOOP-12017.patch
        7 kB
        Bibin A Chundatt

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2210 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2210/)
          HADOOP-12017. Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b)

          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          • hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2210 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2210/ ) HADOOP-12017 . Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b) hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #261 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/261/)
          HADOOP-12017. Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
          • hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #261 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/261/ ) HADOOP-12017 . Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #253 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/253/)
          HADOOP-12017. Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b)

          • hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #253 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/253/ ) HADOOP-12017 . Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b) hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2191 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2191/)
          HADOOP-12017. Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b)

          • hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2191 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2191/ ) HADOOP-12017 . Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b) hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #264 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/264/)
          HADOOP-12017. Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
          • hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #264 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/264/ ) HADOOP-12017 . Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #994 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/994/)
          HADOOP-12017. Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          • hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #994 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/994/ ) HADOOP-12017 . Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          Hide
          zhz Zhe Zhang added a comment -

          Thanks Bibin for fixing the issue! Also thanks Vinay and Nicholas for the reviews.

          Show
          zhz Zhe Zhang added a comment - Thanks Bibin for fixing the issue! Also thanks Vinay and Nicholas for the reviews.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Thanks Tsz Wo Nicholas Sze , Vinayakumar B for review and commit.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Thanks Tsz Wo Nicholas Sze , Vinayakumar B for review and commit.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8199 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8199/)
          HADOOP-12017. Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
          • hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm
          • hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8199 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8199/ ) HADOOP-12017 . Hadoop archives command should use configurable replication factor when closing (Contributed by Bibin A Chundatt) (vinayakumarb: rev 94c6a4aa85e7d98e9b532b330f30783315f4334b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java hadoop-tools/hadoop-archives/src/site/markdown/HadoopArchives.md.vm hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
          Hide
          vinayrpet Vinayakumar B added a comment -

          Committed to trunk and branch-2.
          Thanks Zhe Zhang for reporting the issue.
          Thanks Bibin A Chundatt for the contribution
          Thanks Tsz Wo Nicholas Sze for reviews.

          Show
          vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks Zhe Zhang for reporting the issue. Thanks Bibin A Chundatt for the contribution Thanks Tsz Wo Nicholas Sze for reviews.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 24s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 37s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 59s Site still builds.
          +1 checkstyle 0m 19s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 findbugs 0m 41s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 52s Tests passed in hadoop-archives.
              43m 1s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746330/0012-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 3b7ffc4
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7315/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7315/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7315/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 24s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 2m 59s Site still builds. +1 checkstyle 0m 19s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 0m 41s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 52s Tests passed in hadoop-archives.     43m 1s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746330/0012-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 3b7ffc4 hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7315/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7315/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7315/console This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          > IMO, no need to change replication for srcFiles, ...

          This is a good idea. The -r option was newly added by HADOOP-11021. It seemed mistakenly changed the srcFiles replication to be configurable.

          +1 The new patch looks good. Thanks, Bibin and Vinay.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - > IMO, no need to change replication for srcFiles, ... This is a good idea. The -r option was newly added by HADOOP-11021 . It seemed mistakenly changed the srcFiles replication to be configurable. +1 The new patch looks good. Thanks, Bibin and Vinay.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Vinayakumar B Attaching patch again after updating document

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Vinayakumar B Attaching patch again after updating document
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 29s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 48s There were no new javac warning messages.
          +1 javadoc 9m 42s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 24s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 23s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 30s Tests passed in hadoop-common.
          +1 tools/hadoop tests 0m 52s Tests passed in hadoop-archives.
              64m 42s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746312/0010-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 29cf887b
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7312/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7312/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7312/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7312/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 24s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 23s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 30s Tests passed in hadoop-common. +1 tools/hadoop tests 0m 52s Tests passed in hadoop-archives.     64m 42s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746312/0010-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 29cf887b hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7312/artifact/patchprocess/testrun_hadoop-common.txt hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7312/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7312/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7312/console This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Sorry for bringing this late, document also needs update in the following line for Hadoop Archives page. Default replication needs to change as 3.

          -r indicates the desired replication factor; if this optional argument is not specified, a replication factor of 10 will be used.
          Show
          vinayrpet Vinayakumar B added a comment - Sorry for bringing this late, document also needs update in the following line for Hadoop Archives page. Default replication needs to change as 3. -r indicates the desired replication factor; if this optional argument is not specified, a replication factor of 10 will be used.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Vinayakumar B Sorry my mistake updated patch again

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Vinayakumar B Sorry my mistake updated patch again
          Hide
          vinayrpet Vinayakumar B added a comment -

          Hope VersionInfo.java change is not intended to add in this patch.

          Show
          vinayrpet Vinayakumar B added a comment - Hope VersionInfo.java change is not intended to add in this patch.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Shreyas Vinayakumar Whitespace shown not part of added line.
          Have updated patch again to avoid that too.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Shreyas Vinayakumar Whitespace shown not part of added line. Have updated patch again to avoid that too.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 33s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 3s There were no new javac warning messages.
          +1 javadoc 10m 4s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 21s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 21s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 53s Tests passed in hadoop-archives.
              38m 56s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746302/0009-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 87f29c6
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7311/artifact/patchprocess/whitespace.txt
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7311/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7311/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7311/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 3s There were no new javac warning messages. +1 javadoc 10m 4s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 21s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 53s Tests passed in hadoop-archives.     38m 56s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746302/0009-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 87f29c6 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7311/artifact/patchprocess/whitespace.txt hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7311/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7311/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7311/console This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Vinayakumar B Attached patch after rebasing.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Vinayakumar B Attached patch after rebasing.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Attaching patch after rebasing

          Show
          bibinchundatt Bibin A Chundatt added a comment - Attaching patch after rebasing
          Hide
          vinayrpet Vinayakumar B added a comment -

          Hi Bibin A Chundatt, since HADOOP-12214 is committed, you might need to rebase the patch.

          Show
          vinayrpet Vinayakumar B added a comment - Hi Bibin A Chundatt , since HADOOP-12214 is committed, you might need to rebase the patch.
          Hide
          vinayrpet Vinayakumar B added a comment -

          v08 patch looks good. +1.

          Hi Tsz Wo Nicholas Sze, You have any thoughts on latest patch.

          Will wait for a day before commit. Thanks

          Show
          vinayrpet Vinayakumar B added a comment - v08 patch looks good. +1. Hi Tsz Wo Nicholas Sze , You have any thoughts on latest patch. Will wait for a day before commit. Thanks
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Vinayakumar B please review patch attached

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Vinayakumar B please review patch attached
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Vinayakumar B updated patch as per your comments. please review

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Vinayakumar B updated patch as per your comments. please review
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 18s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 38s There were no new javac warning messages.
          +1 javadoc 9m 38s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 19s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 19s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.
              36m 46s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12745036/0008-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 19295b3
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7261/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7261/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7261/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 18s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 19s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 19s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.     36m 46s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745036/0008-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 19295b3 hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7261/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7261/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7261/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 28s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 41s There were no new javac warning messages.
          +1 javadoc 9m 44s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 20s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 22s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.
              37m 11s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12745034/0007-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 19295b3
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7260/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7260/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7260/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 20s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.     37m 11s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745034/0007-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 19295b3 hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7260/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7260/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7260/console This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Vinayakumar B updated patch as per your latest comments

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Vinayakumar B updated patch as per your latest comments
          Hide
          vinayrpet Vinayakumar B added a comment -

          Source changes looks good.
          Small nits in test.

          1. Remove unused imports
          2. + .numDataNodes(3) format this change properly.
          3. Use braces for if-block if (!next.getPath().toString().endsWith("_SUCCESS"))

          Show
          vinayrpet Vinayakumar B added a comment - Source changes looks good. Small nits in test. 1. Remove unused imports 2. + .numDataNodes(3) format this change properly. 3. Use braces for if-block if (!next.getPath().toString().endsWith("_SUCCESS"))
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Vinayakumar B as per our discussion have updated the patch . Please review .

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Vinayakumar B as per our discussion have updated the patch . Please review .
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 3s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 20s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 19s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.
              36m 25s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744881/0006-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1ea3629
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7243/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7243/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7243/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 3s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 20s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 19s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.     36m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744881/0006-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1ea3629 hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7243/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7243/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7243/console This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Fixed checkstyle. Please review patch attached.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Fixed checkstyle. Please review patch attached.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 12s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 34s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 21s The applied patch generated 1 new checkstyle issues (total was 78, now 79).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 18s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 41s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.
              36m 31s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744877/0005-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1ea3629
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7242/artifact/patchprocess/diffcheckstylehadoop-archives.txt
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7242/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7242/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7242/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 12s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 21s The applied patch generated 1 new checkstyle issues (total was 78, now 79). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 18s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 41s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.     36m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744877/0005-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1ea3629 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7242/artifact/patchprocess/diffcheckstylehadoop-archives.txt hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7242/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7242/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7242/console This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Vinayakumar B Have updated patch as per our discussion.
          Please review.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Vinayakumar B Have updated patch as per our discussion. Please review.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Vinayakumar B Thnk you for super quick reply. I agree to you completely. Lets wait for Tsz Wo Nicholas Sze opinion too.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Vinayakumar B Thnk you for super quick reply. I agree to you completely. Lets wait for Tsz Wo Nicholas Sze opinion too.
          Hide
          vinayrpet Vinayakumar B added a comment -

          parameter -sr for source file replication . Default value for both set as 3.

          IMO, no need to change replication for srcFiles, not even need to use repl, as this is intermediate file, Will be read only once and will be deleted after Job is complete.
          -r only can be used for all master,index,part as these are the files related to archive and will stay.

          Show
          vinayrpet Vinayakumar B added a comment - parameter -sr for source file replication . Default value for both set as 3. IMO, no need to change replication for srcFiles , not even need to use repl , as this is intermediate file, Will be read only once and will be deleted after Job is complete. -r only can be used for all master,index,part as these are the files related to archive and will stay.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Tsz Wo Nicholas Sze and Vinayakumar B thnks for review comments.

          The below are my understanding

          1. In Har filesystem for index and master we are currently using harcoded value 5.
          2. For Part files the replication value will be default 3 always rt?

          Wanted to make replication for part,index,masterindex to be configurable.The only parameter available
          for replication was -r. The same parameter used for srcfiles. I didn't want to add one more parameters.
          Thts the reason have used the same parameter for index and master.

          To implement patch

          option 1 could be define a new parameter.
          For part,master and index new parameter -hr short for har replication??

          Vinayakumar B sorry missed part files earlier will set replication for that too.About not setting replication for srcfiles
          But for source file and output files(part,index,master) if someone want to set different replication values?

          option 2 could be user defined replication -r for master,index,part
          and parameter -sr for source file replication . Default value for both set as 3.

          Tsz Wo Nicholas Sze and Vinayakumar B Does this sound good ?? Please correct me if i am wrong.
          My choice option 2

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Tsz Wo Nicholas Sze and Vinayakumar B thnks for review comments. The below are my understanding In Har filesystem for index and master we are currently using harcoded value 5. For Part files the replication value will be default 3 always rt? Wanted to make replication for part,index,masterindex to be configurable.The only parameter available for replication was -r . The same parameter used for srcfiles . I didn't want to add one more parameters. Thts the reason have used the same parameter for index and master. To implement patch option 1 could be define a new parameter. For part,master and index new parameter -hr short for har replication?? Vinayakumar B sorry missed part files earlier will set replication for that too.About not setting replication for srcfiles But for source file and output files(part,index,master) if someone want to set different replication values? option 2 could be user defined replication -r for master,index,part and parameter -sr for source file replication . Default value for both set as 3. Tsz Wo Nicholas Sze and Vinayakumar B Does this sound good ?? Please correct me if i am wrong. My choice option 2
          Hide
          vinayrpet Vinayakumar B added a comment -

          I understand that you want some way to set the replication of the index files. But why the source file replication factor and the destination index file replication factor have to be the same?

          jobfs.setReplication(srcFiles, repl);, The repl used to set the replication of srcFiles. But this srcFiles is not the actual source files which contains data, this is just an intermediate list of filestatuses, written as sequencefile, which will be read to generate the MR job splits, immediately after this file is created. First, HDFS will not have any time to replicate, second, there is no use of increasing the replication since it will be read in the same client and only once as part of split generation. Also srcFiles will be deleted once the Job is done.

          On the other hand, actual data files, which are created from mappers as part files, have the default replication. Still the proposed patch didn't change this. Need to change this these also.

          So, IMO, user specified 'replication' should be used for the resultant archive (both content and indexes), not for the intermediate file.
          Also, since default replication 10, is not really used, we can change this to default replication 3 itself. and update in docs also.

          Any thoughts?

          Show
          vinayrpet Vinayakumar B added a comment - I understand that you want some way to set the replication of the index files. But why the source file replication factor and the destination index file replication factor have to be the same? jobfs.setReplication(srcFiles, repl); , The repl used to set the replication of srcFiles . But this srcFiles is not the actual source files which contains data, this is just an intermediate list of filestatuses, written as sequencefile, which will be read to generate the MR job splits, immediately after this file is created. First, HDFS will not have any time to replicate, second, there is no use of increasing the replication since it will be read in the same client and only once as part of split generation. Also srcFiles will be deleted once the Job is done. On the other hand, actual data files, which are created from mappers as part files, have the default replication. Still the proposed patch didn't change this. Need to change this these also. So, IMO, user specified 'replication' should be used for the resultant archive (both content and indexes), not for the intermediate file. Also, since default replication 10, is not really used, we can change this to default replication 3 itself. and update in docs also. Any thoughts?
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          So dfs.replication from conf can we use? Tht is one option.Can we use for master and index. No need to be same.

          Show
          bibinchundatt Bibin A Chundatt added a comment - So dfs.replication from conf can we use? Tht is one option.Can we use for master and index. No need to be same.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment - - edited

          > ... because the value of 5 is hardcoded for master and index and we don’t have an option to change that.

          I understand that you want some way to set the replication of the index files. But why the source file replication factor and the destination index file replication factor have to be the same?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - - edited > ... because the value of 5 is hardcoded for master and index and we don’t have an option to change that. I understand that you want some way to set the replication of the index files. But why the source file replication factor and the destination index file replication factor have to be the same?
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Tsz Wo Nicholas Sze because the value of 5 is hardcoded for master and index and we don’t have an option to change that.
          So can we use dfs.replication to set the replication factor for Master and index files since we are running a job?? And also if "-r" argument is not given why for source file the replication factor is 10 ?

          Could you please provide what all values we can give for replication and finalize on the same.

          1. src_file=? dfs.replication or -r argument value
          2. master and index=? dfs.replication or -r argument value
          Show
          bibinchundatt Bibin A Chundatt added a comment - Tsz Wo Nicholas Sze because the value of 5 is hardcoded for master and index and we don’t have an option to change that. So can we use dfs.replication to set the replication factor for Master and index files since we are running a job?? And also if "-r" argument is not given why for source file the replication factor is 10 ? Could you please provide what all values we can give for replication and finalize on the same. src_file=? dfs.replication or -r argument value master and index=? dfs.replication or -r argument value
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          I still don't understand – why using source file replication factor to set index files?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - I still don't understand – why using source file replication factor to set index files?
          Hide
          vinayrpet Vinayakumar B added a comment -

          Hi, Tsz Wo Nicholas Sze. What you feel? Whether its okay to update the replication everywhere as 10 by default?
          Earlier masterIndex and index files were having 5, and src files were having 10 by default.

          Show
          vinayrpet Vinayakumar B added a comment - Hi, Tsz Wo Nicholas Sze . What you feel? Whether its okay to update the replication everywhere as 10 by default? Earlier masterIndex and index files were having 5, and src files were having 10 by default.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Vinayakumar B Thank you for review.

          In the default value for repl was 10 i made replication consistent with repl

            short repl = 10;
          

          Hope that is fine ? Or in all location will change the default to 5 .

          Show
          bibinchundatt Bibin A Chundatt added a comment - Vinayakumar B Thank you for review. In the default value for repl was 10 i made replication consistent with repl short repl = 10; Hope that is fine ? Or in all location will change the default to 5 .
          Hide
          vinayrpet Vinayakumar B added a comment -

          Just before committing, got this.

          After this change, masterIndex and index, by default will have replication of 10, earlier it was 5.
          Can we keep it back to 5 in reducer, only if '-r' not provided in args?

          Show
          vinayrpet Vinayakumar B added a comment - Just before committing, got this. After this change, masterIndex and index, by default will have replication of 10, earlier it was 5. Can we keep it back to 5 in reducer, only if '-r' not provided in args?
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 6s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 30s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 20s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.
              36m 42s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744178/0004-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / d632574
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7194/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7194/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7194/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 6s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 20s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 54s Tests passed in hadoop-archives.     36m 42s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744178/0004-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d632574 hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7194/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7194/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7194/console This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          HAR_REPLICATION_FACTOR is label to be used in job conf to get replication in reduces . i have renamed HAR_REPLICATION_FACTOR to HAR_REPLICATION_LABEL.

          Oh. Yes, I didnt realize that need to pass down repl to the reducer.
          Latest patch looks good. +1.
          Will commit soon.

          Show
          vinayrpet Vinayakumar B added a comment - HAR_REPLICATION_FACTOR is label to be used in job conf to get replication in reduces . i have renamed HAR_REPLICATION_FACTOR to HAR_REPLICATION_LABEL. Oh. Yes, I didnt realize that need to pass down repl to the reducer. Latest patch looks good. +1. Will commit soon.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 9s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 30s There were no new javac warning messages.
          +1 javadoc 9m 34s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 19s The applied patch generated 1 new checkstyle issues (total was 78, now 79).
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 58s Tests passed in hadoop-archives.
              36m 47s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744170/0003-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / d632574
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/artifact/patchprocess/diffcheckstylehadoop-archives.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/artifact/patchprocess/whitespace.txt
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 19s The applied patch generated 1 new checkstyle issues (total was 78, now 79). -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 58s Tests passed in hadoop-archives.     36m 47s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744170/0003-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d632574 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/artifact/patchprocess/diffcheckstylehadoop-archives.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/artifact/patchprocess/whitespace.txt hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7193/console This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          IMO there is no need of separate configuration HAR_REPLICATION_FACTOR

          HAR_REPLICATION_FACTOR is label to be used in job conf to get replication in reduces . i have renamed HAR_REPLICATION_FACTOR to HAR_REPLICATION_LABEL.

          In reducer any other provision is there to get replication passed in "-r "

          Same need to be used to set on index and masterIndex instead of hardcoded 5.

          Current patch i am setting the argument value passed in "-r 3" for master and index .

          Please do correct me if am wrong .Any more update required in patch ?

          Show
          bibinchundatt Bibin A Chundatt added a comment - IMO there is no need of separate configuration HAR_REPLICATION_FACTOR HAR_REPLICATION_FACTOR is label to be used in job conf to get replication in reduces . i have renamed HAR_REPLICATION_FACTOR to HAR_REPLICATION_LABEL . In reducer any other provision is there to get replication passed in "-r " Same need to be used to set on index and masterIndex instead of hardcoded 5. Current patch i am setting the argument value passed in "-r 3" for master and index . Please do correct me if am wrong .Any more update required in patch ?
          Hide
          vinayrpet Vinayakumar B added a comment -

          It seems that repl is for source files but not index files.

          As Tsz Wo Nicholas Sze pointed out, current repl=10 which is passed as "-r" "3" in args, is used to set the replication for source files.

          jobfs.setReplication(srcFiles, repl);

          Same need to be used to set on index and masterIndex instead of hardcoded 5.

          IMO there is no need of separate configuration HAR_REPLICATION_FACTOR

          Show
          vinayrpet Vinayakumar B added a comment - It seems that repl is for source files but not index files. As Tsz Wo Nicholas Sze pointed out, current repl=10 which is passed as "-r" "3" in args, is used to set the replication for source files. jobfs.setReplication(srcFiles, repl); Same need to be used to set on index and masterIndex instead of hardcoded 5. IMO there is no need of separate configuration HAR_REPLICATION_FACTOR
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Akira Ajisaka and Andrew Wang any comments on this issue

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Akira Ajisaka and Andrew Wang any comments on this issue
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Tsz Wo Nicholas Sze the below two i have handled in patch

          1. Argument for replication in test case was not passed correctly.
          2. All files including index and master index uses replication value passed

          The replication value as 5 i feel is definitely wrong .Either should be replication value passed as argument or default dfs.replication value currently i have used argument value passed

          Could you please check the current implementation is fine?

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Tsz Wo Nicholas Sze the below two i have handled in patch Argument for replication in test case was not passed correctly. All files including index and master index uses replication value passed The replication value as 5 i feel is definitely wrong .Either should be replication value passed as argument or default dfs.replication value currently i have used argument value passed Could you please check the current implementation is fine?
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Please review the patch attached.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Please review the patch attached.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 32s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 44s There were no new javac warning messages.
          +1 javadoc 9m 43s There were no new javadoc warning messages.
          +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 21s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 49s Tests passed in hadoop-archives.
              37m 16s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12743587/0003-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 2eae130
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7146/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7146/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7146/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 43s There were no new javadoc warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 21s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 49s Tests passed in hadoop-archives.     37m 16s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743587/0003-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2eae130 hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7146/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7146/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7146/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 23s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 37s There were no new javac warning messages.
          +1 javadoc 9m 45s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 18s The applied patch generated 1 new checkstyle issues (total was 78, now 79).
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 57s Tests passed in hadoop-archives.
              37m 11s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12743497/0002-HADOOP-12017.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 2eae130
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/artifact/patchprocess/diffcheckstylehadoop-archives.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/artifact/patchprocess/whitespace.txt
          hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/artifact/patchprocess/testrun_hadoop-archives.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 23s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 45s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 18s The applied patch generated 1 new checkstyle issues (total was 78, now 79). -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 57s Tests passed in hadoop-archives.     37m 11s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743497/0002-HADOOP-12017.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2eae130 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/artifact/patchprocess/diffcheckstylehadoop-archives.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/artifact/patchprocess/whitespace.txt hadoop-archives test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/artifact/patchprocess/testrun_hadoop-archives.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7141/console This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Zhe Zhang as discussed offline i would like to work on this issue. Please review the patch attached.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Zhe Zhang as discussed offline i would like to work on this issue. Please review the patch attached.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          It seems that repl is for source files but not index files.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - It seems that repl is for source files but not index files.

            People

            • Assignee:
              bibinchundatt Bibin A Chundatt
              Reporter:
              zhz Zhe Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development