[HADOOP-12002] test-patch.sh needs to verify all of the findbugs tools exist

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Won't Fix
• Component/s: build
• Labels: test-patch
• Assignee: Kengo Seki
• Reporter: Sidharta Seethana
• Created: 19/May/15 22:55
• Updated: 05/Nov/15 22:39
• Resolved: 05/Nov/15 22:39

Description

test-patch.sh was used with FINDBUGS_HOME set. See below for an example - there were 4 findbugs warnings generated - however, test-patch.sh doesn't seem to realize that there are missing findbugs tools and +1s the finbugs check.

Running findbugs in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
mvn clean test findbugs:findbugs -DskipTests -DhadoopPatchProcess > /private/tmp/hadoop-test-patch/71089/patchFindBugsOutputhadoop-yarn-server-nodemanager.txt 2>&1
<snip>hadoop/dev-support/test-patch.sh: line 1907: /usr/local/Cellar/findbugs/3.0.0/bin/setBugDatabaseInfo: No such file or directory
<snip>hadoop/dev-support/test-patch.sh: line 1915: /usr/local/Cellar/findbugs/3.0.0/bin/filterBugs: No such file or directory
Found Findbugs warnings (<snip>hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/findbugsXml.xml)
<snip>hadoop/dev-support/test-patch.sh: line 1921: /usr/local/Cellar/findbugs/3.0.0/bin/convertXmlToText: No such file or directory
[Mon May 18 18:08:52 PDT 2015 DEBUG]: Stop clock

Elapsed time: 0m 38s

Findbugs check reported as successful :

+1	findbugs	0m 38s	The patch does not introduce any
			new Findbugs (version 3.0.0)
			warnings.
		23m 51s