Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11983

HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:
      None
    • Target Version/s:

      Description

      The behavior of HADOOP_USER_CLASSPATH_FIRST works the opposite of what it should do. If it is not set, HADOOP_CLASSPATH is prepended. If set, it is appended.

      You can easily try out by doing something like

      HADOOP_CLASSPATH=/Users/alice/tmp hadoop classpath
      

      (HADOOP_CLASSPATH should point to an existing directory)

      I think the if clause in hadoop_add_to_classpath_userpath is reversed.

      This issue seems specific to the trunk.

        Activity

        Hide
        sjlee0 Sangjin Lee added a comment -

        Patch posted.

        Show
        sjlee0 Sangjin Lee added a comment - Patch posted.
        Hide
        sjlee0 Sangjin Lee added a comment -

        The Windows side seems fine (hadoop-config.cmd).

        Show
        sjlee0 Sangjin Lee added a comment - The Windows side seems fine (hadoop-config.cmd).
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
        +1 shellcheck 0m 4s There were no new shellcheck (v0.3.3) issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            0m 22s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12733278/HADOOP-11983.001.patch
        Optional Tests shellcheck
        git revision trunk / 8f37873
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6706/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. +1 shellcheck 0m 4s There were no new shellcheck (v0.3.3) issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733278/HADOOP-11983.001.patch Optional Tests shellcheck git revision trunk / 8f37873 Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6706/console This message was automatically generated.
        Hide
        rvs Roman Shaposhnik added a comment -

        This looks good to me. Allen Wittenauer WDYT?

        Show
        rvs Roman Shaposhnik added a comment - This looks good to me. Allen Wittenauer WDYT?
        Hide
        sjlee0 Sangjin Lee added a comment -

        Allen Wittenauer, could you take a quick look at it? Thanks!

        Show
        sjlee0 Sangjin Lee added a comment - Allen Wittenauer , could you take a quick look at it? Thanks!
        Hide
        aw Allen Wittenauer added a comment -

        +1 committed.

        thanks!

        Show
        aw Allen Wittenauer added a comment - +1 committed. thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7919 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7919/)
        HADOOP-11983. HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7)

        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7919 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7919/ ) HADOOP-11983 . HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/200/)
        HADOOP-11983. HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7)

        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/200/ ) HADOOP-11983 . HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #212 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/212/)
        HADOOP-11983. HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #212 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/212/ ) HADOOP-11983 . HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #942 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/942/)
        HADOOP-11983. HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #942 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/942/ ) HADOOP-11983 . HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2140 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2140/)
        HADOOP-11983. HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7)

        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2140 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2140/ ) HADOOP-11983 . HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/210/)
        HADOOP-11983. HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7)

        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/210/ ) HADOOP-11983 . HADOOP_USER_CLASSPATH_FIRST works the opposite of what it is supposed to do (Sangjin Lee via aw) (aw: rev 08ae87f6ba334bd3442234e65b93495fe312cbb7) hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            sjlee0 Sangjin Lee
            Reporter:
            sjlee0 Sangjin Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development