Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0, 2.3.0, 2.4.1, 2.5.2, 2.6.0, 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      This affects the JNI call to NativeIO_getMemlockLimit0.
      We can just return 0, as Windows does which also does not support this feature.

        Activity

        Hide
        alanburlison Alan Burlison added a comment -

        Patch attached

        Show
        alanburlison Alan Burlison added a comment - Patch attached
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 11s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 common tests 22m 17s Tests passed in hadoop-common.
            37m 30s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741632/HADOOP-11954.001.patch
        Optional Tests javac unit
        git revision trunk / 076948d
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7111/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7111/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7111/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 11s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 34s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 common tests 22m 17s Tests passed in hadoop-common.     37m 30s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741632/HADOOP-11954.001.patch Optional Tests javac unit git revision trunk / 076948d hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7111/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7111/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7111/console This message was automatically generated.
        Hide
        alanburlison Alan Burlison added a comment -

        Whilst returning 0 from NativeIO_getMemlockLimit0 may be OK on Windows as it doesn't support the mlock() syscall, it doesn't work on Solaris which supports the syscall but not the RLIMIT_MEMLOCK ulimit. On Solaris we should probably return MAXINT instead.

        Show
        alanburlison Alan Burlison added a comment - Whilst returning 0 from NativeIO_getMemlockLimit0 may be OK on Windows as it doesn't support the mlock() syscall, it doesn't work on Solaris which supports the syscall but not the RLIMIT_MEMLOCK ulimit. On Solaris we should probably return MAXINT instead.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 8s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 3m 24s trunk passed
        +1 compile 4m 24s trunk passed with JDK v1.8.0_60
        +1 compile 4m 10s trunk passed with JDK v1.7.0_79
        +1 mvneclipse 0m 15s trunk passed
        +1 mvninstall 1m 33s the patch passed
        +1 compile 4m 21s the patch passed with JDK v1.8.0_60
        +1 cc 4m 21s the patch passed
        +1 javac 4m 21s the patch passed
        +1 compile 4m 12s the patch passed with JDK v1.7.0_79
        +1 cc 4m 12s the patch passed
        +1 javac 4m 12s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.8.0_60.
        +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.7.0_79.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        38m 59s



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-05
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12741632/HADOOP-11954.001.patch
        JIRA Issue HADOOP-11954
        Optional Tests asflicense cc unit javac compile
        uname Linux 724d96493f14 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e8bd3ad/precommit/personality/hadoop.sh
        git revision trunk / ea5bb48
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8034/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 227MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8034/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 24s trunk passed +1 compile 4m 24s trunk passed with JDK v1.8.0_60 +1 compile 4m 10s trunk passed with JDK v1.7.0_79 +1 mvneclipse 0m 15s trunk passed +1 mvninstall 1m 33s the patch passed +1 compile 4m 21s the patch passed with JDK v1.8.0_60 +1 cc 4m 21s the patch passed +1 javac 4m 21s the patch passed +1 compile 4m 12s the patch passed with JDK v1.7.0_79 +1 cc 4m 12s the patch passed +1 javac 4m 12s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.8.0_60. +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 38m 59s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-05 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12741632/HADOOP-11954.001.patch JIRA Issue HADOOP-11954 Optional Tests asflicense cc unit javac compile uname Linux 724d96493f14 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-e8bd3ad/precommit/personality/hadoop.sh git revision trunk / ea5bb48 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8034/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8034/console This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        +1 committed

        thanks!

        Show
        aw Allen Wittenauer added a comment - +1 committed thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8880 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8880/)
        HADOOP-11954. Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c)

        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8880 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8880/ ) HADOOP-11954 . Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2658 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2658/)
        HADOOP-11954. Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c)

        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2658 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2658/ ) HADOOP-11954 . Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #727 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/727/)
        HADOOP-11954. Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #727 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/727/ ) HADOOP-11954 . Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #717 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/717/)
        HADOOP-11954. Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #717 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/717/ ) HADOOP-11954 . Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1450 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1450/)
        HADOOP-11954. Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1450 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1450/ ) HADOOP-11954 . Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #639 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/639/)
        HADOOP-11954. Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #639 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/639/ ) HADOOP-11954 . Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2576 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2576/)
        HADOOP-11954. Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2576 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2576/ ) HADOOP-11954 . Solaris does not support RLIMIT_MEMLOCK as in Linux (Alan (aw: rev e8a87d739f0ffa98fdf87d15440d1e2528080d0c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c

          People

          • Assignee:
            alanburlison Alan Burlison
            Reporter:
            malcolm kavalsky Malcolm Kavalsky
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development