Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11932

MetricsSinkAdapter hangs when being stopped

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      We've seen a situation that one RM hangs on stopping the MetricsSinkAdapter

      "main-EventThread" daemon prio=10 tid=0x00007f9b24031000 nid=0x2d18 in Object.wait() [0x00007f9afe7eb000]
         java.lang.Thread.State: WAITING (on object monitor)
              at java.lang.Object.wait(Native Method)
              - waiting on <0x00000000c058dcf8> (a org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1)
              at java.lang.Thread.join(Thread.java:1281)
              - locked <0x00000000c058dcf8> (a org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1)
              at java.lang.Thread.join(Thread.java:1355)
              at org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.stop(MetricsSinkAdapter.java:202)
              at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stopSinks(MetricsSystemImpl.java:472)
              - locked <0x00000000c04cc1a0> (a org.apache.hadoop.metrics2.impl.MetricsSystemImpl)
              at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stop(MetricsSystemImpl.java:213)
              - locked <0x00000000c04cc1a0> (a org.apache.hadoop.metrics2.impl.MetricsSystemImpl)
              at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.shutdown(MetricsSystemImpl.java:592)
              - locked <0x00000000c04cc1a0> (a org.apache.hadoop.metrics2.impl.MetricsSystemImpl)
              at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.shutdownInstance(DefaultMetricsSystem.java:72)
              at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.shutdown(DefaultMetricsSystem.java:68)
              at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceStop(ResourceManager.java:605)
              at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
              - locked <0x00000000c0503568> (a java.lang.Object)
              at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.stopActiveServices(ResourceManager.java:1024)
              at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.transitionToStandby(ResourceManager.java:1076)
              - locked <0x00000000c03fe3b8> (a org.apache.hadoop.yarn.server.resourcemanager.ResourceManager)
              at org.apache.hadoop.yarn.server.resourcemanager.AdminService.transitionToStandby(AdminService.java:322)
              - locked <0x00000000c0502b10> (a org.apache.hadoop.yarn.server.resourcemanager.AdminService)
              at org.apache.hadoop.yarn.server.resourcemanager.EmbeddedElectorService.becomeStandby(EmbeddedElectorService.java:135)
              at org.apache.hadoop.ha.ActiveStandbyElector.becomeStandby(ActiveStandbyElector.java:911)
              at org.apache.hadoop.ha.ActiveStandbyElector.processResult(ActiveStandbyElector.java:428)
              - locked <0x00000000c0718940> (a org.apache.hadoop.ha.ActiveStandbyElector)
              at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:605)
              at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
      
      "timeline" daemon prio=10 tid=0x00007f9b34d55000 nid=0x1d93 runnable [0x00007f9b0cbbf000]
         java.lang.Thread.State: RUNNABLE
              at java.net.SocketInputStream.socketRead0(Native Method)
              at java.net.SocketInputStream.read(SocketInputStream.java:152)
              at java.net.SocketInputStream.read(SocketInputStream.java:122)
              at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
              at java.io.BufferedInputStream.read(BufferedInputStream.java:254)
              - locked <0x00000000c0f522c8> (a java.io.BufferedInputStream)
              at org.apache.commons.httpclient.HttpParser.readRawLine(HttpParser.java:78)
              at org.apache.commons.httpclient.HttpParser.readLine(HttpParser.java:106)
              at org.apache.commons.httpclient.HttpConnection.readLine(HttpConnection.java:1116)
              at org.apache.commons.httpclient.HttpMethodBase.readStatusLine(HttpMethodBase.java:1973)
              at org.apache.commons.httpclient.HttpMethodBase.readResponse(HttpMethodBase.java:1735)
              at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1098)
              at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398)
              at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171)
              at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397)
              at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323)
              at org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:66)
              at org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:203)
              at org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:175)
              at org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
              at org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
              at org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:129)
              at org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)
      

      looks like the sinkThread.interrupt(); in MetricsSinkAdapter#stop doesn't really interrupt the thread, which cause it to hang at join.

      This appears only once.

      1. HADOOP-11932.branch-2.6.patch
        4 kB
        Akira Ajisaka
      2. HADOOP-11932.patch
        1 kB
        Brahma Reddy Battula
      3. HADOOP-11932.patch
        1 kB
        Brahma Reddy Battula
      4. HADOOP-11932-02.patch
        4 kB
        Brahma Reddy Battula
      5. HADOOP-11932-branch-2.patch
        1 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Jian He I would like to work on this.. I am not able to reproduce this .. can you please give scenario ..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Jian He I would like to work on this.. I am not able to reproduce this .. can you please give scenario ..?
        Hide
        jianhe Jian He added a comment -

        Brahma Reddy Battula, I'm also not able to repro.. I wondered if any other folks have seen this issue before.
        we found this while doing ambari integration testing. I added one more stack trace for the blocking thread in the description.

        Show
        jianhe Jian He added a comment - Brahma Reddy Battula , I'm also not able to repro.. I wondered if any other folks have seen this issue before. we found this while doing ambari integration testing. I added one more stack trace for the blocking thread in the description.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Very interesting bug!! Going back to Java basics, Thread.interrupt() does not guarentee the interrupt for running thread unless thread is waintig/sleeping for something.
        In this issue I think queue.consumeAll(this); processing something which never given chance to interrupt it.

        Just to reproduce this, small program wrote below code. If we run below code withoug commenting Thread.sleep, thread never get interrupted. Adding small sleep , result in thread get interrupted.

        package com.test.basic;
        
        public class Test1 {
          Thread sinkThread;
          private volatile boolean stopping = false;
        
          public void start() {
            sinkThread = new Thread() {
              public void run() {
                while (!stopping) {
                  try {
                    while (true) {
                      // Thread.sleep(1);
                    }
                  } catch (Exception e) {
                    System.out.println("Interuppted..");
                  }
                }
              };
            };
            sinkThread.setDaemon(true);
            sinkThread.start();
          }
        
          public void stop() {
            stopping = true;
            System.out.println("Interrupting.. ");
            sinkThread.interrupt();
            try {
              System.out.println("Joining.. ");
              sinkThread.join();
            } catch (InterruptedException e) {
              System.out.println("Stop interrupted " + e);
            }
            System.out.println("Stopped successfully");
          }
        
          public static void main(String[] args) throws InterruptedException {
            Test1 t1 = new Test1();
            t1.start();
            Thread.sleep(2000);
            t1.stop();
          }
        }
        
        Show
        rohithsharma Rohith Sharma K S added a comment - Very interesting bug!! Going back to Java basics, Thread.interrupt() does not guarentee the interrupt for running thread unless thread is waintig/sleeping for something. In this issue I think queue.consumeAll(this); processing something which never given chance to interrupt it. Just to reproduce this, small program wrote below code. If we run below code withoug commenting Thread.sleep, thread never get interrupted. Adding small sleep , result in thread get interrupted. package com.test.basic; public class Test1 { Thread sinkThread; private volatile boolean stopping = false ; public void start() { sinkThread = new Thread () { public void run() { while (!stopping) { try { while ( true ) { // Thread .sleep(1); } } catch (Exception e) { System .out.println( "Interuppted.." ); } } }; }; sinkThread.setDaemon( true ); sinkThread.start(); } public void stop() { stopping = true ; System .out.println( "Interrupting.. " ); sinkThread.interrupt(); try { System .out.println( "Joining.. " ); sinkThread.join(); } catch (InterruptedException e) { System .out.println( "Stop interrupted " + e); } System .out.println( "Stopped successfully" ); } public static void main( String [] args) throws InterruptedException { Test1 t1 = new Test1(); t1.start(); Thread .sleep(2000); t1.stop(); } }
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Done some more investigation on this modifying the above program that start ServerSocket. It is found that SocketInputStream.read() is NOT Interruptible!!

        package com.rohith;
        
        import java.io.DataInputStream;
        import java.io.IOException;
        import java.io.InputStream;
        import java.net.ServerSocket;
        import java.net.Socket;
        import java.net.UnknownHostException;
        
        public class Test {
          Thread sinkThread;
          Socket socket = null;
          InputStream in = null;
          private volatile boolean stopping = false;
        
          public void start() {
            sinkThread = new Thread() {
              public void run() {
        
                try {
                  socket = new Socket("localhost", 4444);
                } catch (UnknownHostException e2) {
                  e2.printStackTrace();
                } catch (IOException e2) {
                  e2.printStackTrace();
                }
        
        
                try {
                  in = socket.getInputStream();
                } catch (IOException e1) {
                  e1.printStackTrace();
                }
                while (!stopping) {
                  try {
                    System.out.println("in.read");
                    in.read();
                  } catch (IOException e) {
                    e.printStackTrace();
                  }
                }
              };
            };
            sinkThread.setDaemon(true);
            sinkThread.start();
          }
        
          public void stop() {
            stopping = true;
        
            try {
              socket.close();
            } catch (IOException e1) {
              e1.printStackTrace();
            }
        
            System.out.println("Interrupting.. ");
            System.out.println(sinkThread.getState());
            sinkThread.interrupt();
            try {
              System.out.println("Joining.. ");
              sinkThread.join();
            } catch (InterruptedException e) {
              System.out.println("Stop interrupted " + e);
            }
            System.out.println("Stopped successfully");
          }
        
          public static void main(String[] args) throws InterruptedException {
            try {
              ServerSocket ss = new ServerSocket(4444);
            } catch (IOException e) {
              e.printStackTrace();
            }
        
            System.out.println("Made socket, now reading from socket");
        
            Test t1 = new Test();
            t1.start();
            Thread.sleep(2000);
            t1.stop();
          }
        
        }
        
        Show
        rohithsharma Rohith Sharma K S added a comment - Done some more investigation on this modifying the above program that start ServerSocket. It is found that SocketInputStream.read() is NOT Interruptible!! package com.rohith; import java.io.DataInputStream; import java.io.IOException; import java.io.InputStream; import java.net.ServerSocket; import java.net.Socket; import java.net.UnknownHostException; public class Test { Thread sinkThread; Socket socket = null ; InputStream in = null ; private volatile boolean stopping = false ; public void start() { sinkThread = new Thread () { public void run() { try { socket = new Socket( "localhost" , 4444); } catch (UnknownHostException e2) { e2.printStackTrace(); } catch (IOException e2) { e2.printStackTrace(); } try { in = socket.getInputStream(); } catch (IOException e1) { e1.printStackTrace(); } while (!stopping) { try { System .out.println( "in.read" ); in.read(); } catch (IOException e) { e.printStackTrace(); } } }; }; sinkThread.setDaemon( true ); sinkThread.start(); } public void stop() { stopping = true ; try { socket.close(); } catch (IOException e1) { e1.printStackTrace(); } System .out.println( "Interrupting.. " ); System .out.println(sinkThread.getState()); sinkThread.interrupt(); try { System .out.println( "Joining.. " ); sinkThread.join(); } catch (InterruptedException e) { System .out.println( "Stop interrupted " + e); } System .out.println( "Stopped successfully" ); } public static void main( String [] args) throws InterruptedException { try { ServerSocket ss = new ServerSocket(4444); } catch (IOException e) { e.printStackTrace(); } System .out.println( "Made socket, now reading from socket" ); Test t1 = new Test(); t1.start(); Thread .sleep(2000); t1.stop(); } }
        Hide
        jianhe Jian He added a comment -

        Thanks Rohith Sharma K S for the investigation !

        Maybe in MetricsSinkAdapter#stop, we can do the IOUtils.cleanup first and then interrupt.

          void stop() {
            stopping = true;
            sinkThread.interrupt();
            try {
              sinkThread.join();
            } catch (InterruptedException e) {
              LOG.warn("Stop interrupted", e);
            }
            if (sink instanceof Closeable) {
              IOUtils.cleanup(LOG, (Closeable)sink);
            }
          }
        

        converting this to hadoop-common ticket

        Show
        jianhe Jian He added a comment - Thanks Rohith Sharma K S for the investigation ! Maybe in MetricsSinkAdapter#stop, we can do the IOUtils.cleanup first and then interrupt. void stop() { stopping = true ; sinkThread.interrupt(); try { sinkThread.join(); } catch (InterruptedException e) { LOG.warn( "Stop interrupted" , e); } if (sink instanceof Closeable) { IOUtils.cleanup(LOG, (Closeable)sink); } } converting this to hadoop-common ticket
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks a lot Rohith Sharma K S and Jian He for investigation on this issue...

        Maybe in MetricsSinkAdapter#stop, we can do the IOUtils.cleanup first and then interrupt.

        Moving IOUtils.cleanup before sinkThread.join(); , should be fine I think..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks a lot Rohith Sharma K S and Jian He for investigation on this issue... Maybe in MetricsSinkAdapter#stop, we can do the IOUtils.cleanup first and then interrupt. Moving IOUtils.cleanup before sinkThread.join(); , should be fine I think..
        Hide
        vinayrpet Vinayakumar B added a comment -

        It is found that SocketInputStream.read() is NOT Interruptible!!

        Right. Once the call comes out from this after closing socket, next call to sleep/wait will get interrupt signal.

        Show
        vinayrpet Vinayakumar B added a comment - It is found that SocketInputStream.read() is NOT Interruptible!! Right. Once the call comes out from this after closing socket, next call to sleep/wait will get interrupt signal.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731147/HADOOP-11932.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d335071
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6518/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731147/HADOOP-11932.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d335071 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6518/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731150/HADOOP-11932-branch-2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d335071
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6520/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731150/HADOOP-11932-branch-2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d335071 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6520/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 35s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 5s There were no new checkstyle issues.
        -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 41s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 23m 59s Tests passed in hadoop-common.
            60m 58s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731158/HADOOP-11932.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d335071
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6521/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6521/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6521/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6521/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 5s There were no new checkstyle issues. -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 41s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 59s Tests passed in hadoop-common.     60m 58s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731158/HADOOP-11932.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d335071 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6521/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6521/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6521/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6521/console This message was automatically generated.
        Hide
        jianhe Jian He added a comment -

        Brahma Reddy Battula, thanks for the patch !
        Do you think we can have a test case to prove this ?
        In the TestMetricsSystemImpl.java, there are a few sink implementation for testing only. We may follow that and write a custom sink which blocks on socket read and also take some input from Rohith's program above.

        Show
        jianhe Jian He added a comment - Brahma Reddy Battula , thanks for the patch ! Do you think we can have a test case to prove this ? In the TestMetricsSystemImpl.java, there are a few sink implementation for testing only. We may follow that and write a custom sink which blocks on socket read and also take some input from Rohith's program above.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Sure, I will update..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Sure, I will update..
        Hide
        jianhe Jian He added a comment -

        Hi Brahma Reddy Battula, are you still working on this ?

        Show
        jianhe Jian He added a comment - Hi Brahma Reddy Battula , are you still working on this ?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Jian He sorry for delay, will upload the patch soon.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Jian He sorry for delay, will upload the patch soon.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Jian He Attached patch kindly Review!! Thanks

        Show
        brahmareddy Brahma Reddy Battula added a comment - Jian He Attached patch kindly Review!! Thanks
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 36s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 43s There were no new javac warning messages.
        +1 javadoc 9m 49s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 4s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 18s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 16s Tests passed in hadoop-common.
            61m 34s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12748132/HADOOP-11932-02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 93d50b7
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7382/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7382/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7382/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 36s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 49s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 18s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 16s Tests passed in hadoop-common.     61m 34s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748132/HADOOP-11932-02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 93d50b7 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7382/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7382/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7382/console This message was automatically generated.
        Hide
        jianhe Jian He added a comment -

        Committed to trunk , branch-2, branch-2.7 thanks Brahma Reddy Battula !

        Show
        jianhe Jian He added a comment - Committed to trunk , branch-2, branch-2.7 thanks Brahma Reddy Battula !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8268 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8268/)
        HADOOP-11932. MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8268 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8268/ ) HADOOP-11932 . MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Jian He thanks a lot for your review and commit , and thanks to others !!!

        Show
        brahmareddy Brahma Reddy Battula added a comment - Jian He thanks a lot for your review and commit , and thanks to others !!!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1009 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1009/)
        HADOOP-11932. MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1009 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1009/ ) HADOOP-11932 . MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #279 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/279/)
        HADOOP-11932. MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #279 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/279/ ) HADOOP-11932 . MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2206 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2206/)
        HADOOP-11932. MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2206 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2206/ ) HADOOP-11932 . MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #268 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/268/)
        HADOOP-11932. MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #268 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/268/ ) HADOOP-11932 . MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/276/)
        HADOOP-11932. MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/276/ ) HADOOP-11932 . MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2225 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2225/)
        HADOOP-11932. MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2225 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2225/ ) HADOOP-11932 . MetricsSinkAdapter may hang when being stopped. Contributed by Brahma Reddy Battula (jianhe: rev f59612edd74d1bef2b60870c24c1f67c56b2b3cb) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSinkAdapter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestMetricsSystemImpl.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Attaching a patch to backport to branch-2.6.

        Show
        ajisakaa Akira Ajisaka added a comment - Attaching a patch to backport to branch-2.6.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Thanks Akira Ajisaka. Pulled this into 2.6.1. Ran compilation and TestMetricsSystemImpl before the push.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Thanks Akira Ajisaka . Pulled this into 2.6.1. Ran compilation and TestMetricsSystemImpl before the push.

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            jianhe Jian He
          • Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development