Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11930

test-patch in offline mode should tell maven to be in offline mode

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      when we use --offline for test-patch, we should also flag maven to be offline so that it doesn't attempt to talk to the internet.

      1. HADOOP-11930.2.patch
        8 kB
        Sean Busbey
      2. HADOOP-11930.1.patch
        8 kB
        Sean Busbey

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/210/)
        HADOOP-11930. test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/210/ ) HADOOP-11930 . test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2140 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2140/)
        HADOOP-11930. test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6)

        • dev-support/test-patch.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2140 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2140/ ) HADOOP-11930 . test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #942 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/942/)
        HADOOP-11930. test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #942 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/942/ ) HADOOP-11930 . test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #212 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/212/)
        HADOOP-11930. test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #212 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/212/ ) HADOOP-11930 . test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/200/)
        HADOOP-11930. test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/200/ ) HADOOP-11930 . test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        aw Allen Wittenauer added a comment -

        +1 committed.

        thanks!

        Show
        aw Allen Wittenauer added a comment - +1 committed. thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7919 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7919/)
        HADOOP-11930. test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7919 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7919/ ) HADOOP-11930 . test-patch in offline mode should tell maven to be in offline mode (Sean Busbey via aw) (aw: rev 7ebe80ec12a91602b4dcdafb4e3a75def6035ad6) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        busbey Sean Busbey added a comment -

        -02

        • rebased to current trunk
        Show
        busbey Sean Busbey added a comment - -02 rebased to current trunk
        Hide
        busbey Sean Busbey added a comment -

        cancel patch till rebase.

        Show
        busbey Sean Busbey added a comment - cancel patch till rebase.
        Hide
        aw Allen Wittenauer added a comment -

        After a bit of playing, this is actually safe to do. Now we just need the patch rebased.

        Show
        aw Allen Wittenauer added a comment - After a bit of playing, this is actually safe to do. Now we just need the patch rebased.
        Hide
        busbey Sean Busbey added a comment -

        I suspect that's true, though I can confirm mvn is ignoring it if so.

        Here's a bash-ism I wasn't sure about. When I have something like

        "${MVN}" "${MAVEN_ARGS[@]}" clean

        and there's multiple elements in MAVEN_ARGS, do they expand to individual quote-wrapped parameters? Or do they turn into a single space separated list that's quoted?

        Show
        busbey Sean Busbey added a comment - I suspect that's true, though I can confirm mvn is ignoring it if so. Here's a bash-ism I wasn't sure about. When I have something like "${MVN}" "${MAVEN_ARGS[@]}" clean and there's multiple elements in MAVEN_ARGS, do they expand to individual quote-wrapped parameters? Or do they turn into a single space separated list that's quoted?
        Hide
        aw Allen Wittenauer added a comment -

        I need to play with this a bit, but a visual inspection makes me concerned that we're passing a null parameter to maven when --offline is not in use.

        Show
        aw Allen Wittenauer added a comment - I need to play with this a bit, but a visual inspection makes me concerned that we're passing a null parameter to maven when --offline is not in use.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s dev-support patch detected.
        0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
        0 @author 0m 0s Skipping @author checks as test-patch has been patched.
        +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
        0 shellcheck 0m 15s Shellcheck was not available.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            0m 27s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730877/HADOOP-11930.1.patch
        Optional Tests shellcheck
        git revision trunk / a583a40
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6506/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 15s Shellcheck was not available. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 27s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730877/HADOOP-11930.1.patch Optional Tests shellcheck git revision trunk / a583a40 Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6506/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        A patch to test-patch or smart-apply-patch has been detected.
        Re-executing against the patched versions to perform further tests.
        The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6506/console in case of problems.

        Show
        hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6506/console in case of problems.

          People

          • Assignee:
            busbey Sean Busbey
            Reporter:
            busbey Sean Busbey
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development