Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      cleanup_and_exit uses the wrong result code check and fails to mv the patchdir when it should, and mv's it when it shouldn't.

      1. HADOOP-11928.00.patch
        0.5 kB
        Allen Wittenauer

        Activity

        Hide
        aw Allen Wittenauer added a comment -

        This is a dumb one. Simple patch.

        Show
        aw Allen Wittenauer added a comment - This is a dumb one. Simple patch.
        Hide
        hadoopqa Hadoop QA added a comment -

        A patch to test-patch or smart-apply-patch has been detected.
        Re-executing against the patched versions to perform further tests.
        The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6497/console in case of problems.

        Show
        hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6497/console in case of problems.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s dev-support patch detected.
        0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
        0 @author 0m 0s Skipping @author checks as test-patch has been patched.
        +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings.
        0 shellcheck 0m 14s Shellcheck was not available.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            0m 17s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730637/HADOOP-11928.00.patch
        Optional Tests shellcheck
        git revision trunk / 9809a16
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6497/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 14s Shellcheck was not available. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730637/HADOOP-11928.00.patch Optional Tests shellcheck git revision trunk / 9809a16 Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6497/console This message was automatically generated.
        Hide
        chris.douglas Chris Douglas added a comment -

        +1 lgtm

        Show
        chris.douglas Chris Douglas added a comment - +1 lgtm
        Hide
        aw Allen Wittenauer added a comment -

        Thanks!
        committed

        Show
        aw Allen Wittenauer added a comment - Thanks! committed
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7743 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7743/)
        HADOOP-11926. test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7743 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7743/ ) HADOOP-11926 . test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/186/)
        HADOOP-11926. test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/186/ ) HADOOP-11926 . test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/919/)
        HADOOP-11926. test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84)

        • dev-support/test-patch.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/919/ ) HADOOP-11926 . test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/)
        HADOOP-11926. test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/ ) HADOOP-11926 . test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/)
        HADOOP-11926. test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84)

        • dev-support/test-patch.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/ ) HADOOP-11926 . test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/)
        HADOOP-11926. test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/ ) HADOOP-11926 . test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/)
        HADOOP-11926. test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84)

        • dev-support/test-patch.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/ ) HADOOP-11926 . test-patch.sh mv does wrong math (aw) (aw: rev 4402e4c633808556d49854df45683688b6a9ce84) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            aw Allen Wittenauer
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development