Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11878

FileContext.java # fixRelativePart should check for not null for a more informative exception

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Following will come when job failed and deletion service trying to delete the log fiels

      2015-04-27 14:56:17,113 INFO org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor: Deleting absolute path : null
      2015-04-27 14:56:17,113 ERROR org.apache.hadoop.yarn.server.nodemanager.DeletionService: Exception during execution of task in DeletionService
      java.lang.NullPointerException
      at org.apache.hadoop.fs.FileContext.fixRelativePart(FileContext.java:274)
      at org.apache.hadoop.fs.FileContext.delete(FileContext.java:761)
      at org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.deleteAsUser(DefaultContainerExecutor.java:457)
      at org.apache.hadoop.yarn.server.nodemanager.DeletionService$FileDeletionTask.run(DeletionService.java:293)
      at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
      at java.util.concurrent.FutureTask.run(FutureTask.java:266)
      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
      at java.lang.Thread.run(Thread.java:745)

      1. HADOOP-11878-004.patch
        1 kB
        Brahma Reddy Battula
      2. HADOOP-11878-003.patch
        1 kB
        Brahma Reddy Battula
      3. HADOOP-11878-002.patch
        1 kB
        Brahma Reddy Battula
      4. HADOOP-11878.patch
        1.0 kB
        Brahma Reddy Battula

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 4s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 43s There were no new javac warning messages.
        +1 javadoc 9m 53s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 5m 34s There were no new checkstyle issues.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 43s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 24m 40s Tests passed in hadoop-common.
            67m 20s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12728337/HADOOP-11878.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 5e67c4d
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6191/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6191/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6191/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 4s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 53s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 5m 34s There were no new checkstyle issues. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 43s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 24m 40s Tests passed in hadoop-common.     67m 20s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728337/HADOOP-11878.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5e67c4d hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6191/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6191/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6191/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Thank Brahma for reporting the issue.
        Comment on the patch, returning null will lead NPE in the subsequent caller methods. I think this require investigagation why path is null while deleting the logs path? I had seen this error while running Yarn cluster when NM is restarted whlie applications are running. But did not get sufficient time to look deeper into this issue.

        Show
        rohithsharma Rohith Sharma K S added a comment - Thank Brahma for reporting the issue. Comment on the patch, returning null will lead NPE in the subsequent caller methods. I think this require investigagation why path is null while deleting the logs path? I had seen this error while running Yarn cluster when NM is restarted whlie applications are running. But did not get sufficient time to look deeper into this issue.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Thank you for taking this issue.

        Path can be null when baseDirs is not null and subDir is null.

          @Override
          public void deleteAsUser(String user, Path subDir, Path... baseDirs)
              throws IOException, InterruptedException {
            if (baseDirs == null || baseDirs.length == 0) {
              LOG.info("Deleting absolute path : " + subDir);
              ...
              return;
            }
        

        According to javadoc of FileContext, FileContext.delete() should throw InvalidPathException if path, f, is invalid. We can use Preconditions.checkNotNull for the validation. This change of behaviour can break backward compatibility, though it should be fixed.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Thank you for taking this issue. Path can be null when baseDirs is not null and subDir is null. @Override public void deleteAsUser( String user, Path subDir, Path... baseDirs) throws IOException, InterruptedException { if (baseDirs == null || baseDirs.length == 0) { LOG.info( "Deleting absolute path : " + subDir); ... return ; } According to javadoc of FileContext, FileContext.delete() should throw InvalidPathException if path, f, is invalid. We can use Preconditions.checkNotNull for the validation. This change of behaviour can break backward compatibility, though it should be fixed.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks for taking a look into this issue.. But Preconditions.checkNotNull will also throw NPE right when refence is null ( here subdir path will be null)..?

         public static <T> T checkNotNull(T reference) {
            if (reference == null) {
              throw new NullPointerException();
            }
            return reference;
          }
        
        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks for taking a look into this issue.. But Preconditions.checkNotNull will also throw NPE right when refence is null ( here subdir path will be null)..? public static <T> T checkNotNull(T reference) { if (reference == null ) { throw new NullPointerException(); } return reference; }
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Brahma Reddy Battula Good catch. It's correct to call Preconditions.checkState() for the assertion here.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Brahma Reddy Battula Good catch. It's correct to call Preconditions.checkState() for the assertion here.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Sorry, s/checkState/checkArgument/

        Show
        ozawa Tsuyoshi Ozawa added a comment - Sorry, s/checkState/checkArgument/
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Updated the patch..Tsuyoshi Ozawa kindly review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Updated the patch.. Tsuyoshi Ozawa kindly review..
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 33s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 6s The applied patch generated 1 new checkstyle issues (total was 38, now 38).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        -1 common tests 22m 33s Tests failed in hadoop-common.
            59m 40s  



        Reason Tests
        Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729931/HADOOP-11878-002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6386/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6386/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6386/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6386/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 6s The applied patch generated 1 new checkstyle issues (total was 38, now 38). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 common tests 22m 33s Tests failed in hadoop-common.     59m 40s   Reason Tests Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729931/HADOOP-11878-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6386/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6386/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6386/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6386/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        can we file seperate jira for following checkstyle or can we ignore?

        ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java:1: File length is 2,570 lines (max allowed is 2,000).
        
        Show
        brahmareddy Brahma Reddy Battula added a comment - can we file seperate jira for following checkstyle or can we ignore? ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java:1: File length is 2,570 lines (max allowed is 2,000).
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Now checkstyle and white space reports sounds good to me ( very clear)..Nice work Allen Wittenauer!!

        Show
        brahmareddy Brahma Reddy Battula added a comment - Now checkstyle and white space reports sounds good to me ( very clear)..Nice work Allen Wittenauer !!
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Brahma Reddy Battula Thank you for updating. I checked the caller of fixRelativePart, then I found that we cannot call Preconditions.checkArgument directory in fixRelativePart since caller can throw different exceptions at callers' side.

        Could you check the all callers' javadoc and check null at the caller's side?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Brahma Reddy Battula Thank you for updating. I checked the caller of fixRelativePart, then I found that we cannot call Preconditions.checkArgument directory in fixRelativePart since caller can throw different exceptions at callers' side. Could you check the all callers' javadoc and check null at the caller's side?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Sure, I will update..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Sure, I will update..
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Please also update the message like "Path is invalid" or "Path is null" based on javadoc.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Please also update the message like "Path is invalid" or "Path is null" based on javadoc.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Tsuyoshi Ozawa IIUC,we can fix by two ways
        1) Just remove the following lines and add one log message..

        LOG.info("Deleting absolute path : " + subDir);
              if (!lfs.delete(subDir, true)) {
                //Maybe retry
                LOG.warn("delete returned false for path: [" + subDir + "]");
              }
        

        2) Or add null check to subdir like following before following log..
        LOG.info("Deleting absolute path : " + subDir);
        Path del = subDir == null ? baseDir : new Path(baseDir, subDir);

        what do you think..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Tsuyoshi Ozawa IIUC,we can fix by two ways 1) Just remove the following lines and add one log message.. LOG.info( "Deleting absolute path : " + subDir); if (!lfs.delete(subDir, true )) { //Maybe retry LOG.warn( "delete returned false for path: [" + subDir + "]" ); } 2) Or add null check to subdir like following before following log.. LOG.info("Deleting absolute path : " + subDir); Path del = subDir == null ? baseDir : new Path(baseDir, subDir); what do you think..?
        Hide
        varun_saxena Varun Saxena added a comment -

        Shouldn't we try to find out why directory is null ? Is it some problem or expected behavior ? If it is expected behavior, then probably we should not try deleting this subdirectory at all.

        Show
        varun_saxena Varun Saxena added a comment - Shouldn't we try to find out why directory is null ? Is it some problem or expected behavior ? If it is expected behavior, then probably we should not try deleting this subdirectory at all.
        Hide
        kasha Karthik Kambatla added a comment -

        As others have mentioned here, we should figure out why the directory is null and fix the root cause in Yarn. Can we use YARN-3793 to do that? Please feel free to take it up.

        That said, it would be nice to make the exception easier to decipher and document it at every place FileContext#fixRelativePart is used. And, I believe checkNotNull is more appropriate than checkArgument.

        Show
        kasha Karthik Kambatla added a comment - As others have mentioned here, we should figure out why the directory is null and fix the root cause in Yarn. Can we use YARN-3793 to do that? Please feel free to take it up. That said, it would be nice to make the exception easier to decipher and document it at every place FileContext#fixRelativePart is used. And, I believe checkNotNull is more appropriate than checkArgument.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Karthik Kambatla As we got the root cause for NPE ( same mentioned in YARN-3793)..Attached the patch to checkNotNull in FileContext.java # fixRelativePart(Path p)...Karthik Kambatla and Tsuyoshi Ozawa kindly review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Karthik Kambatla As we got the root cause for NPE ( same mentioned in YARN-3793 )..Attached the patch to checkNotNull in FileContext.java # fixRelativePart(Path p)... Karthik Kambatla and Tsuyoshi Ozawa kindly review..
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 12s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 4s The applied patch generated 2 new checkstyle issues (total was 38, now 39).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 21m 58s Tests passed in hadoop-common.
            60m 41s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741480/HADOOP-11878-003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2ba6465
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7029/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7029/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7029/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7029/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 12s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 4s The applied patch generated 2 new checkstyle issues (total was 38, now 39). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 21m 58s Tests passed in hadoop-common.     60m 41s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741480/HADOOP-11878-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2ba6465 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7029/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7029/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7029/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7029/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Attached the patch to address the check-style comment.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Attached the patch to address the check-style comment.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 18s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 33s There were no new javac warning messages.
        +1 javadoc 9m 30s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 3s The applied patch generated 1 new checkstyle issues (total was 38, now 38).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 21m 56s Tests passed in hadoop-common.
            60m 43s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741567/HADOOP-11878-004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2ba6465
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7030/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7030/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7030/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7030/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 18s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 30s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 3s The applied patch generated 1 new checkstyle issues (total was 38, now 38). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 21m 56s Tests passed in hadoop-common.     60m 43s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741567/HADOOP-11878-004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2ba6465 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7030/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7030/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7030/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7030/console This message was automatically generated.
        Hide
        kasha Karthik Kambatla added a comment -

        +1. Checking this in.

        Show
        kasha Karthik Kambatla added a comment - +1. Checking this in.
        Hide
        kasha Karthik Kambatla added a comment -

        By the way, I checked none of the direct callers check for NPE and their javadocs don't necessarily mention throwing an NPE if the path is null either. There is a possibility of some indirect caller catching NPE in case the path is null, but I would think that is pretty bleak.

        Show
        kasha Karthik Kambatla added a comment - By the way, I checked none of the direct callers check for NPE and their javadocs don't necessarily mention throwing an NPE if the path is null either. There is a possibility of some indirect caller catching NPE in case the path is null, but I would think that is pretty bleak.
        Hide
        kasha Karthik Kambatla added a comment -

        Thanks for looking into this, Brahma. Just committed this to trunk and branch-2.

        Show
        kasha Karthik Kambatla added a comment - Thanks for looking into this, Brahma . Just committed this to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #8135 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8135/)
        HADOOP-11878. FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8135 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8135/ ) HADOOP-11878 . FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Karthik Kambatla thanks a lot for review and commit..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Karthik Kambatla thanks a lot for review and commit..
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #251 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/251/)
        HADOOP-11878. FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #251 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/251/ ) HADOOP-11878 . FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #981 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/981/)
        HADOOP-11878. FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #981 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/981/ ) HADOOP-11878 . FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/239/)
        HADOOP-11878. FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/239/ ) HADOOP-11878 . FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2178/)
        HADOOP-11878. FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2178/ ) HADOOP-11878 . FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #249 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/249/)
        HADOOP-11878. FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #249 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/249/ ) HADOOP-11878 . FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2197 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2197/)
        HADOOP-11878. FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2197 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2197/ ) HADOOP-11878 . FileContext#fixRelativePart should check for not null for a more informative exception. (Brahma Reddy Battula via kasha) (kasha: rev 2e3d83f97b85c015f16f1c162b8ef0e7fee1ddf2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        jameszhouyi Yi Zhou added a comment -

        Hi Brahma Reddy Battula
        I also come across the issue and if there is workaround to fix it without apply patch ? Thanks in advance !

        Show
        jameszhouyi Yi Zhou added a comment - Hi Brahma Reddy Battula I also come across the issue and if there is workaround to fix it without apply patch ? Thanks in advance !

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development