[HADOOP-11876] Refactor code to make it more readable, minor maybePrintStats bug

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: tools/distcp
• Assignee: Zoran Dimitrijevic
• Reporter: Zoran Dimitrijevic
• Due: 30/Apr/15
• Created: 24/Apr/15 17:19
• Updated: 30/Aug/16 01:29
• Resolved: 24/Apr/15 20:40

Description

This is related to HADOOP-11827 patch from few days ago. I've noticed a minor bug in maybePrintStats logic which is called only when new directory is processed, and prints every 100K objects (effectively, there is a very low probability it'll ever print stats). The reason for this bug is that I was previously printing stats for every new directory, and later decided it's nicer to print stats for large number of new "objects" (files or directories) instead.

This is a minor issue - and since I'm refactoring this I've also changed the minor retry logic to make code nicer and more readable.