Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11123 Uber-JIRA: Hadoop on Java 9
  3. HADOOP-11875

[JDK9] Renaming _ as a one-character identifier to another identifier

    Details

    • Type: Sub-task
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Incompatible change

      Description

      From JDK9, _ as a one-character identifier is banned. Currently Web UI uses it. We should fix them to compile with JDK9. https://bugs.openjdk.java.net/browse/JDK-8061549

      1. build_error_dump.txt
        5 kB
        Kai Sasaki
      2. HADOOP-11875.01.patch
        772 kB
        Akira Ajisaka
      3. HADOOP-11875.02.patch
        1.01 MB
        Akira Ajisaka
      4. HADOOP-11875.03.patch
        1.01 MB
        Akira Ajisaka
      5. HADOOP-11875.04.patch
        1.01 MB
        Akira Ajisaka
      6. HADOOP-11875.05.patch
        1.00 MB
        Akira Ajisaka
      7. HADOOP-11875.06.patch
        1.00 MB
        Akira Ajisaka
      8. HADOOP-11875.07.patch
        1.00 MB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          wheat9 Haohui Mai added a comment -

          Only the YARN Web UI use it. I'd like to propose to move towards a HTML5-based UI like what HDFS did in HDFS-5333.

          Show
          wheat9 Haohui Mai added a comment - Only the YARN Web UI use it. I'd like to propose to move towards a HTML5-based UI like what HDFS did in HDFS-5333 .
          Hide
          andrew.wang Andrew Wang added a comment -

          I think the rename would still be a nice intermediate change to get JDK8 going.

          Haohui, do you mind filing another JIRA to modernize the YARN UI?

          Show
          andrew.wang Andrew Wang added a comment - I think the rename would still be a nice intermediate change to get JDK8 going. Haohui, do you mind filing another JIRA to modernize the YARN UI?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Bear in mind that the YARN Hamlet web framework is used downstream in YARN apps: no matter what is done here, it needs to be retained

          Show
          stevel@apache.org Steve Loughran added a comment - Bear in mind that the YARN Hamlet web framework is used downstream in YARN apps: no matter what is done here, it needs to be retained
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Steve Loughran thank you for notification. Do you know how YARN Hamlet web framework is used in other projects Should we mark this as "incompatible change" since the symbol will be changed in this issue?

          Show
          ozawa Tsuyoshi Ozawa added a comment - Steve Loughran thank you for notification. Do you know how YARN Hamlet web framework is used in other projects Should we mark this as "incompatible change" since the symbol will be changed in this issue?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          yes, it is incompatible. Certainly we use it in Slider, as part of its functionality is to do all the rewrite/security stuff. i'll assume other apps do it.

          Show
          stevel@apache.org Steve Loughran added a comment - yes, it is incompatible. Certainly we use it in Slider, as part of its functionality is to do all the rewrite/security stuff. i'll assume other apps do it.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Marking this as incompatible change.
          I'm thinking that we should just rename the method name here, and more work like HDFS-5333 should be done in another ticket.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Marking this as incompatible change. I'm thinking that we should just rename the method name here, and more work like HDFS-5333 should be done in another ticket.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Are you sure its java8 which forbids this -or merely warns about it?

          Show
          stevel@apache.org Steve Loughran added a comment - Are you sure its java8 which forbids this -or merely warns about it?
          Hide
          mzuehlke Marco Zühlke added a comment -

          http://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.27.1

          It is a compile-time error if a lambda parameter has the name _ (that is, a single underscore character).

          The use of the variable name _ in any context is discouraged. Future versions of the Java programming language may reserve this name as a keyword and/or give it special semantics.

          So for the time being only a warning.

          Show
          mzuehlke Marco Zühlke added a comment - http://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.27.1 It is a compile-time error if a lambda parameter has the name _ (that is, a single underscore character). The use of the variable name _ in any context is discouraged. Future versions of the Java programming language may reserve this name as a keyword and/or give it special semantics. So for the time being only a warning.
          Hide
          lewuathe Kai Sasaki added a comment -

          As I attached build_error_dump.txt, it seems to be ERROR due to JDK8 incompatible change.

          [ERROR] (use of '_' as an identifier might not be supported in releases after Java SE 8)
          
          Show
          lewuathe Kai Sasaki added a comment - As I attached build_error_dump.txt, it seems to be ERROR due to JDK8 incompatible change. [ERROR] (use of '_' as an identifier might not be supported in releases after Java SE 8)
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Are you sure its java8 which forbids this -or merely warns about it?

          Java8 merely warns about it.

          Now trunk build is failing because of the following doc error.

          [ERROR] /Users/aajisaka/git/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java:1009: error: exception not thrown: java.lang.Exception
          [ERROR] * @throws Exception
          [ERROR] ^
          
          Show
          ajisakaa Akira Ajisaka added a comment - Are you sure its java8 which forbids this -or merely warns about it? Java8 merely warns about it. Now trunk build is failing because of the following doc error. [ERROR] /Users/aajisaka/git/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java:1009: error: exception not thrown: java.lang.Exception [ERROR] * @ throws Exception [ERROR] ^
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The javadoc error was caused by YARN-4438 and I asked the assignee to fix this.

          Show
          ajisakaa Akira Ajisaka added a comment - The javadoc error was caused by YARN-4438 and I asked the assignee to fix this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Java8 merely warns about it.

          FYI: Java9 forbids it. https://blogs.oracle.com/sundararajan/entry/underscore_is_a_keyword_in

          Show
          ajisakaa Akira Ajisaka added a comment - Java8 merely warns about it. FYI: Java9 forbids it. https://blogs.oracle.com/sundararajan/entry/underscore_is_a_keyword_in
          Hide
          stevel@apache.org Steve Loughran added a comment -

          This is going to be fun in Hamlet. It not only has the method _(), it has the interface {{ _ }} too.
          We'll have to do something like

          1. define a new method and interface, __
          2. tag the old one as deprecated "will be removed for Java 9"
          3. adopt the new one while retaining the old one for compatibility —for now
          Show
          stevel@apache.org Steve Loughran added a comment - This is going to be fun in Hamlet. It not only has the method _() , it has the interface {{ _ }} too. We'll have to do something like define a new method and interface, __ tag the old one as deprecated "will be removed for Java 9" adopt the new one while retaining the old one for compatibility —for now
          Hide
          wheat9 Haohui Mai added a comment -

          Is there a reason to keep Hamlet? Maybe we should consider moving towards HTML5 UI?

          Show
          wheat9 Haohui Mai added a comment - Is there a reason to keep Hamlet? Maybe we should consider moving towards HTML5 UI?
          Hide
          stevel@apache.org Steve Loughran added a comment -
          1. Hamlet is easy to use from Java code. What do you want, us to switch to JSP?
          2. It's used in downstream YARN apps, which is not just done out of laziness, but to handle the proxy renaming stuff, plus escaping of text.

          Because of #2, Hamlet is going to have to stay around, even if something to replace it is added alongside (or just pulled in from elsewhere)

          Show
          stevel@apache.org Steve Loughran added a comment - Hamlet is easy to use from Java code. What do you want, us to switch to JSP? It's used in downstream YARN apps, which is not just done out of laziness, but to handle the proxy renaming stuff, plus escaping of text. Because of #2, Hamlet is going to have to stay around, even if something to replace it is added alongside (or just pulled in from elsewhere)
          Hide
          wheat9 Haohui Mai added a comment -

          Hamlet is easy to use from Java code. What do you want, us to switch to JSP?

          In HDFS, switching from JSP to JMX + HTML5 has shown various improvement on user experience, productivity and security.

          It's used in downstream YARN apps, which is not just done out of laziness, but to handle the proxy renaming stuff, plus escaping of text.

          Can you be more concrete on what needs to be fixed?

          Show
          wheat9 Haohui Mai added a comment - Hamlet is easy to use from Java code. What do you want, us to switch to JSP? In HDFS, switching from JSP to JMX + HTML5 has shown various improvement on user experience, productivity and security. It's used in downstream YARN apps, which is not just done out of laziness, but to handle the proxy renaming stuff, plus escaping of text. Can you be more concrete on what needs to be fixed?
          Hide
          aw Allen Wittenauer added a comment -

          In HDFS, switching from JSP to JMX + HTML5 has shown various improvement on user experience, productivity and security.

          This isn't nearly so cut and dried. We have users who refuse to update because of the loss of features in the UI (they are sticking to 2.4.1's "legacy mode"), never mind the destruction of long term APIs and the "tossed over the fence" WebHDFS authentication that we had to rework to even make security function if one was using a custom plug-in. The switch took a lot of effort to even get to stable and it's still not what I would consider feature complete compared to the old API. So at least our experience for both beginner and advanced users, that update was somewhere in the middle and definitely not a solid win.

          Show
          aw Allen Wittenauer added a comment - In HDFS, switching from JSP to JMX + HTML5 has shown various improvement on user experience, productivity and security. This isn't nearly so cut and dried. We have users who refuse to update because of the loss of features in the UI (they are sticking to 2.4.1's "legacy mode"), never mind the destruction of long term APIs and the "tossed over the fence" WebHDFS authentication that we had to rework to even make security function if one was using a custom plug-in. The switch took a lot of effort to even get to stable and it's still not what I would consider feature complete compared to the old API. So at least our experience for both beginner and advanced users, that update was somewhere in the middle and definitely not a solid win.
          Hide
          wheat9 Haohui Mai added a comment -

          the loss of features in the UI (they are sticking to 2.4.1's "legacy mode")

          Which feature is lost? Please feel free to file a jira to track this.

          "tossed over the fence" WebHDFS authentication that we had to rework to even make security function if one was using a custom plug-in.

          This is an unfair statement. The JSP UI has a series of security issues (e.g., XSS) because of its architecture. The new UI is much more secure as these issues are addressed systematically. Please familiar yourself with relevant jiras.

          The switch took a lot of effort to even get to stable and it's still not what I would consider feature complete compared to the old API.

          The same argument applies to any components. For example, how long does Yetus take to stabilize? Do you consider Yetus feature complete compared to the test-patch.sh? Yetus is a good improvement in terms of usability and maintainability. It also brings in more people in the community. So does the HTML5 UI.

          Going back to the original topic, are there any specific reasons to not fixing code that fails to compile under the current JDK? What is a good answer to "why a stable release of Hadoop can't be compiled out-of-the-box?"

          Show
          wheat9 Haohui Mai added a comment - the loss of features in the UI (they are sticking to 2.4.1's "legacy mode") Which feature is lost? Please feel free to file a jira to track this. "tossed over the fence" WebHDFS authentication that we had to rework to even make security function if one was using a custom plug-in. This is an unfair statement. The JSP UI has a series of security issues (e.g., XSS) because of its architecture. The new UI is much more secure as these issues are addressed systematically. Please familiar yourself with relevant jiras. The switch took a lot of effort to even get to stable and it's still not what I would consider feature complete compared to the old API. The same argument applies to any components. For example, how long does Yetus take to stabilize? Do you consider Yetus feature complete compared to the test-patch.sh? Yetus is a good improvement in terms of usability and maintainability. It also brings in more people in the community. So does the HTML5 UI. Going back to the original topic, are there any specific reasons to not fixing code that fails to compile under the current JDK? What is a good answer to "why a stable release of Hadoop can't be compiled out-of-the-box?"
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I shouldn't have mentioned JSP. Nothing uses it.

          1. everything builds and runs on Java 8, you can just get a warning about using _ as a variable/method name
          2. that will become illegal on Java 9
          3. but given what else breaks on java 9, I doubt that's the main part of the trouble.

          FWIW, I do like the new HDFS UI. And I do think we could improve the YARN UI too. It's just that hamlet is picked up downstream and used. To move people off it would mean providing a nice, easy to use alternative. Which doesn't have to be implemented in hadoop core -if there is one just as simple which we could point people at, that would work

          Show
          stevel@apache.org Steve Loughran added a comment - I shouldn't have mentioned JSP. Nothing uses it. everything builds and runs on Java 8, you can just get a warning about using _ as a variable/method name that will become illegal on Java 9 but given what else breaks on java 9, I doubt that's the main part of the trouble. FWIW, I do like the new HDFS UI. And I do think we could improve the YARN UI too. It's just that hamlet is picked up downstream and used. To move people off it would mean providing a nice, easy to use alternative. Which doesn't have to be implemented in hadoop core -if there is one just as simple which we could point people at, that would work
          Hide
          wheat9 Haohui Mai added a comment -

          That sounds good to me.

          Show
          wheat9 Haohui Mai added a comment - That sounds good to me.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          New YARN Web UI v2 is now available in Hadoop 3 alpha but I'm thinking the old UI with Hamlet cannot be removed for some time for compatibility and usability. Now I'd like to replace '_' with '__' for upcoming Java9.

          Show
          ajisakaa Akira Ajisaka added a comment - New YARN Web UI v2 is now available in Hadoop 3 alpha but I'm thinking the old UI with Hamlet cannot be removed for some time for compatibility and usability. Now I'd like to replace '_' with '__' for upcoming Java9.
          Hide
          stevel@apache.org Steve Loughran added a comment - - edited

          hamlet has to be considered something used downstream.

          Would it be possible for this patch to retain the _ but deprecate it, so that old code works, but people get told off? We could do that in 2.9 too, so you can do code that works there, & maybe remove it in trunk

          Show
          stevel@apache.org Steve Loughran added a comment - - edited hamlet has to be considered something used downstream. Would it be possible for this patch to retain the _ but deprecate it, so that old code works, but people get told off? We could do that in 2.9 too, so you can do code that works there, & maybe remove it in trunk
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 12m 29s trunk passed
          +1 compile 12m 16s trunk passed
          +1 checkstyle 1m 52s trunk passed
          +1 mvnsite 4m 16s trunk passed
          +1 mvneclipse 2m 53s trunk passed
          +1 findbugs 6m 34s trunk passed
          +1 javadoc 3m 36s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 3m 21s the patch passed
          +1 compile 11m 3s the patch passed
          +1 javac 11m 3s the patch passed
          -0 checkstyle 1m 56s root: The patch generated 308 new + 1155 unchanged - 362 fixed = 1463 total (was 1517)
          +1 mvnsite 4m 46s the patch passed
          +1 mvneclipse 3m 24s the patch passed
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 0s The patch 1 line(s) with tabs.
          +1 findbugs 8m 14s the patch passed
          +1 javadoc 0m 37s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 0 new + 255 unchanged - 4324 fixed = 255 total (was 4579)
          +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161)
          +1 javadoc 0m 28s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 134 unchanged - 96 fixed = 134 total (was 230)
          +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25)
          +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188)
          +1 javadoc 0m 31s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 410 unchanged - 498 fixed = 410 total (was 908)
          +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19)
          +1 javadoc 0m 26s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 176 fixed = 38 total (was 214)
          +1 javadoc 0m 25s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203)
          +1 unit 2m 30s hadoop-yarn-common in the patch passed.
          +1 unit 0m 38s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 5s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 34s hadoop-yarn-server-web-proxy in the patch passed.
          -1 unit 2m 57s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          -1 unit 38m 55s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 0m 36s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 9m 2s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 25s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          181m 3s



          Reason Tests
          Failed junit tests hadoop.yarn.server.timeline.webapp.TestTimelineWebServices
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-11875
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851006/HADOOP-11875.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f21e3041486e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3ea6d35
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 12m 29s trunk passed +1 compile 12m 16s trunk passed +1 checkstyle 1m 52s trunk passed +1 mvnsite 4m 16s trunk passed +1 mvneclipse 2m 53s trunk passed +1 findbugs 6m 34s trunk passed +1 javadoc 3m 36s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 3m 21s the patch passed +1 compile 11m 3s the patch passed +1 javac 11m 3s the patch passed -0 checkstyle 1m 56s root: The patch generated 308 new + 1155 unchanged - 362 fixed = 1463 total (was 1517) +1 mvnsite 4m 46s the patch passed +1 mvneclipse 3m 24s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 0s The patch 1 line(s) with tabs. +1 findbugs 8m 14s the patch passed +1 javadoc 0m 37s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 0 new + 255 unchanged - 4324 fixed = 255 total (was 4579) +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161) +1 javadoc 0m 28s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 134 unchanged - 96 fixed = 134 total (was 230) +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25) +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188) +1 javadoc 0m 31s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 410 unchanged - 498 fixed = 410 total (was 908) +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19) +1 javadoc 0m 26s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 176 fixed = 38 total (was 214) +1 javadoc 0m 25s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203) +1 unit 2m 30s hadoop-yarn-common in the patch passed. +1 unit 0m 38s hadoop-yarn-server-common in the patch passed. +1 unit 13m 5s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 34s hadoop-yarn-server-web-proxy in the patch passed. -1 unit 2m 57s hadoop-yarn-server-applicationhistoryservice in the patch failed. -1 unit 38m 55s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 36s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 9m 2s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 25s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 181m 3s Reason Tests Failed junit tests hadoop.yarn.server.timeline.webapp.TestTimelineWebServices   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-11875 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851006/HADOOP-11875.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f21e3041486e 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3ea6d35 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11585/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Steve Loughran for the comment.

          Would it be possible for this patch to retain the _ but deprecate it, so that old code works, but people get told off? We could do that in 2.9 too, so you can do code that works there, & maybe remove it in trunk

          Probably it's possible. I can

          • Keep the existing Hamlet code as-is and deprecate it.
          • Create a new Hamlet classes using '__'.

          hamlet has to be considered something used downstream.

          I don't think the API is used by the downstream projects because the package is @InterfaceAudience.LimitedPrivate({"YARN", "MapReduce"}). Therefore I'm think we can simply rename '_'.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Steve Loughran for the comment. Would it be possible for this patch to retain the _ but deprecate it, so that old code works, but people get told off? We could do that in 2.9 too, so you can do code that works there, & maybe remove it in trunk Probably it's possible. I can Keep the existing Hamlet code as-is and deprecate it. Create a new Hamlet classes using '__'. hamlet has to be considered something used downstream. I don't think the API is used by the downstream projects because the package is @InterfaceAudience.LimitedPrivate({"YARN", "MapReduce"}) . Therefore I'm think we can simply rename '_'.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          you have to treat anything marked as limited private "mapreduce" as "something you need whenever writing any yarn app". If you look at even the dshell example, it pulls in lots of stuff like that —so no, that marker doesn't give you the freedom to do it.

          Show
          stevel@apache.org Steve Loughran added a comment - you have to treat anything marked as limited private "mapreduce" as "something you need whenever writing any yarn app". If you look at even the dshell example, it pulls in lots of stuff like that —so no, that marker doesn't give you the freedom to do it.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks. I'll update the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks. I'll update the patch.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          02 patch

          • Deprecate org.apache.hadoop.yarn.webapp.hamlet package.
          • Create a new package org.apache.hadoop.yarn.webapp.hamlet4java9 with '__'.
          • Replace the usage of the deprecated API with the new one.
          Show
          ajisakaa Akira Ajisaka added a comment - 02 patch Deprecate org.apache.hadoop.yarn.webapp.hamlet package. Create a new package org.apache.hadoop.yarn.webapp.hamlet4java9 with '__'. Replace the usage of the deprecated API with the new one.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 9 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 13m 5s trunk passed
          +1 compile 13m 59s trunk passed
          +1 checkstyle 1m 49s trunk passed
          +1 mvnsite 4m 24s trunk passed
          +1 mvneclipse 2m 57s trunk passed
          +1 findbugs 6m 42s trunk passed
          +1 javadoc 3m 36s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 3m 30s the patch passed
          +1 compile 12m 58s the patch passed
          -1 javac 12m 58s root generated 25 new + 700 unchanged - 0 fixed = 725 total (was 700)
          -0 checkstyle 2m 1s root: The patch generated 896 new + 1267 unchanged - 248 fixed = 2163 total (was 1515)
          +1 mvnsite 4m 51s the patch passed
          +1 mvneclipse 3m 25s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 0s The patch 1 line(s) with tabs.
          +1 findbugs 8m 49s the patch passed
          -1 javadoc 0m 46s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4438 unchanged - 141 fixed = 4514 total (was 4579)
          +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161)
          +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 134 unchanged - 96 fixed = 134 total (was 230)
          +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25)
          +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188)
          +1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 410 unchanged - 498 fixed = 410 total (was 908)
          +1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19)
          +1 javadoc 0m 24s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 176 fixed = 38 total (was 214)
          +1 javadoc 0m 21s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203)
          +1 unit 2m 38s hadoop-yarn-common in the patch passed.
          +1 unit 0m 38s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 19s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 35s hadoop-yarn-server-web-proxy in the patch passed.
          -1 unit 3m 3s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          +1 unit 39m 41s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 0m 35s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 12m 41s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 6m 38s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          193m 37s



          Reason Tests
          Failed junit tests hadoop.yarn.server.timeline.webapp.TestTimelineWebServices



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-11875
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851650/HADOOP-11875.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1cb78abf386d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eec52e1
          Default Java 1.8.0_121
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/whitespace-tabs.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 9 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 13m 5s trunk passed +1 compile 13m 59s trunk passed +1 checkstyle 1m 49s trunk passed +1 mvnsite 4m 24s trunk passed +1 mvneclipse 2m 57s trunk passed +1 findbugs 6m 42s trunk passed +1 javadoc 3m 36s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 3m 30s the patch passed +1 compile 12m 58s the patch passed -1 javac 12m 58s root generated 25 new + 700 unchanged - 0 fixed = 725 total (was 700) -0 checkstyle 2m 1s root: The patch generated 896 new + 1267 unchanged - 248 fixed = 2163 total (was 1515) +1 mvnsite 4m 51s the patch passed +1 mvneclipse 3m 25s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 0s The patch 1 line(s) with tabs. +1 findbugs 8m 49s the patch passed -1 javadoc 0m 46s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4438 unchanged - 141 fixed = 4514 total (was 4579) +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161) +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 134 unchanged - 96 fixed = 134 total (was 230) +1 javadoc 0m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25) +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188) +1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 410 unchanged - 498 fixed = 410 total (was 908) +1 javadoc 0m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19) +1 javadoc 0m 24s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 176 fixed = 38 total (was 214) +1 javadoc 0m 21s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203) +1 unit 2m 38s hadoop-yarn-common in the patch passed. +1 unit 0m 38s hadoop-yarn-server-common in the patch passed. +1 unit 13m 19s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 35s hadoop-yarn-server-web-proxy in the patch passed. -1 unit 3m 3s hadoop-yarn-server-applicationhistoryservice in the patch failed. +1 unit 39m 41s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 35s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 12m 41s hadoop-mapreduce-client-app in the patch passed. +1 unit 6m 38s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 193m 37s Reason Tests Failed junit tests hadoop.yarn.server.timeline.webapp.TestTimelineWebServices Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-11875 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851650/HADOOP-11875.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1cb78abf386d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eec52e1 Default Java 1.8.0_121 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/whitespace-tabs.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11599/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          03 patch:

          • Remove trailing whitespaces and tabs.
          • Fixed some checkstyle warnings.
            I think the javac warnings (deprecation) can be ignored because all of the new warnings are in the deprecated package.
          Show
          ajisakaa Akira Ajisaka added a comment - 03 patch: Remove trailing whitespaces and tabs. Fixed some checkstyle warnings. I think the javac warnings (deprecation) can be ignored because all of the new warnings are in the deprecated package.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 9 new or modified test files.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 12m 59s trunk passed
          +1 compile 12m 37s trunk passed
          +1 checkstyle 1m 53s trunk passed
          +1 mvnsite 4m 27s trunk passed
          +1 mvneclipse 2m 56s trunk passed
          +1 findbugs 7m 23s trunk passed
          +1 javadoc 3m 46s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 4m 14s the patch passed
          +1 compile 12m 17s the patch passed
          -1 javac 12m 17s root generated 25 new + 700 unchanged - 0 fixed = 725 total (was 700)
          -0 checkstyle 2m 12s root: The patch generated 870 new + 1268 unchanged - 248 fixed = 2138 total (was 1516)
          +1 mvnsite 5m 11s the patch passed
          +1 mvneclipse 3m 30s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 9m 29s the patch passed
          -1 javadoc 0m 47s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4438 unchanged - 141 fixed = 4514 total (was 4579)
          +1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161)
          +1 javadoc 0m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 134 unchanged - 96 fixed = 134 total (was 230)
          +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25)
          +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188)
          +1 javadoc 0m 34s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 410 unchanged - 498 fixed = 410 total (was 908)
          +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19)
          +1 javadoc 0m 28s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 176 fixed = 38 total (was 214)
          +1 javadoc 0m 25s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203)
          +1 unit 2m 55s hadoop-yarn-common in the patch passed.
          +1 unit 0m 43s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 40s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 38s hadoop-yarn-server-web-proxy in the patch passed.
          -1 unit 3m 14s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          -1 unit 40m 1s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 0m 46s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 9m 12s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 34s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          190m 22s



          Reason Tests
          Failed junit tests hadoop.yarn.server.timeline.webapp.TestTimelineWebServices
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-11875
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851775/HADOOP-11875.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dcf52cf981b8 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 37b4acf
          Default Java 1.8.0_121
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 9 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 12m 59s trunk passed +1 compile 12m 37s trunk passed +1 checkstyle 1m 53s trunk passed +1 mvnsite 4m 27s trunk passed +1 mvneclipse 2m 56s trunk passed +1 findbugs 7m 23s trunk passed +1 javadoc 3m 46s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 4m 14s the patch passed +1 compile 12m 17s the patch passed -1 javac 12m 17s root generated 25 new + 700 unchanged - 0 fixed = 725 total (was 700) -0 checkstyle 2m 12s root: The patch generated 870 new + 1268 unchanged - 248 fixed = 2138 total (was 1516) +1 mvnsite 5m 11s the patch passed +1 mvneclipse 3m 30s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 9m 29s the patch passed -1 javadoc 0m 47s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4438 unchanged - 141 fixed = 4514 total (was 4579) +1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161) +1 javadoc 0m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 134 unchanged - 96 fixed = 134 total (was 230) +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25) +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188) +1 javadoc 0m 34s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 410 unchanged - 498 fixed = 410 total (was 908) +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19) +1 javadoc 0m 28s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 176 fixed = 38 total (was 214) +1 javadoc 0m 25s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203) +1 unit 2m 55s hadoop-yarn-common in the patch passed. +1 unit 0m 43s hadoop-yarn-server-common in the patch passed. +1 unit 13m 40s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 38s hadoop-yarn-server-web-proxy in the patch passed. -1 unit 3m 14s hadoop-yarn-server-applicationhistoryservice in the patch failed. -1 unit 40m 1s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 46s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 9m 12s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 34s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 190m 22s Reason Tests Failed junit tests hadoop.yarn.server.timeline.webapp.TestTimelineWebServices   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-11875 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12851775/HADOOP-11875.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dcf52cf981b8 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 37b4acf Default Java 1.8.0_121 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11600/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Looking at this. We'll have to get the yarn & MR projects to review, as they are the main users

          otherwise, I don't think the new package should be "hamlet4java9"; many decades in the future, having a "java9" reference will seem quaint in stack traces. Just call it "hamlet2"

          Show
          stevel@apache.org Steve Loughran added a comment - Looking at this. We'll have to get the yarn & MR projects to review, as they are the main users otherwise, I don't think the new package should be "hamlet4java9"; many decades in the future, having a "java9" reference will seem quaint in stack traces. Just call it "hamlet2"
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Just call it "hamlet2"

          Agreed. I'll update the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Just call it "hamlet2" Agreed. I'll update the patch.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          04 patch

          • renamed hamlet4java9 to hamlet2
          • rebased for the latest trunk
          Show
          ajisakaa Akira Ajisaka added a comment - 04 patch renamed hamlet4java9 to hamlet2 rebased for the latest trunk
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 1s The patch appears to include 9 new or modified test files.
          0 mvndep 1m 55s Maven dependency ordering for branch
          +1 mvninstall 12m 26s trunk passed
          +1 compile 10m 21s trunk passed
          +1 checkstyle 2m 18s trunk passed
          +1 mvnsite 5m 9s trunk passed
          +1 mvneclipse 3m 46s trunk passed
          +1 findbugs 7m 28s trunk passed
          +1 javadoc 4m 29s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 3m 25s the patch passed
          +1 compile 9m 54s the patch passed
          -1 javac 9m 54s root generated 25 new + 784 unchanged - 0 fixed = 809 total (was 784)
          -0 checkstyle 2m 33s root: The patch generated 751 new + 1241 unchanged - 200 fixed = 1992 total (was 1441)
          +1 mvnsite 5m 40s the patch passed
          +1 mvneclipse 4m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 9m 48s the patch passed
          -1 javadoc 0m 50s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4434 unchanged - 141 fixed = 4510 total (was 4575)
          +1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161)
          +1 javadoc 0m 36s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 134 unchanged - 96 fixed = 134 total (was 230)
          +1 javadoc 0m 28s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25)
          +1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188)
          +1 javadoc 0m 37s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 399 unchanged - 498 fixed = 399 total (was 897)
          +1 javadoc 0m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19)
          +1 javadoc 0m 32s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 176 fixed = 38 total (was 214)
          +1 javadoc 0m 30s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203)
          +1 unit 2m 40s hadoop-yarn-common in the patch passed.
          +1 unit 0m 43s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 16s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 40s hadoop-yarn-server-web-proxy in the patch passed.
          -1 unit 3m 4s hadoop-yarn-server-applicationhistoryservice in the patch failed.
          -1 unit 39m 49s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 0m 46s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 9m 5s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 25s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 49s The patch does not generate ASF License warnings.
          190m 35s



          Reason Tests
          Failed junit tests hadoop.yarn.server.timeline.webapp.TestTimelineWebServices
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-11875
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856213/HADOOP-11875.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux aa42267e8870 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fad766e
          Default Java 1.8.0_121
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 1s The patch appears to include 9 new or modified test files. 0 mvndep 1m 55s Maven dependency ordering for branch +1 mvninstall 12m 26s trunk passed +1 compile 10m 21s trunk passed +1 checkstyle 2m 18s trunk passed +1 mvnsite 5m 9s trunk passed +1 mvneclipse 3m 46s trunk passed +1 findbugs 7m 28s trunk passed +1 javadoc 4m 29s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 3m 25s the patch passed +1 compile 9m 54s the patch passed -1 javac 9m 54s root generated 25 new + 784 unchanged - 0 fixed = 809 total (was 784) -0 checkstyle 2m 33s root: The patch generated 751 new + 1241 unchanged - 200 fixed = 1992 total (was 1441) +1 mvnsite 5m 40s the patch passed +1 mvneclipse 4m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 9m 48s the patch passed -1 javadoc 0m 50s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4434 unchanged - 141 fixed = 4510 total (was 4575) +1 javadoc 0m 32s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161) +1 javadoc 0m 36s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 134 unchanged - 96 fixed = 134 total (was 230) +1 javadoc 0m 28s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25) +1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188) +1 javadoc 0m 37s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 399 unchanged - 498 fixed = 399 total (was 897) +1 javadoc 0m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19) +1 javadoc 0m 32s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 176 fixed = 38 total (was 214) +1 javadoc 0m 30s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203) +1 unit 2m 40s hadoop-yarn-common in the patch passed. +1 unit 0m 43s hadoop-yarn-server-common in the patch passed. +1 unit 13m 16s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 40s hadoop-yarn-server-web-proxy in the patch passed. -1 unit 3m 4s hadoop-yarn-server-applicationhistoryservice in the patch failed. -1 unit 39m 49s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 46s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 9m 5s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 25s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 49s The patch does not generate ASF License warnings. 190m 35s Reason Tests Failed junit tests hadoop.yarn.server.timeline.webapp.TestTimelineWebServices   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-11875 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856213/HADOOP-11875.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux aa42267e8870 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fad766e Default Java 1.8.0_121 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11763/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          05: removed unnecessary hamlet4java9 classes

          Show
          ajisakaa Akira Ajisaka added a comment - 05: removed unnecessary hamlet4java9 classes
          Hide
          ajisakaa Akira Ajisaka added a comment -

          MAPREDUCE-6836 added '_' in ConfBlock.java. Updated the patch to replace the '_' with '__'.

          Show
          ajisakaa Akira Ajisaka added a comment - MAPREDUCE-6836 added '_' in ConfBlock.java. Updated the patch to replace the '_' with '__'.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Added a profile to skip compiling the old hamlet when Java version is 9-ea.

          Show
          ajisakaa Akira Ajisaka added a comment - Added a profile to skip compiling the old hamlet when Java version is 9-ea.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 14m 55s trunk passed
          +1 compile 17m 34s trunk passed
          +1 checkstyle 2m 19s trunk passed
          +1 mvnsite 5m 15s trunk passed
          +1 mvneclipse 3m 10s trunk passed
          +1 findbugs 7m 55s trunk passed
          +1 javadoc 4m 11s trunk passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          -1 mvninstall 0m 19s hadoop-mapreduce-client-app in the patch failed.
          -1 compile 12m 9s root in the patch failed.
          -1 javac 12m 9s root in the patch failed.
          -0 checkstyle 2m 28s root: The patch generated 747 new + 1241 unchanged - 200 fixed = 1988 total (was 1441)
          -1 mvnsite 0m 26s hadoop-mapreduce-client-app in the patch failed.
          +1 mvneclipse 3m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 24s hadoop-mapreduce-client-app in the patch failed.
          -1 javadoc 0m 49s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4434 unchanged - 141 fixed = 4510 total (was 4575)
          +1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161)
          +1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 135 unchanged - 96 fixed = 135 total (was 231)
          +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25)
          +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188)
          +1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 382 unchanged - 498 fixed = 382 total (was 880)
          +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19)
          +1 javadoc 0m 26s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 39 unchanged - 176 fixed = 39 total (was 215)
          +1 javadoc 0m 24s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203)
          +1 unit 2m 30s hadoop-yarn-common in the patch passed.
          +1 unit 0m 38s hadoop-yarn-server-common in the patch passed.
          +1 unit 13m 10s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 34s hadoop-yarn-server-web-proxy in the patch passed.
          +1 unit 3m 1s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 39m 32s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 0m 36s hadoop-yarn-server-sharedcachemanager in the patch passed.
          -1 unit 0m 29s hadoop-mapreduce-client-app in the patch failed.
          -1 unit 3m 25s hadoop-mapreduce-client-hs in the patch failed.
          +1 asflicense 0m 37s The patch does not generate ASF License warnings.
          187m 21s



          Reason Tests
          Failed junit tests hadoop.mapreduce.v2.hs.webapp.TestHSWebApp



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-11875
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861659/HADOOP-11875.05.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a658acf89c97 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 845529b
          Default Java 1.8.0_121
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-compile-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/diff-checkstyle-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 14m 55s trunk passed +1 compile 17m 34s trunk passed +1 checkstyle 2m 19s trunk passed +1 mvnsite 5m 15s trunk passed +1 mvneclipse 3m 10s trunk passed +1 findbugs 7m 55s trunk passed +1 javadoc 4m 11s trunk passed 0 mvndep 0m 19s Maven dependency ordering for patch -1 mvninstall 0m 19s hadoop-mapreduce-client-app in the patch failed. -1 compile 12m 9s root in the patch failed. -1 javac 12m 9s root in the patch failed. -0 checkstyle 2m 28s root: The patch generated 747 new + 1241 unchanged - 200 fixed = 1988 total (was 1441) -1 mvnsite 0m 26s hadoop-mapreduce-client-app in the patch failed. +1 mvneclipse 3m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 24s hadoop-mapreduce-client-app in the patch failed. -1 javadoc 0m 49s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4434 unchanged - 141 fixed = 4510 total (was 4575) +1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161) +1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 135 unchanged - 96 fixed = 135 total (was 231) +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25) +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188) +1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 382 unchanged - 498 fixed = 382 total (was 880) +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19) +1 javadoc 0m 26s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 39 unchanged - 176 fixed = 39 total (was 215) +1 javadoc 0m 24s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203) +1 unit 2m 30s hadoop-yarn-common in the patch passed. +1 unit 0m 38s hadoop-yarn-server-common in the patch passed. +1 unit 13m 10s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 34s hadoop-yarn-server-web-proxy in the patch passed. +1 unit 3m 1s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 39m 32s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 36s hadoop-yarn-server-sharedcachemanager in the patch passed. -1 unit 0m 29s hadoop-mapreduce-client-app in the patch failed. -1 unit 3m 25s hadoop-mapreduce-client-hs in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 187m 21s Reason Tests Failed junit tests hadoop.mapreduce.v2.hs.webapp.TestHSWebApp Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-11875 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861659/HADOOP-11875.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a658acf89c97 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 845529b Default Java 1.8.0_121 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-compile-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12010/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 1s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 13m 54s trunk passed
          +1 compile 16m 37s trunk passed
          +1 checkstyle 2m 15s trunk passed
          +1 mvnsite 4m 27s trunk passed
          +1 mvneclipse 2m 59s trunk passed
          +1 findbugs 6m 53s trunk passed
          +1 javadoc 3m 44s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 3m 28s the patch passed
          +1 compile 14m 57s the patch passed
          -1 javac 14m 57s root generated 25 new + 787 unchanged - 0 fixed = 812 total (was 787)
          -0 checkstyle 2m 26s root: The patch generated 747 new + 1241 unchanged - 200 fixed = 1988 total (was 1441)
          +1 mvnsite 5m 0s the patch passed
          +1 mvneclipse 3m 33s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 8m 33s the patch passed
          -1 javadoc 0m 47s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4434 unchanged - 141 fixed = 4510 total (was 4575)
          +1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161)
          +1 javadoc 0m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 135 unchanged - 96 fixed = 135 total (was 231)
          +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25)
          +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188)
          +1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 382 unchanged - 498 fixed = 382 total (was 880)
          +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19)
          +1 javadoc 0m 28s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 177 fixed = 38 total (was 215)
          +1 javadoc 0m 25s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203)
          +1 unit 2m 32s hadoop-yarn-common in the patch passed.
          +1 unit 0m 38s hadoop-yarn-server-common in the patch passed.
          +1 unit 12m 59s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 35s hadoop-yarn-server-web-proxy in the patch passed.
          +1 unit 2m 58s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 unit 38m 27s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 unit 0m 36s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 8m 49s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 26s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          192m 35s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-11875
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861665/HADOOP-11875.06.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 057bc0bf6a66 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 845529b
          Default Java 1.8.0_121
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 13m 54s trunk passed +1 compile 16m 37s trunk passed +1 checkstyle 2m 15s trunk passed +1 mvnsite 4m 27s trunk passed +1 mvneclipse 2m 59s trunk passed +1 findbugs 6m 53s trunk passed +1 javadoc 3m 44s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 3m 28s the patch passed +1 compile 14m 57s the patch passed -1 javac 14m 57s root generated 25 new + 787 unchanged - 0 fixed = 812 total (was 787) -0 checkstyle 2m 26s root: The patch generated 747 new + 1241 unchanged - 200 fixed = 1988 total (was 1441) +1 mvnsite 5m 0s the patch passed +1 mvneclipse 3m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 8m 33s the patch passed -1 javadoc 0m 47s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4434 unchanged - 141 fixed = 4510 total (was 4575) +1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161) +1 javadoc 0m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 135 unchanged - 96 fixed = 135 total (was 231) +1 javadoc 0m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25) +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188) +1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 382 unchanged - 498 fixed = 382 total (was 880) +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19) +1 javadoc 0m 28s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 177 fixed = 38 total (was 215) +1 javadoc 0m 25s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203) +1 unit 2m 32s hadoop-yarn-common in the patch passed. +1 unit 0m 38s hadoop-yarn-server-common in the patch passed. +1 unit 12m 59s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 35s hadoop-yarn-server-web-proxy in the patch passed. +1 unit 2m 58s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 unit 38m 27s hadoop-yarn-server-resourcemanager in the patch passed. +1 unit 0m 36s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 8m 49s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 26s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 192m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-11875 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861665/HADOOP-11875.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 057bc0bf6a66 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 845529b Default Java 1.8.0_121 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12011/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
          0 mvndep 1m 54s Maven dependency ordering for branch
          +1 mvninstall 13m 20s trunk passed
          +1 compile 14m 31s trunk passed
          +1 checkstyle 2m 12s trunk passed
          +1 mvnsite 4m 23s trunk passed
          +1 mvneclipse 3m 3s trunk passed
          +1 findbugs 6m 46s trunk passed
          +1 javadoc 3m 46s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 3m 26s the patch passed
          +1 compile 13m 56s the patch passed
          -1 javac 13m 56s root generated 25 new + 787 unchanged - 0 fixed = 812 total (was 787)
          -0 checkstyle 2m 30s root: The patch generated 747 new + 1240 unchanged - 200 fixed = 1987 total (was 1440)
          +1 mvnsite 4m 56s the patch passed
          +1 mvneclipse 3m 31s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 8m 32s the patch passed
          -1 javadoc 0m 48s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4434 unchanged - 141 fixed = 4510 total (was 4575)
          +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161)
          +1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 135 unchanged - 96 fixed = 135 total (was 231)
          +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25)
          +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188)
          +1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 382 unchanged - 498 fixed = 382 total (was 880)
          +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19)
          +1 javadoc 0m 27s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 177 fixed = 38 total (was 215)
          +1 javadoc 0m 25s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203)
          +1 unit 2m 32s hadoop-yarn-common in the patch passed.
          +1 unit 0m 39s hadoop-yarn-server-common in the patch passed.
          +1 unit 12m 53s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 0m 35s hadoop-yarn-server-web-proxy in the patch passed.
          +1 unit 2m 58s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          -1 unit 38m 18s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 unit 0m 36s hadoop-yarn-server-sharedcachemanager in the patch passed.
          +1 unit 8m 43s hadoop-mapreduce-client-app in the patch passed.
          +1 unit 3m 27s hadoop-mapreduce-client-hs in the patch passed.
          +1 asflicense 0m 41s The patch does not generate ASF License warnings.
          190m 0s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-11875
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861670/HADOOP-11875.07.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 5dd984605838 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 845529b
          Default Java 1.8.0_121
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 1m 54s Maven dependency ordering for branch +1 mvninstall 13m 20s trunk passed +1 compile 14m 31s trunk passed +1 checkstyle 2m 12s trunk passed +1 mvnsite 4m 23s trunk passed +1 mvneclipse 3m 3s trunk passed +1 findbugs 6m 46s trunk passed +1 javadoc 3m 46s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 3m 26s the patch passed +1 compile 13m 56s the patch passed -1 javac 13m 56s root generated 25 new + 787 unchanged - 0 fixed = 812 total (was 787) -0 checkstyle 2m 30s root: The patch generated 747 new + 1240 unchanged - 200 fixed = 1987 total (was 1440) +1 mvnsite 4m 56s the patch passed +1 mvneclipse 3m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 8m 32s the patch passed -1 javadoc 0m 48s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 76 new + 4434 unchanged - 141 fixed = 4510 total (was 4575) +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common generated 0 new + 29 unchanged - 132 fixed = 29 total (was 161) +1 javadoc 0m 30s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager generated 0 new + 135 unchanged - 96 fixed = 135 total (was 231) +1 javadoc 0m 23s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy generated 0 new + 9 unchanged - 16 fixed = 9 total (was 25) +1 javadoc 0m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice generated 0 new + 163 unchanged - 25 fixed = 163 total (was 188) +1 javadoc 0m 33s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 382 unchanged - 498 fixed = 382 total (was 880) +1 javadoc 0m 24s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-sharedcachemanager generated 0 new + 3 unchanged - 16 fixed = 3 total (was 19) +1 javadoc 0m 27s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app generated 0 new + 38 unchanged - 177 fixed = 38 total (was 215) +1 javadoc 0m 25s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs generated 0 new + 15 unchanged - 188 fixed = 15 total (was 203) +1 unit 2m 32s hadoop-yarn-common in the patch passed. +1 unit 0m 39s hadoop-yarn-server-common in the patch passed. +1 unit 12m 53s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 0m 35s hadoop-yarn-server-web-proxy in the patch passed. +1 unit 2m 58s hadoop-yarn-server-applicationhistoryservice in the patch passed. -1 unit 38m 18s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 0m 36s hadoop-yarn-server-sharedcachemanager in the patch passed. +1 unit 8m 43s hadoop-mapreduce-client-app in the patch passed. +1 unit 3m 27s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 41s The patch does not generate ASF License warnings. 190m 0s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-11875 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12861670/HADOOP-11875.07.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 5dd984605838 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 845529b Default Java 1.8.0_121 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12012/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ozawa Tsuyoshi Ozawa
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:

                Development